cpufreq: s3c: avoid use after free issue in xxx_cpufreq_reboot_notifier_evt()
Subsystems (2)
PATCH v2 1/1 cpufreq: s3c: avoid use after free issue in xxx_cpufreq_reboot_notifier_evt()
From: chenqiwu <[email protected]>
There is a potential UAF issue in xxx_cpufreq_reboot_notifier_evt() that the cpufreq policy of cpu0 has been released before using it. So we should make a judgement to avoid it.
---
changes in v2:
- use the combination of cpufreq_cpu_get() and cpufreq_cpu_put() instead of cpufreq_get_policy() in s3c2416-cpufreq.c
--- drivers/cpufreq/s3c2416-cpufreq.c | 12 +++++++++++- drivers/cpufreq/s5pv210-cpufreq.c | 11 ++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-)
drivers/cpufreq/s3c2416-cpufreq.c +11 -1
@@ -304,6 +304,7 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this, {struct s3c2416_data *s3c_freq = &s3c2416_cpufreq;int ret; +struct cpufreq_policy *policy;mutex_lock (&cpufreq_lock);
@@ -318,7 +319,16 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this,*/ if (s3c_freq->is_dvs) {pr_debug ("cpufreq: leave dvs on reboot\n" ); - ret =cpufreq_driver_target (cpufreq_cpu_get (0 ),FREQ_SLEEP ,0 ); + + policy =cpufreq_cpu_get (0 ); +if (!policy) { +pr_debug ("cpufreq: get no policy for cpu0\n" ); +return NOTIFY_BAD ; + } + + ret =cpufreq_driver_target (&policy,FREQ_SLEEP ,0 ); +cpufreq_cpu_put (policy); +if (ret <0 )return NOTIFY_BAD ; }
drivers/cpufreq/s5pv210-cpufreq.c +10 -1
@@ -555,8 +555,17 @@ static int s5pv210_cpufreq_reboot_notifier_event(struct notifier_block *this, unsigned long event, void *ptr) { int ret; +struct cpufreq_policy *policy; + + policy =cpufreq_cpu_get (0 ); +if (!policy) { +pr_debug ("cpufreq: get no policy for cpu0\n" ); +return NOTIFY_BAD ; + } + + ret =cpufreq_driver_target (policy,SLEEP_FREQ ,0 ); +cpufreq_cpu_put (policy); - ret =cpufreq_driver_target (cpufreq_cpu_get (0 ),SLEEP_FREQ ,0 );if (ret <0 )return NOTIFY_BAD ;
Signature · 1 line
1.9.1
Viresh Kumar
maintainerQuoted 5 lines · On 06-01-20, 17:44, [email protected] wrote:
From: chenqiwu <[email protected]>
There is a potential UAF issue in
xxx_cpufreq_reboot_notifier_evt()that the cpufreq policy of cpu0 has been released before using it. So we should make a judgement to avoid it.
Again, the subject and description are incorrect here. This isn't a user after free problem as we were already calling cpufreq_cpu_get(). The problem was that the balancing of refcount wasn't done properly.
Quoted 65 lines
Signed-off-by chenqiwu <[email protected]>---
changes in v2:
- use the combination ofcpufreq_cpu_get()andcpufreq_cpu_put()instead ofcpufreq_get_policy()ins3c2416-cpufreq.c--- drivers/cpufreq/s3c2416-cpufreq.c | 12 +++++++++++- drivers/cpufreq/s5pv210-cpufreq.c | 11 ++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-)drivers/cpufreq/s3c2416-cpufreq.c +11
-1@@ -304,6 +304,7 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this, {struct s3c2416_data *s3c_freq = &s3c2416_cpufreq;int ret; +struct cpufreq_policy *policy;mutex_lock (&cpufreq_lock);@@ -318,7 +319,16 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this,*/ if (s3c_freq->is_dvs) {pr_debug ("cpufreq: leave dvs on reboot\n" ); - ret =cpufreq_driver_target (cpufreq_cpu_get (0 ),FREQ_SLEEP ,0 ); + + policy =cpufreq_cpu_get (0 ); +if (!policy) { +pr_debug ("cpufreq: get no policy for cpu0\n" ); +return NOTIFY_BAD ; + } + + ret =cpufreq_driver_target (&policy,FREQ_SLEEP ,0 ); +cpufreq_cpu_put (policy); +if (ret <0 )return NOTIFY_BAD ; }drivers/cpufreq/s5pv210-cpufreq.c +10
-1@@ -555,8 +555,17 @@ static int s5pv210_cpufreq_reboot_notifier_event(struct notifier_block *this, unsigned long event, void *ptr) { int ret; +struct cpufreq_policy *policy; + + policy =cpufreq_cpu_get (0 ); +if (!policy) { +pr_debug ("cpufreq: get no policy for cpu0\n" ); +return NOTIFY_BAD ; + } + + ret =cpufreq_driver_target (policy,SLEEP_FREQ ,0 ); +cpufreq_cpu_put (policy); - ret =cpufreq_driver_target (cpufreq_cpu_get (0 ),SLEEP_FREQ ,0 );if (ret <0 )return NOTIFY_BAD ;Signature · 1 line
1.9.1
Signature · 1 line
viresh
Quoted 12 lines · Viresh Kumar
Quoted 5 lines · On 06-01-20, 17:44, [email protected] wrote:
From: chenqiwu <[email protected]>
There is a potential UAF issue in
xxx_cpufreq_reboot_notifier_evt()that the cpufreq policy of cpu0 has been released before using it. So we should make a judgement to avoid it.Again, the subject and description are incorrect here. This isn't a user after free problem as we were already calling
cpufreq_cpu_get(). The problem was that the balancing of refcount wasn't done properly.
Yeah, I will rewrite the title and commit message, and resend this as patch v3.
Thanks!
Quoted 59 lines
Quoted 59 lines
Signed-off-by chenqiwu <[email protected]>---
changes in v2:
- use the combination ofcpufreq_cpu_get()andcpufreq_cpu_put()instead ofcpufreq_get_policy()ins3c2416-cpufreq.c--- drivers/cpufreq/s3c2416-cpufreq.c | 12 +++++++++++- drivers/cpufreq/s5pv210-cpufreq.c | 11 ++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-)drivers/cpufreq/s3c2416-cpufreq.c +11
-1@@ -304,6 +304,7 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this, {struct s3c2416_data *s3c_freq = &s3c2416_cpufreq;int ret; +struct cpufreq_policy *policy;mutex_lock (&cpufreq_lock);@@ -318,7 +319,16 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this,*/ if (s3c_freq->is_dvs) {pr_debug ("cpufreq: leave dvs on reboot\n" ); - ret =cpufreq_driver_target (cpufreq_cpu_get (0 ),FREQ_SLEEP ,0 ); + + policy =cpufreq_cpu_get (0 ); +if (!policy) { +pr_debug ("cpufreq: get no policy for cpu0\n" ); +return NOTIFY_BAD ; + } + + ret =cpufreq_driver_target (&policy,FREQ_SLEEP ,0 ); +cpufreq_cpu_put (policy); +if (ret <0 )return NOTIFY_BAD ; }drivers/cpufreq/s5pv210-cpufreq.c +10
-0@@ -555,8 +555,17 @@ static int s5pv210_cpufreq_reboot_notifier_event(struct notifier_block *this, unsigned long event, void *ptr) { int ret; +struct cpufreq_policy *policy; + + policy =cpufreq_cpu_get (0 ); +if (!policy) { +pr_debug ("cpufreq: get no policy for cpu0\n" ); +return NOTIFY_BAD ; + } + + ret =cpufreq_driver_target (policy,SLEEP_FREQ ,0 ); +cpufreq_cpu_put (policy);
Quoted 9 lines
Quoted 6 lines
drivers/cpufreq/s5pv210-cpufreq.c +0
-1- ret =cpufreq_driver_target (cpufreq_cpu_get (0 ),SLEEP_FREQ ,0 );if (ret <0 )return NOTIFY_BAD ;Signature · 1 line
1.9.1Signature · 1 line
viresh
--
Qiwu