FAILED: patch "[PATCH] drm/amdgpu: correct RLC firmwares loading sequence" failed to apply to 5.4-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 969e11529221a6a2a787cb3b63ccf9402f8d2e37 Mon Sep 17 00:00:00 2001
From: Evan Quan <[email protected]>
Date: Mon, 23 Dec 2019 16:13:48 +0800
Subject: [PATCH] drm/amdgpu: correct RLC firmwares loading sequence
Per confirmation with RLC firmware team, the RLC should be unhalted after all RLC related firmwares uploaded. However, in fact the RLC is unhalted immediately after RLCG firmware uploaded. And that may causes unexpected PSP hang on loading the succeeding RLC save restore list related firmwares.
So, we correct the firmware loading sequence to load RLC save restore list related firmwares before RLCG ucode. That will help to get around this issue.
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +1 -1
@@ -1488,7 +1488,7 @@ out:/* Start rlc autoload after psp recieved all the gfx firmware */ if (psp->autoload_supported && ucode->ucode_id == (amdgpu_sriov_vf (adev) ? -AMDGPU_UCODE_ID_CP_MEC2 :AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM )) { +AMDGPU_UCODE_ID_CP_MEC2 :AMDGPU_UCODE_ID_RLC_G )) { ret =psp_rlc_autoload (psp);if (ret) {DRM_ERROR ("Failed to start rlc autoload\n" );
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +1 -1
@@ -292,10 +292,10 @@ enum AMDGPU_UCODE_ID {AMDGPU_UCODE_ID_CP_MEC2_JT ,AMDGPU_UCODE_ID_CP_MES ,AMDGPU_UCODE_ID_CP_MES_DATA , -AMDGPU_UCODE_ID_RLC_G ,AMDGPU_UCODE_ID_RLC_RESTORE_LIST_CNTL ,AMDGPU_UCODE_ID_RLC_RESTORE_LIST_GPM_MEM ,AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM , +AMDGPU_UCODE_ID_RLC_G ,AMDGPU_UCODE_ID_STORAGE ,AMDGPU_UCODE_ID_SMC , AMDGPU_UCODE_ID_UVD,