arm64: dts: imx8mm: Memory node should be in board DT
Subsystems (2)
PATCH 1/2 arm64: dts: imx8mm: Memory node should be in board DT
Memory address/size depends on board design, so memory node should be in board DT.
--- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +5 -0
@@ -16,6 +16,11 @@ stdout-path = &uart2; }; + memory@40000000 { + device_type = "memory"; + reg = <0x0 0x40000000 0 0x80000000>; + }; + leds { compatible = "gpio-leds"; pinctrl-names = "default";
arch/arm64/boot/dts/freescale/imx8mm.dtsi +0 -5
@@ -140,11 +140,6 @@ }; }; - memory@40000000 { - device_type = "memory"; - reg = <0x0 0x40000000 0 0x80000000>; - }; - osc_32k: clock-osc-32k { compatible = "fixed-clock"; #clock-cells = <0>;
Signature · 1 line
2.7.4
PATCH 2/2 arm64: dts: imx8mn: Memory node should be in board DT
Memory address/size depends on board design, so memory node should be in board DT.
--- arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +5 -0
@@ -23,6 +23,11 @@ }; }; + memory@40000000 { + device_type = "memory"; + reg = <0x0 0x40000000 0 0x80000000>; + }; + reg_usdhc2_vmmc: regulator-usdhc2 { compatible = "regulator-fixed"; pinctrl-names = "default";
arch/arm64/boot/dts/freescale/imx8mn.dtsi +0 -5
@@ -139,11 +139,6 @@ }; }; - memory@40000000 { - device_type = "memory"; - reg = <0x0 0x40000000 0 0x80000000>; - }; - osc_32k: clock-osc-32k { compatible = "fixed-clock"; #clock-cells = <0>;
Signature · 1 line
2.7.4
Re: [PATCH 2/2] arm64: dts: imx8mn: Memory node should be in board DT
Quoted 4 lines · Anson Huang
Memory address/size depends on board design, so memory node should be in board DT.
Signed-off-by Anson Huang <[email protected]>
Quoted 39 lines
--- arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-)arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +5
-0@@ -23,6 +23,11 @@ }; }; + memory@40000000 { + device_type = "memory"; + reg = <0x0 0x40000000 0 0x80000000>; + }; + reg_usdhc2_vmmc: regulator-usdhc2 { compatible = "regulator-fixed"; pinctrl-names = "default";arch/arm64/boot/dts/freescale/imx8mn.dtsi +0
-5@@ -139,11 +139,6 @@ }; }; - memory@40000000 { - device_type = "memory"; - reg = <0x0 0x40000000 0 0x80000000>; - }; - osc_32k: clock-osc-32k { compatible = "fixed-clock"; #clock-cells = <0>;
Quoted 4 lines · Anson Huang
Memory address/size depends on board design, so memory node should be in board DT.
Signed-off-by Anson Huang <[email protected]>
Care to add a cover letter for your next patch series? :).
Just use --cover-letter argument for git format-patch.
Thus, we can keep revision history centralized and can just one Reviewed-by/Tested-by tag :).
Quoted 39 lines
--- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-evk.dts +5
-0@@ -16,6 +16,11 @@ stdout-path = &uart2; }; + memory@40000000 { + device_type = "memory"; + reg = <0x0 0x40000000 0 0x80000000>; + }; + leds { compatible = "gpio-leds"; pinctrl-names = "default";arch/arm64/boot/dts/freescale/imx8mm.dtsi +0
-5@@ -140,11 +140,6 @@ }; }; - memory@40000000 { - device_type = "memory"; - reg = <0x0 0x40000000 0 0x80000000>; - }; - osc_32k: clock-osc-32k { compatible = "fixed-clock"; #clock-cells = <0>;
Quoted 6 lines
Cc: dl-linux-imx <[email protected]>
Subject: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DTMemory address/size depends on board design, so memory node should be in board DT.
Not sure it really matters, bootloader will update/create memory node of device tree.
Regards,
Peng.
Quoted 43 lines
Signed-off-by Anson Huang <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-evk.dts +5
-0@@ -16,6 +16,11 @@ stdout-path = &uart2; }; + memory@40000000 { + device_type = "memory"; + reg = <0x0 0x40000000 0 0x80000000>; + }; + leds { compatible = "gpio-leds"; pinctrl-names = "default";arch/arm64/boot/dts/freescale/imx8mm.dtsi +0
-6@@ -140,11 +140,6 @@ }; }; - memory@40000000 { - device_type = "memory"; - reg = <0x0 0x40000000 0 0x80000000>; - }; - osc_32k: clock-osc-32k { compatible = "fixed-clock"; #clock-cells = <0>; --2.7.4
Shawn Guo
AppliedQuoted 4 lines · Anson Huang
Memory address/size depends on board design, so memory node should be in board DT.
Signed-off-by Anson Huang <[email protected]>
Applied both, thanks.