Skip to contentSkip to conversation

arm64: dts: imx8mm: Memory node should be in board DT

PATCH Applied Anson Huang 4 participants 6 messages Jan 8, 2020 – Jan 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: imx8mm: Memory node should be in board DT

Memory address/size depends on board design, so memory node should be in board DT.

---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
 arch/arm64/boot/dts/freescale/imx8mm.dtsi    | 5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +5 -0
index cf044dd..9e54747 100644
@@ -16,6 +16,11 @@
 		stdout-path = &uart2;
 	};
 
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x0 0x40000000 0 0x80000000>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
arch/arm64/boot/dts/freescale/imx8mm.dtsi +0 -5
index a3d179b..1e5e115 100644
@@ -140,11 +140,6 @@
 		};
 	};
 
-	memory@40000000 {
-		device_type = "memory";
-		reg = <0x0 0x40000000 0 0x80000000>;
-	};
-
 	osc_32k: clock-osc-32k {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 arm64: dts: imx8mn: Memory node should be in board DT

Memory address/size depends on board design, so memory node should be in board DT.

---
 arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++
 arch/arm64/boot/dts/freescale/imx8mn.dtsi     | 5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +5 -0
index 7a92952..0d2ec4a 100644
@@ -23,6 +23,11 @@
 		};
 	};
 
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x0 0x40000000 0 0x80000000>;
+	};
+
 	reg_usdhc2_vmmc: regulator-usdhc2 {
 		compatible = "regulator-fixed";
 		pinctrl-names = "default";
arch/arm64/boot/dts/freescale/imx8mn.dtsi +0 -5
index cce65b9..4014029 100644
@@ -139,11 +139,6 @@
 		};
 	};
 
-	memory@40000000 {
-		device_type = "memory";
-		reg = <0x0 0x40000000 0 0x80000000>;
-	};
-
 	osc_32k: clock-osc-32k {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
Signature · 1 line
2.7.4
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: imx8mn: Memory node should be in board DT

Quoted 4 lines · Anson Huang

Memory address/size depends on board design, so memory node should be in board DT.

Quoted 39 lines
---
 arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++
 arch/arm64/boot/dts/freescale/imx8mn.dtsi     | 5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +5 -0
index 7a92952..0d2ec4a 100644
@@ -23,6 +23,11 @@
 		};
 	};
 
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x0 0x40000000 0 0x80000000>;
+	};
+
 	reg_usdhc2_vmmc: regulator-usdhc2 {
 		compatible = "regulator-fixed";
 		pinctrl-names = "default";
arch/arm64/boot/dts/freescale/imx8mn.dtsi +0 -5
index cce65b9..4014029 100644
@@ -139,11 +139,6 @@
 		};
 	};
 
-	memory@40000000 {
-		device_type = "memory";
-		reg = <0x0 0x40000000 0 0x80000000>;
-	};
-
 	osc_32k: clock-osc-32k {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
Reviewed-by on v1 1/2
#3 lore raw
In reply to Anson Huang
Quoted 4 lines · Anson Huang

Memory address/size depends on board design, so memory node should be in board DT.

Care to add a cover letter for your next patch series? :).

Just use --cover-letter argument for git format-patch.

Thus, we can keep revision history centralized and can just one Reviewed-by/Tested-by tag :).

Quoted 39 lines
---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
 arch/arm64/boot/dts/freescale/imx8mm.dtsi    | 5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +5 -0
index cf044dd..9e54747 100644
@@ -16,6 +16,11 @@
 		stdout-path = &uart2;
 	};
 
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x0 0x40000000 0 0x80000000>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
arch/arm64/boot/dts/freescale/imx8mm.dtsi +0 -5
index a3d179b..1e5e115 100644
@@ -140,11 +140,6 @@
 		};
 	};
 
-	memory@40000000 {
-		device_type = "memory";
-		reg = <0x0 0x40000000 0 0x80000000>;
-	};
-
 	osc_32k: clock-osc-32k {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
#4 lore raw
In reply to Anson Huang
Quoted 6 lines

Cc: dl-linux-imx <[email protected]>
Subject: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT

Memory address/size depends on board design, so memory node should be in board DT.

Not sure it really matters, bootloader will update/create memory node of device tree.

Regards,
Peng.

Quoted 43 lines
---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
 arch/arm64/boot/dts/freescale/imx8mm.dtsi    | 5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +5 -0
index cf044dd..9e54747 100644
@@ -16,6 +16,11 @@
 		stdout-path = &uart2;
 	};
 
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x0 0x40000000 0 0x80000000>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
arch/arm64/boot/dts/freescale/imx8mm.dtsi +0 -6
index a3d179b..1e5e115 100644
@@ -140,11 +140,6 @@
 		};
 	};
 
-	memory@40000000 {
-		device_type = "memory";
-		reg = <0x0 0x40000000 0 0x80000000>;
-	};
-
 	osc_32k: clock-osc-32k {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
--

2.7.4