Skip to contentSkip to conversation

x86/resctrl: Take care of PF_EXITING task in callback

PATCH Applied Xiaochen Shen 2 participants 2 messages Jan 8, 2020 – Jan 13, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/resctrl: Take care of PF_EXITING task in callback

When writing a pid to file "tasks", a callback function move_myself() is queued to this task to be called when the task returns from kernel mode or exits. The purpose of move_myself() is to activate the newly assigned closid and/or rmid associated with this task. This activation is done by calling resctrl_sched_in() from move_myself(), the same function that is called when switching to this task.

If this work is successfully queued but then the task enters PF_EXITING status (e.g., receiving signal SIGKILL, SIGTERM) prior to the execution of the callback move_myself() then move_myself() still calls resctrl_sched_in() since the task status is not currently considered.

When a task is exiting then the data structure of the task itself will be freed soon, calling resctrl_sched_in() to write the register that control's the task's resources is unnecessary and it implies extra performance overhead.

Add check on task status in move_myself() and return immediately if the task is PF_EXITING.

---
 arch/x86/kernel/cpu/resctrl/rdtgroup.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/x86/kernel/cpu/resctrl/rdtgroup.c +4 -0
index 2e3b06d6bbc6..205925d802d8 100644
@@ -532,11 +532,15 @@ static void move_myself(struct callback_head *head)
 		kfree(rdtgrp);
 	}
 
+	if (unlikely(current->flags & PF_EXITING))
+		goto out;
+
 	preempt_disable();
 	/* update PQR_ASSOC MSR to make resource group go into effect */
 	resctrl_sched_in();
 	preempt_enable();
 
+out:
 	kfree(callback);
 }
 
Signature · 1 line
1.8.3.1
merge bot Applied
#1 lore raw

[tip: x86/cache] x86/resctrl: Do not reconfigure exiting tasks

The following commit has been merged into the x86/cache branch of tip:

The following commit has been merged into the x86/cache branch of tip:

Commit-ID:     dc433797c6f639e46824585bbf943578f13d54bf
Gitweb:        https://git.kernel.org/tip/dc433797c6f639e46824585bbf943578f13d54bf
Author:        Xiaochen Shen <[email protected]>
AuthorDate:    Thu, 09 Jan 2020 00:13:46 +08:00
Committer:     Borislav Petkov <[email protected]>
CommitterDate: Mon, 13 Jan 2020 14:10:21 +01:00

x86/resctrl: Do not reconfigure exiting tasks

When writing a pid to file "tasks", a callback function move_myself() is queued to this task to be called when the task returns from kernel mode or exits. The purpose of move_myself() is to activate the newly assigned closid and/or rmid associated with this task. This activation is done by calling resctrl_sched_in() from move_myself(), the same function that is called when switching to this task.

If this work is successfully queued but then the task enters PF_EXITING status (e.g., receiving signal SIGKILL, SIGTERM) prior to the execution of the callback move_myself(), move_myself() still calls resctrl_sched_in() since the task status is not currently considered.

When a task is exiting, the data structure of the task itself will be freed soon. Calling resctrl_sched_in() to write the register that controls the task's resources is unnecessary and it implies extra performance overhead.

Add check on task status in move_myself() and return immediately if the task is PF_EXITING.

[ bp: Massage. ]

---
 arch/x86/kernel/cpu/resctrl/rdtgroup.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/x86/kernel/cpu/resctrl/rdtgroup.c +4 -0
index 2e3b06d..205925d 100644
@@ -532,11 +532,15 @@ static void move_myself(struct callback_head *head)
 		kfree(rdtgrp);
 	}
 
+	if (unlikely(current->flags & PF_EXITING))
+		goto out;
+
 	preempt_disable();
 	/* update PQR_ASSOC MSR to make resource group go into effect */
 	resctrl_sched_in();
 	preempt_enable();
 
+out:
 	kfree(callback);
 }