Skip to contentSkip to conversation

vdpasim: fix "mac_pton" undefined error

PATCH In review Laurent Vivier 2 participants 3 messages Nov 13, 2020 virtio core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vdpasim: fix "mac_pton" undefined error

ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!

mac_pton() is defined in lib/net_utils.c and is not built if NET is not set.

Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET.

---
 drivers/vdpa/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/vdpa/Kconfig +1 -0
index d7d32b656102..358f6048dd3c 100644
@@ -13,6 +13,7 @@ config VDPA_SIM
 	depends on RUNTIME_TESTING_MENU && HAS_DMA
 	select DMA_OPS
 	select VHOST_RING
+	select GENERIC_NET_UTILS
 	default n
 	help
 	  vDPA networking device simulator which loop TX traffic back
Signature · 1 line
2.28.0
#1 lore raw
Quoted 7 lines · Laurent Vivier

ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!

mac_pton() is defined in lib/net_utils.c and is not built if NET is not set.

Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET.

On Nov. 2, 2020:

https://lore.kernel.org/lkml/[email protected]/

Quoted 11 lines
---
 drivers/vdpa/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/vdpa/Kconfig +0 -0
index d7d32b656102..358f6048dd3c 100644

drivers/vdpa/Kconfig config VDPA_SIM · line 19

Quoted 7 lines
drivers/vdpa/Kconfig +1 -0
@@ -13,6 +13,7 @@ config VDPA_SIM
 	depends on RUNTIME_TESTING_MENU && HAS_DMA
 	select DMA_OPS
 	select VHOST_RING
+	select GENERIC_NET_UTILS
 	default n
 	help
 	  vDPA networking device simulator which loop TX traffic back

Thanks for the patch.

Signature · 1 line
~Randy
Acked-by
#2 lore raw
Quoted 21 lines · Randy Dunlap
Quoted 7 lines · Laurent Vivier

ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!

mac_pton() is defined in lib/net_utils.c and is not built if NET is not set.

Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET.

On Nov. 2, 2020:

https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines
---
 drivers/vdpa/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

drivers/vdpa/Kconfig config VDPA_SIM · line 19

Quoted 13 lines
drivers/vdpa/Kconfig +1 -0
index d7d32b656102..358f6048dd3c 100644
@@ -13,6 +13,7 @@ config VDPA_SIM
 	depends on RUNTIME_TESTING_MENU && HAS_DMA
 	select DMA_OPS
 	select VHOST_RING
+	select GENERIC_NET_UTILS
 	default n
 	help
 	  vDPA networking device simulator which loop TX traffic back

Thanks for the patch.

Signature · 1 line
~Randy