bnxt_en: Bug fixes.
Michael Chan
maintainercover bnxt_en: Bug fixes.
3 small bug fix patches. The 1st two are aRFS fixes and the last one fixes a fatal driver load failure on some kernels without PCIe extended config space support enabled.
Please also queue these for -stable. Thanks.
Michael Chan (3):
bnxt_en: Fix NTUPLE firmware command failures.
bnxt_en: Fix ipv6 RFS filter matching logic.
bnxt_en: Do not treat DSN (Digital Serial Number) read failure as
fatal.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 29 ++++++++++++++++++--------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +--- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 3 +++ 3 files changed, 24 insertions(+), 12 deletions(-)
Signature · 1 line
2.5.1
Michael Chan
maintainerPATCH 1/3 bnxt_en: Fix NTUPLE firmware command failures.
The NTUPLE related firmware commands are sent to the wrong firmware channel, causing all these commands to fail on new firmware that supports the new firmware channel. Fix it by excluding the 3 NTUPLE firmware commands from the list for the new firmware channel.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 --- 1 file changed, 3 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.h +0 -3
@@ -1936,9 +1936,6 @@ static inline bool bnxt_cfa_hwrm_message(u16 req_type)case HWRM_CFA_ENCAP_RECORD_FREE :case HWRM_CFA_DECAP_FILTER_ALLOC :case HWRM_CFA_DECAP_FILTER_FREE : -case HWRM_CFA_NTUPLE_FILTER_ALLOC : -case HWRM_CFA_NTUPLE_FILTER_FREE : -case HWRM_CFA_NTUPLE_FILTER_CFG :case HWRM_CFA_EM_FLOW_ALLOC :case HWRM_CFA_EM_FLOW_FREE :case HWRM_CFA_EM_FLOW_CFG :
Signature · 1 line
2.5.1
Michael Chan
maintainerPATCH 2/3 bnxt_en: Fix ipv6 RFS filter matching logic.
In reply to Michael ChanFix bnxt_fltr_match() to match ipv6 source and destination addresses. The function currently only checks ipv4 addresses and will not work corrently on ipv6 filters.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +17 -5
@@ -11065,11 +11065,23 @@ static bool bnxt_fltr_match(struct bnxt_ntuple_filter *f1,struct flow_keys *keys1 = &f1->fkeys;struct flow_keys *keys2 = &f2->fkeys; -if (keys1->addrs.v4addrs.src == keys2->addrs.v4addrs.src && - keys1->addrs.v4addrs.dst == keys2->addrs.v4addrs.dst && - keys1->ports.ports == keys2->ports.ports && - keys1->basic.ip_proto == keys2->basic.ip_proto && - keys1->basic.n_proto == keys2->basic.n_proto && +if (keys1->basic.n_proto != keys2->basic.n_proto || + keys1->basic.ip_proto != keys2->basic.ip_proto) +return false; + +if (keys1->basic.n_proto ==htons (ETH_P_IP )) { +if (keys1->addrs.v4addrs.src != keys2->addrs.v4addrs.src || + keys1->addrs.v4addrs.dst != keys2->addrs.v4addrs.dst) +return false; + }else { +if (memcmp (&keys1->addrs.v6addrs.src, &keys2->addrs.v6addrs.src, +sizeof (keys1->addrs.v6addrs.src)) || +memcmp (&keys1->addrs.v6addrs.dst, &keys2->addrs.v6addrs.dst, +sizeof (keys1->addrs.v6addrs.dst))) +return false; + } + +if (keys1->ports.ports == keys2->ports.ports && keys1->control.flags == keys2->control.flags &ðer_addr_equal (f1->src_mac_addr, f2->src_mac_addr) &ðer_addr_equal (f1->dst_mac_addr, f2->dst_mac_addr))
Signature · 1 line
2.5.1
Michael Chan
maintainerPATCH 3/3 bnxt_en: Do not treat DSN (Digital Serial Number) read failure as fatal.
In reply to Michael ChanDSN read can fail, for example on a kdump kernel without PCIe extended config space support. If DSN read fails, don't set the BNXT_FLAG_DSN_VALID flag and continue loading. Check the flag to see if the stored DSN is valid before using it. Only VF reps creation should fail without valid DSN.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 7 +++---- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 3 +++ 3 files changed, 7 insertions(+), 4 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +3 -4
@@ -11373,7 +11373,7 @@ int bnxt_get_port_parent_id(struct net_device *dev,return -EOPNOTSUPP ;/* The PF and it's VF-reps only support the switchdev framework */ -if (!BNXT_PF (bp)) +if (!BNXT_PF (bp) || !(bp->flags &BNXT_FLAG_DSN_VALID ))return -EOPNOTSUPP ; ppid->id_len =sizeof (bp->switch_id);
@@ -11746,6 +11746,7 @@ static int bnxt_pcie_dsn_get(struct bnxt *bp, u8 dsn[])put_unaligned_le32 (dw, &dsn[0 ]);pci_read_config_dword (pdev, pos +4 , &dw);put_unaligned_le32 (dw, &dsn[4 ]); + bp->flags |=BNXT_FLAG_DSN_VALID ;return 0 ; }
@@ -11857,9 +11858,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)if (BNXT_PF (bp)) {/* Read the adapter's DSN to use as the eswitch switch_id */ - rc =bnxt_pcie_dsn_get (bp, bp->switch_id); -if (rc) - goto init_err_pci_clean; +bnxt_pcie_dsn_get (bp, bp->switch_id); }/* MTU range: 60 - FW defined max */
drivers/net/ethernet/broadcom/bnxt/bnxt.h +1 -0
@@ -1532,6 +1532,7 @@ struct bnxt {#define BNXT_FLAG_NO_AGG_RINGS 0x20000#define BNXT_FLAG_RX_PAGE_MODE 0x40000#define BNXT_FLAG_MULTI_HOST 0x100000 +#define BNXT_FLAG_DSN_VALID 0x200000#define BNXT_FLAG_DOUBLE_DB 0x400000#define BNXT_FLAG_CHIP_NITRO_A0 0x1000000#define BNXT_FLAG_DIM 0x2000000
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c +3 -0
@@ -398,6 +398,9 @@ static int bnxt_vf_reps_create(struct bnxt *bp)struct net_device *dev;int rc, i; +if (!(bp->flags &BNXT_FLAG_DSN_VALID )) +return -ENODEV ; + bp->vf_reps =kcalloc (num_vfs,sizeof (vf_rep),GFP_KERNEL );if (!bp->vf_reps)return -ENOMEM ;
Signature · 1 line
2.5.1
From: Michael Chan <[email protected]>
Date: Fri, 17 Jan 2020 00:32:44 -0500
Quoted 3 lines
3 small bug fix patches. The 1st two are aRFS fixes and the last one fixes a fatal driver load failure on some kernels without PCIe extended config space support enabled.
Applied.
Quoted 1 line
Please also queue these for -stable. Thanks.
Done.