soc: qcom: aoss: Read back before triggering the IRQ
Subsystems (2)
PATCH 1/1 soc: qcom: aoss: Read back before triggering the IRQ
In some device memory used by msm_qmp, there can be an early ack of a write to memory succeeding. This may cause the outgoing interrupt to be triggered before the msgram reflects the write.
Add a readback to ensure the data is flushed to device memory before triggering the ipc interrupt.
Signed-off-by Arun Kumar Neelakantam <[email protected]>
--- drivers/soc/qcom/qcom_aoss.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/soc/qcom/qcom_aoss.c +4 -0
@@ -225,6 +225,7 @@ static bool qmp_message_empty(struct qmp *qmp)static int qmp_send (struct qmp *qmp,const void *data,size_t len) {long time_left; +size_t tlen;int ret;if (WARN_ON (len +sizeof (u32) > qmp->size))
@@ -239,6 +240,9 @@ static int qmp_send(struct qmp *qmp, const void *data, size_t len)__iowrite32_copy (qmp->msgram + qmp->offset +sizeof (u32), data, len /sizeof (u32));writel (len, qmp->msgram + qmp->offset); + +/* Read back len to confirm data written in message RAM */ + tlen =readl (qmp->msgram + qmp->offset);qmp_kick (qmp); time_left = wait_event_interruptible_timeout(qmp->event,
Signature · 1 line
1.9.1
Bjorn Andersson
AppliedQuoted 8 lines · Arun Kumar Neelakantam
In some device memory used by
msm_qmp, there can be an early ack of a write to memory succeeding. This may cause the outgoing interrupt to be triggered before the msgram reflects the write.Add a readback to ensure the data is flushed to device memory before triggering the ipc interrupt.
Signed-off-by Arun Kumar Neelakantam <[email protected]>
Applied
Thanks,
Bjorn
Quoted 28 lines
--- drivers/soc/qcom/qcom_aoss.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/soc/qcom/qcom_aoss.c +4
-0@@ -225,6 +225,7 @@ static bool qmp_message_empty(struct qmp *qmp)static int qmp_send (struct qmp *qmp,const void *data,size_t len) {long time_left; +size_t tlen;int ret;if (WARN_ON (len +sizeof (u32) > qmp->size))@@ -239,6 +240,9 @@ static int qmp_send(struct qmp *qmp, const void *data, size_t len)__iowrite32_copy (qmp->msgram + qmp->offset +sizeof (u32), data, len /sizeof (u32));writel (len, qmp->msgram + qmp->offset); + +/* Read back len to confirm data written in message RAM */ + tlen =readl (qmp->msgram + qmp->offset);qmp_kick (qmp); time_left = wait_event_interruptible_timeout(qmp->event,Signature · 1 line
1.9.1