refactor main RAM allocation to use hostmem backend
Subsystems (5)
v3 cover refactor main RAM allocation to use hostmem backend
v3:
- due to libvirt not being ready, postpone till 5.1
* [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types and depended
[PATCH v2 86/86] numa: remove deprecated implicit RAM distribution between nodes
- drop as not related "[PATCH v2 85/86] numa: make exit() usage consistent"
- drop "[PATCH v2 76/86] post conversion default_ram_id cleanup"
so that default memory-backedend won't be created for boards that do not care about -m. Which makes -m optin feature. We should decide what do in case board doesn't use -m (but that's out of scope of this series)
- use object_register_sugar_prop() instead of hacking compat props directly
- simplified/reworked aspeed patches
- s/RAM_ADDR_FMT/size_to_str()/
- rename 'ram-memdev' property to 'memory-backend'
- minor fixes to numa-test
- fixes for issues noticed during review of
[PATCH v2 66/86] ppc/{ppc440_bamboo,sam460x}: drop RAM size fixupv2:
- fix compile errors on mingw32 host by introducing RAM_ADDR_UFMT [11/86]
- replace "[PATCH 43/86] hppa: drop RAM size fixup" with alternative patches made by Philippe (which effectively do the same thing but other way around)
- ppc440: fix crash and add suggested valid RAM size in error output. s/ppc4xx_sdram_adjust/ppc4xx_sdram_prep/ and simplify it by removing not necessary nested loop
- rebase on current master due to new conflicts
Series removes ad hoc RAM allocation API (memory_region_allocate_system_memory)
and consolidates it around hostmem backend. It allows to
* resolve conflicts between global -mem-prealloc and hostmem's "policy" option fixing premature allocation before binding policy is applied
* simplify complicated memory allocation routines which had to deal with 2 ways
to allocate RAM.
* it allows to reuse hostmem backends of a choice for main RAM without adding
extra CLI options to duplicate hostmem features.
Recent case was -mem-shared, to enable vhost-user on targets that don't
support hostmem backends [1] (ex: s390)
* move RAM allocation from individual boards into generic machine code and
provide them with prepared MemoryRegion.
* clean up deprecated NUMA features which were tied to the old API (see patches)
- "numa: remove deprecated -mem-path fallback to anonymous RAM"
- (POSTPONED, waiting on libvirt side) "forbid '-numa node,mem' for 5.0 and newer machine types"
- (POSTPONED) "numa: remove deprecated implicit RAM distribution between nodes"
Conversion introduces a new machine.memory-backend property and wrapper code that aliases global -mem-path and -mem-alloc into automatically created hostmem backend properties (provided memory-backend was not set explicitly given by user). And then follows bulk of trivial patches that incrementally convert individual boards to using machine.memory-backend provided MemoryRegion.
Board conversion typically involves:
* providing MachineClass::default_ram_size and MachineClass::default_ram_id so generic code could create default backend if user didn't explicitly provide memory-backend or -m options
* dropping memory_region_allocate_system_memory() call
* using convenience MachineState::ram MemoryRegion, which points to MemoryRegion allocated by ram-memdev
On top of that for some boards:
* added missing ram_size checks (typically it were boards with fixed ram size)
* ram_size fixups were replaced by checks and hard errors, forcing user to provide correct "-m" values instead of ignoring it and continuing running.
After all boards are converted the old API is removed and memory allocation routines are cleaned up.
git tree for testing:
https://github.com/imammedo/qemu convert_main_ram_to_memdev_v3
previous rev:
https://github.com/imammedo/qemu convert_main_ram_to_memdev_v2
https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02960.html
Igor Mammedov (77):
numa: remove deprecated -mem-path fallback to anonymous RAM
machine: introduce memory-backend property
machine: alias -mem-path and -mem-prealloc into memory-foo backend
machine: introduce convenience MachineState::ram initialize MachineState::ram in NUMA case
alpha:dp264: use memdev for RAM
arm/aspeed: actually check RAM size
arm/aspeed: use memdev for RAM
arm/collie: use memdev for RAM
arm/cubieboard: use memdev for RAM
arm/digic_boards: use memdev for RAM
arm/highbank: use memdev for RAM
arm/imx25_pdk: drop RAM size fixup
arm/imx25_pdk: use memdev for RAM
arm/integratorcp: use memdev for RAM
arm/kzm: drop RAM size fixup
arm/kzm: use memdev for RAM
arm/mcimx6ul-evk: use memdev for RAM
arm/mcimx7d-sabre: use memdev for RAM
arm/mps2-tz: use memdev for RAM
arm/mps2: use memdev for RAM
arm/musicpal: use memdev for RAM
arm/nseries: use memdev for RAM
arm/omap_sx1: use memdev for RAM
arm/palm: use memdev for RAM
arm/raspi: use memdev for RAM
arm/sabrelite: use memdev for RAM
arm/sbsa-ref: use memdev for RAM
arm/versatilepb: use memdev for RAM
arm/vexpress: use memdev for RAM
arm/virt: use memdev for RAM
arm/xilinx_zynq: drop RAM size fixup
arm/xilinx_zynq: use memdev for RAM arm/xlnx-versal-virt: use memdev for RAM arm/xlnx-zcu102: use memdev for RAM s390x/s390-virtio-ccw: use memdev for RAM
null-machine: use memdev for RAM
cris/axis_dev88: use memdev for RAM
hppa: use memdev for RAM
x86/microvm: use memdev for RAM
x86/pc: use memdev for RAM
lm32/lm32_boards: use memdev for RAM
lm32/milkymist: use memdev for RAM
m68k/an5206: use memdev for RAM
m68k/mcf5208: use memdev for RAM
m68k/next-cube: use memdev for RAM
mips/boston-cube: use memdev for RAM mips/mips_fulong2e: drop RAM size fixup mips/mips_fulong2e: use memdev for RAM
mips/mips_jazz: use memdev for RAM
mips/mips_malta: use memdev for RAM
mips/mips_mipssim: use memdev for RAM
mips/mips_r4k: use memdev for RAM
ppc/e500: drop RAM size fixup
ppc/e500: use memdev for RAM
ppc/mac_newworld: use memdev for RAM
ppc/mac_oldworld: use memdev for RAM
ppc/pnv: use memdev for RAM
ppc/ppc405_boards: add RAM size checks ppc/ppc405_boards: use memdev for RAM ppc/{ppc440_bamboo,sam460ex}: drop RAM size fixup ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM ppc/prep: use memdev for RAM
ppc/spapr: use memdev for RAM
ppc/virtex_ml507: remove unused arguments ppc/virtex_ml507: use memdev for RAM
sparc/leon3: use memdev for RAM
sparc/sun4m: use memdev for RAM
sparc/niagara: use memdev for RAM
remove no longer used memory_region_allocate_system_memory()
exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
exec: drop bogus mem_path from qemu_ram_alloc_from_fd() make mem_path local variable
hostmem: introduce "prealloc-threads" property
hostmem: fix strict bind policy
tests:numa-test: make top level args dynamic and g_autofree(cli)
cleanups
tests:numa-test: use explicit memdev to specify node RAM
Philippe Mathieu-Daudé (3):
hw/hppa/machine: Correctly check the firmware is in PDC range hw/hppa/machine: Restrict the total memory size to 3GB hw/hppa/machine: Map the PDC memory region with higher priority
hw/alpha/alpha_sys.h | 2 +- include/hw/boards.h | 48 +++++---------- include/hw/misc/aspeed_sdmc.h | 1 + include/hw/ppc/ppc4xx.h | 9 ++- include/sysemu/hostmem.h | 20 +++++- include/sysemu/numa.h | 1 + include/sysemu/sysemu.h | 2 - backends/hostmem-file.c | 8 --- backends/hostmem-memfd.c | 1 - backends/hostmem-ram.c | 2 - backends/hostmem.c | 53 +++++++++++----- exec.c | 66 +++----------------- hw/alpha/dp264.c | 3 +- hw/alpha/typhoon.c | 8 +-- hw/arm/aspeed.c | 18 +++--- hw/arm/collie.c | 17 ++++-- hw/arm/cubieboard.c | 25 +++----- hw/arm/digic_boards.c | 40 ++++++------ hw/arm/highbank.c | 10 ++- hw/arm/imx25_pdk.c | 13 ++-- hw/arm/integratorcp.c | 9 ++- hw/arm/kzm.c | 18 +++--- hw/arm/mcimx6ul-evk.c | 25 +++----- hw/arm/mcimx7d-sabre.c | 25 +++----- hw/arm/mps2-tz.c | 15 +++-- hw/arm/mps2.c | 15 +++-- hw/arm/musicpal.c | 18 ++++-- hw/arm/nseries.c | 32 ++++++---- hw/arm/omap_sx1.c | 20 ++++-- hw/arm/palm.c | 20 ++++-- hw/arm/raspi.c | 34 ++++------- hw/arm/sabrelite.c | 23 +++---- hw/arm/sbsa-ref.c | 7 +-- hw/arm/versatilepb.c | 7 +-- hw/arm/vexpress.c | 14 ++--- hw/arm/virt.c | 7 +-- hw/arm/xilinx_zynq.c | 20 +++--- hw/arm/xlnx-versal-virt.c | 7 +-- hw/arm/xlnx-zcu102.c | 7 +-- hw/core/machine.c | 30 +++++++++ hw/core/null-machine.c | 8 +-- hw/core/numa.c | 101 +++++++++---------------------- hw/cris/axis_dev88.c | 8 +-- hw/hppa/machine.c | 19 +++--- hw/i386/microvm.c | 12 ++-- hw/i386/pc.c | 19 +++--- hw/lm32/lm32_boards.c | 39 ++++++++---- hw/lm32/milkymist.c | 21 ++++--- hw/m68k/an5206.c | 5 +- hw/m68k/mcf5208.c | 5 +- hw/m68k/next-cube.c | 5 +- hw/mips/boston.c | 11 ++-- hw/mips/mips_fulong2e.c | 15 ++--- hw/mips/mips_jazz.c | 7 +-- hw/mips/mips_malta.c | 10 ++- hw/mips/mips_mipssim.c | 9 +-- hw/mips/mips_r4k.c | 12 ++-- hw/misc/aspeed_sdmc.c | 83 +++++++++++++++++++------ hw/ppc/e500.c | 17 +++--- hw/ppc/e500plat.c | 1 + hw/ppc/mac_newworld.c | 6 +- hw/ppc/mac_oldworld.c | 6 +- hw/ppc/mpc8544ds.c | 1 + hw/ppc/pnv.c | 8 +-- hw/ppc/ppc405_boards.c | 48 +++++++++------ hw/ppc/ppc440_bamboo.c | 12 ++-- hw/ppc/ppc4xx_devs.c | 63 +++++++++---------- hw/ppc/prep.c | 15 +++-- hw/ppc/sam460ex.c | 6 +- hw/ppc/spapr.c | 8 +-- hw/ppc/virtex_ml507.c | 19 +++--- hw/s390x/s390-virtio-ccw.c | 7 +-- hw/sparc/leon3.c | 6 +- hw/sparc/sun4m.c | 73 +++++++++++----------- hw/sparc64/niagara.c | 7 +-- qemu-deprecated.texi | 9 --- tests/qtest/numa-test.c | 138 ++++++++++++++++++++++-------------------- vl.c | 37 ++++++++++- 78 files changed, 785 insertions(+), 791 deletions(-)
Signature · 1 line
2.7.4
PATCH v3 1/80 numa: remove deprecated -mem-path fallback to anonymous RAM
it has been deprecated since 4.0 by commit
cb79224b7 (deprecate -mem-path fallback to anonymous RAM)
Deprecation period ran out and it's time to remove it so it won't get in a way of switching to using hostmem backend for RAM.
---
CC:[email protected]
CC: [email protected]
--- hw/core/numa.c | 18 +----------------- qemu-deprecated.texi | 9 --------- 2 files changed, 1 insertion(+), 26 deletions(-)
hw/core/numa.c +1 -17
@@ -784,24 +784,8 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner, {if (mem_path) {#ifdef __linux__ -Error *err =NULL ;memory_region_init_ram_from_file (mr, owner, name, ram_size,0 ,0 , - mem_path, &err); -if (err) { -error_report_err (err); -if (mem_prealloc) { -exit (1 ); - } -warn_report ("falling back to regular RAM allocation" ); -error_printf ("This is deprecated. Make sure that -mem-path " -" specified path has sufficient resources to allocate" -" -m specified RAM amount\n" ); -/* Legacy behavior: if allocation failed, fall back to -* regular RAM allocation. -*/ - mem_path =NULL ; -memory_region_init_ram_nomigrate (mr, owner, name, ram_size, &error_fatal); - } + mem_path, &error_fatal);#else fprintf (stderr,"-mem-path not supported on this host\n" );exit (1 );
qemu-deprecated.texi +0 -9
@@ -113,15 +113,6 @@ QEMU using implicit generic or board specific splitting rule. Use @option{memdev} with @var{memory-backend-ram} backend or @option{mem} (if it's supported by used machine type) to define mapping explictly instead. -@subsection -mem-path fallback to RAM (since 4.1) -Currently if guest RAM allocation from file pointed by @option{mem-path} -fails, QEMU falls back to allocating from RAM, which might result -in unpredictable behavior since the backing file specified by the user -is ignored. In the future, users will be responsible for making sure -the backing storage specified with @option{-mem-path} can actually provide -the guest RAM configured with @option{-m} and QEMU will fail to start up if -RAM allocation is unsuccessful. - @subsection RISC-V -bios (since 4.1) QEMU 4.1 introduced support for the -bios option in QEMU for RISC-V for the
Signature · 1 line
2.7.4
PATCH v3 2/80 machine: introduce memory-backend property
In reply to Igor MammedovProperty will contain link to memory backend that will be used for backing initial RAM.
Follow up commit will alias -mem-path and -mem-prealloc CLI options into memory backend options to make memory handling consistent (using only hostmem backend family for guest RAM allocation).
---
v3:
* rename property name from ram-memdev to memory-backend (Paolo Bonzini <[email protected]>)
--- include/hw/boards.h | 2 ++ hw/core/machine.c | 9 +++++++++ 2 files changed, 11 insertions(+)
include/hw/boards.h +2 -0
@@ -4,6 +4,7 @@#define HW_BOARDS_H #include "exec/memory.h" +#include "sysemu/hostmem.h" #include "sysemu/blockdev.h" #include "sysemu/accel.h" #include "qapi/qapi-types-machine.h"
@@ -285,6 +286,7 @@ struct MachineState {bool enforce_config_section;bool enable_graphics;char *memory_encryption; +HostMemoryBackend *ram_memdev;DeviceMemoryState *device_memory;ram_addr_t ram_size;
hw/core/machine.c +9 -0
@@ -886,6 +886,15 @@ static void machine_initfn(Object *obj) "Table (HMAT)", NULL); } +object_property_add_link (obj,"memory-backend" ,TYPE_MEMORY_BACKEND , + (Object **)&ms->ram_memdev, + object_property_allow_set_link, +OBJ_PROP_LINK_STRONG , &error_abort); +object_property_set_description (obj,"memory-backend" , +"Set RAM backend" +"Valid value is ID of hostmem based backend" , + &error_abort); +/* Register notifier when init is done for sysbus sanity checks */ ms->sysbus_notifier.notify = machine_init_notify;qemu_add_machine_init_done_notifier (&ms->sysbus_notifier);
Signature · 1 line
2.7.4
PATCH v3 3/80 machine: alias -mem-path and -mem-prealloc into memory-foo backend
In reply to Igor MammedovAllow machine to opt in for hostmem backend based initial RAM even if user uses old -mem-path/prealloc options by providing
MachineClass::default_ram_id
Follow up patches will incrementally convert machines to new API, by dropping memory_region_allocate_system_memory() and setting default_ram_id that board used to use before conversion to keep migration stream the same.
---
v3:
* rename "ram-memdev" property to "memory-backend" (Paolo Bonzini <[email protected]>)
--- include/hw/boards.h | 5 +++++ include/sysemu/hostmem.h | 16 ++++++++++++++++ backends/hostmem-file.c | 7 ------- backends/hostmem-ram.c | 2 -- vl.c | 25 +++++++++++++++++++++++++ 5 files changed, 46 insertions(+), 9 deletions(-)
include/hw/boards.h +5 -0
@@ -170,6 +170,10 @@ typedef struct {* false is returned, an error must be set to show the reason of * the rejection. If the hook is not provided, all hotplug will be * allowed. +* @default_ram_id: +* Specifies inital RAM MemoryRegion name to be used for default backend +* creation if user explicitly hasn't specified backend with "memory-backend" +* property. */ struct MachineClass {/*< private >*/
@@ -226,6 +230,7 @@ struct MachineClass {bool nvdimm_supported;bool numa_mem_supported;bool auto_enable_numa; +const char *default_ram_id; HotplugHandler *(*get_hotplug_handler)(MachineState *machine, DeviceState *dev);
include/sysemu/hostmem.h +16 -0
@@ -27,6 +27,22 @@#define MEMORY_BACKEND_CLASS (klass) \ OBJECT_CLASS_CHECK(HostMemoryBackendClass, (klass), TYPE_MEMORY_BACKEND) +/* hostmem-ram.c */ +/** +* @TYPE_MEMORY_BACKEND_RAM: +* name of backend that uses mmap on the anonymous RAM +*/ + +#define TYPE_MEMORY_BACKEND_RAM "memory-backend-ram" + +/* hostmem-file.c */ +/** +* @TYPE_MEMORY_BACKEND_FILE: +* name of backend that uses mmap on a file descriptor +*/ +#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" + +typedef struct HostMemoryBackend HostMemoryBackend ;typedef struct HostMemoryBackendClass HostMemoryBackendClass ;/**
backends/hostmem-file.c +0 -7
@@ -18,13 +18,6 @@#include "sysemu/sysemu.h" #include "qom/object_interfaces.h" -/* hostmem-file.c */ -/** -* @TYPE_MEMORY_BACKEND_FILE: -* name of backend that uses mmap on a file descriptor -*/ -#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" -#define MEMORY_BACKEND_FILE (obj) \ OBJECT_CHECK(HostMemoryBackendFile, (obj), TYPE_MEMORY_BACKEND_FILE)
backends/hostmem-ram.c +0 -2
@@ -16,8 +16,6 @@#include "qemu/module.h" #include "qom/object_interfaces.h" -#define TYPE_MEMORY_BACKEND_RAM "memory-backend-ram" -static void ram_backend_memory_alloc (HostMemoryBackend *backend,Error **errp) {
vl.c +25 -0
@@ -75,6 +75,7 @@ int main(int argc, char **argv)#include "ui/input.h" #include "sysemu/sysemu.h" #include "sysemu/numa.h" +#include "sysemu/hostmem.h" #include "exec/gdbstub.h" #include "qemu/timer.h" #include "chardev/char.h"
@@ -2822,6 +2823,25 @@ static void configure_accelerators(const char *progname) } } +static void create_default_memdev (MachineState *ms,const char *path, +bool prealloc) +{ +Object *obj; +MachineClass *mc =MACHINE_GET_CLASS (ms); + + obj =object_new (path ?TYPE_MEMORY_BACKEND_FILE :TYPE_MEMORY_BACKEND_RAM ); +if (path) { +object_property_set_str (obj, path,"mem-path" , &error_fatal); + } +object_property_set_bool (obj, prealloc,"prealloc" , &error_fatal); +object_property_set_int (obj, ms->ram_size,"size" , &error_fatal); +object_property_add_child (object_get_objects_root (), mc->default_ram_id, + obj, &error_fatal); +user_creatable_complete (USER_CREATABLE (obj), &error_fatal); +object_unref (obj); +object_property_set_link (OBJECT (ms), obj,"memory-backend" , &error_fatal); +} +int main (int argc,char **argv,char **envp) {int i;
@@ -4285,6 +4305,11 @@ int main(int argc, char **argv, char **envp) }parse_numa_opts (current_machine); +if (!current_machine->ram_memdev && + machine_class->default_ram_size && + machine_class->default_ram_id) { +create_default_memdev (current_machine, mem_path, mem_prealloc); + }/* do monitor/qmp handling at preconfig state if requested */ main_loop ();
Signature · 1 line
2.7.4
PATCH v3 4/80 machine: introduce convenience MachineState::ram
In reply to Igor Mammedovthe new field will be used by boards to get access to main RAM memory region and will help to save boiler plate in boards which often introduce a field or variable just for this purpose.
Memory region will be equivalent to what currently used memory_region_allocate_system_memory() is returning apart from that it will come from hostmem backend. Followup patches will incrementally switch boards to using RAM from MachineState::ram.
Patch takes care of non-NUMA case and follow up patch will initialize MachineState::ram for NUMA case.
---
CC: [email protected]
CC: [email protected]
--- include/hw/boards.h | 9 ++++++++- hw/core/machine.c | 21 +++++++++++++++++++++ hw/core/numa.c | 14 +------------- 3 files changed, 30 insertions(+), 14 deletions(-)
include/hw/boards.h +8 -1
@@ -73,7 +73,12 @@ void machine_set_cpu_numa_node(MachineState *machine, Error **errp);void machine_class_allow_dynamic_sysbus_dev (MachineClass *mc,const char *type); - +/* +* Checks that backend isn't used, preps it for exclusive usage and +* returns migratable MemoryRegion provided by backend. +*/ +MemoryRegion *machine_consume_memdev (MachineState *machine, +HostMemoryBackend *backend);/** * CPUArchId:
@@ -292,6 +297,8 @@ struct MachineState {bool enable_graphics;char *memory_encryption;HostMemoryBackend *ram_memdev; +/* convenience alias to ram_memdev memory region or numa container */ +MemoryRegion *ram;DeviceMemoryState *device_memory;ram_addr_t ram_size;
hw/core/machine.c +21 -0
@@ -26,6 +26,7 @@#include "sysemu/qtest.h" #include "hw/pci/pci.h" #include "hw/mem/nvdimm.h" +#include "migration/vmstate.h" GlobalProperty hw_compat_4_2[] = { {"virtio-blk-device" ,"x-enable-wce-if-config-wce" ,"off" },
@@ -1041,10 +1042,30 @@ static void machine_numa_finish_cpu_init(MachineState *machine)g_string_free (s, true); } +MemoryRegion *machine_consume_memdev (MachineState *machine, +HostMemoryBackend *backend) +{ +MemoryRegion *ret =host_memory_backend_get_memory (backend); + +if (memory_region_is_mapped (ret)) { +char *path =object_get_canonical_path_component (OBJECT (backend)); +error_report ("memory backend %s can't be used multiple times." , path); +g_free (path); +exit (EXIT_FAILURE ); + } +host_memory_backend_set_mapped (backend, true); +vmstate_register_ram_global (ret); +return ret; +} +void machine_run_board_init (MachineState *machine) {MachineClass *machine_class =MACHINE_GET_CLASS (machine); +if (machine->ram_memdev) { + machine->ram =machine_consume_memdev (machine, machine->ram_memdev); + } +if (machine->numa_state) {numa_complete_configuration (machine);if (machine->numa_state->num_nodes) {
hw/core/numa.c +1 -13
@@ -817,20 +817,8 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,if (!backend) {continue ; } -MemoryRegion *seg =host_memory_backend_get_memory (backend); - -if (memory_region_is_mapped (seg)) { -char *path =object_get_canonical_path_component (OBJECT (backend)); -error_report ("memory backend %s is used multiple times. Each " -"-numa option must use a different memdev value." , - path); -g_free (path); -exit (1 ); - } - -host_memory_backend_set_mapped (backend, true); +MemoryRegion *seg =machine_consume_memdev (ms, backend);memory_region_add_subregion (mr, addr, seg); -vmstate_register_ram_global (seg); addr += size; } }
Signature · 1 line
2.7.4
PATCH v3 5/80 initialize MachineState::ram in NUMA case
In reply to Igor MammedovIn case of NUMA there are 2 cases to consider:
1. '-numa node,memdev', the only one that will be available for 5.0 and newer machine types.
In this case reuse current behavior, with only difference memdevs are put into MachineState::ram container +
a temporary glue to keep memory_region_allocate_system_memory() working until all boards converted.
2. fake NUMA ("-numa node mem" and default RAM splitting) the later has been deprecated and will be removed but the former is going to stay available for compat reasons for 5.0 and older machine types
it takes allocate_system_memory_nonnuma() path, like non-NUMA case and falls under conversion to memdev. So extend non-NUMA MachineState::ram initialization introduced in previous patch to take care of fake NUMA case.
---
CC: [email protected]
CC: [email protected]
--- include/sysemu/numa.h | 1 + hw/core/numa.c | 43 ++++++++++++++++++++++++++++++------------- vl.c | 7 ++++--- 3 files changed, 35 insertions(+), 16 deletions(-)
include/sysemu/numa.h +1 -0
@@ -112,5 +112,6 @@ void numa_default_auto_assign_ram(MachineClass *mc, NodeInfo *nodes, int nb_nodes, ram_addr_t size);void numa_cpu_pre_plug (const struct CPUArchId *slot,DeviceState *dev,Error **errp); +bool numa_uses_legacy_mem (void );#endif
hw/core/numa.c +30 -13
75 lines not on this page · raw message
vl.c +4 -3
@@ -4305,9 +4305,10 @@ int main(int argc, char **argv, char **envp) }parse_numa_opts (current_machine); -if (!current_machine->ram_memdev && - machine_class->default_ram_size && - machine_class->default_ram_id) { +if (numa_uses_legacy_mem () && + machine_class->default_ram_size && + machine_class->default_ram_id && + !current_machine->ram_memdev) {create_default_memdev (current_machine, mem_path, mem_prealloc); }/* do monitor/qmp handling at preconfig state if requested */
Signature · 1 line
2.7.4
PATCH v3 6/80 alpha:dp264: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/alpha/alpha_sys.h | 2 +- hw/alpha/dp264.c | 3 ++- hw/alpha/typhoon.c | 8 ++------ 3 files changed, 5 insertions(+), 8 deletions(-)
hw/alpha/alpha_sys.h +1 -1
@@ -11,7 +11,7 @@#include "hw/intc/i8259.h" -PCIBus *typhoon_init (ram_addr_t ,ISABus **,qemu_irq *,AlphaCPU *[4 ], +PCIBus *typhoon_init (MemoryRegion *,ISABus **,qemu_irq *,AlphaCPU *[4 ],pci_map_irq_fn );/* alpha_pci.c. */
hw/alpha/dp264.c +2 -1
@@ -75,7 +75,7 @@ static void clipper_init(MachineState *machine) cpus[0 ]->env.trap_arg2 = smp_cpus;/* Init the chipset. */ - pci_bus =typhoon_init (ram_size, &isa_bus, &rtc_irq, cpus, + pci_bus =typhoon_init (machine->ram, &isa_bus, &rtc_irq, cpus, clipper_pci_map_irq);/* Since we have an SRM-compatible PALcode, use the SRM epoch. */
@@ -183,6 +183,7 @@ static void clipper_machine_init(MachineClass *mc) mc->max_cpus =4 ; mc->is_default =1 ; mc->default_cpu_type =ALPHA_CPU_TYPE_NAME ("ev67" ); + mc->default_ram_id ="ram" ; }DEFINE_MACHINE ("clipper" , clipper_machine_init)
hw/alpha/typhoon.c +2 -6
@@ -58,7 +58,6 @@ typedef struct TyphoonState {TyphoonCchip cchip;TyphoonPchip pchip;MemoryRegion dchip_region; -MemoryRegion ram_region; } TyphoonState;/* Called when one of DRIR or DIM changes. */
@@ -817,8 +816,7 @@ static void typhoon_alarm_timer(void *opaque)cpu_interrupt (CPU (s->cchip.cpu[cpu]),CPU_INTERRUPT_TIMER ); } -PCIBus *typhoon_init (ram_addr_t ram_size,ISABus **isa_bus, -qemu_irq *p_rtc_irq, +PCIBus *typhoon_init (MemoryRegion *ram,ISABus **isa_bus,qemu_irq *p_rtc_irq,AlphaCPU *cpus[4 ],pci_map_irq_fn sys_map_irq) {MemoryRegion *addr_space =get_system_memory ();
@@ -851,9 +849,7 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus **isa_bus,/* Main memory region, 0x00.0000.0000. Real hardware supports 32GB, but the address space hole reserved at this point is 8TB. */ -memory_region_allocate_system_memory (&s->ram_region,OBJECT (s),"ram" , - ram_size); -memory_region_add_subregion (addr_space,0 , &s->ram_region); +memory_region_add_subregion (addr_space,0 , ram);/* TIGbus, 0x801.0000.0000, 1GB. */ /* ??? The TIGbus is used for delivering interrupts, and access to
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 06/80] alpha:dp264: use memdev for RAM
Quoted 12 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 5 lines
---
hw/alpha/alpha_sys.h | 2 +- hw/alpha/dp264.c | 3 ++- hw/alpha/typhoon.c | 8 ++------ 3 files changed, 5 insertions(+), 8 deletions(-)
This still has a : instead of / in the patch title. Maybe should be alpha/dp264: ... Probably does not worth a respin but you could correct it if there will be another version for some other reason or when applying it.
Regrards,
BALATON Zoltan
Re: [PATCH REPOST v3 06/80] alpha:dp264: use memdev for RAM
Quoted 19 lines · On Thu, 23 Jan 2020 16:07:19 +0100 (CET) BALATON Zoltan <[email protected]>…
Quoted 12 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>Quoted 5 lines
---
hw/alpha/alpha_sys.h | 2 +- hw/alpha/dp264.c | 3 ++- hw/alpha/typhoon.c | 8 ++------ 3 files changed, 5 insertions(+), 8 deletions(-)
Quoted 3 lines
This still has a : instead of / in the patch title. Maybe should be alpha/dp264: ... Probably does not worth a respin but you could correct it if there will be another version for some other reason or when applying
I plan to respin series, so it will be fixed up in v4
Thanks
Quoted 4 lines
it.
Regrards,
BALATON Zoltan
PATCH v3 7/80 arm/aspeed: actually check RAM size
In reply to Igor MammedovIt's supposed that SOC will check if "-m" provided RAM size is valid by setting "ram-size" property and then board would read back valid (possibly corrected value) to map RAM MemoryReging with valid size. It isn't doing so, since check is called only indirectly from
aspeed_sdmc_reset()->asc->compute_conf()
or much later when guest writes to configuration register.
So depending on "-m" value QEMU end-ups with a warning and an invalid MemoryRegion size allocated and mapped. (examples:
-M ast2500-evb -m 1M
0000000080000000-000000017ffffffe (prio 0, i/o): aspeed-ram-container
0000000080000000-00000000800fffff (prio 0, ram): ram
0000000080100000-00000000bfffffff (prio 0, i/o): max_ram
-M ast2500-evb -m 3G
0000000080000000-000000017ffffffe (prio 0, i/o): aspeed-ram-container
0000000080000000-000000013fffffff (prio 0, ram): ram
[DETECTED OVERFLOW!] 0000000140000000-00000000bfffffff (prio 0, i/o): max_ram)
On top of that sdmc falls back and reports to guest "default" size, it thinks machine should have.
This patch makes ram-size check actually work and changes behavior from a warning later on during machine reset to error_fatal at the moment SOC.ram-size is set so user will have to fix RAM size on CLI to start machine.
It also gets out of the way mutable ram-size logic, so we could consolidate RAM allocation logic around pre-allocated hostmem backend (supplied by user or auto created by generic machine code depending on supplied -m/mem-path/mem-prealloc options.
---
v3:
* replace
[PATCH v2 07/86] arm:aspeed: convert valid RAM sizes to data [PATCH v2 08/86] arm:aspeed: actually check RAM size
with a simplified variant that adds ram_size check to sdmc.ram-size property
* use g_assert_not_reached() in default branch
(Cédric Le Goater <[email protected]>)
--- include/hw/misc/aspeed_sdmc.h | 1 + hw/arm/aspeed.c | 13 +++---- hw/misc/aspeed_sdmc.c | 83 +++++++++++++++++++++++++++++++++---------- 3 files changed, 70 insertions(+), 27 deletions(-)
include/hw/misc/aspeed_sdmc.h +1 -0
@@ -40,6 +40,7 @@ typedef struct AspeedSDMCClass {SysBusDeviceClass parent_class;uint64_t max_ram_size; +const uint64_t *valid_ram_sizes;uint32_t (*compute_conf)(AspeedSDMCState *s,uint32_t data);void (*write)(AspeedSDMCState *s,uint32_t reg,uint32_t data); } AspeedSDMCClass;
hw/arm/aspeed.c +5 -8
@@ -191,8 +191,12 @@ static void aspeed_machine_init(MachineState *machine) sc =ASPEED_SOC_GET_CLASS (&bmc->soc); +/* +* This will error out if isize is not supported by memory controller. +*/ object_property_set_uint (OBJECT (&bmc->soc), ram_size,"ram-size" , - &error_abort); + &error_fatal); +object_property_set_int (OBJECT (&bmc->soc), amc->hw_strap1,"hw-strap1" , &error_abort); object_property_set_int(OBJECT(&bmc->soc), amc->hw_strap2, "hw-strap2",
@@ -215,13 +219,6 @@ static void aspeed_machine_init(MachineState *machine)object_property_set_bool (OBJECT (&bmc->soc), true,"realized" , &error_abort); -/* -* Allocate RAM after the memory controller has checked the size -* was valid. If not, a default value is used. -*/ - ram_size =object_property_get_uint (OBJECT (&bmc->soc),"ram-size" , - &error_abort); -memory_region_allocate_system_memory (&bmc->ram,NULL ,"ram" , ram_size);memory_region_add_subregion (&bmc->ram_container,0 , &bmc->ram); memory_region_add_subregion(get_system_memory(),
hw/misc/aspeed_sdmc.c +64 -19
167 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 8/80 arm/aspeed: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/aspeed.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
hw/arm/aspeed.c +2 -3
@@ -35,7 +35,6 @@ static struct arm_boot_info aspeed_board_binfo = {struct AspeedBoardState {AspeedSoCState soc;MemoryRegion ram_container; -MemoryRegion ram;MemoryRegion max_ram; };
@@ -184,6 +183,7 @@ static void aspeed_machine_init(MachineState *machine)memory_region_init (&bmc->ram_container,NULL ,"aspeed-ram-container" ,UINT32_MAX ); +memory_region_add_subregion (&bmc->ram_container,0 , machine->ram); object_initialize_child(OBJECT(machine), "soc", &bmc->soc, (sizeof(bmc->soc)), amc->soc_name, &error_abort,
@@ -219,8 +219,6 @@ static void aspeed_machine_init(MachineState *machine)object_property_set_bool (OBJECT (&bmc->soc), true,"realized" , &error_abort); -memory_region_allocate_system_memory (&bmc->ram,NULL ,"ram" , ram_size); -memory_region_add_subregion (&bmc->ram_container,0 , &bmc->ram);memory_region_add_subregion (get_system_memory (), sc->memmap[ASPEED_SDRAM ], &bmc->ram_container);
@@ -397,6 +395,7 @@ static void aspeed_machine_class_init(ObjectClass *oc, void *data) mc->no_floppy =1 ; mc->no_cdrom =1 ; mc->no_parallel =1 ; + mc->default_ram_id ="ram" ; }static void aspeed_machine_palmetto_class_init (ObjectClass *oc,void *data)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 08/80] arm/aspeed: use memdev for RAM
Quoted 9 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.
Quoted 3 lines
Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>Reviewed-by Cédric Le Goater <[email protected]>
PATCH v3 9/80 arm/collie: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
- while at it add check for user supplied RAM size and error out if it mismatches board expected value.
- introduce RAM_ADDR_UFMT to avoid build errors on 32-bit hosts when specifying format string for ram_addr_t type
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
v3:
* instead of RAM_ADDR_UFMT adding use size_to_str() Philippe Mathieu-Daudé <[email protected]>
--- hw/arm/collie.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
hw/arm/collie.c +12 -5
@@ -10,6 +10,7 @@*/ #include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "hw/sysbus.h" #include "hw/boards.h" #include "strongarm.h"
@@ -20,20 +21,24 @@static struct arm_boot_info collie_binfo = { .loader_start =SA_SDCS0 , - .ram_size =0x20000000 , };static void collie_init (MachineState *machine) {StrongARMState *s;DriveInfo *dinfo; -MemoryRegion *sdram =g_new (MemoryRegion,1 ); +MachineClass *mc =MACHINE_GET_CLASS (machine); + +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } s =sa1110_init (machine->cpu_type); -memory_region_allocate_system_memory (sdram,NULL ,"strongarm.sdram" , - collie_binfo.ram_size); -memory_region_add_subregion (get_system_memory (),SA_SDCS0 , sdram); +memory_region_add_subregion (get_system_memory (),SA_SDCS0 , machine->ram); dinfo =drive_get (IF_PFLASH ,0 ,0 ); pflash_cfi01_register(SA_CS0, "collie.fl1", 0x02000000,
@@ -57,6 +62,8 @@ static void collie_machine_init(MachineClass *mc) mc->init = collie_init; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("sa1110" ); + mc->default_ram_size =0x20000000 ; + mc->default_ram_id ="strongarm.sdram" ; }DEFINE_MACHINE ("collie" , collie_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 09/80] arm/collie: use memdev for RAM
Quoted 23 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
- while at it add check for user supplied RAM size and error out if it mismatches board expected value.
- introduceRAM_ADDR_UFMTto avoid build errors on 32-bit hosts when specifying format string forram_addr_ttypeSigned-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
v3:
* instead ofRAM_ADDR_UFMTadding usesize_to_str()Philippe Mathieu-Daudé <[email protected]>
Quoted 7 lines
--- hw/arm/collie.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
I don't know anything about collie, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 10/80 arm/cubieboard: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
While at it, get rid of no longer needed CubieBoardState wrapper.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/cubieboard.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-)
hw/arm/cubieboard.c +8 -17
@@ -28,52 +28,42 @@ static struct arm_boot_info cubieboard_binfo = { .board_id = 0x1008, }; -typedef struct CubieBoardState { -AwA10State *a10; -MemoryRegion sdram; -}CubieBoardState ; -static void cubieboard_init (MachineState *machine) { -CubieBoardState *s =g_new (CubieBoardState,1 ); +AwA10State *a10 =AW_A10 (object_new (TYPE_AW_A10 ));Error *err =NULL ; - s->a10 =AW_A10 (object_new (TYPE_AW_A10 )); - -object_property_set_int (OBJECT (&s->a10->emac),1 ,"phy-addr" , &err); +object_property_set_int (OBJECT (&a10->emac),1 ,"phy-addr" , &err);if (err !=NULL ) {error_reportf_err (err,"Couldn't set phy address: " );exit (1 ); } -object_property_set_int (OBJECT (&s->a10->timer),32768 ,"clk0-freq" , &err); +object_property_set_int (OBJECT (&a10->timer),32768 ,"clk0-freq" , &err);if (err !=NULL ) {error_reportf_err (err,"Couldn't set clk0 frequency: " );exit (1 ); } -object_property_set_int (OBJECT (&s->a10->timer),24000000 ,"clk1-freq" , - &err); +object_property_set_int (OBJECT (&a10->timer),24000000 ,"clk1-freq" , &err);if (err !=NULL ) {error_reportf_err (err,"Couldn't set clk1 frequency: " );exit (1 ); } -object_property_set_bool (OBJECT (s->a10), true,"realized" , &err); +object_property_set_bool (OBJECT (a10), true,"realized" , &err);if (err !=NULL ) {error_reportf_err (err,"Couldn't realize Allwinner A10: " );exit (1 ); } -memory_region_allocate_system_memory (&s->sdram,NULL ,"cubieboard.ram" , - machine->ram_size);memory_region_add_subregion (get_system_memory (),AW_A10_SDRAM_BASE , - &s->sdram); + machine->ram);/* TODO create and connect IDE devices for ide_drive_get() */ cubieboard_binfo.ram_size = machine->ram_size; -arm_load_kernel (&s->a10->cpu, machine, &cubieboard_binfo); +arm_load_kernel (&a10->cpu, machine, &cubieboard_binfo); }static void cubieboard_machine_init (MachineClass *mc)
@@ -84,6 +74,7 @@ static void cubieboard_machine_init(MachineClass *mc) mc->block_default_type =IF_IDE ; mc->units_per_default_bus =1 ; mc->ignore_memory_transaction_failures = true; + mc->default_ram_id ="cubieboard.ram" ; }DEFINE_MACHINE ("cubieboard" , cubieboard_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 10/80] arm/cubieboard: use memdev for RAM
Quoted 12 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
While at it, get rid of no longer needed CubieBoardState wrapper.Signed-off-by Igor Mammedov <[email protected]>
Quoted 9 lines
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/cubieboard.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-)
I don't know anything about cubieboard, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 11/80 arm/digic_boards: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
remove no longer needed DigicBoardState
PS2:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v3:
* move 'DigicState *s' declaration to the top of digic4_board_init()
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/arm/digic_boards.c | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-)
hw/arm/digic_boards.c +21 -19
@@ -35,39 +35,40 @@#include "hw/loader.h" #include "sysemu/sysemu.h" #include "sysemu/qtest.h" +#include "qemu/units.h" +#include "qemu/cutils.h" #define DIGIC4_ROM0_BASE 0xf0000000#define DIGIC4_ROM1_BASE 0xf8000000#define DIGIC4_ROM_MAX_SIZE 0x08000000 -typedef struct DigicBoardState { -DigicState *digic; -MemoryRegion ram; -}DigicBoardState ; -typedef struct DigicBoard { -hwaddr ram_size; -void (*add_rom0)(DigicBoardState *,hwaddr ,const char *); +void (*add_rom0)(DigicState *,hwaddr ,const char *);const char *rom0_def_filename; -void (*add_rom1)(DigicBoardState *,hwaddr ,const char *); +void (*add_rom1)(DigicState *,hwaddr ,const char *);const char *rom1_def_filename; }DigicBoard ; -static void digic4_board_init (DigicBoard *board) +static void digic4_board_init (MachineState *machine,DigicBoard *board) {Error *err =NULL ; +DigicState *s =DIGIC (object_new (TYPE_DIGIC )); +MachineClass *mc =MACHINE_GET_CLASS (machine); + +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } -DigicBoardState *s =g_new (DigicBoardState,1 ); - - s->digic =DIGIC (object_new (TYPE_DIGIC )); -object_property_set_bool (OBJECT (s->digic), true,"realized" , &err); +object_property_set_bool (OBJECT (s), true,"realized" , &err);if (err !=NULL ) {error_reportf_err (err,"Couldn't realize DIGIC SoC: " );exit (1 ); } -memory_region_allocate_system_memory (&s->ram,NULL ,"ram" , board->ram_size); -memory_region_add_subregion (get_system_memory (),0 , &s->ram); +memory_region_add_subregion (get_system_memory (),0 , machine->ram);if (board->add_rom0) { board->add_rom0 (s,DIGIC4_ROM0_BASE , board->rom0_def_filename);
@@ -78,7 +79,7 @@ static void digic4_board_init(DigicBoard *board) } } -static void digic_load_rom (DigicBoardState *s,hwaddr addr, +static void digic_load_rom (DigicState *s,hwaddr addr,hwaddr max_size,const char *def_filename) {target_long rom_size;
@@ -118,7 +119,7 @@ static void digic_load_rom(DigicBoardState *s, hwaddr addr,* Samsung K8P3215UQB * 64M Bit (4Mx16) Page Mode / Multi-Bank NOR Flash Memory */ -static void digic4_add_k8p3215uqb_rom (DigicBoardState *s,hwaddr addr, +static void digic4_add_k8p3215uqb_rom (DigicState *s,hwaddr addr,const char *def_filename) {#define FLASH_K8P3215UQB_SIZE (4 * 1024 * 1024)
@@ -135,14 +136,13 @@ static void digic4_add_k8p3215uqb_rom(DigicBoardState *s, hwaddr addr, }static DigicBoard digic4_board_canon_a1100 = { - .ram_size =64 *1024 *1024 , .add_rom1 = digic4_add_k8p3215uqb_rom, .rom1_def_filename ="canon-a1100-rom1.bin" , };static void canon_a1100_init (MachineState *machine) { -digic4_board_init (&digic4_board_canon_a1100); +digic4_board_init (machine, &digic4_board_canon_a1100); }static void canon_a1100_machine_init (MachineClass *mc)
@@ -150,6 +150,8 @@ static void canon_a1100_machine_init(MachineClass *mc) mc->desc ="Canon PowerShot A1100 IS" ; mc->init = &canon_a1100_init; mc->ignore_memory_transaction_failures = true; + mc->default_ram_size =64 * MiB; + mc->default_ram_id ="ram" ; }DEFINE_MACHINE ("canon-a1100" , canon_a1100_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 11/80] arm/digic_boards: use memdev for RAM
Quoted 23 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
remove no longer needed DigicBoardStatePS2:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v3:
* move 'DigicState *s' declaration to the top ofdigic4_board_init()
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
Quoted 8 lines
--- hw/arm/digic_boards.c | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-)
I don't know anything about digic_boards, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 12/80 arm/highbank: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/highbank.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
hw/arm/highbank.c +4 -6
@@ -236,7 +236,6 @@ enum cxmachines {*/ static void calxeda_init (MachineState *machine,enum cxmachines machine_id) { -ram_addr_t ram_size = machine->ram_size;DeviceState *dev =NULL ;SysBusDevice *busdev;qemu_irq pic[128 ];
@@ -247,7 +246,6 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id)qemu_irq cpu_virq[4 ];qemu_irq cpu_vfiq[4 ];MemoryRegion *sysram; -MemoryRegion *dram;MemoryRegion *sysmem;char *sysboot_filename;
@@ -290,10 +288,8 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id) } sysmem =get_system_memory (); - dram =g_new (MemoryRegion,1 ); -memory_region_allocate_system_memory (dram,NULL ,"highbank.dram" , ram_size);/* SDRAM at address zero. */ -memory_region_add_subregion (sysmem,0 , dram); +memory_region_add_subregion (sysmem,0 , machine->ram); sysram =g_new (MemoryRegion,1 ); memory_region_init_ram(sysram, NULL, "highbank.sysram", 0x8000,
@@ -387,7 +383,7 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id)/* TODO create and connect IDE devices for ide_drive_get() */ - highbank_binfo.ram_size = ram_size; + highbank_binfo.ram_size = machine->ram_size;/* highbank requires a dtb in order to boot, and the dtb will override * the board ID. The following value is ignored, so set it to -1 to be * clear that the value is meaningless.
@@ -430,6 +426,7 @@ static void highbank_class_init(ObjectClass *oc, void *data) mc->units_per_default_bus =1 ; mc->max_cpus =4 ; mc->ignore_memory_transaction_failures = true; + mc->default_ram_id ="highbank.dram" ; }static const TypeInfo highbank_type = {
@@ -448,6 +445,7 @@ static void midway_class_init(ObjectClass *oc, void *data) mc->units_per_default_bus =1 ; mc->max_cpus =4 ; mc->ignore_memory_transaction_failures = true; + mc->default_ram_id ="highbank.dram" ; }static const TypeInfo midway_type = {
Signature · 1 line
2.7.4
PATCH v3 13/80 arm/imx25_pdk: drop RAM size fixup
In reply to Igor MammedovIf user provided non-sense RAM size, board will complain and continue running with max RAM size supported.
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/imx25_pdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
hw/arm/imx25_pdk.c +2 -2
@@ -78,10 +78,10 @@ static void imx25_pdk_init(MachineState *machine)/* We need to initialize our memory */ if (machine->ram_size > (FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE )) { -warn_report ("RAM size " RAM_ADDR_FMT " above max supported, " +error_report ("RAM size " RAM_ADDR_FMT " above max supported, " "reduced to %x" , machine->ram_size,FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE ); - machine->ram_size =FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE ; +exit (EXIT_FAILURE ); } memory_region_allocate_system_memory(&s->ram, NULL, "imx25.ram",
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 13/80] arm/imx25_pdk: drop RAM size fixup
Quoted 38 lines · Igor Mammedov
If user provided non-sense RAM size, board will complain and continue running with max RAM size supported.
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
Signed-off-by Igor Mammedov <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/imx25_pdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/arm/imx25_pdk.c +2
-2@@ -78,10 +78,10 @@ static void imx25_pdk_init(MachineState *machine)/* We need to initialize our memory */ if (machine->ram_size > (FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE )) { -warn_report ("RAM size " RAM_ADDR_FMT " above max supported, " +error_report ("RAM size " RAM_ADDR_FMT " above max supported, " "reduced to %x" , machine->ram_size,FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE ); - machine->ram_size =FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE ; +exit (EXIT_FAILURE ); } memory_region_allocate_system_memory(&s->ram, NULL, "imx25.ram",Signature · 1 line
2.7.4
This would break existing command lines that are happily using the max ram size, which is only 512 MB. Yes, those command lines are wrong, but I'm not sure we want to flip the warn to an error without machine type versioning - which this board doesn't have.
Thanks,
drew
Re: [PATCH REPOST v3 13/80] arm/imx25_pdk: drop RAM size fixup
Quoted 35 lines · On Thu, 23 Jan 2020 13:39:07 +0100 Andrew Jones <[email protected]> wrote:
Quoted 34 lines · Igor Mammedov
If user provided non-sense RAM size, board will complain and continue running with max RAM size supported.
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
Signed-off-by Igor Mammedov <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/imx25_pdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/arm/imx25_pdk.c +2
-2@@ -78,10 +78,10 @@ static void imx25_pdk_init(MachineState *machine)/* We need to initialize our memory */ if (machine->ram_size > (FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE )) { -warn_report ("RAM size " RAM_ADDR_FMT " above max supported, " +error_report ("RAM size " RAM_ADDR_FMT " above max supported, " "reduced to %x" , machine->ram_size,FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE ); - machine->ram_size =FSL_IMX25_SDRAM0_SIZE +FSL_IMX25_SDRAM1_SIZE ; +exit (EXIT_FAILURE ); }
Quoted 9 lines
Quoted 4 lines
hw/arm/imx25_pdk.c +0
-0memory_region_allocate_system_memory(&s->ram, NULL, "imx25.ram",Signature · 1 line
2.7.4This would break existing command lines that are happily using the max ram size, which is only 512 MB. Yes, those command lines are wrong, but I'm not sure we want to flip the warn to an error without machine type versioning - which this board doesn't have.
We typically don't do machine type versioning for CLI changes and in this case it would be plain user error in providing invalid CLI, so it should be fixed on user's side and not worked around by QEMU.
It was fine before when board was allocating RAM on its own, but with RAM initialization moved to generic code it won't be possible. Hence fixup dropped and warning is converted to error to let user know that their CLI should be fixed.
Board description [1] says that it supports up to 512Mb of RAM max.
1) https://www.nxp.com/design/development-boards/i.mx-evaluation-and-development-boards/i.mx25-product-development-kit:IMX25PDK
Quoted 2 lines
Thanks,
drew
PATCH v3 14/80 arm/imx25_pdk: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/imx25_pdk.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
hw/arm/imx25_pdk.c +4 -5
@@ -58,7 +58,6 @@typedef struct IMX25PDK {FslIMX25State soc; -MemoryRegion ram;MemoryRegion ram_alias; }IMX25PDK ;
@@ -84,10 +83,8 @@ static void imx25_pdk_init(MachineState *machine)exit (EXIT_FAILURE ); } -memory_region_allocate_system_memory (&s->ram,NULL ,"imx25.ram" , - machine->ram_size);memory_region_add_subregion (get_system_memory (),FSL_IMX25_SDRAM0_ADDR , - &s->ram); + machine->ram);/* initialize the alias memory if any */ for (i = 0, ram_size = machine->ram_size, alias_offset = 0;
@@ -107,7 +104,8 @@ static void imx25_pdk_init(MachineState *machine)if (size < ram[i].size) {memory_region_init_alias (&s->ram_alias,NULL ,"ram.alias" , - &s->ram, alias_offset, ram[i].size - size); + machine->ram, + alias_offset, ram[i].size - size);memory_region_add_subregion (get_system_memory (), ram[i].addr + size, &s->ram_alias); }
@@ -135,6 +133,7 @@ static void imx25_pdk_machine_init(MachineClass *mc) mc->desc ="ARM i.MX25 PDK board (ARM926)" ; mc->init = imx25_pdk_init; mc->ignore_memory_transaction_failures = true; + mc->default_ram_id ="imx25.ram" ; }DEFINE_MACHINE ("imx25-pdk" , imx25_pdk_machine_init)
Signature · 1 line
2.7.4
PATCH v3 15/80 arm/integratorcp: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/integratorcp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
hw/arm/integratorcp.c +4 -5
@@ -585,7 +585,6 @@ static void integratorcp_init(MachineState *machine)Object *cpuobj;ARMCPU *cpu;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *ram_alias =g_new (MemoryRegion,1 );qemu_irq pic[32 ];DeviceState *dev, *sic, *icp;
@@ -605,14 +604,13 @@ static void integratorcp_init(MachineState *machine) cpu =ARM_CPU (cpuobj); -memory_region_allocate_system_memory (ram,NULL ,"integrator.ram" , - ram_size);/* ??? On a real system the first 1Mb is mapped as SSRAM or boot flash. */ /* ??? RAM should repeat to fill physical memory space. */ /* SDRAM at address zero*/ -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);/* And again at address 0x80000000 */ -memory_region_init_alias (ram_alias,NULL ,"ram.alias" , ram,0 , ram_size); +memory_region_init_alias (ram_alias,NULL ,"ram.alias" , machine->ram, +0 , ram_size);memory_region_add_subregion (address_space_mem,0x80000000 , ram_alias); dev =qdev_create (NULL ,TYPE_INTEGRATOR_CM );
@@ -660,6 +658,7 @@ static void integratorcp_machine_init(MachineClass *mc) mc->init = integratorcp_init; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("arm926" ); + mc->default_ram_id ="integrator.ram" ; }DEFINE_MACHINE ("integratorcp" , integratorcp_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 15/80] arm/integratorcp: use memdev for RAM
Quoted 9 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.Signed-off-by Igor Mammedov <[email protected]>
Quoted 9 lines
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/integratorcp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
I don't know anything about integratorcp, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 16/80 arm/kzm: drop RAM size fixup
In reply to Igor MammedovIf the user provided too large a RAM size, the code used to complain and trim it to the max size. Now tht RAM is allocated by generic code, that's no longer possible, so generate an error and exit instead.
---
v3:
* rephrase commit message in nicer way
("Chubb, Peter (Data61, Kensington NSW)" <[email protected]>)
* reword error message and use size_to_str() to pretty print suggested size ("Chubb, Peter (Data61, Kensington NSW)" <[email protected]>)
--- hw/arm/kzm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
hw/arm/kzm.c +5 -4
@@ -25,6 +25,7 @@#include "hw/char/serial.h" #include "sysemu/qtest.h" #include "sysemu/sysemu.h" +#include "qemu/cutils.h" /* Memory map for Kzm Emulation Baseboard: * 0x00000000-0x7fffffff See i.MX31 SOC for support
@@ -78,10 +79,10 @@ static void kzm_init(MachineState *machine)/* Check the amount of memory is compatible with the SOC */ if (machine->ram_size > (FSL_IMX31_SDRAM0_SIZE +FSL_IMX31_SDRAM1_SIZE )) { -warn_report ("RAM size " RAM_ADDR_FMT " above max supported, " -"reduced to %x" , machine->ram_size, -FSL_IMX31_SDRAM0_SIZE +FSL_IMX31_SDRAM1_SIZE ); - machine->ram_size =FSL_IMX31_SDRAM0_SIZE +FSL_IMX31_SDRAM1_SIZE ; +char *sz =size_to_str (FSL_IMX31_SDRAM0_SIZE +FSL_IMX31_SDRAM1_SIZE ); +error_report ("RAM size more than %s is not supported" , sz); +g_free (sz); +exit (EXIT_FAILURE ); } memory_region_allocate_system_memory(&s->ram, NULL, "kzm.ram",
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 16/80] arm/kzm: drop RAM size fixup
Igor> If the user provided too large a RAM size, the code used to Igor> complain and trim it to the max size. Now tht RAM is allocated by Igor> generic code, that's no longer possible, so generate an error and Igor> exit instead.
You can add my 'reviewed-by' to this. There's one really minor typo in the comment (tht->that) that you may wish to fix before the final commit.
Signature · 2 lines
Dr Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/ Trustworthy Systems Group CSIRO's Data61
Re: [PATCH REPOST v3 16/80] arm/kzm: drop RAM size fixup
Quoted 8 lines · Kensington NSW)
Igor> If the user provided too large a RAM size, the code used to Igor> complain and trim it to the max size. Now tht RAM is allocated by Igor> generic code, that's no longer possible, so generate an error and Igor> exit instead.
You can add my 'reviewed-by' to this. There's one really minor typo in the comment (
tht->that) that you may wish to fix before the final commit.
Thanks,
will do it in v4
(considering that there are already fixes to
the current version, I'll rebase and repost)
Quoted 3 lines
Reviewed-by Peter Chubb <[email protected]>
PATCH v3 17/80 arm/kzm: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/kzm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
hw/arm/kzm.c +4 -5
@@ -52,7 +52,6 @@typedef struct IMX31KZM {FslIMX31State soc; -MemoryRegion ram;MemoryRegion ram_alias; }IMX31KZM ;
@@ -85,10 +84,8 @@ static void kzm_init(MachineState *machine)exit (EXIT_FAILURE ); } -memory_region_allocate_system_memory (&s->ram,NULL ,"kzm.ram" , - machine->ram_size);memory_region_add_subregion (get_system_memory (),FSL_IMX31_SDRAM0_ADDR , - &s->ram); + machine->ram);/* initialize the alias memory if any */ for (i = 0, ram_size = machine->ram_size, alias_offset = 0;
@@ -108,7 +105,8 @@ static void kzm_init(MachineState *machine)if (size < ram[i].size) {memory_region_init_alias (&s->ram_alias,NULL ,"ram.alias" , - &s->ram, alias_offset, ram[i].size - size); + machine->ram, + alias_offset, ram[i].size - size);memory_region_add_subregion (get_system_memory (), ram[i].addr + size, &s->ram_alias); }
@@ -140,6 +138,7 @@ static void kzm_machine_init(MachineClass *mc) mc->desc ="ARM KZM Emulation Baseboard (ARM1136)" ; mc->init = kzm_init; mc->ignore_memory_transaction_failures = true; + mc->default_ram_id ="kzm.ram" ; }DEFINE_MACHINE ("kzm" , kzm_machine_init)
Signature · 1 line
2.7.4
PATCH v3 18/80 arm/mcimx6ul-evk: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
remove no longer needed MCIMX6ULEVK
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/mcimx6ul-evk.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-)
hw/arm/mcimx6ul-evk.c +9 -16
@@ -19,15 +19,10 @@#include "qemu/error-report.h" #include "sysemu/qtest.h" -typedef struct { -FslIMX6ULState soc; -MemoryRegion ram; -}MCIMX6ULEVK ; -static void mcimx6ul_evk_init (MachineState *machine) {static struct arm_boot_info boot_info; -MCIMX6ULEVK *s =g_new0 (MCIMX6ULEVK ,1 ); +FslIMX6ULState *s;int i;if (machine->ram_size >FSL_IMX6UL_MMDC_SIZE ) {
@@ -43,15 +38,12 @@ static void mcimx6ul_evk_init(MachineState *machine) .nb_cpus = machine->smp.cpus, }; -object_initialize_child (OBJECT (machine),"soc" , &s->soc,sizeof (s->soc), -TYPE_FSL_IMX6UL , &error_fatal,NULL ); - -object_property_set_bool (OBJECT (&s->soc), true,"realized" , &error_fatal); + s =FSL_IMX6UL (object_new (TYPE_FSL_IMX6UL )); +object_property_add_child (OBJECT (machine),"soc" ,OBJECT (s), &error_fatal); +object_property_set_bool (OBJECT (s), true,"realized" , &error_fatal); -memory_region_allocate_system_memory (&s->ram,NULL ,"mcimx6ul-evk.ram" , - machine->ram_size); -memory_region_add_subregion (get_system_memory (), -FSL_IMX6UL_MMDC_ADDR , &s->ram); +memory_region_add_subregion (get_system_memory (),FSL_IMX6UL_MMDC_ADDR , + machine->ram);for (i =0 ; i <FSL_IMX6UL_NUM_USDHCS ; i++) {BusState *bus;
@@ -61,7 +53,7 @@ static void mcimx6ul_evk_init(MachineState *machine) di =drive_get_next (IF_SD ); blk = di ?blk_by_legacy_dinfo (di) :NULL ; - bus =qdev_get_child_bus (DEVICE (&s->soc.usdhc[i]),"sd-bus" ); + bus =qdev_get_child_bus (DEVICE (&s->usdhc[i]),"sd-bus" ); carddev =qdev_create (bus,TYPE_SD_CARD );qdev_prop_set_drive (carddev,"drive" , blk, &error_fatal); object_property_set_bool(OBJECT(carddev), true,
@@ -69,7 +61,7 @@ static void mcimx6ul_evk_init(MachineState *machine) }if (!qtest_enabled ()) { -arm_load_kernel (&s->soc.cpu, machine, &boot_info); +arm_load_kernel (&s->cpu, machine, &boot_info); } }
@@ -78,5 +70,6 @@ static void mcimx6ul_evk_machine_init(MachineClass *mc) mc->desc ="Freescale i.MX6UL Evaluation Kit (Cortex A7)" ; mc->init = mcimx6ul_evk_init; mc->max_cpus =FSL_IMX6UL_NUM_CPUS ; + mc->default_ram_id ="mcimx6ul-evk.ram" ; }DEFINE_MACHINE ("mcimx6ul-evk" , mcimx6ul_evk_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 18/80] arm/mcimx6ul-evk: use memdev for RAM
Quoted 12 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
remove no longer needed MCIMX6ULEVKSigned-off-by Igor Mammedov <[email protected]>
Quoted 9 lines
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/mcimx6ul-evk.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-)
I don't know anything about mcimx6ul-evk, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 19/80 arm/mcimx7d-sabre: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
remove no longer needed MCIMX7Sabre
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/mcimx7d-sabre.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-)
hw/arm/mcimx7d-sabre.c +9 -16
@@ -21,15 +21,10 @@#include "qemu/error-report.h" #include "sysemu/qtest.h" -typedef struct { -FslIMX7State soc; -MemoryRegion ram; -}MCIMX7Sabre ; -static void mcimx7d_sabre_init (MachineState *machine) {static struct arm_boot_info boot_info; -MCIMX7Sabre *s =g_new0 (MCIMX7Sabre,1 ); +FslIMX7State *s;int i;if (machine->ram_size >FSL_IMX7_MMDC_SIZE ) {
@@ -45,15 +40,12 @@ static void mcimx7d_sabre_init(MachineState *machine) .nb_cpus = machine->smp.cpus, }; -object_initialize_child (OBJECT (machine),"soc" , - &s->soc,sizeof (s->soc), -TYPE_FSL_IMX7 , &error_fatal,NULL ); -object_property_set_bool (OBJECT (&s->soc), true,"realized" , &error_fatal); + s =FSL_IMX7 (object_new (TYPE_FSL_IMX7 )); +object_property_add_child (OBJECT (machine),"soc" ,OBJECT (s), &error_fatal); +object_property_set_bool (OBJECT (s), true,"realized" , &error_fatal); -memory_region_allocate_system_memory (&s->ram,NULL ,"mcimx7d-sabre.ram" , - machine->ram_size); -memory_region_add_subregion (get_system_memory (), -FSL_IMX7_MMDC_ADDR , &s->ram); +memory_region_add_subregion (get_system_memory (),FSL_IMX7_MMDC_ADDR , + machine->ram);for (i =0 ; i <FSL_IMX7_NUM_USDHCS ; i++) {BusState *bus;
@@ -63,7 +55,7 @@ static void mcimx7d_sabre_init(MachineState *machine) di =drive_get_next (IF_SD ); blk = di ?blk_by_legacy_dinfo (di) :NULL ; - bus =qdev_get_child_bus (DEVICE (&s->soc.usdhc[i]),"sd-bus" ); + bus =qdev_get_child_bus (DEVICE (&s->usdhc[i]),"sd-bus" ); carddev =qdev_create (bus,TYPE_SD_CARD );qdev_prop_set_drive (carddev,"drive" , blk, &error_fatal); object_property_set_bool(OBJECT(carddev), true,
@@ -71,7 +63,7 @@ static void mcimx7d_sabre_init(MachineState *machine) }if (!qtest_enabled ()) { -arm_load_kernel (&s->soc.cpu[0 ], machine, &boot_info); +arm_load_kernel (&s->cpu[0 ], machine, &boot_info); } }
@@ -80,5 +72,6 @@ static void mcimx7d_sabre_machine_init(MachineClass *mc) mc->desc ="Freescale i.MX7 DUAL SABRE (Cortex A7)" ; mc->init = mcimx7d_sabre_init; mc->max_cpus =FSL_IMX7_NUM_CPUS ; + mc->default_ram_id ="mcimx7d-sabre.ram" ; }DEFINE_MACHINE ("mcimx7d-sabre" , mcimx7d_sabre_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 19/80] arm/mcimx7d-sabre: use memdev for RAM
Quoted 12 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
remove no longer needed MCIMX7SabreSigned-off-by Igor Mammedov <[email protected]>
Quoted 9 lines
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/mcimx7d-sabre.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-)
I don't know anything about mcimx7d-sabre, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 20/80 arm/mps2-tz: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/arm/mps2-tz.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
hw/arm/mps2-tz.c +11 -4
@@ -39,6 +39,7 @@#include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/arm/boot.h"
@@ -79,7 +80,6 @@ typedef struct {MachineState parent;ARMSSE iotkit; -MemoryRegion psram;MemoryRegion ssram[3 ];MemoryRegion ssram1_m;MPS2SCC scc;
@@ -388,6 +388,13 @@ static void mps2tz_common_init(MachineState *machine)exit (1 ); } +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +sysbus_init_child_obj (OBJECT (machine),"iotkit" , &mms->iotkit,sizeof (mms->iotkit), mmc->armsse_type); iotkitdev =DEVICE (&mms->iotkit);
@@ -458,9 +465,7 @@ static void mps2tz_common_init(MachineState *machine)* tradeoffs. For QEMU they're all just RAM, though. We arbitrarily * call the 16MB our "system memory", as it's the largest lump. */ -memory_region_allocate_system_memory (&mms->psram, -NULL ,"mps.ram" ,16 * MiB); -memory_region_add_subregion (system_memory,0x80000000 , &mms->psram); +memory_region_add_subregion (system_memory,0x80000000 , machine->ram);/* The overflow IRQs for all UARTs are ORed together. * Tx, Rx and "combined" IRQs are sent to the NVIC separately.
@@ -642,6 +647,7 @@ static void mps2tz_class_init(ObjectClass *oc, void *data) mc->init = mps2tz_common_init; iic->check = mps2_tz_idau_check; + mc->default_ram_id ="mps.ram" ; }static void mps2tz_an505_class_init (ObjectClass *oc,void *data)
@@ -657,6 +663,7 @@ static void mps2tz_an505_class_init(ObjectClass *oc, void *data) mc->default_cpu_type =ARM_CPU_TYPE_NAME ("cortex-m33" ); mmc->scc_id =0x41045050 ; mmc->armsse_type =TYPE_IOTKIT ; + mc->default_ram_size =16 * MiB; }static void mps2tz_an521_class_init (ObjectClass *oc,void *data)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 20/80] arm/mps2-tz: use memdev for RAM
Quoted 79 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)--- hw/arm/mps2-tz.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)hw/arm/mps2-tz.c +10
-4@@ -39,6 +39,7 @@#include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/arm/boot.h" @@ -79,7 +80,6 @@ typedef struct {MachineState parent;ARMSSE iotkit; -MemoryRegion psram;MemoryRegion ssram[3 ];MemoryRegion ssram1_m;MPS2SCC scc;@@ -388,6 +388,13 @@ static void mps2tz_common_init(MachineState *machine)exit (1 ); } +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +sysbus_init_child_obj (OBJECT (machine),"iotkit" , &mms->iotkit,sizeof (mms->iotkit), mmc->armsse_type); iotkitdev =DEVICE (&mms->iotkit);@@ -458,9 +465,7 @@ static void mps2tz_common_init(MachineState *machine)* tradeoffs. For QEMU they're all just RAM, though. We arbitrarily * call the 16MB our "system memory", as it's the largest lump. */ -memory_region_allocate_system_memory (&mms->psram, -NULL ,"mps.ram" ,16 * MiB); -memory_region_add_subregion (system_memory,0x80000000 , &mms->psram); +memory_region_add_subregion (system_memory,0x80000000 , machine->ram);/* The overflow IRQs for all UARTs are ORed together. * Tx, Rx and "combined" IRQs are sent to the NVIC separately. @@ -642,6 +647,7 @@ static void mps2tz_class_init(ObjectClass *oc, void *data) mc->init = mps2tz_common_init; iic->check = mps2_tz_idau_check; + mc->default_ram_id ="mps.ram" ; }static void mps2tz_an505_class_init (ObjectClass *oc,void *data)
hw/arm/mps2-tz.c static void mps2tz_an505_class_init(ObjectClass *oc, void *data) · line 666
Quoted 4 lines
hw/arm/mps2-tz.c +1
-0@@ -657,6 +663,7 @@ static void mps2tz_an505_class_init(ObjectClass *oc, void *data) mc->default_cpu_type =ARM_CPU_TYPE_NAME ("cortex-m33" ); mmc->scc_id =0x41045050 ; mmc->armsse_type =TYPE_IOTKIT ; + mc->default_ram_size =16 * MiB;
Shouldn't this line be added to mps2tz_class_init ?
Thanks,
drew
Quoted 6 lines
hw/arm/mps2-tz.c +0
-0}static void mps2tz_an521_class_init (ObjectClass *oc,void *data)Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 20/80] arm/mps2-tz: use memdev for RAM
Quoted 78 lines · On Thu, 23 Jan 2020 13:59:09 +0100 Andrew Jones <[email protected]> wrote:
Quoted 77 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)--- hw/arm/mps2-tz.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)hw/arm/mps2-tz.c +10
-4@@ -39,6 +39,7 @@#include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/arm/boot.h" @@ -79,7 +80,6 @@ typedef struct {MachineState parent;ARMSSE iotkit; -MemoryRegion psram;MemoryRegion ssram[3 ];MemoryRegion ssram1_m;MPS2SCC scc;@@ -388,6 +388,13 @@ static void mps2tz_common_init(MachineState *machine)exit (1 ); } +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +sysbus_init_child_obj (OBJECT (machine),"iotkit" , &mms->iotkit,sizeof (mms->iotkit), mmc->armsse_type); iotkitdev =DEVICE (&mms->iotkit);@@ -458,9 +465,7 @@ static void mps2tz_common_init(MachineState *machine)* tradeoffs. For QEMU they're all just RAM, though. We arbitrarily * call the 16MB our "system memory", as it's the largest lump. */ -memory_region_allocate_system_memory (&mms->psram, -NULL ,"mps.ram" ,16 * MiB); -memory_region_add_subregion (system_memory,0x80000000 , &mms->psram); +memory_region_add_subregion (system_memory,0x80000000 , machine->ram);/* The overflow IRQs for all UARTs are ORed together. * Tx, Rx and "combined" IRQs are sent to the NVIC separately. @@ -642,6 +647,7 @@ static void mps2tz_class_init(ObjectClass *oc, void *data) mc->init = mps2tz_common_init; iic->check = mps2_tz_idau_check; + mc->default_ram_id ="mps.ram" ; }
Quoted 8 lines
hw/arm/mps2-tz.c static void mps2tz_an505_class_init(ObjectClass *oc, void *data) · line 666
Quoted 6 lines
hw/arm/mps2-tz.c +1
-0static void mps2tz_an505_class_init (ObjectClass *oc,void *data)@@ -657,6 +663,7 @@ static void mps2tz_an505_class_init(ObjectClass *oc, void *data) mc->default_cpu_type =ARM_CPU_TYPE_NAME ("cortex-m33" ); mmc->scc_id =0x41045050 ; mmc->armsse_type =TYPE_IOTKIT ; + mc->default_ram_size =16 * MiB;Shouldn't this line be added to
mps2tz_class_init?
Yep, it should be there
Quoted 10 lines
Thanks,
drewQuoted 6 lines
hw/arm/mps2-tz.c +0
-0}static void mps2tz_an521_class_init (ObjectClass *oc,void *data)Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 20/80] arm/mps2-tz: use memdev for RAM
Quoted 90 lines · Igor Mammedov
Quoted 78 lines · On Thu, 23 Jan 2020 13:59:09 +0100 Andrew Jones <[email protected]> wrote:
Quoted 77 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)--- hw/arm/mps2-tz.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)hw/arm/mps2-tz.c +10
-4@@ -39,6 +39,7 @@#include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/arm/boot.h" @@ -79,7 +80,6 @@ typedef struct {MachineState parent;ARMSSE iotkit; -MemoryRegion psram;MemoryRegion ssram[3 ];MemoryRegion ssram1_m;MPS2SCC scc;@@ -388,6 +388,13 @@ static void mps2tz_common_init(MachineState *machine)exit (1 ); } +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +sysbus_init_child_obj (OBJECT (machine),"iotkit" , &mms->iotkit,sizeof (mms->iotkit), mmc->armsse_type); iotkitdev =DEVICE (&mms->iotkit);@@ -458,9 +465,7 @@ static void mps2tz_common_init(MachineState *machine)* tradeoffs. For QEMU they're all just RAM, though. We arbitrarily * call the 16MB our "system memory", as it's the largest lump. */ -memory_region_allocate_system_memory (&mms->psram, -NULL ,"mps.ram" ,16 * MiB); -memory_region_add_subregion (system_memory,0x80000000 , &mms->psram); +memory_region_add_subregion (system_memory,0x80000000 , machine->ram);/* The overflow IRQs for all UARTs are ORed together. * Tx, Rx and "combined" IRQs are sent to the NVIC separately. @@ -642,6 +647,7 @@ static void mps2tz_class_init(ObjectClass *oc, void *data) mc->init = mps2tz_common_init; iic->check = mps2_tz_idau_check; + mc->default_ram_id ="mps.ram" ; }Quoted 8 lines
hw/arm/mps2-tz.c static void mps2tz_an505_class_init(ObjectClass *oc, void *data) · line 666
Quoted 6 lines
hw/arm/mps2-tz.c +1
-0static void mps2tz_an505_class_init (ObjectClass *oc,void *data)@@ -657,6 +663,7 @@ static void mps2tz_an505_class_init(ObjectClass *oc, void *data) mc->default_cpu_type =ARM_CPU_TYPE_NAME ("cortex-m33" ); mmc->scc_id =0x41045050 ; mmc->armsse_type =TYPE_IOTKIT ; + mc->default_ram_size =16 * MiB;Shouldn't this line be added to
mps2tz_class_init?
Quoted 1 line
Yep, it should be there
With that change you can add my r-b.
Thanks,
drew
PATCH v4 20/80 arm/mps2-tz: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
v4:
* move default_ram_size to mps2tz_class_init() (Andrew Jones <[email protected]>)
mps2-tz
--- hw/arm/mps2-tz.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
hw/arm/mps2-tz.c +11 -4
@@ -39,6 +39,7 @@#include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/arm/boot.h"
@@ -79,7 +80,6 @@ typedef struct {MachineState parent;ARMSSE iotkit; -MemoryRegion psram;MemoryRegion ssram[3 ];MemoryRegion ssram1_m;MPS2SCC scc;
@@ -388,6 +388,13 @@ static void mps2tz_common_init(MachineState *machine)exit (1 ); } +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +sysbus_init_child_obj (OBJECT (machine),"iotkit" , &mms->iotkit,sizeof (mms->iotkit), mmc->armsse_type); iotkitdev =DEVICE (&mms->iotkit);
@@ -458,9 +465,7 @@ static void mps2tz_common_init(MachineState *machine)* tradeoffs. For QEMU they're all just RAM, though. We arbitrarily * call the 16MB our "system memory", as it's the largest lump. */ -memory_region_allocate_system_memory (&mms->psram, -NULL ,"mps.ram" ,16 * MiB); -memory_region_add_subregion (system_memory,0x80000000 , &mms->psram); +memory_region_add_subregion (system_memory,0x80000000 , machine->ram);/* The overflow IRQs for all UARTs are ORed together. * Tx, Rx and "combined" IRQs are sent to the NVIC separately.
@@ -642,6 +647,8 @@ static void mps2tz_class_init(ObjectClass *oc, void *data) mc->init = mps2tz_common_init; iic->check = mps2_tz_idau_check; + mc->default_ram_size =16 * MiB; + mc->default_ram_id ="mps.ram" ; }static void mps2tz_an505_class_init (ObjectClass *oc,void *data)
Signature · 1 line
2.7.4
Re: [PATCH v4 20/80] arm/mps2-tz: use memdev for RAM
Quoted 21 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
v4:
* movedefault_ram_sizetomps2tz_class_init()(Andrew Jones <[email protected]>)
Quoted 9 lines
mps2-tz
--- hw/arm/mps2-tz.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
PATCH v3 21/80 arm/mps2: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/arm/mps2.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
hw/arm/mps2.c +11 -4
@@ -24,6 +24,7 @@#include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/arm/boot.h"
@@ -55,7 +56,6 @@ typedef struct {MachineState parent;ARMv7MState armv7m; -MemoryRegion psram;MemoryRegion ssram1;MemoryRegion ssram1_m;MemoryRegion ssram23;
@@ -118,6 +118,13 @@ static void mps2_common_init(MachineState *machine)exit (1 ); } +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +/* The FPGA images have an odd combination of different RAMs, * because in hardware they are different implementations and * connected to different buses, giving varying performance/size
@@ -146,9 +153,7 @@ static void mps2_common_init(MachineState *machine)* This is of no use for QEMU so we don't implement it (as if * zbt_boot_ctrl is always zero). */ -memory_region_allocate_system_memory (&mms->psram, -NULL ,"mps.ram" ,16 * MiB); -memory_region_add_subregion (system_memory,0x21000000 , &mms->psram); +memory_region_add_subregion (system_memory,0x21000000 , machine->ram);switch (mmc->fpga_type) {case FPGA_AN385 :
@@ -338,6 +343,8 @@ static void mps2_class_init(ObjectClass *oc, void *data) mc->init = mps2_common_init; mc->max_cpus =1 ; + mc->default_ram_size =16 * MiB; + mc->default_ram_id ="mps.ram" ; }static void mps2_an385_class_init (ObjectClass *oc,void *data)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 21/80] arm/mps2: use memdev for RAM
Quoted 18 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
Quoted 6 lines
--- hw/arm/mps2.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
I don't know anything about mps2, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 22/80 arm/musicpal: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/arm/musicpal.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
hw/arm/musicpal.c +13 -5
@@ -32,6 +32,7 @@#include "sysemu/runstate.h" #include "exec/address-spaces.h" #include "ui/pixel_ops.h" +#include "qemu/cutils.h" #define MP_MISC_BASE 0x80002000#define MP_MISC_SIZE 0x00001000
@@ -1589,16 +1590,21 @@ static void musicpal_init(MachineState *machine)int i;unsigned long flash_size;DriveInfo *dinfo; +MachineClass *mc =MACHINE_GET_CLASS (machine);MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *sram =g_new (MemoryRegion,1 ); +/* For now we use a fixed - the original - RAM size */ +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } + cpu =ARM_CPU (cpu_create (machine->cpu_type)); -/* For now we use a fixed - the original - RAM size */ -memory_region_allocate_system_memory (ram,NULL ,"musicpal.ram" , -MP_RAM_DEFAULT_SIZE ); -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);memory_region_init_ram (sram,NULL ,"musicpal.sram" ,MP_SRAM_SIZE , &error_fatal);
@@ -1714,6 +1720,8 @@ static void musicpal_machine_init(MachineClass *mc) mc->init = musicpal_init; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("arm926" ); + mc->default_ram_size =MP_RAM_DEFAULT_SIZE ; + mc->default_ram_id ="musicpal.ram" ; }DEFINE_MACHINE ("musicpal" , musicpal_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 22/80] arm/musicpal: use memdev for RAM
Quoted 18 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
Quoted 8 lines
--- hw/arm/musicpal.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
I don't know anything about musicpal, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 23/80 arm/nseries: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/arm/nseries.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-)
hw/arm/nseries.c +19 -13
@@ -47,7 +47,6 @@/* Nokia N8x0 support */ struct n800_s { -MemoryRegion sdram;struct omap_mpu_state_s *mpu;struct rfbi_chip_s blizzard;
@@ -1311,13 +1310,19 @@ static void n8x0_init(MachineState *machine, struct arm_boot_info *binfo, int model) {struct n800_s *s = (struct n800_s *)g_malloc0 (sizeof (*s)); -uint64_t sdram_size = binfo->ram_size; +MachineClass *mc =MACHINE_GET_CLASS (machine); -memory_region_allocate_system_memory (&s->sdram,NULL ,"omap2.dram" , - sdram_size); -memory_region_add_subregion (get_system_memory (),OMAP2_Q2_BASE , &s->sdram); +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } + +memory_region_add_subregion (get_system_memory (),OMAP2_Q2_BASE , + machine->ram); - s->mpu =omap2420_mpu_init (&s->sdram, machine->cpu_type); + s->mpu =omap2420_mpu_init (machine->ram, machine->cpu_type);/* Setup peripherals *
@@ -1383,9 +1388,8 @@ static void n8x0_init(MachineState *machine,* * The code above is for loading the `zImage' file from Nokia * images. */ -load_image_targphys (option_rom[0 ].name, -OMAP2_Q2_BASE +0x400000 , - sdram_size -0x400000 ); +load_image_targphys (option_rom[0 ].name,OMAP2_Q2_BASE +0x400000 , + machine->ram_size -0x400000 );n800_setup_nolo_tags (nolo_tags);cpu_physical_memory_write (OMAP2_SRAM_BASE , nolo_tags,0x10000 );
@@ -1395,16 +1399,12 @@ static void n8x0_init(MachineState *machine,static struct arm_boot_info n800_binfo = { .loader_start =OMAP2_Q2_BASE , -/* Actually two chips of 0x4000000 bytes each */ - .ram_size =0x08000000 , .board_id =0x4f7 , .atag_board = n800_atag_setup, };static struct arm_boot_info n810_binfo = { .loader_start =OMAP2_Q2_BASE , -/* Actually two chips of 0x4000000 bytes each */ - .ram_size =0x08000000 ,/* 0x60c and 0x6bf (WiMAX Edition) have been assigned but are not * used by some older versions of the bootloader and 5555 is used * instead (including versions that shipped with many devices). */
@@ -1431,6 +1431,9 @@ static void n800_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="" ; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("arm1136-r2" ); +/* Actually two chips of 0x4000000 bytes each */ + mc->default_ram_size =0x08000000 ; + mc->default_ram_id ="omap2.dram" ; }static const TypeInfo n800_type = {
@@ -1448,6 +1451,9 @@ static void n810_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="" ; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("arm1136-r2" ); +/* Actually two chips of 0x4000000 bytes each */ + mc->default_ram_size =0x08000000 ; + mc->default_ram_id ="omap2.dram" ; }static const TypeInfo n810_type = {
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 23/80] arm/nseries: use memdev for RAM
Quoted 18 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
Quoted 8 lines
--- hw/arm/nseries.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-)
I don't know anything about nseries, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 24/80 arm/omap_sx1: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/arm/omap_sx1.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-)
hw/arm/omap_sx1.c +15 -5
@@ -35,6 +35,7 @@#include "sysemu/qtest.h" #include "exec/address-spaces.h" #include "cpu.h" +#include "qemu/cutils.h" /*****************************************************************************/ /* Siemens SX1 Cellphone V1 */
@@ -102,8 +103,8 @@ static struct arm_boot_info sx1_binfo = {static void sx1_init (MachineState *machine,const int version) {struct omap_mpu_state_s *mpu; +MachineClass *mc =MACHINE_GET_CLASS (machine);MemoryRegion *address_space =get_system_memory (); -MemoryRegion *dram =g_new (MemoryRegion,1 );MemoryRegion *flash =g_new (MemoryRegion,1 );MemoryRegion *cs =g_new (MemoryRegion,4 );static uint32_t cs0val =0x00213090 ;
@@ -115,15 +116,20 @@ static void sx1_init(MachineState *machine, const int version)uint32_t flash_size = flash0_size;int be; +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +if (version ==2 ) { flash_size = flash2_size; } -memory_region_allocate_system_memory (dram,NULL ,"omap1.dram" , - sx1_binfo.ram_size); -memory_region_add_subregion (address_space,OMAP_EMIFF_BASE , dram); +memory_region_add_subregion (address_space,OMAP_EMIFF_BASE , machine->ram); - mpu =omap310_mpu_init (dram, machine->cpu_type); + mpu =omap310_mpu_init (machine->ram, machine->cpu_type);/* External Flash (EMIFS) */ memory_region_init_ram(flash, NULL, "omap_sx1.flash0-0", flash_size,
@@ -223,6 +229,8 @@ static void sx1_machine_v2_class_init(ObjectClass *oc, void *data) mc->init = sx1_init_v2; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("ti925t" ); + mc->default_ram_size = sdram_size; + mc->default_ram_id ="omap1.dram" ; }static const TypeInfo sx1_machine_v2_type = {
@@ -239,6 +247,8 @@ static void sx1_machine_v1_class_init(ObjectClass *oc, void *data) mc->init = sx1_init_v1; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("ti925t" ); + mc->default_ram_size = sdram_size; + mc->default_ram_id ="omap1.dram" ; }static const TypeInfo sx1_machine_v1_type = {
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 24/80] arm/omap_sx1: use memdev for RAM
Quoted 18 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
Quoted 7 lines
--- hw/arm/omap_sx1.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-)
I don't know anything about omap_sx1, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 25/80 arm/palm: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/arm/palm.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-)
hw/arm/palm.c +14 -6
@@ -31,6 +31,7 @@#include "hw/loader.h" #include "exec/address-spaces.h" #include "cpu.h" +#include "qemu/cutils.h" static uint64_t static_read (void *opaque,hwaddr offset,unsigned size) {
@@ -181,7 +182,6 @@ static void palmte_gpio_setup(struct omap_mpu_state_s *cpu)static struct arm_boot_info palmte_binfo = { .loader_start =OMAP_EMIFF_BASE , - .ram_size =0x02000000 , .board_id =0x331 , };
@@ -195,15 +195,21 @@ static void palmte_init(MachineState *machine)static uint32_t cs2val =0x0000e1a0 ;static uint32_t cs3val =0xe1a0e1a0 ;int rom_size, rom_loaded =0 ; -MemoryRegion *dram =g_new (MemoryRegion,1 ); +MachineClass *mc =MACHINE_GET_CLASS (machine);MemoryRegion *flash =g_new (MemoryRegion,1 );MemoryRegion *cs =g_new (MemoryRegion,4 ); -memory_region_allocate_system_memory (dram,NULL ,"omap1.dram" , - palmte_binfo.ram_size); -memory_region_add_subregion (address_space_mem,OMAP_EMIFF_BASE , dram); +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } + +memory_region_add_subregion (address_space_mem,OMAP_EMIFF_BASE , + machine->ram); - mpu =omap310_mpu_init (dram, machine->cpu_type); + mpu =omap310_mpu_init (machine->ram, machine->cpu_type);/* External Flash (EMIFS) */ memory_region_init_ram(flash, NULL, "palmte.flash", flash_size,
@@ -265,6 +271,8 @@ static void palmte_machine_init(MachineClass *mc) mc->init = palmte_init; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("ti925t" ); + mc->default_ram_size =0x02000000 ; + mc->default_ram_id ="omap1.dram" ; }DEFINE_MACHINE ("cheetah" , palmte_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 25/80] arm/palm: use memdev for RAM
Quoted 18 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.Signed-off-by Igor Mammedov <[email protected]>---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
Quoted 8 lines
--- hw/arm/palm.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-)
I don't know anything about palm, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 26/80 arm/raspi: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
remove no longer needed RasPiState
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/raspi.c | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-)
hw/arm/raspi.c +13 -21
@@ -32,11 +32,6 @@/* Table of Linux board IDs for different Pi versions */ static const int raspi_boardid[] = {[1 ] =0xc42 , [2 ] =0xc43 , [3 ] =0xc44 }; -typedef struct RasPiState { -BCM283XState soc; -MemoryRegion ram; -}RasPiState ; -static void write_smpboot (ARMCPU *cpu,const struct arm_boot_info *info) {static const uint32_t smpboot[] = {
@@ -166,7 +161,7 @@ static void setup_boot(MachineState *machine, int version, size_t ram_size)static void raspi_init (MachineState *machine,int version) { -RasPiState *s =g_new0 (RasPiState,1 ); +Object *soc;uint32_t vcram_size;DriveInfo *di;BlockBackend *blk;
@@ -179,30 +174,26 @@ static void raspi_init(MachineState *machine, int version)exit (1 ); } -object_initialize_child (OBJECT (machine),"soc" , &s->soc,sizeof (s->soc), - version ==3 ?TYPE_BCM2837 :TYPE_BCM2836 , - &error_abort,NULL ); + soc =object_new (version ==3 ?TYPE_BCM2837 :TYPE_BCM2836 ); +object_property_add_child (OBJECT (machine),"soc" , soc, &error_fatal); -/* Allocate and map RAM */ -memory_region_allocate_system_memory (&s->ram,OBJECT (machine),"ram" , - machine->ram_size);/* FIXME: Remove when we have custom CPU address space support */ -memory_region_add_subregion_overlap (get_system_memory (),0 , &s->ram,0 ); +memory_region_add_subregion_overlap (get_system_memory (),0 , + machine->ram,0 );/* Setup the SOC */ -object_property_add_const_link (OBJECT (&s->soc),"ram" ,OBJECT (&s->ram), +object_property_add_const_link (soc,"ram" ,OBJECT (machine->ram), &error_abort); -object_property_set_int (OBJECT (&s->soc), machine->smp.cpus,"enabled-cpus" , +object_property_set_int (soc, machine->smp.cpus,"enabled-cpus" , &error_abort);int board_rev = version ==3 ?0xa02082 :0xa21041 ; -object_property_set_int (OBJECT (&s->soc), board_rev,"board-rev" , - &error_abort); -object_property_set_bool (OBJECT (&s->soc), true,"realized" , &error_abort); +object_property_set_int (soc, board_rev,"board-rev" , &error_abort); +object_property_set_bool (soc, true,"realized" , &error_abort);/* Create and plug in the SD cards */ di =drive_get_next (IF_SD ); blk = di ?blk_by_legacy_dinfo (di) :NULL ; - bus =qdev_get_child_bus (DEVICE (&s->soc),"sd-bus" ); + bus =qdev_get_child_bus (DEVICE (soc),"sd-bus" );if (bus ==NULL ) {error_report ("No SD bus found in SOC object" );exit (1 );
@@ -211,8 +202,7 @@ static void raspi_init(MachineState *machine, int version)qdev_prop_set_drive (carddev,"drive" , blk, &error_fatal);object_property_set_bool (OBJECT (carddev), true,"realized" , &error_fatal); - vcram_size =object_property_get_uint (OBJECT (&s->soc),"vcram-size" , - &error_abort); + vcram_size =object_property_get_uint (soc,"vcram-size" , &error_abort);setup_boot (machine, version, machine->ram_size - vcram_size); }
@@ -233,6 +223,7 @@ static void raspi2_machine_init(MachineClass *mc) mc->min_cpus =BCM283X_NCPUS ; mc->default_cpus =BCM283X_NCPUS ; mc->default_ram_size =1 * GiB; + mc->default_ram_id ="ram" ; mc->ignore_memory_transaction_failures = true; };DEFINE_MACHINE ("raspi2" , raspi2_machine_init)
@@ -255,6 +246,7 @@ static void raspi3_machine_init(MachineClass *mc) mc->min_cpus =BCM283X_NCPUS ; mc->default_cpus =BCM283X_NCPUS ; mc->default_ram_size =1 * GiB; + mc->default_ram_id ="ram" ; } DEFINE_MACHINE("raspi3", raspi3_machine_init)#endif
Signature · 1 line
2.7.4
PATCH v3 27/80 arm/sabrelite: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
remove no longer needed IMX6Sabrelite
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/sabrelite.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)
hw/arm/sabrelite.c +8 -15
@@ -19,11 +19,6 @@#include "qemu/error-report.h" #include "sysemu/qtest.h" -typedef struct IMX6Sabrelite { -FslIMX6State soc; -MemoryRegion ram; -}IMX6Sabrelite ; -static struct arm_boot_info sabrelite_binfo = {/* DDR memory start */ .loader_start =FSL_IMX6_MMDC_ADDR ,
@@ -45,7 +40,7 @@ static void sabrelite_reset_secondary(ARMCPU *cpu,static void sabrelite_init (MachineState *machine) { -IMX6Sabrelite *s =g_new0 (IMX6Sabrelite,1 ); +FslIMX6State *s;Error *err =NULL ;/* Check the amount of memory is compatible with the SOC */
@@ -55,19 +50,16 @@ static void sabrelite_init(MachineState *machine)exit (1 ); } -object_initialize_child (OBJECT (machine),"soc" , &s->soc,sizeof (s->soc), -TYPE_FSL_IMX6 , &error_abort,NULL ); - -object_property_set_bool (OBJECT (&s->soc), true,"realized" , &err); + s =FSL_IMX6 (object_new (TYPE_FSL_IMX6 )); +object_property_add_child (OBJECT (machine),"soc" ,OBJECT (s), &error_fatal); +object_property_set_bool (OBJECT (s), true,"realized" , &err);if (err !=NULL ) {error_report ("%s" ,error_get_pretty (err));exit (1 ); } -memory_region_allocate_system_memory (&s->ram,NULL ,"sabrelite.ram" , - machine->ram_size);memory_region_add_subregion (get_system_memory (),FSL_IMX6_MMDC_ADDR , - &s->ram); + machine->ram); {/*
@@ -78,7 +70,7 @@ static void sabrelite_init(MachineState *machine)/* Add the sst25vf016b NOR FLASH memory to first SPI */ Object *spi_dev; - spi_dev =object_resolve_path_component (OBJECT (&s->soc),"spi1" ); + spi_dev =object_resolve_path_component (OBJECT (s),"spi1" );if (spi_dev) {SSIBus *spi_bus;
@@ -109,7 +101,7 @@ static void sabrelite_init(MachineState *machine) sabrelite_binfo.secondary_cpu_reset_hook = sabrelite_reset_secondary;if (!qtest_enabled ()) { -arm_load_kernel (&s->soc.cpu[0 ], machine, &sabrelite_binfo); +arm_load_kernel (&s->cpu[0 ], machine, &sabrelite_binfo); } }
@@ -119,6 +111,7 @@ static void sabrelite_machine_init(MachineClass *mc) mc->init = sabrelite_init; mc->max_cpus =FSL_IMX6_NUM_CPUS ; mc->ignore_memory_transaction_failures = true; + mc->default_ram_id ="sabrelite.ram" ; }DEFINE_MACHINE ("sabrelite" , sabrelite_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 27/80] arm/sabrelite: use memdev for RAM
Quoted 12 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.PS:
remove no longer needed IMX6SabreliteSigned-off-by Igor Mammedov <[email protected]>
Quoted 9 lines
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/sabrelite.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)
I don't know anything about sabrelite, but I promised Igor to put another pair of eyes on his changes. Looks fine to me.
PATCH v3 28/80 arm/sbsa-ref: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/sbsa-ref.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
hw/arm/sbsa-ref.c +3 -4
@@ -593,7 +593,6 @@ static void sbsa_ref_init(MachineState *machine)MachineClass *mc =MACHINE_GET_CLASS (machine);MemoryRegion *sysmem =get_system_memory ();MemoryRegion *secure_sysmem =g_new (MemoryRegion,1 ); -MemoryRegion *ram =g_new (MemoryRegion,1 );bool firmware_loaded;const CPUArchIdList *possible_cpus;int n, sbsa_max_cpus;
@@ -685,9 +684,8 @@ static void sbsa_ref_init(MachineState *machine)object_unref (cpuobj); } -memory_region_allocate_system_memory (ram,NULL ,"sbsa-ref.ram" , - machine->ram_size); -memory_region_add_subregion (sysmem, sbsa_ref_memmap[SBSA_MEM ].base, ram); +memory_region_add_subregion (sysmem, sbsa_ref_memmap[SBSA_MEM ].base, + machine->ram);create_fdt (sms);
@@ -785,6 +783,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data) mc->block_default_type =IF_IDE ; mc->no_cdrom =1 ; mc->default_ram_size =1 * GiB; + mc->default_ram_id ="sbsa-ref.ram" ; mc->default_cpus =4 ; mc->possible_cpu_arch_ids = sbsa_ref_possible_cpu_arch_ids; mc->cpu_index_to_instance_props = sbsa_ref_cpu_index_to_props;
Signature · 1 line
2.7.4
PATCH v3 29/80 arm/versatilepb: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
--- hw/arm/versatilepb.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
hw/arm/versatilepb.c +3 -4
@@ -184,7 +184,6 @@ static void versatile_init(MachineState *machine, int board_id)Object *cpuobj;ARMCPU *cpu;MemoryRegion *sysmem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );qemu_irq pic[32 ];qemu_irq sic[32 ];DeviceState *dev, *sysctl;
@@ -220,11 +219,9 @@ static void versatile_init(MachineState *machine, int board_id) cpu =ARM_CPU (cpuobj); -memory_region_allocate_system_memory (ram,NULL ,"versatile.ram" , - machine->ram_size);/* ??? RAM should repeat to fill physical memory space. */ /* SDRAM at address zero. */ -memory_region_add_subregion (sysmem,0 , ram); +memory_region_add_subregion (sysmem,0 , machine->ram); sysctl =qdev_create (NULL ,"realview_sysctl" );qdev_prop_set_uint32 (sysctl,"sys_id" ,0x41007004 );
@@ -398,6 +395,7 @@ static void versatilepb_class_init(ObjectClass *oc, void *data) mc->block_default_type =IF_SCSI ; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("arm926" ); + mc->default_ram_id ="versatile.ram" ; }static const TypeInfo versatilepb_type = {
@@ -415,6 +413,7 @@ static void versatileab_class_init(ObjectClass *oc, void *data) mc->block_default_type =IF_SCSI ; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("arm926" ); + mc->default_ram_id ="versatile.ram" ; }static const TypeInfo versatileab_type = {
Signature · 1 line
2.7.4
PATCH v3 30/80 arm/vexpress: use memdev for RAM
In reply to Igor Mammedovreplace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
--- hw/arm/vexpress.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
hw/arm/vexpress.c +5 -9
@@ -273,7 +273,6 @@ static void a9_daughterboard_init(const VexpressMachineState *vms, {MachineState *machine =MACHINE (vms);MemoryRegion *sysmem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *lowram =g_new (MemoryRegion,1 );ram_addr_t low_ram_size;
@@ -283,8 +282,6 @@ static void a9_daughterboard_init(const VexpressMachineState *vms,exit (1 ); } -memory_region_allocate_system_memory (ram,NULL ,"vexpress.highmem" , - ram_size); low_ram_size = ram_size;if (low_ram_size >0x4000000 ) { low_ram_size =0x4000000 ;
@@ -293,9 +290,10 @@ static void a9_daughterboard_init(const VexpressMachineState *vms,* address space should in theory be remappable to various * things including ROM or RAM; we always map the RAM there. */ -memory_region_init_alias (lowram,NULL ,"vexpress.lowmem" , ram,0 , low_ram_size); +memory_region_init_alias (lowram,NULL ,"vexpress.lowmem" , machine->ram, +0 , low_ram_size);memory_region_add_subregion (sysmem,0x0 , lowram); -memory_region_add_subregion (sysmem,0x60000000 , ram); +memory_region_add_subregion (sysmem,0x60000000 , machine->ram);/* 0x1e000000 A9MPCore (SCU) private memory region */ init_cpus(machine, cpu_type, TYPE_A9MPCORE_PRIV, 0x1e000000, pic,
@@ -360,7 +358,6 @@ static void a15_daughterboard_init(const VexpressMachineState *vms, {MachineState *machine =MACHINE (vms);MemoryRegion *sysmem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *sram =g_new (MemoryRegion,1 ); {
@@ -375,10 +372,8 @@ static void a15_daughterboard_init(const VexpressMachineState *vms, } } -memory_region_allocate_system_memory (ram,NULL ,"vexpress.highmem" , - ram_size);/* RAM is from 0x80000000 upwards; there is no low-memory alias for it. */ -memory_region_add_subregion (sysmem,0x80000000 , ram); +memory_region_add_subregion (sysmem,0x80000000 , machine->ram);/* 0x2c000000 A15MPCore private memory region (GIC) */ init_cpus(machine, cpu_type, TYPE_A15MPCORE_PRIV,
@@ -795,6 +790,7 @@ static void vexpress_class_init(ObjectClass *oc, void *data) mc->init = vexpress_common_init; mc->max_cpus =4 ; mc->ignore_memory_transaction_failures = true; + mc->default_ram_id ="vexpress.highmem" ; }static void vexpress_a9_class_init (ObjectClass *oc,void *data)
Signature · 1 line
2.7.4
PATCH v3 31/80 arm/virt: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and then map memory region provided by
MachineState::ram_memdev
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/virt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
hw/arm/virt.c +3 -4
@@ -1512,7 +1512,6 @@ static void machvirt_init(MachineState *machine)MemoryRegion *sysmem =get_system_memory ();MemoryRegion *secure_sysmem =NULL ;int n, virt_max_cpus; -MemoryRegion *ram =g_new (MemoryRegion,1 );bool firmware_loaded;bool aarch64 = true;bool has_ged = !vmc->no_ged;
@@ -1701,9 +1700,8 @@ static void machvirt_init(MachineState *machine) } } -memory_region_allocate_system_memory (ram,NULL ,"mach-virt.ram" , - machine->ram_size); -memory_region_add_subregion (sysmem, vms->memmap[VIRT_MEM ].base, ram); +memory_region_add_subregion (sysmem, vms->memmap[VIRT_MEM ].base, + machine->ram);if (machine->device_memory) {memory_region_add_subregion (sysmem, machine->device_memory->base, &machine->device_memory->mr);
@@ -2053,6 +2051,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) hc->unplug_request = virt_machine_device_unplug_request_cb; mc->numa_mem_supported = true; mc->auto_enable_numa_with_memhp = true; + mc->default_ram_id ="mach-virt.ram" ; }static void virt_instance_init (Object *obj)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 31/80] arm/virt: use memdev for RAM
Quoted 54 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and then map memory region provided by
MachineState::ram_memdevSigned-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/arm/virt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)hw/arm/virt.c +3
-4@@ -1512,7 +1512,6 @@ static void machvirt_init(MachineState *machine)MemoryRegion *sysmem =get_system_memory ();MemoryRegion *secure_sysmem =NULL ;int n, virt_max_cpus; -MemoryRegion *ram =g_new (MemoryRegion,1 );bool firmware_loaded;bool aarch64 = true;bool has_ged = !vmc->no_ged;@@ -1701,9 +1700,8 @@ static void machvirt_init(MachineState *machine) } } -memory_region_allocate_system_memory (ram,NULL ,"mach-virt.ram" , - machine->ram_size); -memory_region_add_subregion (sysmem, vms->memmap[VIRT_MEM ].base, ram); +memory_region_add_subregion (sysmem, vms->memmap[VIRT_MEM ].base, + machine->ram);if (machine->device_memory) {memory_region_add_subregion (sysmem, machine->device_memory->base, &machine->device_memory->mr);@@ -2053,6 +2051,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) hc->unplug_request = virt_machine_device_unplug_request_cb; mc->numa_mem_supported = true; mc->auto_enable_numa_with_memhp = true; + mc->default_ram_id ="mach-virt.ram" ; }static void virt_instance_init (Object *obj)Signature · 1 line
2.7.4
PATCH v3 32/80 arm/xilinx_zynq: drop RAM size fixup
In reply to Igor MammedovIf user provided non-sense RAM size, board will complain and continue running with max RAM size supported.
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/xilinx_zynq.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
hw/arm/xilinx_zynq.c +8 -8
@@ -158,7 +158,6 @@ static inline void zynq_init_spi_flashes(uint32_t base_addr, qemu_irq irq,static void zynq_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;ARMCPU *cpu;MemoryRegion *address_space_mem =get_system_memory ();MemoryRegion *ext_ram =g_new (MemoryRegion,1 );
@@ -168,6 +167,12 @@ static void zynq_init(MachineState *machine)qemu_irq pic[64 ];int n; +/* max 2GB ram */ +if (machine->ram_size >0x80000000 ) { +error_report ("RAM size more than %d is not supported" ,0x80000000 ); +exit (EXIT_FAILURE ); + } + cpu =ARM_CPU (object_new (machine->cpu_type));/* By default A9 CPUs have EL3 enabled. This board does not
@@ -184,14 +189,9 @@ static void zynq_init(MachineState *machine) &error_fatal);object_property_set_bool (OBJECT (cpu), true,"realized" , &error_fatal); -/* max 2GB ram */ -if (ram_size >0x80000000 ) { - ram_size =0x80000000 ; - } -/* DDR remapped to address zero. */ memory_region_allocate_system_memory (ext_ram,NULL ,"zynq.ext_ram" , - ram_size); + machine->ram_size);memory_region_add_subregion (address_space_mem,0 , ext_ram);/* 256K of on-chip memory */
@@ -300,7 +300,7 @@ static void zynq_init(MachineState *machine)sysbus_connect_irq (busdev,0 , pic[40 -IRQ_OFFSET ]);sysbus_mmio_map (busdev,0 ,0xF8007000 ); - zynq_binfo.ram_size = ram_size; + zynq_binfo.ram_size = machine->ram_size; zynq_binfo.nb_cpus =1 ; zynq_binfo.board_id =0xd32 ; zynq_binfo.loader_start =0 ;
Signature · 1 line
2.7.4
PATCH v3 33/80 arm/xilinx_zynq: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/xilinx_zynq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
hw/arm/xilinx_zynq.c +2 -4
@@ -160,7 +160,6 @@ static void zynq_init(MachineState *machine) {ARMCPU *cpu;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ext_ram =g_new (MemoryRegion,1 );MemoryRegion *ocm_ram =g_new (MemoryRegion,1 );DeviceState *dev;SysBusDevice *busdev;
@@ -190,9 +189,7 @@ static void zynq_init(MachineState *machine)object_property_set_bool (OBJECT (cpu), true,"realized" , &error_fatal);/* DDR remapped to address zero. */ -memory_region_allocate_system_memory (ext_ram,NULL ,"zynq.ext_ram" , - machine->ram_size); -memory_region_add_subregion (address_space_mem,0 , ext_ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);/* 256K of on-chip memory */ memory_region_init_ram(ocm_ram, NULL, "zynq.ocm_ram", 256 * KiB,
@@ -318,6 +315,7 @@ static void zynq_machine_init(MachineClass *mc) mc->no_sdcard =1 ; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type =ARM_CPU_TYPE_NAME ("cortex-a9" ); + mc->default_ram_id ="zynq.ext_ram" ; }DEFINE_MACHINE ("xilinx-zynq-a9" , zynq_machine_init)
Signature · 1 line
2.7.4
PATCH v3 34/80 arm/xlnx-versal-virt: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/arm/xlnx-versal-virt.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
hw/arm/xlnx-versal-virt.c +2 -5
@@ -30,7 +30,6 @@ typedef struct VersalVirt {MachineState parent_obj;Versal soc; -MemoryRegion mr_ddr;void *fdt;int fdt_size;
@@ -414,12 +413,9 @@ static void versal_virt_init(MachineState *machine) psci_conduit =QEMU_PSCI_CONDUIT_SMC ; } -memory_region_allocate_system_memory (&s->mr_ddr,NULL ,"ddr" , - machine->ram_size); -sysbus_init_child_obj (OBJECT (machine),"xlnx-ve" , &s->soc,sizeof (s->soc),TYPE_XLNX_VERSAL ); -object_property_set_link (OBJECT (&s->soc),OBJECT (&s->mr_ddr), +object_property_set_link (OBJECT (&s->soc),OBJECT (machine->ram),"ddr" , &error_abort);object_property_set_int (OBJECT (&s->soc), psci_conduit,"psci-conduit" , &error_abort);
@@ -473,6 +469,7 @@ static void versal_virt_machine_class_init(ObjectClass *oc, void *data) mc->max_cpus =XLNX_VERSAL_NR_ACPUS ; mc->default_cpus =XLNX_VERSAL_NR_ACPUS ; mc->no_cdrom = true; + mc->default_ram_id ="ddr" ; }static const TypeInfo versal_virt_machine_init_typeinfo = {
Signature · 1 line
2.7.4
PATCH v3 35/80 arm/xlnx-zcu102: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/arm/xlnx-zcu102.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
hw/arm/xlnx-zcu102.c +2 -5
@@ -28,7 +28,6 @@ typedef struct XlnxZCU102 {MachineState parent_obj;XlnxZynqMPState soc; -MemoryRegion ddr_ram;bool secure;bool virt;
@@ -87,13 +86,10 @@ static void xlnx_zcu102_init(MachineState *machine) ram_size); } -memory_region_allocate_system_memory (&s->ddr_ram,NULL ,"ddr-ram" , - ram_size); -object_initialize_child (OBJECT (machine),"soc" , &s->soc,sizeof (s->soc),TYPE_XLNX_ZYNQMP , &error_abort,NULL ); -object_property_set_link (OBJECT (&s->soc),OBJECT (&s->ddr_ram), +object_property_set_link (OBJECT (&s->soc),OBJECT (machine->ram),"ddr-ram" , &error_abort);object_property_set_bool (OBJECT (&s->soc), s->secure,"secure" , &error_fatal);
@@ -211,6 +207,7 @@ static void xlnx_zcu102_machine_class_init(ObjectClass *oc, void *data) mc->ignore_memory_transaction_failures = true; mc->max_cpus =XLNX_ZYNQMP_NUM_APU_CPUS +XLNX_ZYNQMP_NUM_RPU_CPUS ; mc->default_cpus =XLNX_ZYNQMP_NUM_APU_CPUS ; + mc->default_ram_id ="ddr-ram" ; }static const TypeInfo xlnx_zcu102_machine_init_typeinfo = {
Signature · 1 line
2.7.4
PATCH v3 36/80 s390x/s390-virtio-ccw: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/s390x/s390-virtio-ccw.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
hw/s390x/s390-virtio-ccw.c +3 -4
@@ -154,14 +154,12 @@ static void virtio_ccw_register_hcalls(void) virtio_ccw_hcall_early_printk); } -static void s390_memory_init (ram_addr_t mem_size) +static void s390_memory_init (MemoryRegion *ram) {MemoryRegion *sysmem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );Error *local_err =NULL ;/* allocate RAM for core */ -memory_region_allocate_system_memory (ram,NULL ,"s390.ram" , mem_size);memory_region_add_subregion (sysmem,0 , ram);/*
@@ -245,7 +243,7 @@ static void ccw_init(MachineState *machine)s390_sclp_init ();/* init memory + setup max page size. Required for the CPU model */ -s390_memory_init (machine->ram_size); +s390_memory_init (machine->ram);/* init CPUs (incl. CPU model) early so s390_has_feature() works */ s390_init_cpus (machine);
@@ -471,6 +469,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data) hc->plug = s390_machine_device_plug; hc->unplug_request = s390_machine_device_unplug_request; nc->nmi_monitor_handler = s390_nmi; + mc->default_ram_id ="s390.ram" ; }static inline bool machine_get_aes_key_wrap (Object *obj,Error **errp)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 36/80] s390x/s390-virtio-ccw: use memdev for RAM
Quoted 18 lines · On Thu, 23 Jan 2020 12:38:01 +0100 Igor Mammedov <[email protected]> wrote:
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>Reviewed-by David Hildenbrand <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
Quoted 3 lines
--- hw/s390x/s390-virtio-ccw.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
PATCH v3 37/80 null-machine: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/core/null-machine.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
hw/core/null-machine.c +3 -5
@@ -32,11 +32,8 @@ static void machine_none_init(MachineState *mch) }/* RAM at address zero */ -if (mch->ram_size) { -MemoryRegion *ram =g_new (MemoryRegion,1 ); - -memory_region_allocate_system_memory (ram,NULL ,"ram" , mch->ram_size); -memory_region_add_subregion (get_system_memory (),0 , ram); +if (mch->ram) { +memory_region_add_subregion (get_system_memory (),0 , mch->ram); }if (mch->kernel_filename) {
@@ -52,6 +49,7 @@ static void machine_none_machine_init(MachineClass *mc) mc->init = machine_none_init; mc->max_cpus =1 ; mc->default_ram_size =0 ; + mc->default_ram_id ="ram" ; }DEFINE_MACHINE ("none" , machine_none_machine_init)
Signature · 1 line
2.7.4
PATCH v3 38/80 cris/axis_dev88: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
--- hw/cris/axis_dev88.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
hw/cris/axis_dev88.c +2 -6
@@ -249,7 +249,6 @@ static struct cris_load_info li;static void axisdev88_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;CRISCPU *cpu;
@@ -261,16 +260,12 @@ void axisdev88_init(MachineState *machine)struct etraxfs_dma_client *dma_eth;int i;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *phys_ram =g_new (MemoryRegion,1 );MemoryRegion *phys_intmem =g_new (MemoryRegion,1 );/* init CPUs */ cpu =CRIS_CPU (cpu_create (machine->cpu_type)); -/* allocate RAM */ -memory_region_allocate_system_memory (phys_ram,NULL ,"axisdev88.ram" , - ram_size); -memory_region_add_subregion (address_space_mem,0x40000000 , phys_ram); +memory_region_add_subregion (address_space_mem,0x40000000 , machine->ram);/* The ETRAX-FS has 128Kb on chip ram, the docs refer to it as the internal memory. */
@@ -351,6 +346,7 @@ static void axisdev88_machine_init(MachineClass *mc) mc->init = axisdev88_init; mc->is_default =1 ; mc->default_cpu_type =CRIS_CPU_TYPE_NAME ("crisv32" ); + mc->default_ram_id ="axisdev88.ram" ; }DEFINE_MACHINE ("axis-dev88" , axisdev88_machine_init)
Signature · 1 line
2.7.4
PATCH v3 39/80 hw/hppa/machine: Correctly check the firmware is in PDC range
In reply to Igor MammedovFrom: Philippe Mathieu-Daudé <[email protected]>
The firmware has to reside in the PDC range. If the Elf file expects to load it below FIRMWARE_START, it is incorrect, regardless the RAM size.
--- hw/hppa/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/hppa/machine.c +1 -1
@@ -155,7 +155,7 @@ static void machine_hppa_init(MachineState *machine)qemu_log_mask (CPU_LOG_PAGE ,"Firmware loaded at 0x%08" PRIx64"-0x%08" PRIx64", entry at 0x%08" PRIx64".\n" , firmware_low, firmware_high, firmware_entry); -if (firmware_low < ram_size || firmware_high >=FIRMWARE_END ) { +if (firmware_low <FIRMWARE_START || firmware_high >=FIRMWARE_END ) {error_report ("Firmware overlaps with memory or IO space" );exit (1 ); }
Signature · 1 line
2.7.4
PATCH v3 40/80 hw/hppa/machine: Restrict the total memory size to 3GB
In reply to Igor MammedovFrom: Philippe Mathieu-Daudé <[email protected]>
The hardware expects DIMM slots of 1 or 2 GB, allowing up to 4 GB of memory. We want to accept the same amount of memory the hardware can deal with. DIMMs of 768MB are not available.
However we have to deal with a firmware limitation: currently SeaBIOS only supports 32-bit, and expects the RAM size in a 32-bit register. When using a 4GB configuration, the 32-bit register get truncated and we report a size of 0MB to SeaBIOS, which ends halting the machine:
$ qemu-system-hppa -m 4g -serial stdio
SeaBIOS: Machine configured with too little memory (0 MB), minimum is 16 MB.
SeaBIOS wants SYSTEM HALT.
The easiest way is to restrict the machine to 3GB of memory.
--- hw/hppa/machine.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
hw/hppa/machine.c +4 -5
@@ -90,12 +90,11 @@ static void machine_hppa_init(MachineState *machine)g_free (name); } -/* Limit main memory. */ -if (ram_size >FIRMWARE_START ) { - machine->ram_size = ram_size =FIRMWARE_START ; - } -/* Main memory region. */ +if (machine->ram_size >3 * GiB) { +error_report ("RAM size is currently restricted to 3GB" ); +exit (EXIT_FAILURE ); + } ram_region =g_new (MemoryRegion,1 );memory_region_allocate_system_memory (ram_region,OBJECT (machine),"ram" , ram_size);
Signature · 1 line
2.7.4
PATCH v3 41/80 hw/hppa/machine: Map the PDC memory region with higher priority
In reply to Igor MammedovFrom: Philippe Mathieu-Daudé <[email protected]>
The region in range [0xf0000000 - 0xf1000000] is the PDC area (Processor Dependent Code), where the firmware is loaded. This region has higher priority than the main memory.
When the machine has more than 3840MB of RAM, there is an overlap. Since the PDC is closer to the CPU in the bus hierarchy, it gets accessed first, and the CPU does not have access to the RAM in this range.
To model the same behavior and keep a simple memory layout, reduce the priority of the RAM region. The PDC region ends overlapping the RAM.
--- hw/hppa/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/hppa/machine.c +1 -1
@@ -98,7 +98,7 @@ static void machine_hppa_init(MachineState *machine) ram_region =g_new (MemoryRegion,1 );memory_region_allocate_system_memory (ram_region,OBJECT (machine),"ram" , ram_size); -memory_region_add_subregion (addr_space,0 , ram_region); +memory_region_add_subregion_overlap (addr_space,0 , ram_region,-1 );/* Init Dino (PCI host bus chip). */ pci_bus =dino_init (addr_space, &rtc_irq, &serial_irq);
Signature · 1 line
2.7.4
PATCH v3 42/80 hppa: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
--- hw/hppa/machine.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
hw/hppa/machine.c +3 -7
@@ -70,13 +70,10 @@ static void machine_hppa_init(MachineState *machine)uint64_t kernel_entry =0 , kernel_low, kernel_high;MemoryRegion *addr_space =get_system_memory ();MemoryRegion *rom_region; -MemoryRegion *ram_region;MemoryRegion *cpu_region;long i;unsigned int smp_cpus = machine->smp.cpus; - ram_size = machine->ram_size; -/* Create CPUs. */ for (i =0 ; i < smp_cpus; i++) {char *name =g_strdup_printf ("cpu%ld-io-eir" , i);
@@ -95,10 +92,8 @@ static void machine_hppa_init(MachineState *machine)error_report ("RAM size is currently restricted to 3GB" );exit (EXIT_FAILURE ); } - ram_region =g_new (MemoryRegion,1 ); -memory_region_allocate_system_memory (ram_region,OBJECT (machine), -"ram" , ram_size); -memory_region_add_subregion_overlap (addr_space,0 , ram_region,-1 ); +memory_region_add_subregion_overlap (addr_space,0 , machine->ram,-1 ); +/* Init Dino (PCI host bus chip). */ pci_bus =dino_init (addr_space, &rtc_irq, &serial_irq);
@@ -282,6 +277,7 @@ static void machine_hppa_machine_init(MachineClass *mc) mc->is_default =1 ; mc->default_ram_size =512 * MiB; mc->default_boot_order ="cd" ; + mc->default_ram_id ="ram" ; }DEFINE_MACHINE ("hppa" , machine_hppa_machine_init)
Signature · 1 line
2.7.4
PATCH v3 43/80 x86/microvm: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/i386/microvm.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
hw/i386/microvm.c +5 -7
@@ -167,7 +167,7 @@ static void microvm_memory_init(MicrovmMachineState *mms) {MachineState *machine =MACHINE (mms);X86MachineState *x86ms =X86_MACHINE (mms); -MemoryRegion *ram, *ram_below_4g, *ram_above_4g; +MemoryRegion *ram_below_4g, *ram_above_4g;MemoryRegion *system_memory =get_system_memory ();FWCfgState *fw_cfg;ram_addr_t lowmem;
@@ -214,12 +214,8 @@ static void microvm_memory_init(MicrovmMachineState *mms) x86ms->below_4g_mem_size = machine->ram_size; } - ram =g_malloc (sizeof (*ram)); -memory_region_allocate_system_memory (ram,NULL ,"microvm.ram" , - machine->ram_size); - ram_below_4g =g_malloc (sizeof (*ram_below_4g)); -memory_region_init_alias (ram_below_4g,NULL ,"ram-below-4g" , ram, +memory_region_init_alias (ram_below_4g,NULL ,"ram-below-4g" , machine->ram,0 , x86ms->below_4g_mem_size);memory_region_add_subregion (system_memory,0 , ram_below_4g);
@@ -227,7 +223,8 @@ static void microvm_memory_init(MicrovmMachineState *mms)if (x86ms->above_4g_mem_size >0 ) { ram_above_4g =g_malloc (sizeof (*ram_above_4g)); -memory_region_init_alias (ram_above_4g,NULL ,"ram-above-4g" , ram, +memory_region_init_alias (ram_above_4g,NULL ,"ram-above-4g" , + machine->ram, x86ms->below_4g_mem_size, x86ms->above_4g_mem_size); memory_region_add_subregion(system_memory, 0x100000000ULL,
@@ -502,6 +499,7 @@ static void microvm_class_init(ObjectClass *oc, void *data) mc->auto_enable_numa_with_memhp = false; mc->default_cpu_type =TARGET_DEFAULT_CPU_TYPE ; mc->nvdimm_supported = false; + mc->default_ram_id ="microvm.ram" ;/* Avoid relying too much on kernel components */ mc->default_kernel_irqchip_split = true;
Signature · 1 line
2.7.4
PATCH v3 44/80 x86/pc: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/i386/pc.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)
hw/i386/pc.c +9 -10
@@ -935,7 +935,7 @@ void pc_memory_init(PCMachineState *pcms, MemoryRegion **ram_memory) {int linux_boot, i; -MemoryRegion *ram, *option_rom_mr; +MemoryRegion *option_rom_mr;MemoryRegion *ram_below_4g, *ram_above_4g;FWCfgState *fw_cfg;MachineState *machine =MACHINE (pcms);
@@ -948,22 +948,20 @@ void pc_memory_init(PCMachineState *pcms, linux_boot = (machine->kernel_filename !=NULL ); -/* Allocate RAM. We allocate it as a single memory region and use -* aliases to address portions of it, mostly for backwards compatibility -* with older qemus that used qemu_ram_alloc(). +/* +* Split single memory region and use aliases to address portions of it, +* done for backwards compatibility with older qemus. */ - ram =g_malloc (sizeof (*ram)); -memory_region_allocate_system_memory (ram,NULL ,"pc.ram" , - machine->ram_size); - *ram_memory = ram; + *ram_memory = machine->ram; ram_below_4g =g_malloc (sizeof (*ram_below_4g)); -memory_region_init_alias (ram_below_4g,NULL ,"ram-below-4g" , ram, +memory_region_init_alias (ram_below_4g,NULL ,"ram-below-4g" , machine->ram,0 , x86ms->below_4g_mem_size);memory_region_add_subregion (system_memory,0 , ram_below_4g);e820_add_entry (0 , x86ms->below_4g_mem_size,E820_RAM );if (x86ms->above_4g_mem_size >0 ) { ram_above_4g =g_malloc (sizeof (*ram_above_4g)); -memory_region_init_alias (ram_above_4g,NULL ,"ram-above-4g" , ram, +memory_region_init_alias (ram_above_4g,NULL ,"ram-above-4g" , + machine->ram, x86ms->below_4g_mem_size, x86ms->above_4g_mem_size); memory_region_add_subregion(system_memory, 0x100000000ULL,
@@ -1950,6 +1948,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) mc->default_cpu_type =TARGET_DEFAULT_CPU_TYPE ; mc->nvdimm_supported = true; mc->numa_mem_supported = true; + mc->default_ram_id ="pc.ram" ; object_class_property_add(oc, PC_MACHINE_DEVMEM_REGION_SIZE, "int", pc_machine_get_device_memory_region_size, NULL,
Signature · 1 line
2.7.4
PATCH v3 45/80 lm32/lm32_boards: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/lm32/lm32_boards.c | 39 ++++++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 13 deletions(-)
hw/lm32/lm32_boards.c +26 -13
@@ -19,6 +19,7 @@#include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/cutils.h" #include "qemu/error-report.h" #include "cpu.h" #include "hw/sysbus.h"
@@ -75,22 +76,28 @@ static void main_cpu_reset(void *opaque)static void lm32_evr_init (MachineState *machine) { +MachineClass *mc =MACHINE_GET_CLASS (machine);const char *kernel_filename = machine->kernel_filename;LM32CPU *cpu;CPULM32State *env;DriveInfo *dinfo;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *phys_ram =g_new (MemoryRegion,1 );qemu_irq irq[32 ];ResetInfo *reset_info;int i; +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +/* memory map */ hwaddr flash_base =0x04000000 ;size_t flash_sector_size =256 * KiB;size_t flash_size =32 * MiB;hwaddr ram_base =0x08000000 ; -size_t ram_size =64 * MiB;hwaddr timer0_base =0x80002000 ;hwaddr uart0_base =0x80006000 ;hwaddr timer1_base =0x8000a000 ;
@@ -107,9 +114,7 @@ static void lm32_evr_init(MachineState *machine) reset_info->flash_base = flash_base; -memory_region_allocate_system_memory (phys_ram,NULL ,"lm32_evr.sdram" , - ram_size); -memory_region_add_subregion (address_space_mem, ram_base, phys_ram); +memory_region_add_subregion (address_space_mem, ram_base, machine->ram); dinfo =drive_get (IF_PFLASH ,0 ,0 );/* Spansion S29NS128P */
@@ -144,7 +149,7 @@ static void lm32_evr_init(MachineState *machine)if (kernel_size <0 ) { kernel_size =load_image_targphys (kernel_filename, ram_base, - ram_size); + machine->ram_size); reset_info->bootstrap_pc = ram_base; }
@@ -159,6 +164,7 @@ static void lm32_evr_init(MachineState *machine)static void lm32_uclinux_init (MachineState *machine) { +MachineClass *mc =MACHINE_GET_CLASS (machine);const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;
@@ -166,18 +172,23 @@ static void lm32_uclinux_init(MachineState *machine)CPULM32State *env;DriveInfo *dinfo;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *phys_ram =g_new (MemoryRegion,1 );qemu_irq irq[32 ];HWSetup *hw;ResetInfo *reset_info;int i; +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +/* memory map */ hwaddr flash_base =0x04000000 ;size_t flash_sector_size =256 * KiB;size_t flash_size =32 * MiB;hwaddr ram_base =0x08000000 ; -size_t ram_size =64 * MiB;hwaddr uart0_base =0x80000000 ;hwaddr timer0_base =0x80002000 ;hwaddr timer1_base =0x80010000 ;
@@ -200,9 +211,7 @@ static void lm32_uclinux_init(MachineState *machine) reset_info->flash_base = flash_base; -memory_region_allocate_system_memory (phys_ram,NULL , -"lm32_uclinux.sdram" , ram_size); -memory_region_add_subregion (address_space_mem, ram_base, phys_ram); +memory_region_add_subregion (address_space_mem, ram_base, machine->ram); dinfo =drive_get (IF_PFLASH ,0 ,0 );/* Spansion S29NS128P */
@@ -238,7 +247,7 @@ static void lm32_uclinux_init(MachineState *machine)if (kernel_size <0 ) { kernel_size =load_image_targphys (kernel_filename, ram_base, - ram_size); + machine->ram_size); reset_info->bootstrap_pc = ram_base; }
@@ -252,7 +261,7 @@ static void lm32_uclinux_init(MachineState *machine) hw =hwsetup_init ();hwsetup_add_cpu (hw,"LM32" ,75000000 );hwsetup_add_flash (hw,"flash" , flash_base, flash_size); -hwsetup_add_ddr_sdram (hw,"ddr_sdram" , ram_base, ram_size); +hwsetup_add_ddr_sdram (hw,"ddr_sdram" , ram_base, machine->ram_size);hwsetup_add_timer (hw,"timer0" , timer0_base, timer0_irq);hwsetup_add_timer (hw,"timer1_dev_only" , timer1_base, timer1_irq);hwsetup_add_timer (hw,"timer2_dev_only" , timer2_base, timer2_irq);
@@ -288,6 +297,8 @@ static void lm32_evr_class_init(ObjectClass *oc, void *data) mc->init = lm32_evr_init; mc->is_default =1 ; mc->default_cpu_type =LM32_CPU_TYPE_NAME ("lm32-full" ); + mc->default_ram_size =64 * MiB; + mc->default_ram_id ="lm32_evr.sdram" ; }static const TypeInfo lm32_evr_type = {
@@ -304,6 +315,8 @@ static void lm32_uclinux_class_init(ObjectClass *oc, void *data) mc->init = lm32_uclinux_init; mc->is_default =0 ; mc->default_cpu_type =LM32_CPU_TYPE_NAME ("lm32-full" ); + mc->default_ram_size =64 * MiB; + mc->default_ram_id ="lm32_uclinux.sdram" ; }static const TypeInfo lm32_uclinux_type = {
Signature · 1 line
2.7.4
PATCH v3 46/80 lm32/milkymist: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
while at it add check for user supplied RAM size and error out if it mismatches board expected value.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
v3:
* use size_to_str() to pretty print size in MiB (Philippe Mathieu-Daudé <[email protected]>)
--- hw/lm32/milkymist.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)
hw/lm32/milkymist.c +14 -7
@@ -36,6 +36,7 @@#include "hw/display/milkymist_tmu2.h" #include "lm32.h" #include "exec/address-spaces.h" +#include "qemu/cutils.h" #define BIOS_FILENAME "mmone-bios.bin"#define BIOS_OFFSET 0x00860000
@@ -82,6 +83,7 @@ static void main_cpu_reset(void *opaque)static void milkymist_init (MachineState *machine) { +MachineClass *mc =MACHINE_GET_CLASS (machine);const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;
@@ -90,22 +92,27 @@ milkymist_init(MachineState *machine)int kernel_size;DriveInfo *dinfo;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *phys_sdram =g_new (MemoryRegion,1 );qemu_irq irq[32 ];int i;char *bios_filename;ResetInfo *reset_info; +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +/* memory map */ hwaddr flash_base =0x00000000 ;size_t flash_sector_size =128 * KiB;size_t flash_size =32 * MiB;hwaddr sdram_base =0x40000000 ; -size_t sdram_size =128 * MiB;hwaddr initrd_base = sdram_base +0x1002000 ;hwaddr cmdline_base = sdram_base +0x1000000 ; -size_t initrd_max = sdram_size -0x1002000 ; +size_t initrd_max = machine->ram_size -0x1002000 ; reset_info =g_malloc0 (sizeof (ResetInfo));
@@ -116,9 +123,7 @@ milkymist_init(MachineState *machine)cpu_lm32_set_phys_msb_ignore (env,1 ); -memory_region_allocate_system_memory (phys_sdram,NULL ,"milkymist.sdram" , - sdram_size); -memory_region_add_subregion (address_space_mem, sdram_base, phys_sdram); +memory_region_add_subregion (address_space_mem, sdram_base, machine->ram); dinfo =drive_get (IF_PFLASH ,0 ,0 );/* Numonyx JS28F256J3F105 */
@@ -183,7 +188,7 @@ milkymist_init(MachineState *machine)if (kernel_size <0 ) { kernel_size =load_image_targphys (kernel_filename, sdram_base, - sdram_size); + machine->ram_size); reset_info->bootstrap_pc = sdram_base; }
@@ -216,6 +221,8 @@ static void milkymist_machine_init(MachineClass *mc) mc->init = milkymist_init; mc->is_default =0 ; mc->default_cpu_type =LM32_CPU_TYPE_NAME ("lm32-full" ); + mc->default_ram_size =128 * MiB; + mc->default_ram_id ="milkymist.sdram" ; }DEFINE_MACHINE ("milkymist" , milkymist_machine_init)
Signature · 1 line
2.7.4
PATCH v3 47/80 m68k/an5206: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/m68k/an5206.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
hw/m68k/an5206.c +2 -3
@@ -33,7 +33,6 @@ static void an5206_init(MachineState *machine)uint64_t elf_entry;hwaddr entry;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *sram =g_new (MemoryRegion,1 ); cpu =M68K_CPU (cpu_create (machine->cpu_type));
@@ -46,8 +45,7 @@ static void an5206_init(MachineState *machine) env->rambar0 =AN5206_RAMBAR_ADDR |1 ;/* DRAM at address zero */ -memory_region_allocate_system_memory (ram,NULL ,"an5206.ram" , ram_size); -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);/* Internal SRAM. */ memory_region_init_ram (sram,NULL ,"an5206.sram" ,512 , &error_fatal);
@@ -89,6 +87,7 @@ static void an5206_machine_init(MachineClass *mc) mc->desc ="Arnewsh 5206" ; mc->init = an5206_init; mc->default_cpu_type =M68K_CPU_TYPE_NAME ("m5206" ); + mc->default_ram_id ="an5206.ram" ; }DEFINE_MACHINE ("an5206" , an5206_machine_init)
Signature · 1 line
2.7.4
PATCH v3 48/80 m68k/mcf5208: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/m68k/mcf5208.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
hw/m68k/mcf5208.c +2 -3
@@ -234,7 +234,6 @@ static void mcf5208evb_init(MachineState *machine)qemu_irq *pic;MemoryRegion *address_space_mem =get_system_memory ();MemoryRegion *rom =g_new (MemoryRegion,1 ); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *sram =g_new (MemoryRegion,1 ); cpu =M68K_CPU (cpu_create (machine->cpu_type));
@@ -249,8 +248,7 @@ static void mcf5208evb_init(MachineState *machine)memory_region_add_subregion (address_space_mem,0x00000000 , rom);/* DRAM at 0x40000000 */ -memory_region_allocate_system_memory (ram,NULL ,"mcf5208.ram" , ram_size); -memory_region_add_subregion (address_space_mem,0x40000000 , ram); +memory_region_add_subregion (address_space_mem,0x40000000 , machine->ram);/* Internal SRAM. */ memory_region_init_ram (sram,NULL ,"mcf5208.sram" ,16 * KiB, &error_fatal);
@@ -354,6 +352,7 @@ static void mcf5208evb_machine_init(MachineClass *mc) mc->init = mcf5208evb_init; mc->is_default =1 ; mc->default_cpu_type =M68K_CPU_TYPE_NAME ("m5208" ); + mc->default_ram_id ="mcf5208.ram" ; }DEFINE_MACHINE ("mcf5208evb" , mcf5208evb_machine_init)
Signature · 1 line
2.7.4
PATCH v3 49/80 m68k/next-cube: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/m68k/next-cube.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
hw/m68k/next-cube.c +2 -3
@@ -860,7 +860,6 @@ static void next_cube_init(MachineState *machine) {M68kCPU *cpu;CPUM68KState *env; -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *rom =g_new (MemoryRegion,1 );MemoryRegion *mmiomem =g_new (MemoryRegion,1 );MemoryRegion *scrmem =g_new (MemoryRegion,1 );
@@ -893,8 +892,7 @@ static void next_cube_init(MachineState *machine)memcpy (ns->rtc.ram, rtc_ram2,32 );/* 64MB RAM starting at 0x04000000 */ -memory_region_allocate_system_memory (ram,NULL ,"next.ram" , ram_size); -memory_region_add_subregion (sysmem,0x04000000 , ram); +memory_region_add_subregion (sysmem,0x04000000 , machine->ram);/* Framebuffer */ dev =qdev_create (NULL ,TYPE_NEXTFB );
@@ -967,6 +965,7 @@ static void next_machine_class_init(ObjectClass *oc, void *data) mc->desc ="NeXT Cube" ; mc->init = next_cube_init; mc->default_ram_size =RAM_SIZE ; + mc->default_ram_id ="next.ram" ; mc->default_cpu_type =M68K_CPU_TYPE_NAME ("m68040" ); }
Signature · 1 line
2.7.4
PATCH v3 50/80 mips/boston-cube: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/mips/boston.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
hw/mips/boston.c +5 -6
@@ -427,7 +427,7 @@ static void boston_mach_init(MachineState *machine)DeviceState *dev;BostonState *s;Error *err =NULL ; -MemoryRegion *flash, *ddr, *ddr_low_alias, *lcd, *platreg; +MemoryRegion *flash, *ddr_low_alias, *lcd, *platreg;MemoryRegion *sys_mem =get_system_memory ();XilinxPCIEHost *pcie2;PCIDevice *ahci;
@@ -473,14 +473,12 @@ static void boston_mach_init(MachineState *machine)memory_region_init_rom (flash,NULL ,"boston.flash" ,128 * MiB, &err);memory_region_add_subregion_overlap (sys_mem,0x18000000 , flash,0 ); - ddr =g_new (MemoryRegion,1 ); -memory_region_allocate_system_memory (ddr,NULL ,"boston.ddr" , - machine->ram_size); -memory_region_add_subregion_overlap (sys_mem,0x80000000 , ddr,0 ); +memory_region_add_subregion_overlap (sys_mem,0x80000000 , machine->ram,0 ); ddr_low_alias =g_new (MemoryRegion,1 );memory_region_init_alias (ddr_low_alias,NULL ,"boston_low.ddr" , - ddr,0 ,MIN (machine->ram_size, (256 * MiB))); + machine->ram,0 , +MIN (machine->ram_size, (256 * MiB)));memory_region_add_subregion_overlap (sys_mem,0 , ddr_low_alias,0 ); xilinx_pcie_init(sys_mem, 0,
@@ -552,6 +550,7 @@ static void boston_mach_class_init(MachineClass *mc) mc->init = boston_mach_init; mc->block_default_type =IF_IDE ; mc->default_ram_size =1 * GiB; + mc->default_ram_id ="boston.ddr" ; mc->max_cpus =16 ; mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("I6400" ); }
Signature · 1 line
2.7.4
PATCH v3 51/80 mips/mips_fulong2e: drop RAM size fixup
In reply to Igor MammedovIf user provided non-sense RAM size, board will complain and continue running with max RAM size supported.
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
---
v2:
* fix format string cousing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
v3:
* since size is ifxed, just hardcode 256Mb value as text in error message
(BALATON Zoltan <[email protected]>)
--- hw/mips/mips_fulong2e.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
hw/mips/mips_fulong2e.c +8 -5
@@ -296,7 +296,6 @@ static void mips_fulong2e_init(MachineState *machine)MemoryRegion *address_space_mem =get_system_memory ();MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios =g_new (MemoryRegion,1 ); -ram_addr_t ram_size = machine->ram_size;long bios_size;uint8_t *spd_data;Error *err =NULL ;
@@ -315,10 +314,14 @@ static void mips_fulong2e_init(MachineState *machine)qemu_register_reset (main_cpu_reset, cpu);/* TODO: support more than 256M RAM as highmem */ - ram_size =256 * MiB; +if (machine->ram_size !=256 * MiB) { +error_report ("Invalid RAM size, should be 256MB" ); +exit (EXIT_FAILURE ); + }/* allocate RAM */ -memory_region_allocate_system_memory (ram,NULL ,"fulong2e.ram" , ram_size); +memory_region_allocate_system_memory (ram,NULL ,"fulong2e.ram" , + machine->ram_size);memory_region_init_ram (bios,NULL ,"fulong2e.bios" ,BIOS_SIZE , &error_fatal);memory_region_set_readonly (bios, true);
@@ -332,7 +335,7 @@ static void mips_fulong2e_init(MachineState *machine)*/ if (kernel_filename) { - loaderparams.ram_size = ram_size; + loaderparams.ram_size = machine->ram_size; loaderparams.kernel_filename = kernel_filename; loaderparams.kernel_cmdline = kernel_cmdline; loaderparams.initrd_filename = initrd_filename;
@@ -378,7 +381,7 @@ static void mips_fulong2e_init(MachineState *machine) }/* Populate SPD eeprom data */ - spd_data =spd_data_generate (DDR , ram_size, &err); + spd_data =spd_data_generate (DDR , machine->ram_size, &err);if (err) {warn_report_err (err); }
Signature · 1 line
2.7.4
PATCH v3 52/80 mips/mips_fulong2e: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/mips/mips_fulong2e.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
hw/mips/mips_fulong2e.c +2 -4
@@ -294,7 +294,6 @@ static void mips_fulong2e_init(MachineState *machine)const char *initrd_filename = machine->initrd_filename;char *filename;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios =g_new (MemoryRegion,1 );long bios_size;uint8_t *spd_data;
@@ -320,13 +319,11 @@ static void mips_fulong2e_init(MachineState *machine) }/* allocate RAM */ -memory_region_allocate_system_memory (ram,NULL ,"fulong2e.ram" , - machine->ram_size);memory_region_init_ram (bios,NULL ,"fulong2e.bios" ,BIOS_SIZE , &error_fatal);memory_region_set_readonly (bios, true); -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);memory_region_add_subregion (address_space_mem,0x1fc00000LL , bios);/*
@@ -402,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc) mc->block_default_type =IF_IDE ; mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("Loongson-2E" ); mc->default_ram_size =256 * MiB; + mc->default_ram_id ="fulong2e.ram" ; }DEFINE_MACHINE ("fulong2e" , mips_fulong2e_machine_init)
Signature · 1 line
2.7.4
PATCH v3 53/80 mips/mips_jazz: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/mips/mips_jazz.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
hw/mips/mips_jazz.c +3 -4
@@ -159,7 +159,6 @@ static void mips_jazz_init(MachineState *machine,ISABus *isa_bus;ISADevice *pit;DriveInfo *fds[MAX_FD ]; -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios =g_new (MemoryRegion,1 );MemoryRegion *bios2 =g_new (MemoryRegion,1 );SysBusESPState *sysbus_esp;
@@ -191,9 +190,7 @@ static void mips_jazz_init(MachineState *machine, cc->do_transaction_failed = mips_jazz_do_transaction_failed;/* allocate RAM */ -memory_region_allocate_system_memory (ram,NULL ,"mips_jazz.ram" , - machine->ram_size); -memory_region_add_subregion (address_space,0 , ram); +memory_region_add_subregion (address_space,0 , machine->ram);memory_region_init_ram (bios,NULL ,"mips_jazz.bios" ,MAGNUM_BIOS_SIZE , &error_fatal);
@@ -393,6 +390,7 @@ static void mips_magnum_class_init(ObjectClass *oc, void *data) mc->init = mips_magnum_init; mc->block_default_type =IF_SCSI ; mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("R4000" ); + mc->default_ram_id ="mips_jazz.ram" ; }static const TypeInfo mips_magnum_type = {
@@ -409,6 +407,7 @@ static void mips_pica61_class_init(ObjectClass *oc, void *data) mc->init = mips_pica61_init; mc->block_default_type =IF_SCSI ; mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("R4000" ); + mc->default_ram_id ="mips_jazz.ram" ; }static const TypeInfo mips_pica61_type = {
Signature · 1 line
2.7.4
Aleksandar Markovic
AppliedRe: [PATCH REPOST v3 53/80] mips/mips_jazz: use memdev for RAM
Quoted 8 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.
Quoted 7 lines
Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>--- hw/mips/mips_jazz.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Applied to MIPS queue.
Quoted 46 lines
hw/mips/mips_jazz.c +2
-4@@ -159,7 +159,6 @@ static void mips_jazz_init(MachineState *machine,ISABus *isa_bus;ISADevice *pit;DriveInfo *fds[MAX_FD ]; -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios =g_new (MemoryRegion,1 );MemoryRegion *bios2 =g_new (MemoryRegion,1 );SysBusESPState *sysbus_esp;@@ -191,9 +190,7 @@ static void mips_jazz_init(MachineState *machine, cc->do_transaction_failed = mips_jazz_do_transaction_failed;/* allocate RAM */ -memory_region_allocate_system_memory (ram,NULL ,"mips_jazz.ram" , - machine->ram_size); -memory_region_add_subregion (address_space,0 , ram); +memory_region_add_subregion (address_space,0 , machine->ram);memory_region_init_ram (bios,NULL ,"mips_jazz.bios" ,MAGNUM_BIOS_SIZE , &error_fatal);@@ -393,6 +390,7 @@ static void mips_magnum_class_init(ObjectClass *oc, void *data) mc->init = mips_magnum_init; mc->block_default_type =IF_SCSI ; mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("R4000" ); + mc->default_ram_id ="mips_jazz.ram" ; }static const TypeInfo
mips_magnum_type= {hw/mips/mips_jazz.c +1
-0@@ -409,6 +407,7 @@ static void mips_pica61_class_init(ObjectClass *oc, void *data) mc->init = mips_pica61_init; mc->block_default_type =IF_SCSI ; mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("R4000" ); + mc->default_ram_id ="mips_jazz.ram" ; }static const TypeInfo
mips_pica61_type= {
--
2.7.4
PATCH v3 54/80 mips/mips_malta: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/mips/mips_malta.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
hw/mips/mips_malta.c +4 -6
@@ -1223,7 +1223,6 @@ void mips_malta_init(MachineState *machine)char *filename;PFlashCFI01 *fl;MemoryRegion *system_memory =get_system_memory (); -MemoryRegion *ram_high =g_new (MemoryRegion,1 );MemoryRegion *ram_low_preio =g_new (MemoryRegion,1 );MemoryRegion *ram_low_postio;MemoryRegion *bios, *bios_copy =g_new (MemoryRegion,1 );
@@ -1261,13 +1260,11 @@ void mips_malta_init(MachineState *machine) }/* register RAM at high address where it is undisturbed by IO */ -memory_region_allocate_system_memory (ram_high,NULL ,"mips_malta.ram" , - ram_size); -memory_region_add_subregion (system_memory,0x80000000 , ram_high); +memory_region_add_subregion (system_memory,0x80000000 , machine->ram);/* alias for pre IO hole access */ memory_region_init_alias (ram_low_preio,NULL ,"mips_malta_low_preio.ram" , - ram_high,0 ,MIN (ram_size,256 * MiB)); + machine->ram,0 ,MIN (ram_size,256 * MiB));memory_region_add_subregion (system_memory,0 , ram_low_preio);/* alias for post IO hole access, if there is enough RAM */
@@ -1275,7 +1272,7 @@ void mips_malta_init(MachineState *machine) ram_low_postio =g_new (MemoryRegion,1 );memory_region_init_alias (ram_low_postio,NULL ,"mips_malta_low_postio.ram" , - ram_high,512 * MiB, + machine->ram,512 * MiB, ram_size -512 * MiB);memory_region_add_subregion (system_memory,512 * MiB, ram_low_postio);
@@ -1447,6 +1444,7 @@ static void mips_malta_machine_init(MachineClass *mc)#else mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("24Kf" );#endif + mc->default_ram_id ="mips_malta.ram" ; }DEFINE_MACHINE ("malta" , mips_malta_machine_init)
Signature · 1 line
2.7.4
Aleksandar Markovic
AppliedRe: [PATCH REPOST v3 54/80] mips/mips_malta: use memdev for RAM
Quoted 8 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.
Quoted 8 lines
Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>--- hw/mips/mips_malta.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
Applied to MIPS queue.
Quoted 51 lines
hw/mips/mips_malta.c +2
-5@@ -1223,7 +1223,6 @@ void mips_malta_init(MachineState *machine)char *filename;PFlashCFI01 *fl;MemoryRegion *system_memory =get_system_memory (); -MemoryRegion *ram_high =g_new (MemoryRegion,1 );MemoryRegion *ram_low_preio =g_new (MemoryRegion,1 );MemoryRegion *ram_low_postio;MemoryRegion *bios, *bios_copy =g_new (MemoryRegion,1 );@@ -1261,13 +1260,11 @@ void mips_malta_init(MachineState *machine) }/* register RAM at high address where it is undisturbed by IO */ -memory_region_allocate_system_memory (ram_high,NULL ,"mips_malta.ram" , - ram_size); -memory_region_add_subregion (system_memory,0x80000000 , ram_high); +memory_region_add_subregion (system_memory,0x80000000 , machine->ram);/* alias for pre IO hole access */ memory_region_init_alias (ram_low_preio,NULL ,"mips_malta_low_preio.ram" , - ram_high,0 ,MIN (ram_size,256 * MiB)); + machine->ram,0 ,MIN (ram_size,256 * MiB));memory_region_add_subregion (system_memory,0 , ram_low_preio);/* alias for post IO hole access, if there is enough RAM */hw/mips/mips_malta.c +2
-2@@ -1275,7 +1272,7 @@ void mips_malta_init(MachineState *machine) ram_low_postio =g_new (MemoryRegion,1 );memory_region_init_alias (ram_low_postio,NULL ,"mips_malta_low_postio.ram" , - ram_high,512 * MiB, + machine->ram,512 * MiB, ram_size -512 * MiB);memory_region_add_subregion (system_memory,512 * MiB, ram_low_postio);@@ -1447,6 +1444,7 @@ static void mips_malta_machine_init(MachineClass *mc)#else mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("24Kf" );#endif + mc->default_ram_id ="mips_malta.ram" ; }DEFINE_MACHINE ("malta" , mips_malta_machine_init) --2.7.4
PATCH v3 55/80 mips/mips_mipssim: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/mips/mips_mipssim.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
hw/mips/mips_mipssim.c +3 -6
@@ -143,14 +143,12 @@ static void mipsnet_init(int base, qemu_irq irq, NICInfo *nd)static void mips_mipssim_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;char *filename;MemoryRegion *address_space_mem =get_system_memory ();MemoryRegion *isa =g_new (MemoryRegion,1 ); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios =g_new (MemoryRegion,1 );MIPSCPU *cpu;CPUMIPSState *env;
@@ -167,13 +165,11 @@ mips_mipssim_init(MachineState *machine)qemu_register_reset (main_cpu_reset, reset_info);/* Allocate RAM. */ -memory_region_allocate_system_memory (ram,NULL ,"mips_mipssim.ram" , - ram_size);memory_region_init_ram (bios,NULL ,"mips_mipssim.bios" ,BIOS_SIZE , &error_fatal);memory_region_set_readonly (bios, true); -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);/* Map the BIOS / boot exception handler. */ memory_region_add_subregion (address_space_mem,0x1fc00000LL , bios);
@@ -200,7 +196,7 @@ mips_mipssim_init(MachineState *machine) }if (kernel_filename) { - loaderparams.ram_size = ram_size; + loaderparams.ram_size = machine->ram_size; loaderparams.kernel_filename = kernel_filename; loaderparams.kernel_cmdline = kernel_cmdline; loaderparams.initrd_filename = initrd_filename;
@@ -245,6 +241,7 @@ static void mips_mipssim_machine_init(MachineClass *mc)#else mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("24Kf" );#endif + mc->default_ram_id ="mips_mipssim.ram" ; }DEFINE_MACHINE ("mipssim" , mips_mipssim_machine_init)
Signature · 1 line
2.7.4
Aleksandar Markovic
AppliedRe: [PATCH REPOST v3 55/80] mips/mips_mipssim: use memdev for RAM
Quoted 8 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.
Quoted 8 lines
Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>--- hw/mips/mips_mipssim.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
Applied to MIPS queue.
Quoted 57 lines
hw/mips/mips_mipssim.c +0
-2@@ -143,14 +143,12 @@ static void mipsnet_init(int base, qemu_irq irq, NICInfo *nd)static void mips_mipssim_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;char *filename;MemoryRegion *address_space_mem =get_system_memory ();MemoryRegion *isa =g_new (MemoryRegion,1 ); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios =g_new (MemoryRegion,1 );MIPSCPU *cpu;CPUMIPSState *env;hw/mips/mips_mipssim.c +3
-5@@ -167,13 +165,11 @@ mips_mipssim_init(MachineState *machine)qemu_register_reset (main_cpu_reset, reset_info);/* Allocate RAM. */ -memory_region_allocate_system_memory (ram,NULL ,"mips_mipssim.ram" , - ram_size);memory_region_init_ram (bios,NULL ,"mips_mipssim.bios" ,BIOS_SIZE , &error_fatal);memory_region_set_readonly (bios, true); -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);/* Map the BIOS / boot exception handler. */ memory_region_add_subregion (address_space_mem,0x1fc00000LL , bios);@@ -200,7 +196,7 @@ mips_mipssim_init(MachineState *machine) }if (kernel_filename) { - loaderparams.ram_size = ram_size; + loaderparams.ram_size = machine->ram_size; loaderparams.kernel_filename = kernel_filename; loaderparams.kernel_cmdline = kernel_cmdline; loaderparams.initrd_filename = initrd_filename;@@ -245,6 +241,7 @@ static void mips_mipssim_machine_init(MachineClass *mc)#else mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("24Kf" );#endif + mc->default_ram_id ="mips_mipssim.ram" ; }DEFINE_MACHINE ("mipssim" , mips_mipssim_machine_init) --2.7.4
PATCH v3 56/80 mips/mips_r4k: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/mips/mips_r4k.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
hw/mips/mips_r4k.c +4 -8
@@ -171,13 +171,11 @@ static const int sector_len = 32 * KiB;static void mips_r4k_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;char *filename;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios;MemoryRegion *iomem =g_new (MemoryRegion,1 );MemoryRegion *isa_io =g_new (MemoryRegion,1 );
@@ -203,14 +201,12 @@ void mips_r4k_init(MachineState *machine)qemu_register_reset (main_cpu_reset, reset_info);/* allocate RAM */ -if (ram_size >256 * MiB) { +if (machine->ram_size >256 * MiB) {error_report ("Too much memory for this machine: %" PRId64"MB," " maximum 256MB" , ram_size / MiB);exit (1 ); } -memory_region_allocate_system_memory (ram,NULL ,"mips_r4k.ram" , ram_size); - -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram);memory_region_init_io (iomem,NULL , &mips_qemu_ops,NULL ,"mips-qemu" ,0x10000 );
@@ -261,7 +257,7 @@ void mips_r4k_init(MachineState *machine)g_free (filename);if (kernel_filename) { - loaderparams.ram_size = ram_size; + loaderparams.ram_size = machine->ram_size; loaderparams.kernel_filename = kernel_filename; loaderparams.kernel_cmdline = kernel_cmdline; loaderparams.initrd_filename = initrd_filename;
@@ -316,7 +312,7 @@ static void mips_machine_init(MachineClass *mc)#else mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("24Kf" );#endif - + mc->default_ram_id ="mips_r4k.ram" ; }DEFINE_MACHINE ("mips" , mips_machine_init)
Signature · 1 line
2.7.4
Aleksandar Markovic
AppliedRe: [PATCH REPOST v3 56/80] mips/mips_r4k: use memdev for RAM
Quoted 8 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.
Quoted 7 lines
Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>--- hw/mips/mips_r4k.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
Applied to MIPS queue.
Quoted 59 lines
hw/mips/mips_r4k.c +2
-6@@ -171,13 +171,11 @@ static const int sector_len = 32 * KiB;static void mips_r4k_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;char *filename;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios;MemoryRegion *iomem =g_new (MemoryRegion,1 );MemoryRegion *isa_io =g_new (MemoryRegion,1 );@@ -203,14 +201,12 @@ void mips_r4k_init(MachineState *machine)qemu_register_reset (main_cpu_reset, reset_info);/* allocate RAM */ -if (ram_size >256 * MiB) { +if (machine->ram_size >256 * MiB) {error_report ("Too much memory for this machine: %" PRId64"MB," " maximum 256MB" , ram_size / MiB);exit (1 ); } -memory_region_allocate_system_memory (ram,NULL ,"mips_r4k.ram" , ram_size); - -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram); memory_region_init_io(iomem, NULL, &mips_qemu_ops,NULL, "mips-qemu", 0x10000);hw/mips/mips_r4k.c +2
-3@@ -261,7 +257,7 @@ void mips_r4k_init(MachineState *machine)g_free (filename);if (kernel_filename) { - loaderparams.ram_size = ram_size; + loaderparams.ram_size = machine->ram_size; loaderparams.kernel_filename = kernel_filename; loaderparams.kernel_cmdline = kernel_cmdline; loaderparams.initrd_filename = initrd_filename;@@ -316,7 +312,7 @@ static void mips_machine_init(MachineClass *mc)#else mc->default_cpu_type =MIPS_CPU_TYPE_NAME ("24Kf" );#endif - + mc->default_ram_id ="mips_r4k.ram" ; }DEFINE_MACHINE ("mips" , mips_machine_init) --2.7.4
PATCH v3 57/80 ppc/e500: drop RAM size fixup
In reply to Igor MammedovIf user provided non-sense RAM size, board will complain and continue running with max RAM size supported.
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
While at it, replace usage of global ram_size with machine->ram_size
---
v2:
* fix format string cousing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
--- hw/ppc/e500.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)
hw/ppc/e500.c +9 -7
@@ -906,12 +906,14 @@ void ppce500_init(MachineState *machine) env = firstenv; -/* Fixup Memory size on a alignment boundary */ - ram_size &= ~(RAM_SIZES_ALIGN -1 ); - machine->ram_size = ram_size; +if (!QEMU_IS_ALIGNED (machine->ram_size,RAM_SIZES_ALIGN )) { +error_report ("RAM size must be multiple of %" PRIu64,RAM_SIZES_ALIGN ); +exit (EXIT_FAILURE ); + }/* Register Memory */ -memory_region_allocate_system_memory (ram,NULL ,"mpc8544ds.ram" , ram_size); +memory_region_allocate_system_memory (ram,NULL ,"mpc8544ds.ram" , + machine->ram_size);memory_region_add_subregion (address_space_mem,0 , ram); dev =qdev_create (NULL ,"e500-ccsr" );
@@ -1083,7 +1085,7 @@ void ppce500_init(MachineState *machine) kernel_base = cur_base; kernel_size =load_image_targphys (machine->kernel_filename, cur_base, - ram_size - cur_base); + machine->ram_size - cur_base);if (kernel_size <0 ) {error_report ("could not load kernel '%s'" , machine->kernel_filename);
@@ -1097,7 +1099,7 @@ void ppce500_init(MachineState *machine)if (machine->initrd_filename) { initrd_base = (cur_base +INITRD_LOAD_PAD ) & ~INITRD_PAD_MASK ; initrd_size =load_image_targphys (machine->initrd_filename, initrd_base, - ram_size - initrd_base); + machine->ram_size - initrd_base);if (initrd_size <0 ) { error_report("could not load initial ram disk '%s'",
@@ -1115,7 +1117,7 @@ void ppce500_init(MachineState *machine)* ensures enough space between kernel and initrd. */ dt_base = (loadaddr + payload_size +DTC_LOAD_PAD ) & ~DTC_PAD_MASK ; -if (dt_base +DTB_MAX_SIZE > ram_size) { +if (dt_base +DTB_MAX_SIZE > machine->ram_size) {error_report ("not enough memory for device tree" );exit (1 ); }
Signature · 1 line
2.7.4
PATCH v3 58/80 ppc/e500: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
--- hw/ppc/e500.c | 5 +---- hw/ppc/e500plat.c | 1 + hw/ppc/mpc8544ds.c | 1 + 3 files changed, 3 insertions(+), 4 deletions(-)
hw/ppc/e500.c +1 -4
@@ -831,7 +831,6 @@ static void ppce500_power_off(void *opaque, int line, int on)void ppce500_init (MachineState *machine) {MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );PPCE500MachineState *pms =PPCE500_MACHINE (machine);const PPCE500MachineClass *pmc =PPCE500_MACHINE_GET_CLASS (machine);PCIBus *pci_bus;
@@ -912,9 +911,7 @@ void ppce500_init(MachineState *machine) }/* Register Memory */ -memory_region_allocate_system_memory (ram,NULL ,"mpc8544ds.ram" , - machine->ram_size); -memory_region_add_subregion (address_space_mem,0 , ram); +memory_region_add_subregion (address_space_mem,0 , machine->ram); dev =qdev_create (NULL ,"e500-ccsr" ); object_property_add_child(qdev_get_machine(), "e500-ccsr",
hw/ppc/e500plat.c +1 -0
@@ -97,6 +97,7 @@ static void e500plat_machine_class_init(ObjectClass *oc, void *data) mc->init = e500plat_init; mc->max_cpus =32 ; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("e500v2_v30" ); + mc->default_ram_id ="mpc8544ds.ram" ;machine_class_allow_dynamic_sysbus_dev (mc,TYPE_ETSEC_COMMON ); }
hw/ppc/mpc8544ds.c +1 -0
@@ -55,6 +55,7 @@ static void e500plat_machine_class_init(ObjectClass *oc, void *data) mc->init = mpc8544ds_init; mc->max_cpus =15 ; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("e500v2_v30" ); + mc->default_ram_id ="mpc8544ds.ram" ; }#define TYPE_MPC8544DS_MACHINE MACHINE_TYPE_NAME("mpc8544ds")
Signature · 1 line
2.7.4
PATCH v3 59/80 ppc/mac_newworld: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/ppc/mac_newworld.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
hw/ppc/mac_newworld.c +3 -3
@@ -118,7 +118,7 @@ static void ppc_core99_init(MachineState *machine)char *filename;IrqLines *openpic_irqs;int linux_boot, i, j, k; -MemoryRegion *ram =g_new (MemoryRegion,1 ), *bios =g_new (MemoryRegion,1 ); +MemoryRegion *bios =g_new (MemoryRegion,1 );hwaddr kernel_base, initrd_base, cmdline_base =0 ;long kernel_size, initrd_size;UNINHostState *uninorth_pci;
@@ -152,8 +152,7 @@ static void ppc_core99_init(MachineState *machine) }/* allocate RAM */ -memory_region_allocate_system_memory (ram,NULL ,"ppc_core99.ram" , ram_size); -memory_region_add_subregion (get_system_memory (),0 , ram); +memory_region_add_subregion (get_system_memory (),0 , machine->ram);/* allocate and load BIOS */ memory_region_init_ram(bios, NULL, "ppc_core99.bios", BIOS_SIZE,
@@ -586,6 +585,7 @@ static void core99_machine_class_init(ObjectClass *oc, void *data)#else mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("7400_v2.9" );#endif + mc->default_ram_id ="ppc_core99.ram" ; mc->ignore_boot_device_suffixes = true; fwc->get_dev_path = core99_fw_dev_path; }
Signature · 1 line
2.7.4
PATCH v3 60/80 ppc/mac_oldworld: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/ppc/mac_oldworld.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
hw/ppc/mac_oldworld.c +2 -4
@@ -91,7 +91,6 @@ static void ppc_heathrow_init(MachineState *machine)CPUPPCState *env =NULL ;char *filename;int linux_boot, i; -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *bios =g_new (MemoryRegion,1 );uint32_t kernel_base, initrd_base, cmdline_base =0 ;int32_t kernel_size, initrd_size;
@@ -127,9 +126,7 @@ static void ppc_heathrow_init(MachineState *machine)exit (1 ); } -memory_region_allocate_system_memory (ram,NULL ,"ppc_heathrow.ram" , - ram_size); -memory_region_add_subregion (sysmem,0 , ram); +memory_region_add_subregion (sysmem,0 , machine->ram);/* allocate and load BIOS */ memory_region_init_ram(bios, NULL, "ppc_heathrow.bios", BIOS_SIZE,
@@ -446,6 +443,7 @@ static void heathrow_class_init(ObjectClass *oc, void *data) mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("750_v3.1" ); mc->default_display ="std" ; mc->ignore_boot_device_suffixes = true; + mc->default_ram_id ="ppc_heathrow.ram" ; fwc->get_dev_path = heathrow_fw_dev_path; }
Signature · 1 line
2.7.4
PATCH v3 61/80 ppc/pnv: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/ppc/pnv.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
hw/ppc/pnv.c +2 -6
@@ -676,7 +676,6 @@ static void pnv_init(MachineState *machine) {PnvMachineState *pnv =PNV_MACHINE (machine);MachineClass *mc =MACHINE_GET_CLASS (machine); -MemoryRegion *ram;char *fw_filename;long fw_size;int i;
@@ -688,11 +687,7 @@ static void pnv_init(MachineState *machine)if (machine->ram_size < (1 * GiB)) {warn_report ("skiboot may not work with < 1GB of RAM" ); } - - ram =g_new (MemoryRegion,1 ); -memory_region_allocate_system_memory (ram,NULL ,"pnv.ram" , - machine->ram_size); -memory_region_add_subregion (get_system_memory (),0 , ram); +memory_region_add_subregion (get_system_memory (),0 , machine->ram);/* * Create our simple PNOR device
@@ -1785,6 +1780,7 @@ static void pnv_machine_class_init(ObjectClass *oc, void *data)* enough to fit the maximum initrd size at it's load address */ mc->default_ram_size =INITRD_LOAD_ADDR +INITRD_MAX_SIZE ; + mc->default_ram_id ="pnv.ram" ; ispc->print_info = pnv_pic_print_info; }
Signature · 1 line
2.7.4
PATCH v3 62/80 ppc/ppc405_boards: add RAM size checks
In reply to Igor MammedovIf user provided non-sense RAM size, board will ignore it and continue running with fixed RAM size.
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix CLI.
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
PS:
move fixed RAM size into mc->default_ram_size, so that generic code will know how much to allocate.
---
v2:
* fix format string causing build failure on 32-bit host (Philippe Mathieu-Daudé <[email protected]>)
v3:
* use size_to_str() to pretty print size in MiB (Philippe Mathieu-Daudé <[email protected]>/ BALATON Zoltan <[email protected]>)
--- hw/ppc/ppc405_boards.c | 39 ++++++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 13 deletions(-)
hw/ppc/ppc405_boards.c +26 -13
@@ -40,6 +40,7 @@#include "qemu/error-report.h" #include "hw/loader.h" #include "exec/address-spaces.h" +#include "qemu/cutils.h" #define BIOS_FILENAME "ppc405_rom.bin"#define BIOS_SIZE (2 * MiB)
@@ -137,7 +138,7 @@ static void ref405ep_fpga_init(MemoryRegion *sysmem, uint32_t base)static void ref405ep_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size; +MachineClass *mc =MACHINE_GET_CLASS (machine);const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;
@@ -161,15 +162,21 @@ static void ref405ep_init(MachineState *machine)DriveInfo *dinfo;MemoryRegion *sysmem =get_system_memory (); +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + } +/* XXX: fix this */ memory_region_allocate_system_memory (&ram_memories[0 ],NULL ,"ef405ep.ram" , -0x08000000 ); + machine->ram_size); ram_bases[0 ] =0 ; - ram_sizes[0 ] =0x08000000 ; + ram_sizes[0 ] = machine->ram_size;memory_region_init (&ram_memories[1 ],NULL ,"ef405ep.ram1" ,0 ); ram_bases[1 ] =0x00000000 ; ram_sizes[1 ] =0x00000000 ; - ram_size =128 * MiB; env =ppc405ep_init (sysmem, ram_memories, ram_bases, ram_sizes,33333333 , &pic, kernel_filename ==NULL ?0 :1 );/* allocate SRAM */
@@ -227,7 +234,7 @@ static void ref405ep_init(MachineState *machine)if (linux_boot) {memset (&bd,0 ,sizeof (bd)); bd.bi_memstart =0x00000000 ; - bd.bi_memsize = ram_size; + bd.bi_memsize = machine->ram_size; bd.bi_flashstart = -bios_size; bd.bi_flashsize = -bios_size; bd.bi_flashoffset =0 ;
@@ -255,7 +262,7 @@ static void ref405ep_init(MachineState *machine) kernel_base =KERNEL_LOAD_ADDR ;/* now we can load the kernel */ kernel_size =load_image_targphys (kernel_filename, kernel_base, - ram_size - kernel_base); + machine->ram_size - kernel_base);if (kernel_size <0 ) {error_report ("could not load kernel '%s'" , kernel_filename);exit (1 );
@@ -266,7 +273,7 @@ static void ref405ep_init(MachineState *machine)if (initrd_filename) { initrd_base =INITRD_LOAD_ADDR ; initrd_size =load_image_targphys (initrd_filename, initrd_base, - ram_size - initrd_base); + machine->ram_size - initrd_base);if (initrd_size <0 ) {error_report ("could not load initial ram disk '%s'" , initrd_filename);
@@ -304,6 +311,7 @@ static void ref405ep_class_init(ObjectClass *oc, void *data) mc->desc ="ref405ep" ; mc->init = ref405ep_init; + mc->default_ram_size =0x08000000 ; }static const TypeInfo ref405ep_type = {
@@ -408,7 +416,7 @@ static void taihu_cpld_init(MemoryRegion *sysmem, uint32_t base)static void taihu_405ep_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size; +MachineClass *mc =MACHINE_GET_CLASS (machine);const char *kernel_filename = machine->kernel_filename;const char *initrd_filename = machine->initrd_filename;char *filename;
@@ -425,10 +433,14 @@ static void taihu_405ep_init(MachineState *machine)int fl_idx;DriveInfo *dinfo; -/* RAM is soldered to the board so the size cannot be changed */ - ram_size =0x08000000 ; +if (machine->ram_size != mc->default_ram_size) { +char *sz =size_to_str (mc->default_ram_size); +error_report ("Invalid RAM size, should be %s" , sz); +g_free (sz); +exit (EXIT_FAILURE ); + }memory_region_allocate_system_memory (ram,NULL ,"taihu_405ep.ram" , - ram_size); + machine->ram_size); ram_bases[0 ] =0 ; ram_sizes[0 ] =0x04000000 ;
@@ -500,7 +512,7 @@ static void taihu_405ep_init(MachineState *machine) kernel_base =KERNEL_LOAD_ADDR ;/* now we can load the kernel */ kernel_size =load_image_targphys (kernel_filename, kernel_base, - ram_size - kernel_base); + machine->ram_size - kernel_base);if (kernel_size <0 ) {error_report ("could not load kernel '%s'" , kernel_filename);exit (1 );
@@ -509,7 +521,7 @@ static void taihu_405ep_init(MachineState *machine)if (initrd_filename) { initrd_base =INITRD_LOAD_ADDR ; initrd_size =load_image_targphys (initrd_filename, initrd_base, - ram_size - initrd_base); + machine->ram_size - initrd_base);if (initrd_size <0 ) {error_report ("could not load initial ram disk '%s'" , initrd_filename);
@@ -533,6 +545,7 @@ static void taihu_class_init(ObjectClass *oc, void *data) mc->desc ="taihu" ; mc->init = taihu_405ep_init; + mc->default_ram_size =0x08000000 ; }static const TypeInfo taihu_type = {
Signature · 1 line
2.7.4
PATCH v3 63/80 ppc/ppc405_boards: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
PS:
in ref405ep alias RAM into ram_memories[] to avoid re-factoring its user ppc405ep_init(), which would be invasive and out of scope this patch.
---
CC: [email protected]
CC: [email protected]
--- hw/ppc/ppc405_boards.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
hw/ppc/ppc405_boards.c +6 -7
@@ -170,8 +170,8 @@ static void ref405ep_init(MachineState *machine) }/* XXX: fix this */ -memory_region_allocate_system_memory (&ram_memories[0 ],NULL ,"ef405ep.ram" , - machine->ram_size); +memory_region_init_alias (&ram_memories[0 ],NULL ,"ef405ep.ram.alias" , + machine->ram,0 , machine->ram_size); ram_bases[0 ] =0 ; ram_sizes[0 ] = machine->ram_size;memory_region_init (&ram_memories[1 ],NULL ,"ef405ep.ram1" ,0 );
@@ -312,6 +312,7 @@ static void ref405ep_class_init(ObjectClass *oc, void *data) mc->desc ="ref405ep" ; mc->init = ref405ep_init; mc->default_ram_size =0x08000000 ; + mc->default_ram_id ="ef405ep.ram" ; }static const TypeInfo ref405ep_type = {
@@ -424,7 +425,6 @@ static void taihu_405ep_init(MachineState *machine)MemoryRegion *sysmem =get_system_memory ();MemoryRegion *bios;MemoryRegion *ram_memories =g_new (MemoryRegion,2 ); -MemoryRegion *ram =g_malloc0 (sizeof (*ram));hwaddr ram_bases[2 ], ram_sizes[2 ];long bios_size;target_ulong kernel_base, initrd_base;
@@ -439,18 +439,16 @@ static void taihu_405ep_init(MachineState *machine)g_free (sz);exit (EXIT_FAILURE ); } -memory_region_allocate_system_memory (ram,NULL ,"taihu_405ep.ram" , - machine->ram_size); ram_bases[0 ] =0 ; ram_sizes[0 ] =0x04000000 ;memory_region_init_alias (&ram_memories[0 ],NULL , -"taihu_405ep.ram-0" , ram, ram_bases[0 ], +"taihu_405ep.ram-0" , machine->ram, ram_bases[0 ], ram_sizes[0 ]); ram_bases[1 ] =0x04000000 ; ram_sizes[1 ] =0x04000000 ;memory_region_init_alias (&ram_memories[1 ],NULL , -"taihu_405ep.ram-1" , ram, ram_bases[1 ], +"taihu_405ep.ram-1" , machine->ram, ram_bases[1 ], ram_sizes[1 ]);ppc405ep_init (sysmem, ram_memories, ram_bases, ram_sizes,33333333 , &pic, kernel_filename ==NULL ?0 :1 );
@@ -546,6 +544,7 @@ static void taihu_class_init(ObjectClass *oc, void *data) mc->desc ="taihu" ; mc->init = taihu_405ep_init; mc->default_ram_size =0x08000000 ; + mc->default_ram_id ="ef405ep.ram" ; }static const TypeInfo taihu_type = {
Signature · 1 line
2.7.4
PATCH v3 64/80 ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup
In reply to Igor MammedovIf user provided non-sense RAM size, board will complain and continue running with max RAM size supported or sometimes crash like this:
%QEMU -M bamboo -m 1
exec.c:1926: find_ram_offset: Assertion `size != 0' failed. Aborted (core dumped)
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
That also fixes crash issue, since wrongly calculated size isn't used to allocate RAM
---
v2:
* s/ppc4xx_sdram_adjust/ppc4xx_sdram_prep/
(BALATON Zoltan <[email protected]>)
* print possible valid ram size id not all RAM was distributed
* initialize ram_bases/ram_bases at the same time we are checking that user supplied RAM would fit available banks and drop nested loop that were duplicating the same calculations.
* coincidentally fix crash when -m is less than minimal bank size
v3:
* s/ppc4xx_sdram_prep/ppc4xx_sdram_banks/
(BALATON Zoltan <[email protected]>)
* fix subject line in commit message
v3.1:
* add lost 'break' statement in 'j' loop
v3.2:
* replace global ram_size with machine->ram_size in ppc4xx_sdram_banks() call
* add a comment about the expected sorting order within sdram_bank_sizes[] (BALATON Zoltan <[email protected]>)
--- include/hw/ppc/ppc4xx.h | 9 ++++---- hw/ppc/ppc440_bamboo.c | 11 ++++----- hw/ppc/ppc4xx_devs.c | 60 ++++++++++++++++++++++++++----------------------- hw/ppc/sam460ex.c | 5 ++--- 4 files changed, 42 insertions(+), 43 deletions(-)
include/hw/ppc/ppc4xx.h +4 -5
@@ -42,11 +42,10 @@ enum {qemu_irq *ppcuic_init (CPUPPCState *env,qemu_irq *irqs,uint32_t dcr_base,int has_ssr,int has_vr); -ram_addr_t ppc4xx_sdram_adjust (ram_addr_t ram_size,int nr_banks, -MemoryRegion ram_memories[], -hwaddr ram_bases[], -hwaddr ram_sizes[], -const ram_addr_t sdram_bank_sizes[]); +void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +MemoryRegion ram_memories[], +hwaddr ram_bases[],hwaddr ram_sizes[], +const ram_addr_t sdram_bank_sizes[]); void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks, MemoryRegion ram_memories[],
hw/ppc/ppc440_bamboo.c +4 -7
@@ -158,7 +158,6 @@ static void main_cpu_reset(void *opaque)static void bamboo_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;
@@ -203,10 +202,8 @@ static void bamboo_init(MachineState *machine)/* SDRAM controller */ memset (ram_bases,0 ,sizeof (ram_bases));memset (ram_sizes,0 ,sizeof (ram_sizes)); - ram_size =ppc4xx_sdram_adjust (ram_size,PPC440EP_SDRAM_NR_BANKS , - ram_memories, - ram_bases, ram_sizes, - ppc440ep_sdram_bank_sizes); +ppc4xx_sdram_banks (machine->ram_size,PPC440EP_SDRAM_NR_BANKS , ram_memories, + ram_bases, ram_sizes, ppc440ep_sdram_bank_sizes);/* XXX 440EP's ECC interrupts are on UIC1, but we've only created UIC0. */ ppc4xx_sdram_init (env, pic[14 ],PPC440EP_SDRAM_NR_BANKS , ram_memories, ram_bases, ram_sizes,1 );
@@ -268,7 +265,7 @@ static void bamboo_init(MachineState *machine)/* Load initrd. */ if (initrd_filename) { initrd_size =load_image_targphys (initrd_filename,RAMDISK_ADDR , - ram_size -RAMDISK_ADDR ); + machine->ram_size -RAMDISK_ADDR );if (initrd_size <0 ) { error_report("could not load ram disk '%s' at %x",
@@ -279,7 +276,7 @@ static void bamboo_init(MachineState *machine)/* If we're loading a kernel directly, we must load the device tree too. */ if (kernel_filename) { -if (bamboo_load_device_tree (FDT_ADDR , ram_size,RAMDISK_ADDR , +if (bamboo_load_device_tree (FDT_ADDR , machine->ram_size,RAMDISK_ADDR , initrd_size, kernel_cmdline) <0 ) {error_report ("couldn't load device tree" );exit (1 );
hw/ppc/ppc4xx_devs.c +32 -28
94 lines not on this page · raw message
hw/ppc/sam460ex.c +2 -3
@@ -324,9 +324,8 @@ static void sam460ex_init(MachineState *machine)/* SDRAM controller */ /* put all RAM on first bank because board has one slot * and firmware only checks that */ - machine->ram_size =ppc4xx_sdram_adjust (machine->ram_size,1 , - ram_memories, ram_bases, ram_sizes, - ppc460ex_sdram_bank_sizes); +ppc4xx_sdram_banks (machine->ram_size,1 , ram_memories, ram_bases, ram_sizes, + ppc460ex_sdram_bank_sizes);/* FIXME: does 460EX have ECC interrupts? */ ppc440_sdram_init(env, SDRAM_NR_BANKS, ram_memories,
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 64/80] ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup
Quoted 9 lines · Igor Mammedov
If user provided non-sense RAM size, board will complain and continue running with max RAM size supported or sometimes crash like this:
%QEMU -M bamboo -m 1
exec.c:1926:find_ram_offset: Assertion `size != 0' failed. Aborted (core dumped)
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.
Quoted 6 lines
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
That also fixes crash issue, since wrongly calculated size isn't used to allocate RAMSigned-off-by Igor Mammedov <[email protected]>
Regards,
BALATON Zoltan
Quoted 211 lines
---
v2:
* s/ppc4xx_sdram_adjust/ppc4xx_sdram_prep/
(BALATON Zoltan <[email protected]>)
* print possible valid ram size id not all RAM was distributed
* initialize ram_bases/ram_bases at the same time we are checking that user supplied RAM would fit available banks and drop nested loop that were duplicating the same calculations.
* coincidentally fix crash when -m is less than minimal bank size
v3:
* s/ppc4xx_sdram_prep/ppc4xx_sdram_banks/
(BALATON Zoltan <[email protected]>)
* fix subject line in commit message
v3.1:
* add lost 'break' statement in 'j' loop
v3.2:
* replace globalram_sizewithmachine->ram_sizeinppc4xx_sdram_banks()call
* add a comment about the expected sorting order within sdram_bank_sizes[] (BALATON Zoltan <[email protected]>)---
include/hw/ppc/ppc4xx.h | 9 ++++---- hw/ppc/ppc440_bamboo.c | 11 ++++----- hw/ppc/ppc4xx_devs.c | 60 ++++++++++++++++++++++++++----------------------- hw/ppc/sam460ex.c | 5 ++--- 4 files changed, 42 insertions(+), 43 deletions(-)include/hw/ppc/ppc4xx.h +4
-5@@ -42,11 +42,10 @@ enum {qemu_irq *ppcuic_init (CPUPPCState *env,qemu_irq *irqs,uint32_t dcr_base,int has_ssr,int has_vr); -ram_addr_t ppc4xx_sdram_adjust (ram_addr_t ram_size,int nr_banks, -MemoryRegion ram_memories[], -hwaddr ram_bases[], -hwaddr ram_sizes[], -const ram_addr_t sdram_bank_sizes[]); +void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +MemoryRegion ram_memories[], +hwaddr ram_bases[],hwaddr ram_sizes[], +const ram_addr_t sdram_bank_sizes[]); void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks, MemoryRegion ram_memories[],hw/ppc/ppc440_bamboo.c +4
-7@@ -158,7 +158,6 @@ static void main_cpu_reset(void *opaque)static void bamboo_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;@@ -203,10 +202,8 @@ static void bamboo_init(MachineState *machine)/* SDRAM controller */ memset (ram_bases,0 ,sizeof (ram_bases));memset (ram_sizes,0 ,sizeof (ram_sizes)); - ram_size =ppc4xx_sdram_adjust (ram_size,PPC440EP_SDRAM_NR_BANKS , - ram_memories, - ram_bases, ram_sizes, - ppc440ep_sdram_bank_sizes); +ppc4xx_sdram_banks (machine->ram_size,PPC440EP_SDRAM_NR_BANKS , ram_memories, + ram_bases, ram_sizes, ppc440ep_sdram_bank_sizes);/* XXX 440EP's ECC interrupts are on UIC1, but we've only created UIC0. */ ppc4xx_sdram_init (env, pic[14 ],PPC440EP_SDRAM_NR_BANKS , ram_memories, ram_bases, ram_sizes,1 );@@ -268,7 +265,7 @@ static void bamboo_init(MachineState *machine)/* Load initrd. */ if (initrd_filename) { initrd_size =load_image_targphys (initrd_filename,RAMDISK_ADDR , - ram_size -RAMDISK_ADDR ); + machine->ram_size -RAMDISK_ADDR );if (initrd_size <0 ) { error_report("could not load ram disk '%s' at %x",@@ -279,7 +276,7 @@ static void bamboo_init(MachineState *machine)/* If we're loading a kernel directly, we must load the device tree too. */ if (kernel_filename) { -if (bamboo_load_device_tree (FDT_ADDR , ram_size,RAMDISK_ADDR , +if (bamboo_load_device_tree (FDT_ADDR , machine->ram_size,RAMDISK_ADDR , initrd_size, kernel_cmdline) <0 ) {error_report ("couldn't load device tree" );exit (1 );hw/ppc/ppc4xx_devs.c +32
-28@@ -668,21 +668,22 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,/* Fill in consecutive SDRAM banks with 'ram_size' bytes of memory. * -* sdram_bank_sizes[] must be 0-terminated. +* sdram_bank_sizes[] must be in descending order, that is sizes[i] > sizes[i+1] +* and must be 0-terminated. * * The 4xx SDRAM controller supports a small number of banks, and each bank * must be one of a small set of sizes. The number of banks and the supported * sizes varies by SoC. */ -ram_addr_t ppc4xx_sdram_adjust (ram_addr_t ram_size,int nr_banks, -MemoryRegion ram_memories[], -hwaddr ram_bases[], -hwaddr ram_sizes[], -const ram_addr_t sdram_bank_sizes[]) +void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +MemoryRegion ram_memories[], +hwaddr ram_bases[],hwaddr ram_sizes[], +const ram_addr_t sdram_bank_sizes[]) {MemoryRegion *ram =g_malloc0 (sizeof (*ram));ram_addr_t size_left = ram_size;ram_addr_t base =0 ;ram_addr_t bank_size; +int last_bank =0 ;int i;int j;@@ -690,7 +691,12 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks,for (j =0 ; sdram_bank_sizes[j] !=0 ; j++) { bank_size = sdram_bank_sizes[j];if (bank_size <= size_left) { + ram_bases[i] = base; + ram_sizes[i] = bank_size; + base += bank_size; size_left -= bank_size; + last_bank = i; +break ; } }if (!size_left) {@@ -699,34 +705,32 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks, } } - ram_size -= size_left;if (size_left) { -error_report ("Truncating memory to %" PRId64" MiB to fit SDRAM" -" controller limits" , ram_size / MiB); +ram_addr_t used_size = ram_size - size_left; +GString *s =g_string_new (NULL ); + +for (i =0 ; sdram_bank_sizes[i]; i++) { +g_string_append_printf (s,"%" PRIi64"%s" , + sdram_bank_sizes[i] / MiB, + sdram_bank_sizes[i +1 ] ?" ," :"" ); + } +error_report ("Max %d banks of %s MB DIMM/bank supported" , + nr_banks, s->str); +error_report ("Possible valid RAM size: %" PRIi64, + used_size ? used_size / MiB : sdram_bank_sizes[i -1 ] / MiB); + +g_string_free (s, true); +exit (EXIT_FAILURE ); }memory_region_allocate_system_memory (ram,NULL ,"ppc4xx.sdram" , ram_size); - size_left = ram_size; -for (i =0 ; i < nr_banks && size_left; i++) { -for (j =0 ; sdram_bank_sizes[j] !=0 ; j++) { - bank_size = sdram_bank_sizes[j]; - -if (bank_size <= size_left) { -char name[32 ]; -snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); -memory_region_init_alias (&ram_memories[i],NULL , name, ram, - base, bank_size); - ram_bases[i] = base; - ram_sizes[i] = bank_size; - base += bank_size; - size_left -= bank_size; -break ; - } - } +for (i =0 ; i <= last_bank; i++) { +char name[32 ]; +snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); +memory_region_init_alias (&ram_memories[i],NULL , name, ram, + ram_bases[i], ram_sizes[i]); } - -return ram_size; }/*****************************************************************************/ hw/ppc/sam460ex.c +2
-3@@ -324,9 +324,8 @@ static void sam460ex_init(MachineState *machine)/* SDRAM controller */ /* put all RAM on first bank because board has one slot * and firmware only checks that */ - machine->ram_size =ppc4xx_sdram_adjust (machine->ram_size,1 , - ram_memories, ram_bases, ram_sizes, - ppc460ex_sdram_bank_sizes); +ppc4xx_sdram_banks (machine->ram_size,1 , ram_memories, ram_bases, ram_sizes, + ppc460ex_sdram_bank_sizes);/* FIXME: does 460EX have ECC interrupts? */ ppc440_sdram_init(env, SDRAM_NR_BANKS, ram_memories,
Re: [PATCH REPOST v3 64/80] ppc/{ppc440_bamboo,sam460ex}: drop RAM size fixup
In reply to Igor MammedovQuoted 9 lines · Igor Mammedov
If user provided non-sense RAM size, board will complain and continue running with max RAM size supported or sometimes crash like this:
%QEMU -M bamboo -m 1
exec.c:1926:find_ram_offset: Assertion `size != 0' failed. Aborted (core dumped)
Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user.
Quoted 6 lines
Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values.
That also fixes crash issue, since wrongly calculated size isn't used to allocate RAMSigned-off-by Igor Mammedov <[email protected]>
Quoted 210 lines
---
v2:
* s/ppc4xx_sdram_adjust/ppc4xx_sdram_prep/
(BALATON Zoltan <[email protected]>)
* print possible valid ram size id not all RAM was distributed
* initialize ram_bases/ram_bases at the same time we are checking that user supplied RAM would fit available banks and drop nested loop that were duplicating the same calculations.
* coincidentally fix crash when -m is less than minimal bank size
v3:
* s/ppc4xx_sdram_prep/ppc4xx_sdram_banks/
(BALATON Zoltan <[email protected]>)
* fix subject line in commit message
v3.1:
* add lost 'break' statement in 'j' loop
v3.2:
* replace globalram_sizewithmachine->ram_sizeinppc4xx_sdram_banks()call
* add a comment about the expected sorting order within sdram_bank_sizes[] (BALATON Zoltan <[email protected]>)--- include/hw/ppc/ppc4xx.h | 9 ++++---- hw/ppc/ppc440_bamboo.c | 11 ++++----- hw/ppc/ppc4xx_devs.c | 60 ++++++++++++++++++++++++++----------------------- hw/ppc/sam460ex.c | 5 ++--- 4 files changed, 42 insertions(+), 43 deletions(-)include/hw/ppc/ppc4xx.h +4
-5@@ -42,11 +42,10 @@ enum {qemu_irq *ppcuic_init (CPUPPCState *env,qemu_irq *irqs,uint32_t dcr_base,int has_ssr,int has_vr); -ram_addr_t ppc4xx_sdram_adjust (ram_addr_t ram_size,int nr_banks, -MemoryRegion ram_memories[], -hwaddr ram_bases[], -hwaddr ram_sizes[], -const ram_addr_t sdram_bank_sizes[]); +void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +MemoryRegion ram_memories[], +hwaddr ram_bases[],hwaddr ram_sizes[], +const ram_addr_t sdram_bank_sizes[]); void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks, MemoryRegion ram_memories[],hw/ppc/ppc440_bamboo.c +4
-7@@ -158,7 +158,6 @@ static void main_cpu_reset(void *opaque)static void bamboo_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;@@ -203,10 +202,8 @@ static void bamboo_init(MachineState *machine)/* SDRAM controller */ memset (ram_bases,0 ,sizeof (ram_bases));memset (ram_sizes,0 ,sizeof (ram_sizes)); - ram_size =ppc4xx_sdram_adjust (ram_size,PPC440EP_SDRAM_NR_BANKS , - ram_memories, - ram_bases, ram_sizes, - ppc440ep_sdram_bank_sizes); +ppc4xx_sdram_banks (machine->ram_size,PPC440EP_SDRAM_NR_BANKS , ram_memories, + ram_bases, ram_sizes, ppc440ep_sdram_bank_sizes);/* XXX 440EP's ECC interrupts are on UIC1, but we've only created UIC0. */ ppc4xx_sdram_init (env, pic[14 ],PPC440EP_SDRAM_NR_BANKS , ram_memories, ram_bases, ram_sizes,1 );@@ -268,7 +265,7 @@ static void bamboo_init(MachineState *machine)/* Load initrd. */ if (initrd_filename) { initrd_size =load_image_targphys (initrd_filename,RAMDISK_ADDR , - ram_size -RAMDISK_ADDR ); + machine->ram_size -RAMDISK_ADDR );if (initrd_size <0 ) { error_report("could not load ram disk '%s' at %x",@@ -279,7 +276,7 @@ static void bamboo_init(MachineState *machine)/* If we're loading a kernel directly, we must load the device tree too. */ if (kernel_filename) { -if (bamboo_load_device_tree (FDT_ADDR , ram_size,RAMDISK_ADDR , +if (bamboo_load_device_tree (FDT_ADDR , machine->ram_size,RAMDISK_ADDR , initrd_size, kernel_cmdline) <0 ) {error_report ("couldn't load device tree" );exit (1 );hw/ppc/ppc4xx_devs.c +32
-28@@ -668,21 +668,22 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,/* Fill in consecutive SDRAM banks with 'ram_size' bytes of memory. * -* sdram_bank_sizes[] must be 0-terminated. +* sdram_bank_sizes[] must be in descending order, that is sizes[i] > sizes[i+1] +* and must be 0-terminated. * * The 4xx SDRAM controller supports a small number of banks, and each bank * must be one of a small set of sizes. The number of banks and the supported * sizes varies by SoC. */ -ram_addr_t ppc4xx_sdram_adjust (ram_addr_t ram_size,int nr_banks, -MemoryRegion ram_memories[], -hwaddr ram_bases[], -hwaddr ram_sizes[], -const ram_addr_t sdram_bank_sizes[]) +void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +MemoryRegion ram_memories[], +hwaddr ram_bases[],hwaddr ram_sizes[], +const ram_addr_t sdram_bank_sizes[]) {MemoryRegion *ram =g_malloc0 (sizeof (*ram));ram_addr_t size_left = ram_size;ram_addr_t base =0 ;ram_addr_t bank_size; +int last_bank =0 ;int i;int j;@@ -690,7 +691,12 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks,for (j =0 ; sdram_bank_sizes[j] !=0 ; j++) { bank_size = sdram_bank_sizes[j];if (bank_size <= size_left) { + ram_bases[i] = base; + ram_sizes[i] = bank_size; + base += bank_size; size_left -= bank_size; + last_bank = i; +break ; } }if (!size_left) {@@ -699,34 +705,32 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks, } } - ram_size -= size_left;if (size_left) { -error_report ("Truncating memory to %" PRId64" MiB to fit SDRAM" -" controller limits" , ram_size / MiB); +ram_addr_t used_size = ram_size - size_left; +GString *s =g_string_new (NULL ); + +for (i =0 ; sdram_bank_sizes[i]; i++) { +g_string_append_printf (s,"%" PRIi64"%s" , + sdram_bank_sizes[i] / MiB, + sdram_bank_sizes[i +1 ] ?" ," :"" ); + } +error_report ("Max %d banks of %s MB DIMM/bank supported" , + nr_banks, s->str); +error_report ("Possible valid RAM size: %" PRIi64, + used_size ? used_size / MiB : sdram_bank_sizes[i -1 ] / MiB); + +g_string_free (s, true); +exit (EXIT_FAILURE ); }memory_region_allocate_system_memory (ram,NULL ,"ppc4xx.sdram" , ram_size); - size_left = ram_size; -for (i =0 ; i < nr_banks && size_left; i++) { -for (j =0 ; sdram_bank_sizes[j] !=0 ; j++) { - bank_size = sdram_bank_sizes[j]; - -if (bank_size <= size_left) { -char name[32 ]; -snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); -memory_region_init_alias (&ram_memories[i],NULL , name, ram, - base, bank_size); - ram_bases[i] = base; - ram_sizes[i] = bank_size; - base += bank_size; - size_left -= bank_size; -break ; - } - } +for (i =0 ; i <= last_bank; i++) { +char name[32 ]; +snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); +memory_region_init_alias (&ram_memories[i],NULL , name, ram, + ram_bases[i], ram_sizes[i]); } - -return ram_size; }/*****************************************************************************/ hw/ppc/sam460ex.c +2
-3@@ -324,9 +324,8 @@ static void sam460ex_init(MachineState *machine)/* SDRAM controller */ /* put all RAM on first bank because board has one slot * and firmware only checks that */ - machine->ram_size =ppc4xx_sdram_adjust (machine->ram_size,1 , - ram_memories, ram_bases, ram_sizes, - ppc460ex_sdram_bank_sizes); +ppc4xx_sdram_banks (machine->ram_size,1 , ram_memories, ram_bases, ram_sizes, + ppc460ex_sdram_bank_sizes);/* FIXME: does 460EX have ECC interrupts? */ ppc440_sdram_init(env, SDRAM_NR_BANKS, ram_memories,
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH v3 65/80 ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
v3:
* drop ram_size from comment above ppc4xx_sdram_banks (BALATON Zoltan <[email protected]>)
* move memory alias initialization into the same loop where RAM is split on banks.
(BALATON Zoltan <[email protected]>)
v3.1
* rebase on top of previous patch due to changed context
--- include/hw/ppc/ppc4xx.h | 2 +- hw/ppc/ppc440_bamboo.c | 3 ++- hw/ppc/ppc4xx_devs.c | 25 +++++++++---------------- hw/ppc/sam460ex.c | 3 ++- 4 files changed, 14 insertions(+), 19 deletions(-)
include/hw/ppc/ppc4xx.h +1 -1
@@ -42,7 +42,7 @@ enum {qemu_irq *ppcuic_init (CPUPPCState *env,qemu_irq *irqs,uint32_t dcr_base,int has_ssr,int has_vr); -void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +void ppc4xx_sdram_banks (MemoryRegion *ram,int nr_banks,MemoryRegion ram_memories[],hwaddr ram_bases[],hwaddr ram_sizes[],const ram_addr_t sdram_bank_sizes[]);
hw/ppc/ppc440_bamboo.c +2 -1
@@ -202,7 +202,7 @@ static void bamboo_init(MachineState *machine)/* SDRAM controller */ memset (ram_bases,0 ,sizeof (ram_bases));memset (ram_sizes,0 ,sizeof (ram_sizes)); -ppc4xx_sdram_banks (machine->ram_size,PPC440EP_SDRAM_NR_BANKS , ram_memories, +ppc4xx_sdram_banks (machine->ram,PPC440EP_SDRAM_NR_BANKS , ram_memories, ram_bases, ram_sizes, ppc440ep_sdram_bank_sizes);/* XXX 440EP's ECC interrupts are on UIC1, but we've only created UIC0. */ ppc4xx_sdram_init(env, pic[14], PPC440EP_SDRAM_NR_BANKS, ram_memories,
@@ -289,6 +289,7 @@ static void bamboo_machine_init(MachineClass *mc) mc->desc ="bamboo" ; mc->init = bamboo_init; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("440epb" ); + mc->default_ram_id ="ppc4xx.sdram" ; }DEFINE_MACHINE ("bamboo" , bamboo_machine_init)
hw/ppc/ppc4xx_devs.c +9 -16
@@ -666,7 +666,7 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,sdram_map_bcr (sdram); } -/* Fill in consecutive SDRAM banks with 'ram_size' bytes of memory. +/* Split RAM between SDRAM banks. * * sdram_bank_sizes[] must be in descending order, that is sizes[i] > sizes[i+1] * and must be 0-terminated.
@@ -674,16 +674,14 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,* The 4xx SDRAM controller supports a small number of banks, and each bank * must be one of a small set of sizes. The number of banks and the supported * sizes varies by SoC. */ -void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +void ppc4xx_sdram_banks (MemoryRegion *ram,int nr_banks,MemoryRegion ram_memories[],hwaddr ram_bases[],hwaddr ram_sizes[],const ram_addr_t sdram_bank_sizes[]) { -MemoryRegion *ram =g_malloc0 (sizeof (*ram)); -ram_addr_t size_left = ram_size; +ram_addr_t size_left =memory_region_size (ram);ram_addr_t base =0 ;ram_addr_t bank_size; -int last_bank =0 ;int i;int j;
@@ -691,11 +689,15 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks,for (j =0 ; sdram_bank_sizes[j] !=0 ; j++) { bank_size = sdram_bank_sizes[j];if (bank_size <= size_left) { +char name[32 ]; + ram_bases[i] = base; ram_sizes[i] = bank_size; base += bank_size; size_left -= bank_size; - last_bank = i; +snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); +memory_region_init_alias (&ram_memories[i],NULL , name, ram, + ram_bases[i], ram_sizes[i]);break ; } }
@@ -706,7 +708,7 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks, }if (size_left) { -ram_addr_t used_size = ram_size - size_left; +ram_addr_t used_size =memory_region_size (ram) - size_left;GString *s =g_string_new (NULL );for (i =0 ; sdram_bank_sizes[i]; i++) {
@@ -722,15 +724,6 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks,g_string_free (s, true);exit (EXIT_FAILURE ); } - -memory_region_allocate_system_memory (ram,NULL ,"ppc4xx.sdram" , ram_size); - -for (i =0 ; i <= last_bank; i++) { -char name[32 ]; -snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); -memory_region_init_alias (&ram_memories[i],NULL , name, ram, - ram_bases[i], ram_sizes[i]); - } }/*****************************************************************************/
hw/ppc/sam460ex.c +2 -1
@@ -324,7 +324,7 @@ static void sam460ex_init(MachineState *machine)/* SDRAM controller */ /* put all RAM on first bank because board has one slot * and firmware only checks that */ -ppc4xx_sdram_banks (machine->ram_size,1 , ram_memories, ram_bases, ram_sizes, +ppc4xx_sdram_banks (machine->ram,1 , ram_memories, ram_bases, ram_sizes, ppc460ex_sdram_bank_sizes);/* FIXME: does 460EX have ECC interrupts? */
@@ -483,6 +483,7 @@ static void sam460ex_machine_init(MachineClass *mc) mc->init = sam460ex_init; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("460exb" ); mc->default_ram_size =512 * MiB; + mc->default_ram_id ="ppc4xx.sdram" ; }DEFINE_MACHINE ("sam460ex" , sam460ex_machine_init)
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 65/80] ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM
Quoted 9 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.Signed-off-by Igor Mammedov <[email protected]>
Regards,
BALATON Zoltan
Quoted 150 lines
---
v3:
* dropram_sizefrom comment aboveppc4xx_sdram_banks(BALATON Zoltan <[email protected]>)
* move memory alias initialization into the same loop where RAM is split on banks.
(BALATON Zoltan <[email protected]>)
v3.1
* rebase on top of previous patch due to changed context---
include/hw/ppc/ppc4xx.h | 2 +- hw/ppc/ppc440_bamboo.c | 3 ++- hw/ppc/ppc4xx_devs.c | 25 +++++++++---------------- hw/ppc/sam460ex.c | 3 ++- 4 files changed, 14 insertions(+), 19 deletions(-)include/hw/ppc/ppc4xx.h +1
-1@@ -42,7 +42,7 @@ enum {qemu_irq *ppcuic_init (CPUPPCState *env,qemu_irq *irqs,uint32_t dcr_base,int has_ssr,int has_vr); -void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +void ppc4xx_sdram_banks (MemoryRegion *ram,int nr_banks,MemoryRegion ram_memories[],hwaddr ram_bases[],hwaddr ram_sizes[],const ram_addr_t sdram_bank_sizes[]);hw/ppc/ppc440_bamboo.c +2
-1@@ -202,7 +202,7 @@ static void bamboo_init(MachineState *machine)/* SDRAM controller */ memset (ram_bases,0 ,sizeof (ram_bases));memset (ram_sizes,0 ,sizeof (ram_sizes)); -ppc4xx_sdram_banks (machine->ram_size,PPC440EP_SDRAM_NR_BANKS , ram_memories, +ppc4xx_sdram_banks (machine->ram,PPC440EP_SDRAM_NR_BANKS , ram_memories, ram_bases, ram_sizes, ppc440ep_sdram_bank_sizes);/* XXX 440EP's ECC interrupts are on UIC1, but we've only created UIC0. */ ppc4xx_sdram_init(env, pic[14], PPC440EP_SDRAM_NR_BANKS, ram_memories,@@ -289,6 +289,7 @@ static void bamboo_machine_init(MachineClass *mc) mc->desc ="bamboo" ; mc->init = bamboo_init; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("440epb" ); + mc->default_ram_id ="ppc4xx.sdram" ; }DEFINE_MACHINE ("bamboo" , bamboo_machine_init)hw/ppc/ppc4xx_devs.c +9
-16@@ -666,7 +666,7 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,sdram_map_bcr (sdram); } -/* Fill in consecutive SDRAM banks with 'ram_size' bytes of memory. +/* Split RAM between SDRAM banks. * * sdram_bank_sizes[] must be in descending order, that is sizes[i] > sizes[i+1] * and must be 0-terminated. @@ -674,16 +674,14 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,* The 4xx SDRAM controller supports a small number of banks, and each bank * must be one of a small set of sizes. The number of banks and the supported * sizes varies by SoC. */ -void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +void ppc4xx_sdram_banks (MemoryRegion *ram,int nr_banks,MemoryRegion ram_memories[],hwaddr ram_bases[],hwaddr ram_sizes[],const ram_addr_t sdram_bank_sizes[]) { -MemoryRegion *ram =g_malloc0 (sizeof (*ram)); -ram_addr_t size_left = ram_size; +ram_addr_t size_left =memory_region_size (ram);ram_addr_t base =0 ;ram_addr_t bank_size; -int last_bank =0 ;int i;int j;@@ -691,11 +689,15 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks,for (j =0 ; sdram_bank_sizes[j] !=0 ; j++) { bank_size = sdram_bank_sizes[j];if (bank_size <= size_left) { +char name[32 ]; + ram_bases[i] = base; ram_sizes[i] = bank_size; base += bank_size; size_left -= bank_size; - last_bank = i; +snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); +memory_region_init_alias (&ram_memories[i],NULL , name, ram, + ram_bases[i], ram_sizes[i]);break ; } }@@ -706,7 +708,7 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks, }if (size_left) { -ram_addr_t used_size = ram_size - size_left; +ram_addr_t used_size =memory_region_size (ram) - size_left;GString *s =g_string_new (NULL );for (i =0 ; sdram_bank_sizes[i]; i++) {@@ -722,15 +724,6 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks,g_string_free (s, true);exit (EXIT_FAILURE ); } - -memory_region_allocate_system_memory (ram,NULL ,"ppc4xx.sdram" , ram_size); - -for (i =0 ; i <= last_bank; i++) { -char name[32 ]; -snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); -memory_region_init_alias (&ram_memories[i],NULL , name, ram, - ram_bases[i], ram_sizes[i]); - } }/*****************************************************************************/ hw/ppc/sam460ex.c +2
-1@@ -324,7 +324,7 @@ static void sam460ex_init(MachineState *machine)/* SDRAM controller */ /* put all RAM on first bank because board has one slot * and firmware only checks that */ -ppc4xx_sdram_banks (machine->ram_size,1 , ram_memories, ram_bases, ram_sizes, +ppc4xx_sdram_banks (machine->ram,1 , ram_memories, ram_bases, ram_sizes, ppc460ex_sdram_bank_sizes);/* FIXME: does 460EX have ECC interrupts? */ @@ -483,6 +483,7 @@ static void sam460ex_machine_init(MachineClass *mc) mc->init = sam460ex_init; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("460exb" ); mc->default_ram_size =512 * MiB; + mc->default_ram_id ="ppc4xx.sdram" ; }DEFINE_MACHINE ("sam460ex" , sam460ex_machine_init)
Re: [PATCH REPOST v3 65/80] ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM
In reply to Igor MammedovQuoted 9 lines · Igor Mammedov
memory_region_allocate_system_memory()API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and usingMachineState::raminstead of manually initializing RAM memory region.Signed-off-by Igor Mammedov <[email protected]>
Quoted 149 lines
---
v3:
* dropram_sizefrom comment aboveppc4xx_sdram_banks(BALATON Zoltan <[email protected]>)
* move memory alias initialization into the same loop where RAM is split on banks.
(BALATON Zoltan <[email protected]>)
v3.1
* rebase on top of previous patch due to changed context--- include/hw/ppc/ppc4xx.h | 2 +- hw/ppc/ppc440_bamboo.c | 3 ++- hw/ppc/ppc4xx_devs.c | 25 +++++++++---------------- hw/ppc/sam460ex.c | 3 ++- 4 files changed, 14 insertions(+), 19 deletions(-)include/hw/ppc/ppc4xx.h +1
-1@@ -42,7 +42,7 @@ enum {qemu_irq *ppcuic_init (CPUPPCState *env,qemu_irq *irqs,uint32_t dcr_base,int has_ssr,int has_vr); -void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +void ppc4xx_sdram_banks (MemoryRegion *ram,int nr_banks,MemoryRegion ram_memories[],hwaddr ram_bases[],hwaddr ram_sizes[],const ram_addr_t sdram_bank_sizes[]);hw/ppc/ppc440_bamboo.c +2
-1@@ -202,7 +202,7 @@ static void bamboo_init(MachineState *machine)/* SDRAM controller */ memset (ram_bases,0 ,sizeof (ram_bases));memset (ram_sizes,0 ,sizeof (ram_sizes)); -ppc4xx_sdram_banks (machine->ram_size,PPC440EP_SDRAM_NR_BANKS , ram_memories, +ppc4xx_sdram_banks (machine->ram,PPC440EP_SDRAM_NR_BANKS , ram_memories, ram_bases, ram_sizes, ppc440ep_sdram_bank_sizes);/* XXX 440EP's ECC interrupts are on UIC1, but we've only created UIC0. */ ppc4xx_sdram_init(env, pic[14], PPC440EP_SDRAM_NR_BANKS, ram_memories,@@ -289,6 +289,7 @@ static void bamboo_machine_init(MachineClass *mc) mc->desc ="bamboo" ; mc->init = bamboo_init; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("440epb" ); + mc->default_ram_id ="ppc4xx.sdram" ; }DEFINE_MACHINE ("bamboo" , bamboo_machine_init)hw/ppc/ppc4xx_devs.c +9
-16@@ -666,7 +666,7 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,sdram_map_bcr (sdram); } -/* Fill in consecutive SDRAM banks with 'ram_size' bytes of memory. +/* Split RAM between SDRAM banks. * * sdram_bank_sizes[] must be in descending order, that is sizes[i] > sizes[i+1] * and must be 0-terminated. @@ -674,16 +674,14 @@ void ppc4xx_sdram_init (CPUPPCState *env, qemu_irq irq, int nbanks,* The 4xx SDRAM controller supports a small number of banks, and each bank * must be one of a small set of sizes. The number of banks and the supported * sizes varies by SoC. */ -void ppc4xx_sdram_banks (ram_addr_t ram_size,int nr_banks, +void ppc4xx_sdram_banks (MemoryRegion *ram,int nr_banks,MemoryRegion ram_memories[],hwaddr ram_bases[],hwaddr ram_sizes[],const ram_addr_t sdram_bank_sizes[]) { -MemoryRegion *ram =g_malloc0 (sizeof (*ram)); -ram_addr_t size_left = ram_size; +ram_addr_t size_left =memory_region_size (ram);ram_addr_t base =0 ;ram_addr_t bank_size; -int last_bank =0 ;int i;int j;@@ -691,11 +689,15 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks,for (j =0 ; sdram_bank_sizes[j] !=0 ; j++) { bank_size = sdram_bank_sizes[j];if (bank_size <= size_left) { +char name[32 ]; + ram_bases[i] = base; ram_sizes[i] = bank_size; base += bank_size; size_left -= bank_size; - last_bank = i; +snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); +memory_region_init_alias (&ram_memories[i],NULL , name, ram, + ram_bases[i], ram_sizes[i]);break ; } }@@ -706,7 +708,7 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks, }if (size_left) { -ram_addr_t used_size = ram_size - size_left; +ram_addr_t used_size =memory_region_size (ram) - size_left;GString *s =g_string_new (NULL );for (i =0 ; sdram_bank_sizes[i]; i++) {@@ -722,15 +724,6 @@ void ppc4xx_sdram_banks(ram_addr_t ram_size, int nr_banks,g_string_free (s, true);exit (EXIT_FAILURE ); } - -memory_region_allocate_system_memory (ram,NULL ,"ppc4xx.sdram" , ram_size); - -for (i =0 ; i <= last_bank; i++) { -char name[32 ]; -snprintf (name,sizeof (name),"ppc4xx.sdram%d" , i); -memory_region_init_alias (&ram_memories[i],NULL , name, ram, - ram_bases[i], ram_sizes[i]); - } }/*****************************************************************************/ hw/ppc/sam460ex.c +2
-1@@ -324,7 +324,7 @@ static void sam460ex_init(MachineState *machine)/* SDRAM controller */ /* put all RAM on first bank because board has one slot * and firmware only checks that */ -ppc4xx_sdram_banks (machine->ram_size,1 , ram_memories, ram_bases, ram_sizes, +ppc4xx_sdram_banks (machine->ram,1 , ram_memories, ram_bases, ram_sizes, ppc460ex_sdram_bank_sizes);/* FIXME: does 460EX have ECC interrupts? */ @@ -483,6 +483,7 @@ static void sam460ex_machine_init(MachineClass *mc) mc->init = sam460ex_init; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("460exb" ); mc->default_ram_size =512 * MiB; + mc->default_ram_id ="ppc4xx.sdram" ; }DEFINE_MACHINE ("sam460ex" , sam460ex_machine_init)
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH v3 66/80 ppc/prep: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/ppc/prep.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
hw/ppc/prep.c +7 -8
@@ -400,7 +400,6 @@ static int PPC_NVRAM_set_params (Nvram *nvram, uint16_t NVRAM_size,/* PowerPC PREP hardware initialisation */ static void ppc_prep_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;const char *initrd_filename = machine->initrd_filename;
@@ -413,7 +412,6 @@ static void ppc_prep_init(MachineState *machine)MemoryRegion *xcsr =g_new (MemoryRegion,1 );#endif int linux_boot, i, nb_nics1; -MemoryRegion *ram =g_new (MemoryRegion,1 );uint32_t kernel_base, initrd_base;long kernel_size, initrd_size;DeviceState *dev;
@@ -444,15 +442,14 @@ static void ppc_prep_init(MachineState *machine)qemu_register_reset (ppc_prep_reset, cpu); } -/* allocate RAM */ -memory_region_allocate_system_memory (ram,NULL ,"ppc_prep.ram" , ram_size); -memory_region_add_subregion (sysmem,0 , ram); +/* map RAM */ +memory_region_add_subregion (sysmem,0 , machine->ram);if (linux_boot) { kernel_base =KERNEL_LOAD_ADDR ;/* now we can load the kernel */ kernel_size =load_image_targphys (kernel_filename, kernel_base, - ram_size - kernel_base); + machine->ram_size - kernel_base);if (kernel_size <0 ) {error_report ("could not load kernel '%s'" , kernel_filename);exit (1 );
@@ -461,7 +458,7 @@ static void ppc_prep_init(MachineState *machine)if (initrd_filename) { initrd_base =INITRD_LOAD_ADDR ; initrd_size =load_image_targphys (initrd_filename, initrd_base, - ram_size - initrd_base); + machine->ram_size - initrd_base);if (initrd_size <0 ) {error_report ("could not load initial ram disk '%s'" , initrd_filename);
@@ -576,7 +573,7 @@ static void ppc_prep_init(MachineState *machine) sysctrl->nvram = m48t59;/* Initialise NVRAM */ - PPC_NVRAM_set_params(m48t59, NVRAM_SIZE, "PREP", ram_size, + PPC_NVRAM_set_params(m48t59, NVRAM_SIZE, "PREP", machine->ram_size, ppc_boot_device, kernel_base, kernel_size, kernel_cmdline,
@@ -596,6 +593,7 @@ static void prep_machine_init(MachineClass *mc) mc->default_boot_order ="cad" ; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("602" ); mc->default_display ="std" ; + mc->default_ram_id ="ppc_prep.ram" ; }static int prep_set_cmos_checksum (DeviceState *dev,void *opaque)
@@ -814,6 +812,7 @@ static void ibm_40p_machine_init(MachineClass *mc) mc->init = ibm_40p_init; mc->max_cpus =1 ; mc->default_ram_size =128 * MiB; + mc->default_ram_id ="ppc_prep.ram" ; mc->block_default_type =IF_SCSI ; mc->default_boot_order ="c" ; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("604" );
Signature · 1 line
2.7.4
PATCH v3 67/80 ppc/spapr: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
--- hw/ppc/spapr.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
hw/ppc/spapr.c +3 -5
@@ -2587,7 +2587,6 @@ static void spapr_machine_init(MachineState *machine)PCIHostState *phb;int i;MemoryRegion *sysmem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );hwaddr node0_size =spapr_node0_size (machine);long load_limit, fw_size;char *filename;
@@ -2766,10 +2765,8 @@ static void spapr_machine_init(MachineState *machine)kvmppc_enable_h_page_init (); } -/* allocate RAM */ -memory_region_allocate_system_memory (ram,NULL ,"ppc_spapr.ram" , - machine->ram_size); -memory_region_add_subregion (sysmem,0 , ram); +/* map RAM */ +memory_region_add_subregion (sysmem,0 , machine->ram);/* always allocate the device memory information */ machine->device_memory =g_malloc0 (sizeof (*machine->device_memory));
@@ -4344,6 +4341,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data) mc->no_parallel =1 ; mc->default_boot_order ="" ; mc->default_ram_size =512 * MiB; + mc->default_ram_id ="ppc_spapr.ram" ; mc->default_display ="std" ; mc->kvm_type = spapr_kvm_type;machine_class_allow_dynamic_sysbus_dev (mc,TYPE_SPAPR_PCI_HOST_BRIDGE );
Signature · 1 line
2.7.4
PATCH v3 68/80 ppc/virtex_ml507: remove unused arguments
In reply to Igor Mammedov---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/ppc/virtex_ml507.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
hw/ppc/virtex_ml507.c +2 -5
@@ -89,10 +89,7 @@ static void mmubooke_create_initial_mapping(CPUPPCState *env, tlb->PID =0 ; } -static PowerPCCPU *ppc440_init_xilinx (ram_addr_t *ram_size, -int do_init, -const char *cpu_type, -uint32_t sysclk) +static PowerPCCPU *ppc440_init_xilinx (const char *cpu_type,uint32_t sysclk) {PowerPCCPU *cpu;CPUPPCState *env;
@@ -213,7 +210,7 @@ static void virtex_init(MachineState *machine)int i;/* init CPUs */ - cpu =ppc440_init_xilinx (&ram_size,1 , machine->cpu_type,400000000 ); + cpu =ppc440_init_xilinx (machine->cpu_type,400000000 ); env = &cpu->env;if (env->mmu_model !=POWERPC_MMU_BOOKE ) {
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 68/80] ppc/virtex_ml507: remove unused arguments
Quoted 2 lines · Igor Mammedov
Signed-off-by Igor Mammedov <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 33 lines
---
CC: [email protected]
CC: [email protected]
CC: [email protected]--- hw/ppc/virtex_ml507.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)hw/ppc/virtex_ml507.c +2
-5@@ -89,10 +89,7 @@ static void mmubooke_create_initial_mapping(CPUPPCState *env, tlb->PID =0 ; } -static PowerPCCPU *ppc440_init_xilinx (ram_addr_t *ram_size, -int do_init, -const char *cpu_type, -uint32_t sysclk) +static PowerPCCPU *ppc440_init_xilinx (const char *cpu_type,uint32_t sysclk) {PowerPCCPU *cpu;CPUPPCState *env;@@ -213,7 +210,7 @@ static void virtex_init(MachineState *machine)int i;/* init CPUs */ - cpu =ppc440_init_xilinx (&ram_size,1 , machine->cpu_type,400000000 ); + cpu =ppc440_init_xilinx (machine->cpu_type,400000000 ); env = &cpu->env;if (env->mmu_model !=POWERPC_MMU_BOOKE ) {
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH v3 69/80 ppc/virtex_ml507: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- hw/ppc/virtex_ml507.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
hw/ppc/virtex_ml507.c +5 -7
@@ -193,7 +193,6 @@ static int xilinx_load_device_tree(hwaddr addr,static void virtex_init (MachineState *machine) { -ram_addr_t ram_size = machine->ram_size;const char *kernel_filename = machine->kernel_filename;const char *kernel_cmdline = machine->kernel_cmdline;hwaddr initrd_base =0 ;
@@ -204,7 +203,6 @@ static void virtex_init(MachineState *machine)CPUPPCState *env;hwaddr ram_base =0 ;DriveInfo *dinfo; -MemoryRegion *phys_ram =g_new (MemoryRegion,1 );qemu_irq irq[32 ], *cpu_irq;int kernel_size;int i;
@@ -221,8 +219,7 @@ static void virtex_init(MachineState *machine)qemu_register_reset (main_cpu_reset, cpu); -memory_region_allocate_system_memory (phys_ram,NULL ,"ram" , ram_size); -memory_region_add_subregion (address_space_mem, ram_base, phys_ram); +memory_region_add_subregion (address_space_mem, ram_base, machine->ram); dinfo =drive_get (IF_PFLASH ,0 ,0 ); pflash_cfi01_register(PFLASH_BASEADDR, "virtex.flash", FLASH_SIZE,
@@ -265,7 +262,7 @@ static void virtex_init(MachineState *machine)/* If we failed loading ELF's try a raw image. */ kernel_size =load_image_targphys (kernel_filename, boot_offset, - ram_size); + machine->ram_size); boot_info.bootstrap_pc = boot_offset; high = boot_info.bootstrap_pc + kernel_size +8192 ; }
@@ -276,7 +273,7 @@ static void virtex_init(MachineState *machine)if (machine->initrd_filename) { initrd_base = high =ROUND_UP (high,4 ); initrd_size =load_image_targphys (machine->initrd_filename, - high, ram_size - high); + high, machine->ram_size - high);if (initrd_size <0 ) { error_report("couldn't load ram disk '%s'",
@@ -290,7 +287,7 @@ static void virtex_init(MachineState *machine) boot_info.fdt = high + (8192 *2 ); boot_info.fdt &= ~8191 ; -xilinx_load_device_tree (boot_info.fdt, ram_size, +xilinx_load_device_tree (boot_info.fdt, machine->ram_size, initrd_base, initrd_size, kernel_cmdline); }
@@ -302,6 +299,7 @@ static void virtex_machine_init(MachineClass *mc) mc->desc ="Xilinx Virtex ML507 reference design" ; mc->init = virtex_init; mc->default_cpu_type =POWERPC_CPU_TYPE_NAME ("440-xilinx" ); + mc->default_ram_id ="ram" ; }DEFINE_MACHINE ("virtex-ml507" , virtex_machine_init)
Signature · 1 line
2.7.4
PATCH v3 70/80 sparc/leon3: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/sparc/leon3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
hw/sparc/leon3.c +3 -3
@@ -189,7 +189,6 @@ static void leon3_generic_hw_init(MachineState *machine)SPARCCPU *cpu;CPUSPARCState *env;MemoryRegion *address_space_mem =get_system_memory (); -MemoryRegion *ram =g_new (MemoryRegion,1 );MemoryRegion *prom =g_new (MemoryRegion,1 );int ret;char *filename;
@@ -251,8 +250,8 @@ static void leon3_generic_hw_init(MachineState *machine)exit (1 ); } -memory_region_allocate_system_memory (ram,NULL ,"leon3.ram" , ram_size); -memory_region_add_subregion (address_space_mem,LEON3_RAM_OFFSET , ram); +memory_region_add_subregion (address_space_mem,LEON3_RAM_OFFSET , + machine->ram);/* Allocate BIOS */ prom_size =8 * MiB;
@@ -358,6 +357,7 @@ static void leon3_generic_machine_init(MachineClass *mc) mc->desc ="Leon-3 generic" ; mc->init = leon3_generic_hw_init; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("LEON3" ); + mc->default_ram_id ="leon3.ram" ; }DEFINE_MACHINE ("leon3_generic" , leon3_generic_machine_init)
Signature · 1 line
2.7.4
PATCH v3 71/80 sparc/sun4m: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
Patch moves ram size check into sun4m_hw_init() and drops ram_init() moving remainder to sun4m_hw_init() as well, as it was the only place that called it.
Also it rewrites impl. of RamDevice a little bit, which could serve as an example of frontend device for RAM backend. (Caveats are:
1. it doesn't check for memdev backend being mapped since it's been usurped by generic machine to handle majority of machines which don't have RAM frontend device
2. it still lacks 'addr' property and still has hardcoded sysbus_mmio_map() in board init. If done right, board should set 'addr' property and bus/machine plug handler should map it during device realize time.
)
Further improvements were left as exercise for the future, since frontends are out scope of RAM conversion to memdev.
---
CC: [email protected]
CC: [email protected]
--- hw/sparc/sun4m.c | 73 ++++++++++++++++++++++++++++---------------------------- 1 file changed, 36 insertions(+), 37 deletions(-)
hw/sparc/sun4m.c +36 -37
@@ -777,63 +777,42 @@ static const TypeInfo prom_info = {typedef struct RamDevice {SysBusDevice parent_obj; - -MemoryRegion ram; -uint64_t size; +HostMemoryBackend *memdev; }RamDevice ;/* System RAM */ static void ram_realize (DeviceState *dev,Error **errp) {RamDevice *d =SUN4M_RAM (dev); -SysBusDevice *sbd =SYS_BUS_DEVICE (dev); +MemoryRegion *ram =host_memory_backend_get_memory (d->memdev); -memory_region_allocate_system_memory (&d->ram,OBJECT (d),"sun4m.ram" , - d->size); -sysbus_init_mmio (sbd, &d->ram); +sysbus_init_mmio (SYS_BUS_DEVICE (dev), ram); } -static void ram_init (hwaddr addr,ram_addr_t RAM_size, -uint64_t max_mem) +static void ram_initfn (Object *obj) { -DeviceState *dev; -SysBusDevice *s; -RamDevice *d; - -/* allocate RAM */ -if ((uint64_t )RAM_size > max_mem) { -error_report ("Too much memory for this machine: %" PRId64"," -" maximum %" PRId64, - RAM_size / MiB, max_mem / MiB); -exit (1 ); - } - dev =qdev_create (NULL ,"memory" ); - s =SYS_BUS_DEVICE (dev); - - d =SUN4M_RAM (dev); - d->size = RAM_size; -qdev_init_nofail (dev); - -sysbus_mmio_map (s,0 , addr); +RamDevice *d =SUN4M_RAM (obj); +object_property_add_link (obj,"memdev" ,TYPE_MEMORY_BACKEND , + (Object **)&d->memdev, + object_property_allow_set_link, +OBJ_PROP_LINK_STRONG , &error_abort); +object_property_set_description (obj,"memdev" ,"Set RAM backend" +"Valid value is ID of a hostmem backend" , + &error_abort); } -static Property ram_properties[] = { -DEFINE_PROP_UINT64 ("size" , RamDevice, size,0 ), -DEFINE_PROP_END_OF_LIST (), -}; -static void ram_class_init (ObjectClass *klass,void *data) {DeviceClass *dc =DEVICE_CLASS (klass); dc->realize = ram_realize; - dc->props = ram_properties; }static const TypeInfo ram_info = { .name =TYPE_SUN4M_MEMORY , .parent =TYPE_SYS_BUS_DEVICE , .instance_size =sizeof (RamDevice), + .instance_init = ram_initfn, .class_init = ram_class_init, };
@@ -880,6 +859,13 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,unsigned int smp_cpus = machine->smp.cpus;unsigned int max_cpus = machine->smp.max_cpus; +if (machine->ram_size > hwdef->max_mem) { +error_report ("Too much memory for this machine: %" PRId64"," +" maximum %" PRId64, + machine->ram_size / MiB, hwdef->max_mem / MiB); +exit (1 ); + } +/* init CPUs */ for (i =0 ; i < smp_cpus; i++) {cpu_devinit (machine->cpu_type, i, hwdef->slavio_base, &cpu_irqs[i]);
@@ -888,9 +874,13 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,for (i = smp_cpus; i <MAX_CPUS ; i++) cpu_irqs[i] =qemu_allocate_irqs (dummy_cpu_set_irq,NULL ,MAX_PILS ); +/* Create and map RAM frontend */ + dev =qdev_create (NULL ,"memory" ); +object_property_set_link (OBJECT (dev),OBJECT (machine->ram_memdev), +"memdev" , &error_fatal); +qdev_init_nofail (dev); +sysbus_mmio_map (SYS_BUS_DEVICE (dev),0 ,0 ); -/* set up devices */ -ram_init (0 , machine->ram_size, hwdef->max_mem);/* models without ECC don't trap when missing ram is accessed */ if (!hwdef->ecc_base) {empty_slot_init (machine->ram_size, hwdef->max_mem - machine->ram_size);
@@ -1078,7 +1068,7 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,fw_cfg_add_i16 (fw_cfg,FW_CFG_NB_CPUS , (uint16_t )smp_cpus);fw_cfg_add_i16 (fw_cfg,FW_CFG_MAX_CPUS , (uint16_t )max_cpus); -fw_cfg_add_i64 (fw_cfg,FW_CFG_RAM_SIZE , (uint64_t )ram_size); +fw_cfg_add_i64 (fw_cfg,FW_CFG_RAM_SIZE , (uint64_t )machine->ram_size);fw_cfg_add_i16 (fw_cfg,FW_CFG_MACHINE_ID , hwdef->machine_id);fw_cfg_add_i16 (fw_cfg,FW_CFG_SUN4M_DEPTH , graphic_depth);fw_cfg_add_i16 (fw_cfg,FW_CFG_SUN4M_WIDTH , graphic_width);
@@ -1415,6 +1405,7 @@ static void ss5_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("Fujitsu-MB86904" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo ss5_type = {
@@ -1434,6 +1425,7 @@ static void ss10_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("TI-SuperSparc-II" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo ss10_type = {
@@ -1453,6 +1445,7 @@ static void ss600mp_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("TI-SuperSparc-II" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo ss600mp_type = {
@@ -1472,6 +1465,7 @@ static void ss20_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("TI-SuperSparc-II" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo ss20_type = {
@@ -1490,6 +1484,7 @@ static void voyager_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("Fujitsu-MB86904" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo voyager_type = {
@@ -1508,6 +1503,7 @@ static void ss_lx_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("TI-MicroSparc-I" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo ss_lx_type = {
@@ -1526,6 +1522,7 @@ static void ss4_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("Fujitsu-MB86904" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo ss4_type = {
@@ -1544,6 +1541,7 @@ static void scls_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("TI-MicroSparc-I" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo scls_type = {
@@ -1562,6 +1560,7 @@ static void sbook_class_init(ObjectClass *oc, void *data) mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("TI-MicroSparc-I" ); mc->default_display ="tcx" ; + mc->default_ram_id ="sun4m.ram" ; }static const TypeInfo sbook_type = {
Signature · 1 line
2.7.4
PATCH v3 72/80 sparc/niagara: use memdev for RAM
In reply to Igor Mammedovmemory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing RAM memory region.
--- hw/sparc64/niagara.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
hw/sparc64/niagara.c +2 -5
@@ -40,7 +40,6 @@ typedef struct NiagaraBoardState { MemoryRegion hv_ram; - MemoryRegion partition_ram; MemoryRegion nvram; MemoryRegion md_rom; MemoryRegion hv_rom;
@@ -111,11 +110,8 @@ static void niagara_init(MachineState *machine) NIAGARA_HV_RAM_SIZE, &error_fatal);memory_region_add_subregion (sysmem,NIAGARA_HV_RAM_BASE , &s->hv_ram); -memory_region_allocate_system_memory (&s->partition_ram,NULL , -"sun4v-partition.ram" , - machine->ram_size);memory_region_add_subregion (sysmem,NIAGARA_PARTITION_RAM_BASE , - &s->partition_ram); + machine->ram);memory_region_init_ram (&s->nvram,NULL ,"sun4v.nvram" ,NIAGARA_NVRAM_SIZE , &error_fatal);
@@ -173,6 +169,7 @@ static void niagara_class_init(ObjectClass *oc, void *data) mc->max_cpus =1 ;/* XXX for now */ mc->default_boot_order ="c" ; mc->default_cpu_type =SPARC_CPU_TYPE_NAME ("Sun-UltraSparc-T1" ); + mc->default_ram_id ="sun4v-partition.ram" ; }static const TypeInfo niagara_type = {
Signature · 1 line
2.7.4
PATCH v3 73/80 remove no longer used memory_region_allocate_system_memory()
In reply to Igor Mammedovall boards were switched to using memdev backend for main RAM, so we can drop no longer used memory_region_allocate_system_memory()
---
CC: [email protected]
CC: [email protected]
--- include/hw/boards.h | 32 -------------------------------- hw/core/numa.c | 34 ---------------------------------- 2 files changed, 66 deletions(-)
include/hw/boards.h +0 -32
@@ -12,38 +12,6 @@#include "qom/object.h" #include "hw/core/cpu.h" -/** -* memory_region_allocate_system_memory - Allocate a board's main memory -* @mr: the #MemoryRegion to be initialized -* @owner: the object that tracks the region's reference count -* @name: name of the memory region -* @ram_size: size of the region in bytes -* -* This function allocates the main memory for a board model, and -* initializes @mr appropriately. It also arranges for the memory -* to be migrated (by calling vmstate_register_ram_global()). -* -* Memory allocated via this function will be backed with the memory -* backend the user provided using "-mem-path" or "-numa node,memdev=..." -* if appropriate; this is typically used to cause host huge pages to be -* used. This function should therefore be called by a board exactly once, -* for the primary or largest RAM area it implements. -* -* For boards where the major RAM is split into two parts in the memory -* map, you can deal with this by calling memory_region_allocate_system_memory() -* once to get a MemoryRegion with enough RAM for both parts, and then -* creating alias MemoryRegions via memory_region_init_alias() which -* alias into different parts of the RAM MemoryRegion and can be mapped -* into the memory map in the appropriate places. -* -* Smaller pieces of memory (display RAM, static RAMs, etc) don't need -* to be backed via the -mem-path memory backend and can simply -* be created via memory_region_init_ram(). -*/ -void memory_region_allocate_system_memory (MemoryRegion *mr,Object *owner, -const char *name, -uint64_t ram_size); -#define TYPE_MACHINE_SUFFIX "-machine"/* Machine class name that needs to be used for class-name-based machine
hw/core/numa.c +0 -34
@@ -806,40 +806,6 @@ void numa_cpu_pre_plug(const CPUArchId *slot, DeviceState *dev, Error **errp) } } -static void allocate_system_memory_nonnuma (MemoryRegion *mr,Object *owner, -const char *name, -uint64_t ram_size) -{ -if (mem_path) { -#ifdef __linux__ -memory_region_init_ram_from_file (mr, owner, name, ram_size,0 ,0 , - mem_path, &error_fatal); -#else -fprintf (stderr,"-mem-path not supported on this host\n" ); -exit (1 ); -#endif - }else { -memory_region_init_ram_nomigrate (mr, owner, name, ram_size, &error_fatal); - } -vmstate_register_ram_global (mr); -} - -void memory_region_allocate_system_memory (MemoryRegion *mr,Object *owner, -const char *name, -uint64_t ram_size) -{ -MachineState *ms =MACHINE (qdev_get_machine ()); - -if (ms->numa_state ==NULL || - ms->numa_state->num_nodes ==0 ||numa_uses_legacy_mem ()) { -allocate_system_memory_nonnuma (mr, owner, name, ram_size); -return ; - } - -memory_region_init (mr, owner, name, ram_size); -numa_init_memdev_container (ms, mr); -} -static void numa_stat_memory_devices (NumaNodeMem node_mem[]) {MemoryDeviceInfoList *info_list =qmp_memory_device_list ();
Signature · 1 line
2.7.4
PATCH v3 74/80 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
In reply to Igor MammedovSince all RAM is backed by hostmem backends, drop
global -mem-path invariant and simplify code.
---
CC: [email protected]
CC: [email protected]
--- exec.c | 51 +++++---------------------------------------------- 1 file changed, 5 insertions(+), 46 deletions(-)
exec.c +5 -46
@@ -1667,60 +1667,19 @@ static int find_max_backend_pagesize(Object *obj, void *opaque)*/ long qemu_minrampagesize (void ) { -long hpsize =LONG_MAX ; -long mainrampagesize; -Object *memdev_root; -MachineState *ms =MACHINE (qdev_get_machine ()); - - mainrampagesize =qemu_mempath_getpagesize (mem_path); - -/* it's possible we have memory-backend objects with -* hugepage-backed RAM. these may get mapped into system -* address space via -numa parameters or memory hotplug -* hooks. we want to take these into account, but we -* also want to make sure these supported hugepage -* sizes are applicable across the entire range of memory -* we may boot from, so we take the min across all -* backends, and assume normal pages in cases where a -* backend isn't backed by hugepages. -*/ - memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize); - } -if (hpsize ==LONG_MAX ) { -/* No additional memory regions found ==> Report main RAM page size */ -return mainrampagesize; - } - -/* If NUMA is disabled or the NUMA nodes are not backed with a -* memory-backend, then there is at least one node using "normal" RAM, -* so if its page size is smaller we have got to report that size instead. -*/ -if (hpsize > mainrampagesize && - (ms->numa_state ==NULL || - ms->numa_state->num_nodes ==0 || - ms->numa_state->nodes[0 ].node_memdev ==NULL )) { -static bool warned; -if (!warned) { -error_report ("Huge page support disabled (n/a for main memory)." ); - warned = true; - } -return mainrampagesize; - } +long hpsize; +Object *memdev_root =object_resolve_path ("/objects" ,NULL ); +object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize);return hpsize; }long qemu_maxrampagesize (void ) { -long pagesize =qemu_mempath_getpagesize (mem_path); +long pagesize;Object *memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_max_backend_pagesize, - &pagesize); - } +object_child_foreach (memdev_root, find_max_backend_pagesize, &pagesize);return pagesize; }#else
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 74/80] exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
Quoted 2 lines · On Thu, 23 Jan 2020 12:38:39 +0100 Igor Mammedov <[email protected]> wrote:
Since all RAM is backed by hostmem backends, drop
global -mem-path invariant and simplify code.
Looks like origin of removed here code is PPC,
could PPC folk review this please?
Quoted 78 lines
Signed-off-by Igor Mammedov <[email protected]>---
CC: [email protected]
CC: [email protected]--- exec.c | 51 +++++---------------------------------------------- 1 file changed, 5 insertions(+), 46 deletions(-)exec.c +5
-46@@ -1667,60 +1667,19 @@ static int find_max_backend_pagesize(Object *obj, void *opaque)*/ long qemu_minrampagesize (void ) { -long hpsize =LONG_MAX ; -long mainrampagesize; -Object *memdev_root; -MachineState *ms =MACHINE (qdev_get_machine ()); - - mainrampagesize =qemu_mempath_getpagesize (mem_path); - -/* it's possible we have memory-backend objects with -* hugepage-backed RAM. these may get mapped into system -* address space via -numa parameters or memory hotplug -* hooks. we want to take these into account, but we -* also want to make sure these supported hugepage -* sizes are applicable across the entire range of memory -* we may boot from, so we take the min across all -* backends, and assume normal pages in cases where a -* backend isn't backed by hugepages. -*/ - memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize); - } -if (hpsize ==LONG_MAX ) { -/* No additional memory regions found ==> Report main RAM page size */ -return mainrampagesize; - } - -/* If NUMA is disabled or the NUMA nodes are not backed with a -* memory-backend, then there is at least one node using "normal" RAM, -* so if its page size is smaller we have got to report that size instead. -*/ -if (hpsize > mainrampagesize && - (ms->numa_state ==NULL || - ms->numa_state->num_nodes ==0 || - ms->numa_state->nodes[0 ].node_memdev ==NULL )) { -static bool warned; -if (!warned) { -error_report ("Huge page support disabled (n/a for main memory)." ); - warned = true; - } -return mainrampagesize; - } +long hpsize; +Object *memdev_root =object_resolve_path ("/objects" ,NULL ); +object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize);return hpsize; }long qemu_maxrampagesize (void ) { -long pagesize =qemu_mempath_getpagesize (mem_path); +long pagesize;Object *memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_max_backend_pagesize, - &pagesize); - } +object_child_foreach (memdev_root, find_max_backend_pagesize, &pagesize);return pagesize; }#else
Re: [PATCH REPOST v3 74/80] exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
Quoted 8 lines · Igor Mammedov
Quoted 2 lines · On Thu, 23 Jan 2020 12:38:39 +0100 Igor Mammedov <[email protected]> wrote:
Since all RAM is backed by hostmem backends, drop
global -mem-path invariant and simplify code.Looks like origin of removed here code is PPC,
could PPC folk review this please?
Oh, sure. I don't think I was CCed initially - I generally don't have the bandwidth to scan qemu-devel.
I haven't looked at this series as a whole, only the bits which were CCed to me (presumably because they touched ppc code). But assuming the statement above is correct, that everything is now backed by hostmem backends, then the idea of this change should be fine.
But...
Quoted 51 lines
Quoted 51 lines
Signed-off-by Igor Mammedov <[email protected]>---
CC: [email protected]
CC: [email protected]--- exec.c | 51 +++++---------------------------------------------- 1 file changed, 5 insertions(+), 46 deletions(-)exec.c +0
-34@@ -1667,60 +1667,19 @@ static int find_max_backend_pagesize(Object *obj, void *opaque)*/ long qemu_minrampagesize (void ) { -long hpsize =LONG_MAX ; -long mainrampagesize; -Object *memdev_root; -MachineState *ms =MACHINE (qdev_get_machine ()); - - mainrampagesize =qemu_mempath_getpagesize (mem_path); - -/* it's possible we have memory-backend objects with -* hugepage-backed RAM. these may get mapped into system -* address space via -numa parameters or memory hotplug -* hooks. we want to take these into account, but we -* also want to make sure these supported hugepage -* sizes are applicable across the entire range of memory -* we may boot from, so we take the min across all -* backends, and assume normal pages in cases where a -* backend isn't backed by hugepages. -*/ - memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize); - } -if (hpsize ==LONG_MAX ) { -/* No additional memory regions found ==> Report main RAM page size */ -return mainrampagesize; - } - -/* If NUMA is disabled or the NUMA nodes are not backed with a -* memory-backend, then there is at least one node using "normal" RAM, -* so if its page size is smaller we have got to report that size instead. -*/ -if (hpsize > mainrampagesize && - (ms->numa_state ==NULL || - ms->numa_state->num_nodes ==0 || - ms->numa_state->nodes[0 ].node_memdev ==NULL )) {
Quoted 8 lines
exec.c static int find_max_backend_pagesize(Object *obj, void *opaque) · line 1670
Quoted 8 lines
exec.c +1
-7-static bool warned; -if (!warned) { -error_report ("Huge page support disabled (n/a for main memory)." ); - warned = true; - } -return mainrampagesize; - } +long hpsize;
hpsize absolutely has to be initialized. find_min_backend_pagesize() reads it as well as writing it, so if it's uninitialized you'll have UB.
Quoted 10 lines
exec.c static int find_max_backend_pagesize(Object *obj, void *opaque) · line 1679
Quoted 10 lines
exec.c +3
-1+Object *memdev_root =object_resolve_path ("/objects" ,NULL ); +object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize);return hpsize; }long qemu_maxrampagesize (void ) { -long pagesize =qemu_mempath_getpagesize (mem_path); +long pagesize;
Same here.
Quoted 11 lines
Quoted 10 lines
exec.c +1
-4Object *memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_max_backend_pagesize, - &pagesize); - } +object_child_foreach (memdev_root, find_max_backend_pagesize, &pagesize); return pagesize; }#else
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH v3 74/80 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
In reply to Igor MammedovSince all RAM is backed by hostmem backends, drop
global -mem-path invariant and simplify code.
---
v4:
* fix access to uninitialized pagesize/hpsize
(David Gibson <[email protected]>)
--- exec.c | 49 ++++--------------------------------------------- 1 file changed, 4 insertions(+), 45 deletions(-)
exec.c +4 -45
@@ -1668,59 +1668,18 @@ static int find_max_backend_pagesize(Object *obj, void *opaque)long qemu_minrampagesize (void ) {long hpsize =LONG_MAX ; -long mainrampagesize; -Object *memdev_root; -MachineState *ms =MACHINE (qdev_get_machine ()); - - mainrampagesize =qemu_mempath_getpagesize (mem_path); - -/* it's possible we have memory-backend objects with -* hugepage-backed RAM. these may get mapped into system -* address space via -numa parameters or memory hotplug -* hooks. we want to take these into account, but we -* also want to make sure these supported hugepage -* sizes are applicable across the entire range of memory -* we may boot from, so we take the min across all -* backends, and assume normal pages in cases where a -* backend isn't backed by hugepages. -*/ - memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize); - } -if (hpsize ==LONG_MAX ) { -/* No additional memory regions found ==> Report main RAM page size */ -return mainrampagesize; - } - -/* If NUMA is disabled or the NUMA nodes are not backed with a -* memory-backend, then there is at least one node using "normal" RAM, -* so if its page size is smaller we have got to report that size instead. -*/ -if (hpsize > mainrampagesize && - (ms->numa_state ==NULL || - ms->numa_state->num_nodes ==0 || - ms->numa_state->nodes[0 ].node_memdev ==NULL )) { -static bool warned; -if (!warned) { -error_report ("Huge page support disabled (n/a for main memory)." ); - warned = true; - } -return mainrampagesize; - } +Object *memdev_root =object_resolve_path ("/objects" ,NULL ); +object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize);return hpsize; }long qemu_maxrampagesize (void ) { -long pagesize =qemu_mempath_getpagesize (mem_path); +long pagesize =0 ;Object *memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_max_backend_pagesize, - &pagesize); - } +object_child_foreach (memdev_root, find_max_backend_pagesize, &pagesize);return pagesize; }#else
Signature · 1 line
2.7.4
Re: [PATCH v3.1 74/80] exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
Quoted 8 lines · Igor Mammedov
Since all RAM is backed by hostmem backends, drop
global -mem-path invariant and simplify code.Signed-off-by Igor Mammedov <[email protected]>---
v4:
* fix access to uninitialized pagesize/hpsize
(David Gibson <[email protected]>)
Quoted 79 lines
--- exec.c | 49 ++++--------------------------------------------- 1 file changed, 4 insertions(+), 45 deletions(-)exec.c +4
-45@@ -1668,59 +1668,18 @@ static int find_max_backend_pagesize(Object *obj, void *opaque)long qemu_minrampagesize (void ) {long hpsize =LONG_MAX ; -long mainrampagesize; -Object *memdev_root; -MachineState *ms =MACHINE (qdev_get_machine ()); - - mainrampagesize =qemu_mempath_getpagesize (mem_path); - -/* it's possible we have memory-backend objects with -* hugepage-backed RAM. these may get mapped into system -* address space via -numa parameters or memory hotplug -* hooks. we want to take these into account, but we -* also want to make sure these supported hugepage -* sizes are applicable across the entire range of memory -* we may boot from, so we take the min across all -* backends, and assume normal pages in cases where a -* backend isn't backed by hugepages. -*/ - memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize); - } -if (hpsize ==LONG_MAX ) { -/* No additional memory regions found ==> Report main RAM page size */ -return mainrampagesize; - } - -/* If NUMA is disabled or the NUMA nodes are not backed with a -* memory-backend, then there is at least one node using "normal" RAM, -* so if its page size is smaller we have got to report that size instead. -*/ -if (hpsize > mainrampagesize && - (ms->numa_state ==NULL || - ms->numa_state->num_nodes ==0 || - ms->numa_state->nodes[0 ].node_memdev ==NULL )) { -static bool warned; -if (!warned) { -error_report ("Huge page support disabled (n/a for main memory)." ); - warned = true; - } -return mainrampagesize; - } +Object *memdev_root =object_resolve_path ("/objects" ,NULL ); +object_child_foreach (memdev_root, find_min_backend_pagesize, &hpsize);return hpsize; }long qemu_maxrampagesize (void ) { -long pagesize =qemu_mempath_getpagesize (mem_path); +long pagesize =0 ;Object *memdev_root =object_resolve_path ("/objects" ,NULL ); -if (memdev_root) { -object_child_foreach (memdev_root, find_max_backend_pagesize, - &pagesize); - } +object_child_foreach (memdev_root, find_max_backend_pagesize, &pagesize);return pagesize; }#else
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH v3 75/80 exec: drop bogus mem_path from qemu_ram_alloc_from_fd()
In reply to Igor MammedovFunction will report error that will mention global mem_path, which was valid the only if legacy -mem-path was used and only in case of main RAM.
However it doesn't work with hostmem backends
(for example:
"
qemu: -object memory-backend-file,id=ram0,size=128M,mem-path=foo:
backing store (null) size 0x200000 does not match 'size' option 0x8000000
")
and couldn't possibly work in general FD case the function is supposed to handle.
Taking in account that main RAM was converted into memory-backend-foo object, there is no point in printing file name (from inappropriate place) as failing path is a part of backend's error message.
Hence drop bogus mem_path usage from qemu_ram_alloc_from_fd(), it's a job of its user to add file name to error message if applicable.
---
CC: [email protected]
CC: [email protected]
--- exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
exec.c +2 -2
@@ -2308,9 +2308,9 @@ RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr, size =HOST_PAGE_ALIGN (size); file_size =get_file_size (fd);if (file_size >0 && file_size < size) { -error_setg (errp,"backing store %s size 0x%" PRIx64 +error_setg (errp,"backing store size 0x%" PRIx64" does not match 'size' option 0x" RAM_ADDR_FMT , - mem_path, file_size, size); + file_size, size);return NULL ; }
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 75/80] exec: drop bogus mem_path from qemu_ram_alloc_from_fd()
Quoted 18 lines · On Thu, 23 Jan 2020 12:38:40 +0100 Igor Mammedov <[email protected]> wrote:
Function will report error that will mention global
mem_path, which was valid the only if legacy -mem-path was used and only in case of main RAM.However it doesn't work with hostmem backends
(for example:
"
qemu: -object memory-backend-file,id=ram0,size=128M,mem-path=foo:backing store (null) size 0x200000 does not match 'size' option 0x8000000")
and couldn't possibly work in general FD case the function is supposed to handle.Taking in account that main RAM was converted into memory-backend-foo object, there is no point in printing file name (from inappropriate place) as failing path is a part of backend's error message.
Quoted 4 lines
Hence drop bogus
mem_pathusage fromqemu_ram_alloc_from_fd(), it's a job of its user to add file name to error message if applicable.Signed-off-by Igor Mammedov <[email protected]>
Marc-André,
git blames you as the one who introduced it,
could you take a look at this patch
probably I should add here as well
Quoted 23 lines
---
CC: [email protected]
CC: [email protected]--- exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)exec.c +2
-2@@ -2308,9 +2308,9 @@ RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr, size =HOST_PAGE_ALIGN (size); file_size =get_file_size (fd);if (file_size >0 && file_size < size) { -error_setg (errp,"backing store %s size 0x%" PRIx64 +error_setg (errp,"backing store size 0x%" PRIx64" does not match 'size' option 0x" RAM_ADDR_FMT , - mem_path, file_size, size); + file_size, size);return NULL ; }
PATCH v3 76/80 make mem_path local variable
In reply to Igor MammedovIt's no longer used anywhere beside main(), so make it local variable that is used for CLI compat purposes to keep -mem-path option working.
Under hood QEMU will use it to create
memory-backend-file,mem-path=...
backend and use its MemoryRegion as main RAM.
---
CC: [email protected]
--- include/sysemu/sysemu.h | 1 - vl.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
include/sysemu/sysemu.h +0 -1
@@ -53,7 +53,6 @@ extern uint8_t *boot_splash_filedata;extern bool enable_mlock;extern bool enable_cpu_pm;extern QEMUClockType rtc_clock; -extern const char *mem_path;extern int mem_prealloc;#define MAX_OPTION_ROMS 16
vl.c +1 -1
@@ -140,7 +140,6 @@ enum vga_retrace_method vga_retrace_method = VGA_RETRACE_DUMB;int display_opengl;const char * keyboard_layout =NULL ;ram_addr_t ram_size; -const char *mem_path =NULL ;int mem_prealloc =0 ;/* force preallocation of physical target memory */ bool enable_mlock = false;bool enable_cpu_pm = false;
@@ -2876,6 +2875,7 @@ int main(int argc, char **argv, char **envp)Error *err =NULL ;bool list_data_dirs = false;char *dir, **dirs; +const char *mem_path =NULL ;BlockdevOptionsQueue bdo_queue =QSIMPLEQ_HEAD_INITIALIZER (bdo_queue);QemuPluginList plugin_list =QTAILQ_HEAD_INITIALIZER (plugin_list);
Signature · 1 line
2.7.4
PATCH v3 77/80 hostmem: introduce "prealloc-threads" property
In reply to Igor Mammedovthe property will allow user to specify number of threads to use in pre-allocation stage. It also will allow to reduce implicit hostmem dependency on current_machine.
On object creation it will default to 1, but via machine compat property it will be updated to MachineState::smp::cpus to keep current behavior for hostmem and main RAM (which is now also hostmem based).
---
v3:
- use object_register_sugar_prop() instead of directly hacking compat_props (Paolo Bonzini <[email protected]>)
- fix TODO description
--- include/sysemu/hostmem.h | 2 ++ backends/hostmem.c | 43 +++++++++++++++++++++++++++++++++++++++---- vl.c | 14 ++++++++++---- 3 files changed, 51 insertions(+), 8 deletions(-)
include/sysemu/hostmem.h +2 -0
@@ -61,6 +61,7 @@ struct HostMemoryBackendClass {* @parent: opaque parent object container * @size: amount of memory backend provides * @mr: MemoryRegion representing host memory belonging to backend +* @prealloc_threads: number of threads to be used for preallocatining RAM */ struct HostMemoryBackend {/* private */
@@ -70,6 +71,7 @@ struct HostMemoryBackend {uint64_t size;bool merge, dump, use_canonical_path;bool prealloc, force_prealloc, is_mapped, share; +uint32_t prealloc_threads;DECLARE_BITMAP (host_nodes,MAX_NODES +1 );HostMemPolicy policy;
backends/hostmem.c +39 -4
87 lines not on this page · raw message
vl.c +10 -4
@@ -2822,8 +2822,7 @@ static void configure_accelerators(const char *progname) } } -static void create_default_memdev (MachineState *ms,const char *path, -bool prealloc) +static void create_default_memdev (MachineState *ms,const char *path) {Object *obj;MachineClass *mc =MACHINE_GET_CLASS (ms);
@@ -2832,7 +2831,6 @@ static void create_default_memdev(MachineState *ms, const char *path,if (path) {object_property_set_str (obj, path,"mem-path" , &error_fatal); } -object_property_set_bool (obj, prealloc,"prealloc" , &error_fatal);object_property_set_int (obj, ms->ram_size,"size" , &error_fatal);object_property_add_child (object_get_objects_root (), mc->default_ram_id, obj, &error_fatal);
@@ -3975,6 +3973,14 @@ int main(int argc, char **argv, char **envp)exit (1 ); } +if (mem_prealloc) { +char *val; + + val =g_strdup_printf ("%d" , current_machine->smp.cpus); +object_register_sugar_prop ("memory-backend" ,"prealloc-threads" , val); +g_free (val); + } +/* * Get the default machine options from the machine if it is not already * specified either by the configuration file or by the command line.
@@ -4309,7 +4315,7 @@ int main(int argc, char **argv, char **envp) machine_class->default_ram_size && machine_class->default_ram_id && !current_machine->ram_memdev) { -create_default_memdev (current_machine, mem_path, mem_prealloc); +create_default_memdev (current_machine, mem_path); }/* do monitor/qmp handling at preconfig state if requested */ main_loop ();
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 77/80] hostmem: introduce "prealloc-threads" property
Quoted 9 lines · On Thu, 23 Jan 2020 12:38:42 +0100 Igor Mammedov <[email protected]> wrote:
the property will allow user to specify number of threads to use in pre-allocation stage. It also will allow to reduce implicit hostmem dependency on
current_machine.
On object creation it will default to 1, but via machine compat property it will be updated toMachineState::smp::cpusto keep current behavior for hostmem and main RAM (which is now also hostmem based).Signed-off-by Igor Mammedov <[email protected]>
Jitendra,
As the one who introduced smp_cpus in backend
(1e356fc14be mem-prealloc: reduce large guest start-up and migration time.)
could you review this patch please?
Quoted 177 lines
---
v3:
- useobject_register_sugar_prop()instead of directly hackingcompat_props(Paolo Bonzini <[email protected]>)
- fix TODO description--- include/sysemu/hostmem.h | 2 ++ backends/hostmem.c | 43 +++++++++++++++++++++++++++++++++++++++---- vl.c | 14 ++++++++++---- 3 files changed, 51 insertions(+), 8 deletions(-)include/sysemu/hostmem.h +2
-0@@ -61,6 +61,7 @@ struct HostMemoryBackendClass {* @parent: opaque parent object container * @size: amount of memory backend provides * @mr: MemoryRegion representing host memory belonging to backend +* @prealloc_threads: number of threads to be used for preallocatining RAM */ struct HostMemoryBackend {/* private */ @@ -70,6 +71,7 @@ struct HostMemoryBackend {uint64_t size;bool merge, dump, use_canonical_path;bool prealloc, force_prealloc, is_mapped, share; +uint32_t prealloc_threads;DECLARE_BITMAP (host_nodes,MAX_NODES +1 );HostMemPolicy policy;backends/hostmem.c +39
-4@@ -223,7 +223,6 @@ static void host_memory_backend_set_prealloc(Object *obj, bool value, {Error *local_err =NULL ;HostMemoryBackend *backend =MEMORY_BACKEND (obj); -MachineState *ms =MACHINE (qdev_get_machine ());if (backend->force_prealloc) {if (value) {@@ -243,7 +242,7 @@ static void host_memory_backend_set_prealloc(Object *obj, bool value,void *ptr =memory_region_get_ram_ptr (&backend->mr);uint64_t sz =memory_region_size (&backend->mr); -os_mem_prealloc (fd, ptr, sz, ms->smp.cpus, &local_err); +os_mem_prealloc (fd, ptr, sz, backend->prealloc_threads, &local_err);if (local_err) {error_propagate (errp, local_err);return ;@@ -252,14 +251,45 @@ static void host_memory_backend_set_prealloc(Object *obj, bool value, } } +static void host_memory_backend_get_prealloc_threads (Object *obj,Visitor *v, +const char *name,void *opaque,Error **errp) +{ +HostMemoryBackend *backend =MEMORY_BACKEND (obj); +visit_type_uint32 (v, name, &backend->prealloc_threads, errp); +} + +static void host_memory_backend_set_prealloc_threads (Object *obj,Visitor *v, +const char *name,void *opaque,Error **errp) +{ +HostMemoryBackend *backend =MEMORY_BACKEND (obj); +Error *local_err =NULL ; +uint32_t value; + +visit_type_uint32 (v, name, &value, &local_err); +if (local_err) { + goto out; + } +if (value <=0 ) { +error_setg (&local_err, +"property '%s' of %s doesn't take value '%d'" , + name,object_get_typename (obj), value); + goto out; + } + backend->prealloc_threads = value; +out: +error_propagate (errp, local_err); +} +static void host_memory_backend_init (Object *obj) {HostMemoryBackend *backend =MEMORY_BACKEND (obj);MachineState *machine =MACHINE (qdev_get_machine ()); +/* TODO: convert access to globals to compat properties */ backend->merge =machine_mem_merge (machine); backend->dump =machine_dump_guest_core (machine); backend->prealloc = mem_prealloc; + backend->prealloc_threads =1 ; }static void host_memory_backend_post_init (Object *obj)@@ -313,7 +343,6 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) {HostMemoryBackend *backend =MEMORY_BACKEND (uc);HostMemoryBackendClass *bc =MEMORY_BACKEND_GET_CLASS (uc); -MachineState *ms =MACHINE (qdev_get_machine ());Error *local_err =NULL ;void *ptr;uint64_t sz;@@ -378,7 +407,7 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)*/ if (backend->prealloc) {os_mem_prealloc (memory_region_get_fd (&backend->mr), ptr, sz, - ms->smp.cpus, &local_err); + backend->prealloc_threads, &local_err);if (local_err) { goto out; }@@ -456,6 +485,12 @@ host_memory_backend_class_init(ObjectClass *oc, void *data) host_memory_backend_set_prealloc, &error_abort);object_class_property_set_description (oc,"prealloc" ,"Preallocate memory" , &error_abort); +object_class_property_add (oc,"prealloc-threads" ,"int" , + host_memory_backend_get_prealloc_threads, + host_memory_backend_set_prealloc_threads, +NULL ,NULL , &error_abort); +object_class_property_set_description (oc,"prealloc-threads" , +"Number of CPU threads to use for prealloc" , &error_abort); object_class_property_add(oc, "size", "int", host_memory_backend_get_size, host_memory_backend_set_size,vl.c +10
-4@@ -2822,8 +2822,7 @@ static void configure_accelerators(const char *progname) } } -static void create_default_memdev (MachineState *ms,const char *path, -bool prealloc) +static void create_default_memdev (MachineState *ms,const char *path) {Object *obj;MachineClass *mc =MACHINE_GET_CLASS (ms);@@ -2832,7 +2831,6 @@ static void create_default_memdev(MachineState *ms, const char *path,if (path) {object_property_set_str (obj, path,"mem-path" , &error_fatal); } -object_property_set_bool (obj, prealloc,"prealloc" , &error_fatal);object_property_set_int (obj, ms->ram_size,"size" , &error_fatal);object_property_add_child (object_get_objects_root (), mc->default_ram_id, obj, &error_fatal);@@ -3975,6 +3973,14 @@ int main(int argc, char **argv, char **envp)exit (1 ); } +if (mem_prealloc) { +char *val; + + val =g_strdup_printf ("%d" , current_machine->smp.cpus); +object_register_sugar_prop ("memory-backend" ,"prealloc-threads" , val); +g_free (val); + } +/* * Get the default machine options from the machine if it is not already * specified either by the configuration file or by the command line. @@ -4309,7 +4315,7 @@ int main(int argc, char **argv, char **envp) machine_class->default_ram_size && machine_class->default_ram_id && !current_machine->ram_memdev) { -create_default_memdev (current_machine, mem_path, mem_prealloc); +create_default_memdev (current_machine, mem_path); }/* do monitor/qmp handling at preconfig state if requested */ main_loop ();
PATCH v3 78/80 hostmem: fix strict bind policy
In reply to Igor MammedovWhen option -mem-prealloc is used with one or more memory-backend objects, created backends may not obey configured bind policy or creation may fail after kernel attempts to move pages according to bind policy.
Reason is in file_ram_alloc(), which will pre-allocate any descriptor based RAM if global mem_prealloc != 0 and that happens way before bind policy is applied to memory range.
One way to fix it would be to extend memory_region_foo() API and add more invariants that could broken later due implicit dependencies that's hard to track.
Another approach is to drop adhoc main RAM allocation and consolidate it around memory-backend. That allows to have single place that allocates guest RAM (main and memdev) in the same way and then global mem_prealloc could be replaced by backend's property[s] that will affect created memory-backend objects but only in correct order this time.
With main RAM now converted to hostmem backends, there is no point in keeping global mem_prealloc around, so alias
-mem-prealloc to "memory-backend.prealloc=on"
machine compat[*] property and make mem_prealloc a local variable to only stir registration of compat property.
*) currently user accessible -global works only with DEVICE
based objects and extra work is needed to make it work with hostmem backends. But that is convenience option and out of scope of this already huge refactoring. Hence machine compat properties were used.
---
v3:
- use object_register_sugar_prop() instead of directly hacking compat_props (Paolo Bonzini <[email protected]>)
--- include/sysemu/hostmem.h | 2 +- include/sysemu/sysemu.h | 1 - backends/hostmem-file.c | 1 - backends/hostmem-memfd.c | 1 - backends/hostmem.c | 12 +----------- exec.c | 11 ----------- vl.c | 3 ++- 7 files changed, 4 insertions(+), 27 deletions(-)
include/sysemu/hostmem.h +1 -1
@@ -70,7 +70,7 @@ struct HostMemoryBackend {/* protected */ uint64_t size;bool merge, dump, use_canonical_path; -bool prealloc, force_prealloc, is_mapped, share; +bool prealloc, is_mapped, share;uint32_t prealloc_threads;DECLARE_BITMAP (host_nodes,MAX_NODES +1 );HostMemPolicy policy;
include/sysemu/sysemu.h +0 -1
@@ -53,7 +53,6 @@ extern uint8_t *boot_splash_filedata;extern bool enable_mlock;extern bool enable_cpu_pm;extern QEMUClockType rtc_clock; -extern int mem_prealloc;#define MAX_OPTION_ROMS 16 typedef struct QEMUOptionRom {
backends/hostmem-file.c +0 -1
@@ -51,7 +51,6 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)return ; } - backend->force_prealloc = mem_prealloc; name =host_memory_backend_get_name (backend); memory_region_init_ram_from_file(&backend->mr, OBJECT(backend), name,
backends/hostmem-memfd.c +0 -1
@@ -45,7 +45,6 @@ memfd_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)return ; } - backend->force_prealloc = mem_prealloc; fd = qemu_memfd_create(TYPE_MEMORY_BACKEND_MEMFD, backend->size, m->hugetlb, m->hugetlbsize, m->seal ? F_SEAL_GROW | F_SEAL_SHRINK | F_SEAL_SEAL : 0,
backends/hostmem.c +1 -11
@@ -215,7 +215,7 @@ static bool host_memory_backend_get_prealloc(Object *obj, Error **errp) {HostMemoryBackend *backend =MEMORY_BACKEND (obj); -return backend->prealloc || backend->force_prealloc; +return backend->prealloc; } static void host_memory_backend_set_prealloc(Object *obj, bool value,
@@ -224,14 +224,6 @@ static void host_memory_backend_set_prealloc(Object *obj, bool value,Error *local_err =NULL ;HostMemoryBackend *backend =MEMORY_BACKEND (obj); -if (backend->force_prealloc) { -if (value) { -error_setg (errp, -"remove -mem-prealloc to use the prealloc property" ); -return ; - } - } -if (!host_memory_backend_mr_inited (backend)) { backend->prealloc = value;return ;
@@ -288,8 +280,6 @@ static void host_memory_backend_init(Object *obj)/* TODO: convert access to globals to compat properties */ backend->merge =machine_mem_merge (machine); backend->dump =machine_dump_guest_core (machine); - backend->prealloc = mem_prealloc; - backend->prealloc_threads =1 ; }static void host_memory_backend_post_init (Object *obj)
exec.c +0 -11
@@ -1802,8 +1802,6 @@ static void *file_ram_alloc(RAMBlock *block,bool truncate, Error **errp) { - Error *err = NULL; -MachineState *ms =MACHINE (qdev_get_machine ()); void *area; block->page_size =qemu_fd_getpagesize (fd);
@@ -1859,15 +1857,6 @@ static void *file_ram_alloc(RAMBlock *block,return NULL ; } -if (mem_prealloc) { -os_mem_prealloc (fd, area, memory, ms->smp.cpus, &err); -if (err) { -error_propagate (errp, err); -qemu_ram_munmap (fd, area, memory); -return NULL ; - } - } - block->fd = fd;return area; }
vl.c +2 -1
@@ -140,7 +140,6 @@ enum vga_retrace_method vga_retrace_method = VGA_RETRACE_DUMB;int display_opengl;const char * keyboard_layout =NULL ;ram_addr_t ram_size; -int mem_prealloc =0 ;/* force preallocation of physical target memory */ bool enable_mlock = false;bool enable_cpu_pm = false;int nb_nics;
@@ -2876,6 +2875,7 @@ int main(int argc, char **argv, char **envp)const char *mem_path =NULL ;BlockdevOptionsQueue bdo_queue =QSIMPLEQ_HEAD_INITIALIZER (bdo_queue);QemuPluginList plugin_list =QTAILQ_HEAD_INITIALIZER (plugin_list); +int mem_prealloc =0 ;/* force preallocation of physical target memory */ os_set_line_buffering ();
@@ -3979,6 +3979,7 @@ int main(int argc, char **argv, char **envp) val =g_strdup_printf ("%d" , current_machine->smp.cpus);object_register_sugar_prop ("memory-backend" ,"prealloc-threads" , val);g_free (val); +object_register_sugar_prop ("memory-backend" ,"prealloc" ,"on" ); }/*
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 78/80] hostmem: fix strict bind policy
Quoted 11 lines · On Thu, 23 Jan 2020 12:38:43 +0100 Igor Mammedov <[email protected]> wrote:
With main RAM now converted to hostmem backends, there is no point in keeping global
mem_preallocaround, so alias
-mem-prealloc to "memory-backend.prealloc=on"
machine compat[*] property and makemem_prealloca local variable to only stir registration of compat property.*) currently user accessible -global works only with DEVICE
based objects and extra work is needed to make it work with hostmem backends. But that is convenience option and out of scope of this already huge refactoring. Hence machine compat properties were used.
AFAIU because of this something like
-global memory-backend-file.share=on
(as proposed by
https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00531.html)
can not be used to make the main RAM shared (e.g. for vhost on s390x). Or am I wrong? If not, is -global still the way we want to make this work for non-numa machines, or did I miss updates?
Regards,
Halil
Re: [PATCH REPOST v3 78/80] hostmem: fix strict bind policy
Quoted 15 lines · On Fri, 24 Jan 2020 20:17:48 +0100 Halil Pasic <[email protected]> wrote:
Quoted 11 lines · On Thu, 23 Jan 2020 12:38:43 +0100 Igor Mammedov <[email protected]> wrote:
With main RAM now converted to hostmem backends, there is no point in keeping global
mem_preallocaround, so alias
-mem-prealloc to "memory-backend.prealloc=on"
machine compat[*] property and makemem_prealloca local variable to only stir registration of compat property.*) currently user accessible -global works only with DEVICE
based objects and extra work is needed to make it work with hostmem backends. But that is convenience option and out of scope of this already huge refactoring. Hence machine compat properties were used.
Quoted 7 lines
AFAIU because of this something like
-global memory-backend-file.share=on
(as proposed by
https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00531.html)
can not be used to make the main RAM shared (e.g. for vhost on s390x). Or am I wrong? If not, is -global still the way we want to make this work for non-numa machines, or did I miss updates?
one should be able to use memory-backend property to make it work instead of -m convenience option in s390 case.
As for -global for objects (or more limited variant for memory-backends), it needs more work to support objects. (that's mostly policy decision)
Quoted 3 lines
Regards,
Halil
Re: [PATCH REPOST v3 78/80] hostmem: fix strict bind policy
Quoted 26 lines · On Mon, 27 Jan 2020 08:39:25 +0100 Igor Mammedov <[email protected]> wrote:
Quoted 15 lines · On Fri, 24 Jan 2020 20:17:48 +0100 Halil Pasic <[email protected]> wrote:
Quoted 11 lines · On Thu, 23 Jan 2020 12:38:43 +0100 Igor Mammedov <[email protected]> wrote:
With main RAM now converted to hostmem backends, there is no point in keeping global
mem_preallocaround, so alias
-mem-prealloc to "memory-backend.prealloc=on"
machine compat[*] property and makemem_prealloca local variable to only stir registration of compat property.*) currently user accessible -global works only with DEVICE
based objects and extra work is needed to make it work with hostmem backends. But that is convenience option and out of scope of this already huge refactoring. Hence machine compat properties were used.Quoted 7 lines
AFAIU because of this something like
-global memory-backend-file.share=on
(as proposed by
https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00531.html)
can not be used to make the main RAM shared (e.g. for vhost on s390x). Or am I wrong? If not, is -global still the way we want to make this work for non-numa machines, or did I miss updates?
Quoted 2 lines
one should be able to use memory-backend property to make it work instead of -m convenience option in s390 case.
Thank you very much for the quick response!
Honestly, I overlooked the memory-backed machine property, but regardless of that -machine,memory-backend=id *does not seem viable* at the moment.
My understanding is that one has to do something like:
-machine type=s390-ccw-virtio,memory-backend=mem \
-object memory-backend-file,id=mem,size=2G,mem-path=/dev/shm/virtiofs.shm,share=on \
I get
qemu: : Device 'mem' not found
because the 'memory-backend-*' objects are delayed, i.e. !object_create_initial(), and at the time when machine_set_property() tries to look the memory-backend up the memory-backend is not yet created.
For why delayed, object_create_initial() has a comment:
/* Memory allocation by backends needs to be done
* after configure_accelerator() (due to the tcg_enabled()
* checks at memory_region_init_*()).
*
* Also, allocation of large amounts of memory may delay
* chardev initialization for too long, and trigger timeouts
* on software that waits for a monitor socket to be created
* (e.g. libvirt).
*/
if (g_str_has_prefix(type, "memory-backend-")) {
Or, am I using it wrong?
Quoted 4 lines
As for -global for objects (or more limited variant for memory-backends), it needs more work to support objects. (that's mostly policy decision)
I agree.
Regards,
Halil
Re: [PATCH REPOST v3 78/80] hostmem: fix strict bind policy
Quoted 62 lines · On Mon, 27 Jan 2020 15:41:45 +0100 Halil Pasic <[email protected]> wrote:
Quoted 26 lines · On Mon, 27 Jan 2020 08:39:25 +0100 Igor Mammedov <[email protected]> wrote:
Quoted 15 lines · On Fri, 24 Jan 2020 20:17:48 +0100 Halil Pasic <[email protected]> wrote:
Quoted 11 lines · On Thu, 23 Jan 2020 12:38:43 +0100 Igor Mammedov <[email protected]> wrote:
With main RAM now converted to hostmem backends, there is no point in keeping global
mem_preallocaround, so alias
-mem-prealloc to "memory-backend.prealloc=on"
machine compat[*] property and makemem_prealloca local variable to only stir registration of compat property.*) currently user accessible -global works only with DEVICE
based objects and extra work is needed to make it work with hostmem backends. But that is convenience option and out of scope of this already huge refactoring. Hence machine compat properties were used.Quoted 7 lines
AFAIU because of this something like
-global memory-backend-file.share=on
(as proposed by
https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00531.html)
can not be used to make the main RAM shared (e.g. for vhost on s390x). Or am I wrong? If not, is -global still the way we want to make this work for non-numa machines, or did I miss updates?Quoted 2 lines
one should be able to use memory-backend property to make it work instead of -m convenience option in s390 case.
Thank you very much for the quick response!
Honestly, I overlooked the memory-backed machine property, but regardless of that -machine,memory-backend=id *does not seem viable* at the moment.
My understanding is that one has to do something like:
(quoted diff) +0
-2-machine type=s390-ccw-virtio,memory-backend=mem \ -object memory-backend-file,id=mem,size=2G,mem-path=/dev/shm/virtiofs.shm,share=on \I get
qemu: : Device 'mem' not found
because the 'memory-backend-*' objects are delayed, i.e. !object_create_initial(), and at the time whenmachine_set_property()tries to look the memory-backend up the memory-backend is not yet created.For why delayed,
object_create_initial()has a comment:/* Memory allocation by backends needs to be done
* afterconfigure_accelerator()(due to thetcg_enabled()
* checks at memory_region_init_*()).
*
* Also, allocation of large amounts of memory may delay
* chardev initialization for too long, and trigger timeouts
* on software that waits for a monitor socket to be created
* (e.g. libvirt).
*/
if (g_str_has_prefix(type, "memory-backend-")) {
Quoted 1 line
Or, am I using it wrong?
You right,
I even had an alternative impl. earlier that used string property instead of link, but later I forgot about this complication and simplified it to link property which works fine but only for -m case.
It's necessary to rewrite patches 2-4/80 to use string property for memory-backend which will be used for delayed backend access at machine_run_board_init() time.
I'll CC you on relevant patches for reviewing when I post v4.
Quoted 10 lines
Quoted 4 lines
As for -global for objects (or more limited variant for memory-backends), it needs more work to support objects. (that's mostly policy decision)
I agree.
Regards,
Halil
Re: [PATCH REPOST v3 78/80] hostmem: fix strict bind policy
Quoted 5 lines · On Tue, 28 Jan 2020 13:07:40 +0100 Igor Mammedov <[email protected]> wrote:
Quoted 2 lines · On Mon, 27 Jan 2020 15:41:45 +0100 Halil Pasic <[email protected]> wrote:
On Mon, 27 Jan 2020 08:39:25 +0100
Igor Mammedov <[email protected]> wrote:
[..]
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
one should be able to use memory-backend property to make it work instead of -m convenience option in s390 case.
Thank you very much for the quick response!
Honestly, I overlooked the memory-backed machine property, but regardless of that -machine,memory-backend=id *does not seem viable* at the moment.
[..]
Quoted 9 lines
Quoted 2 lines
Or, am I using it wrong?
You right,
I even had an alternative impl. earlier that used string property instead of link, but later I forgot about this complication and simplified it to link property which works fine but only for -m case.
Quoted 6 lines
It's necessary to rewrite patches 2-4/80 to use string property for memory-backend which will be used for delayed backend access at
machine_run_board_init()time.I'll CC you on relevant patches for reviewing when I post v4.
Thanks! I will give it a spin.
Halil
PATCH v3 79/80 tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups
In reply to Igor MammedovUse GString to pass argument to make_cli() so that it would be easy to dynamically change test case arguments from main(). The follow up patch will use it to change RAM size options depending on target.
While at it cleanup 'cli' freeing, using g_autofree annotation.
---
v3:
* s/strcmp/g_str_equal/
(Thomas Huth <[email protected]>)
* use pair make_cli/qtest_init instead of qtest_initf
PS:
made as a separate patch so it won't clutter followup testcase changes.
--- tests/qtest/numa-test.c | 108 ++++++++++++++++++++++++------------------------ 1 file changed, 54 insertions(+), 54 deletions(-)
tests/qtest/numa-test.c +54 -54
@@ -14,16 +14,16 @@#include "qapi/qmp/qdict.h" #include "qapi/qmp/qlist.h" -static char *make_cli (const char *generic_cli,const char *test_cli) +static char *make_cli (const GString *generic_cli,const char *test_cli) { -return g_strdup_printf ("%s %s" , generic_cli ? generic_cli :"" , test_cli); +return g_strdup_printf ("%s %s" , generic_cli->str, test_cli); }static void test_mon_explicit (const void *data) { -char *s; -char *cli;QTestState *qts; + g_autofree char *s = NULL; + g_autofree char *cli = NULL; cli =make_cli (data,"-smp 8 " "-numa node,nodeid=0,cpus=0-3 "
@@ -33,17 +33,15 @@ static void test_mon_explicit(const void *data) s =qtest_hmp (qts,"info numa" );g_assert (strstr (s,"node 0 cpus: 0 1 2 3" ));g_assert (strstr (s,"node 1 cpus: 4 5 6 7" )); -g_free (s);qtest_quit (qts); -g_free (cli); }static void test_mon_default (const void *data) { -char *s; -char *cli;QTestState *qts; + g_autofree char *s = NULL; + g_autofree char *cli = NULL; cli =make_cli (data,"-smp 8 -numa node -numa node" ); qts =qtest_init (cli);
@@ -51,17 +49,15 @@ static void test_mon_default(const void *data) s =qtest_hmp (qts,"info numa" );g_assert (strstr (s,"node 0 cpus: 0 2 4 6" ));g_assert (strstr (s,"node 1 cpus: 1 3 5 7" )); -g_free (s);qtest_quit (qts); -g_free (cli); }static void test_mon_partial (const void *data) { -char *s; -char *cli;QTestState *qts; + g_autofree char *s = NULL; + g_autofree char *cli = NULL; cli =make_cli (data,"-smp 8 " "-numa node,nodeid=0,cpus=0-1 "
@@ -71,10 +67,8 @@ static void test_mon_partial(const void *data) s =qtest_hmp (qts,"info numa" );g_assert (strstr (s,"node 0 cpus: 0 1 2 3 6 7" ));g_assert (strstr (s,"node 1 cpus: 4 5" )); -g_free (s);qtest_quit (qts); -g_free (cli); }static QList *get_cpus (QTestState *qts,QDict **resp)
@@ -87,11 +81,11 @@ static QList *get_cpus(QTestState *qts, QDict **resp)static void test_query_cpus (const void *data) { -char *cli;QDict *resp;QList *cpus;QObject *e;QTestState *qts; + g_autofree char *cli = NULL; cli =make_cli (data,"-smp 8 -numa node,cpus=0-3 -numa node,cpus=4-7" ); qts =qtest_init (cli);
@@ -120,16 +114,15 @@ static void test_query_cpus(const void *data)qobject_unref (resp);qtest_quit (qts); -g_free (cli); }static void pc_numa_cpu (const void *data) { -char *cli;QDict *resp;QList *cpus;QObject *e;QTestState *qts; + g_autofree char *cli = NULL; cli =make_cli (data,"-cpu pentium -smp 8,sockets=2,cores=2,threads=2 " "-numa node,nodeid=0 -numa node,nodeid=1 "
@@ -174,16 +167,15 @@ static void pc_numa_cpu(const void *data)qobject_unref (resp);qtest_quit (qts); -g_free (cli); }static void spapr_numa_cpu (const void *data) { -char *cli;QDict *resp;QList *cpus;QObject *e;QTestState *qts; + g_autofree char *cli = NULL; cli =make_cli (data,"-smp 4,cores=4 " "-numa node,nodeid=0 -numa node,nodeid=1 "
@@ -220,16 +212,15 @@ static void spapr_numa_cpu(const void *data)qobject_unref (resp);qtest_quit (qts); -g_free (cli); }static void aarch64_numa_cpu (const void *data) { -char *cli;QDict *resp;QList *cpus;QObject *e;QTestState *qts; + g_autofree char *cli = NULL; cli =make_cli (data,"-smp 2 " "-numa node,nodeid=0 -numa node,nodeid=1 "
@@ -264,7 +255,6 @@ static void aarch64_numa_cpu(const void *data)qobject_unref (resp);qtest_quit (qts); -g_free (cli); }static void pc_dynamic_cpu_cfg (const void *data)
@@ -273,9 +263,10 @@ static void pc_dynamic_cpu_cfg(const void *data)QDict *resp;QList *cpus;QTestState *qs; + g_autofree char *cli = NULL; - qs =qtest_initf ("%s -nodefaults --preconfig -smp 2" , - data ? (char *)data :"" ); + cli =make_cli (data,"-nodefaults --preconfig -smp 2" ); + qs =qtest_init (cli);/* create 2 numa nodes */ g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'set-numa-node',"
@@ -329,16 +320,19 @@ static void pc_dynamic_cpu_cfg(const void *data)static void pc_hmat_build_cfg (const void *data) { -QTestState *qs =qtest_initf ("%s -nodefaults --preconfig -machine hmat=on " -"-smp 2,sockets=2 " -"-m 128M,slots=2,maxmem=1G " -"-object memory-backend-ram,size=64M,id=m0 " -"-object memory-backend-ram,size=64M,id=m1 " -"-numa node,nodeid=0,memdev=m0 " -"-numa node,nodeid=1,memdev=m1,initiator=0 " -"-numa cpu,node-id=0,socket-id=0 " -"-numa cpu,node-id=0,socket-id=1" , - data ? (char *)data :"" ); +QTestState *qs; + g_autofree char *cli = NULL; + + cli =make_cli (data,"-nodefaults --preconfig -machine hmat=on " +"-smp 2,sockets=2 " +"-m 128M,slots=2,maxmem=1G " +"-object memory-backend-ram,size=64M,id=m0 " +"-object memory-backend-ram,size=64M,id=m1 " +"-numa node,nodeid=0,memdev=m0 " +"-numa node,nodeid=1,memdev=m1,initiator=0 " +"-numa cpu,node-id=0,socket-id=0 " +"-numa cpu,node-id=0,socket-id=1" ); + qs =qtest_init (cli);/* Fail: Initiator should be less than the number of nodes */ g_assert_true(qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'set-numa-node',"
@@ -455,13 +449,16 @@ static void pc_hmat_build_cfg(const void *data)static void pc_hmat_off_cfg (const void *data) { -QTestState *qs =qtest_initf ("%s -nodefaults --preconfig " -"-smp 2,sockets=2 " -"-m 128M,slots=2,maxmem=1G " -"-object memory-backend-ram,size=64M,id=m0 " -"-object memory-backend-ram,size=64M,id=m1 " -"-numa node,nodeid=0,memdev=m0" , - data ? (char *)data :"" ); +QTestState *qs; + g_autofree char *cli = NULL; + + cli =make_cli (data,"-nodefaults --preconfig " +"-smp 2,sockets=2 " +"-m 128M,slots=2,maxmem=1G " +"-object memory-backend-ram,size=64M,id=m0 " +"-object memory-backend-ram,size=64M,id=m1 " +"-numa node,nodeid=0,memdev=m0" ); + qs =qtest_init (cli);/* * Fail: Enable HMAT with -machine hmat=on
@@ -491,16 +488,19 @@ static void pc_hmat_off_cfg(const void *data)static void pc_hmat_erange_cfg (const void *data) { -QTestState *qs =qtest_initf ("%s -nodefaults --preconfig -machine hmat=on " -"-smp 2,sockets=2 " -"-m 128M,slots=2,maxmem=1G " -"-object memory-backend-ram,size=64M,id=m0 " -"-object memory-backend-ram,size=64M,id=m1 " -"-numa node,nodeid=0,memdev=m0 " -"-numa node,nodeid=1,memdev=m1,initiator=0 " -"-numa cpu,node-id=0,socket-id=0 " -"-numa cpu,node-id=0,socket-id=1" , - data ? (char *)data :"" ); +QTestState *qs; + g_autofree char *cli = NULL; + + cli =make_cli (data,"-nodefaults --preconfig -machine hmat=on " +"-smp 2,sockets=2 " +"-m 128M,slots=2,maxmem=1G " +"-object memory-backend-ram,size=64M,id=m0 " +"-object memory-backend-ram,size=64M,id=m1 " +"-numa node,nodeid=0,memdev=m0 " +"-numa node,nodeid=1,memdev=m1,initiator=0 " +"-numa cpu,node-id=0,socket-id=0 " +"-numa cpu,node-id=0,socket-id=1" ); + qs =qtest_init (cli);/* Can't store the compressed latency */ g_assert_false(qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'set-numa-node',"
@@ -539,11 +539,11 @@ static void pc_hmat_erange_cfg(const void *data)int main (int argc,char **argv) { -const char *args =NULL ; +g_autoptr (GString) args =g_string_new ("" );const char *arch =qtest_get_arch (); -if (strcmp (arch,"aarch64" ) ==0 ) { - args ="-machine virt" ; +if (g_str_equal (arch,"aarch64" )) { +g_string_append (args," -machine virt" ); }g_test_init (&argc, &argv,NULL );
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 79/80] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups
Quoted 8 lines · Igor Mammedov
Use GString to pass argument to
make_cli()so that it would be easy to dynamically change test case arguments frommain(). The follow up patch will use it to change RAM size options depending on target.While at it cleanup 'cli' freeing, using
g_autofreeannotation.Signed-off-by Igor Mammedov <[email protected]>---
[...]
tests/qtest/numa-test.c static void pc_hmat_erange_cfg(const void *data) · line 542
Quoted 6 lines
tests/qtest/numa-test.c +1
-1@@ -539,11 +539,11 @@ static void pc_hmat_erange_cfg(const void *data)int main (int argc,char **argv) { -const char *args =NULL ; +g_autoptr (GString) args =g_string_new ("" );
Nit: You could use g_string_new(NULL) here to save two bytes ;-)
tests/qtest/numa-test.c static void pc_hmat_erange_cfg(const void *data) · line 549
Quoted 10 lines
tests/qtest/numa-test.c +2
-2const char *arch =qtest_get_arch (); -if (strcmp (arch,"aarch64" ) ==0 ) { - args ="-machine virt" ; +if (g_str_equal (arch,"aarch64" )) { +g_string_append (args," -machine virt" ); }g_test_init (&argc, &argv,NULL );
Re: [PATCH REPOST v3 79/80] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups
In reply to Igor MammedovQuoted 15 lines · Igor Mammedov
Use GString to pass argument to
make_cli()so that it would be easy to dynamically change test case arguments frommain(). The follow up patch will use it to change RAM size options depending on target.While at it cleanup 'cli' freeing, using
g_autofreeannotation.Signed-off-by Igor Mammedov <[email protected]>---
v3:
* s/strcmp/g_str_equal/
(Thomas Huth <[email protected]>)
* use pair make_cli/qtest_init instead ofqtest_initf
PS:
made as a separate patch so it won't clutter followup testcase changes.
Quoted 5 lines
---
tests/qtest/numa-test.c| 108 ++++++++++++++++++++++++------------------------1 file changed, 54 insertions(+), 54 deletions(-)
Title of this and next (80/80) patch is probably better written as tests/numa-test: to follow usual patch titles but this may not be too important.
Regards,
BALATON Zoltan
PATCH v3 80/80 tests:numa-test: use explicit memdev to specify node RAM
In reply to Igor MammedovFollow up patches will remove automatic RAM distribution between nodes and will make default machine types require "memdev" option instead of legacy "mem" option.
Make tests to follow new rules and add an additional test for legacy "mem" option on old machine type, to make sure it won't regress in the future.
---
v3:
* s/strcmp/g_str_equal/
* put -object lines before -m
(Thomas Huth <[email protected]>)
* drop new test_pc_legacy_mem(), due to dropping
"numa: forbid '-numa node,mem' for 5.0 and newer machine types"
it will be posted later, when libvirt side is prepared for disabled '-numa node,mem' (hopefully 5.1)
--- tests/qtest/numa-test.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-)
tests/qtest/numa-test.c +18 -12
@@ -25,9 +25,8 @@ static void test_mon_explicit(const void *data) g_autofree char *s = NULL; g_autofree char *cli = NULL; - cli =make_cli (data,"-smp 8 " -"-numa node,nodeid=0,cpus=0-3 " -"-numa node,nodeid=1,cpus=4-7 " ); + cli =make_cli (data,"-smp 8 -numa node,nodeid=0,memdev=ram,cpus=0-3 " +"-numa node,nodeid=1,cpus=4-7" ); qts =qtest_init (cli); s =qtest_hmp (qts,"info numa" );
@@ -37,13 +36,13 @@ static void test_mon_explicit(const void *data)qtest_quit (qts); } -static void test_mon_default (const void *data) +static void test_def_cpu_split (const void *data) {QTestState *qts; g_autofree char *s = NULL; g_autofree char *cli = NULL; - cli =make_cli (data,"-smp 8 -numa node -numa node" ); + cli =make_cli (data,"-smp 8 -numa node,memdev=ram -numa node" ); qts =qtest_init (cli); s =qtest_hmp (qts,"info numa" );
@@ -60,7 +59,7 @@ static void test_mon_partial(const void *data) g_autofree char *cli = NULL; cli =make_cli (data,"-smp 8 " -"-numa node,nodeid=0,cpus=0-1 " +"-numa node,nodeid=0,memdev=ram,cpus=0-1 " "-numa node,nodeid=1,cpus=4-5 " ); qts =qtest_init (cli);
@@ -87,7 +86,8 @@ static void test_query_cpus(const void *data)QTestState *qts; g_autofree char *cli = NULL; - cli =make_cli (data,"-smp 8 -numa node,cpus=0-3 -numa node,cpus=4-7" ); + cli =make_cli (data,"-smp 8 -numa node,memdev=ram,cpus=0-3 " +"-numa node,cpus=4-7" ); qts =qtest_init (cli); cpus =get_cpus (qts, &resp);g_assert (cpus);
@@ -125,7 +125,7 @@ static void pc_numa_cpu(const void *data) g_autofree char *cli = NULL; cli =make_cli (data,"-cpu pentium -smp 8,sockets=2,cores=2,threads=2 " -"-numa node,nodeid=0 -numa node,nodeid=1 " +"-numa node,nodeid=0,memdev=ram -numa node,nodeid=1 " "-numa cpu,node-id=1,socket-id=0 " "-numa cpu,node-id=0,socket-id=1,core-id=0 " "-numa cpu,node-id=0,socket-id=1,core-id=1,thread-id=0 "
@@ -178,7 +178,7 @@ static void spapr_numa_cpu(const void *data) g_autofree char *cli = NULL; cli =make_cli (data,"-smp 4,cores=4 " -"-numa node,nodeid=0 -numa node,nodeid=1 " +"-numa node,nodeid=0,memdev=ram -numa node,nodeid=1 " "-numa cpu,node-id=0,core-id=0 " "-numa cpu,node-id=0,core-id=1 " "-numa cpu,node-id=0,core-id=2 "
@@ -223,7 +223,7 @@ static void aarch64_numa_cpu(const void *data) g_autofree char *cli = NULL; cli =make_cli (data,"-smp 2 " -"-numa node,nodeid=0 -numa node,nodeid=1 " +"-numa node,nodeid=0,memdev=ram -numa node,nodeid=1 " "-numa cpu,node-id=1,thread-id=0 " "-numa cpu,node-id=0,thread-id=1" ); qts =qtest_init (cli);
@@ -270,7 +270,7 @@ static void pc_dynamic_cpu_cfg(const void *data)/* create 2 numa nodes */ g_assert (!qmp_rsp_is_err (qtest_qmp (qs,"{ 'execute': 'set-numa-node'," -" 'arguments': { 'type': 'node', 'nodeid': 0 } }" ))); +" 'arguments': { 'type': 'node', 'nodeid': 0, 'memdev': 'ram' } }" )));g_assert (!qmp_rsp_is_err (qtest_qmp (qs,"{ 'execute': 'set-numa-node'," " 'arguments': { 'type': 'node', 'nodeid': 1 } }" )));
@@ -542,13 +542,19 @@ int main(int argc, char **argv)g_autoptr (GString) args =g_string_new ("" );const char *arch =qtest_get_arch (); +if (g_str_equal (arch,"ppc64" )) { +g_string_append (args," -object memory-backend-ram,id=ram,size=512M" ); + }else { +g_string_append (args," -object memory-backend-ram,id=ram,size=128M" ); + } +if (g_str_equal (arch,"aarch64" )) {g_string_append (args," -machine virt" ); }g_test_init (&argc, &argv,NULL ); -qtest_add_data_func ("/numa/mon/default" , args, test_mon_default); +qtest_add_data_func ("/numa/mon/cpus/default" , args, test_def_cpu_split);qtest_add_data_func ("/numa/mon/cpus/explicit" , args, test_mon_explicit);qtest_add_data_func ("/numa/mon/cpus/partial" , args, test_mon_partial);qtest_add_data_func ("/numa/qmp/cpus/query-cpus" , args, test_query_cpus);
Signature · 1 line
2.7.4
Re: [PATCH REPOST v3 80/80] tests:numa-test: use explicit memdev to specify node RAM
Quoted 10 lines · Igor Mammedov
Follow up patches will remove automatic RAM distribution between nodes and will make default machine types require "memdev" option instead of legacy "mem" option.
Make tests to follow new rules and add an additional test for legacy "mem" option on old machine type, to make sure it won't regress in the future.
Signed-off-by Igor Mammedov <[email protected]>---
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series seems to have some coding style problems. See output below for more information:
Type: series
Message-id: [email protected]
Subject: [PATCH REPOST v3 00/80] refactor main RAM allocation to use hostmem backend
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
- [tag update] patchew/[email protected] -> patchew/[email protected]
Switched to a new branch 'test'
28f0d42 tests:numa-test: use explicit memdev to specify node RAM 64e4393 tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups e6ea9bb hostmem: fix strict bind policy
339ae3c hostmem: introduce "prealloc-threads" property
a0a8b7f make mem_path local variable
cac7077 exec: drop bogus mem_path from qemu_ram_alloc_from_fd() 937af3d exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() 294588b remove no longer used memory_region_allocate_system_memory() 6a13317 sparc/niagara: use memdev for RAM
6b50ac9 sparc/sun4m: use memdev for RAM
6c88353 sparc/leon3: use memdev for RAM
c35345c ppc/virtex_ml507: use memdev for RAM
2b9aeb4 ppc/virtex_ml507: remove unused arguments
7f5e309 ppc/spapr: use memdev for RAM
d5ec039 ppc/prep: use memdev for RAM
4f02b90 ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM
d02eb66 ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup
dd10982 ppc/ppc405_boards: use memdev for RAM
9741a0e ppc/ppc405_boards: add RAM size checks
fe790ac ppc/pnv: use memdev for RAM
3bec0ee ppc/mac_oldworld: use memdev for RAM
46e6217 ppc/mac_newworld: use memdev for RAM
281b13d ppc/e500: use memdev for RAM
8f31839 ppc/e500: drop RAM size fixup
06ffc73 mips/mips_r4k: use memdev for RAM
6c48078 mips/mips_mipssim: use memdev for RAM
74f382e mips/mips_malta: use memdev for RAM
49962be mips/mips_jazz: use memdev for RAM
b4e5189 mips/mips_fulong2e: use memdev for RAM
f7ef86f mips/mips_fulong2e: drop RAM size fixup
2349c09 mips/boston-cube: use memdev for RAM
288b0f9 m68k/next-cube: use memdev for RAM
d664fda m68k/mcf5208: use memdev for RAM
0ed8640 m68k/an5206: use memdev for RAM
2bafeaa lm32/milkymist: use memdev for RAM
5d13e10 lm32/lm32_boards: use memdev for RAM
1d97c07 x86/pc: use memdev for RAM
0628c4d x86/microvm: use memdev for RAM
f420b0e hppa: use memdev for RAM
a2a5383 hw/hppa/machine: Map the PDC memory region with higher priority ce86cda hw/hppa/machine: Restrict the total memory size to 3GB f451860 hw/hppa/machine: Correctly check the firmware is in PDC range 1220207 cris/axis_dev88: use memdev for RAM
0bf39f2 null-machine: use memdev for RAM
21613ae s390x/s390-virtio-ccw: use memdev for RAM
3641332 arm/xlnx-zcu102: use memdev for RAM
478a2a9 arm/xlnx-versal-virt: use memdev for RAM
07e35dd arm/xilinx_zynq: use memdev for RAM
ec3ff8e arm/xilinx_zynq: drop RAM size fixup
c73467d arm/virt: use memdev for RAM
a03708e arm/vexpress: use memdev for RAM
9dfd635 arm/versatilepb: use memdev for RAM
6b6397a arm/sbsa-ref: use memdev for RAM
10babd5 arm/sabrelite: use memdev for RAM
33a4e2b arm/raspi: use memdev for RAM
85cd733 arm/palm: use memdev for RAM
e587591 arm/omap_sx1: use memdev for RAM
44b7506 arm/nseries: use memdev for RAM
310bbb2 arm/musicpal: use memdev for RAM
cc5a043 arm/mps2: use memdev for RAM
e032a25 arm/mps2-tz: use memdev for RAM
0abbf17 arm/mcimx7d-sabre: use memdev for RAM
a44bded arm/mcimx6ul-evk: use memdev for RAM
395bc05 arm/kzm: use memdev for RAM
90a7cd2 arm/kzm: drop RAM size fixup
ca13b69 arm/integratorcp: use memdev for RAM
0893e7d arm/imx25_pdk: use memdev for RAM
021caf5 arm/imx25_pdk: drop RAM size fixup
af2dbf9 arm/highbank: use memdev for RAM
6e9dc93 arm/digic_boards: use memdev for RAM
64313e8 arm/cubieboard: use memdev for RAM
425d057 arm/collie: use memdev for RAM
73e2bc8 arm/aspeed: use memdev for RAM
6de64f3 arm/aspeed: actually check RAM size
954e0ec alpha:dp264: use memdev for RAM
34f13c1 initialize MachineState::ram in NUMA case
fdfae56 machine: introduce convenience MachineState::ram
065fc14 machine: alias -mem-path and -mem-prealloc into memory-foo backend 76900f9 machine: introduce memory-backend property
6a49dc0 numa: remove deprecated -mem-path fallback to anonymous RAM
=== OUTPUT BEGIN ===
1/80 Checking commit 6a49dc0538bc (numa: remove deprecated -mem-path fallback to anonymous RAM) 2/80 Checking commit 76900f97f62a (machine: introduce memory-backend property)
3/80 Checking commit 065fc1476423 (machine: alias -mem-path and -mem-prealloc into memory-foo backend) 4/80 Checking commit fdfae5645ca1 (machine: introduce convenience MachineState::ram) 5/80 Checking commit 34f13c129a81 (initialize MachineState::ram in NUMA case)
6/80 Checking commit 954e0ec8737b (alpha:dp264: use memdev for RAM)
ERROR: spaces required around that '*' (ctx:WxV)
#30: FILE: hw/alpha/alpha_sys.h:14:
+PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4],
^
total: 1 errors, 0 warnings, 49 lines checked
Patch 6/80 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
7/80 Checking commit 6de64f38ddf7 (arm/aspeed: actually check RAM size)
8/80 Checking commit 73e2bc8bb37e (arm/aspeed: use memdev for RAM)
9/80 Checking commit 425d057fe70e (arm/collie: use memdev for RAM)
10/80 Checking commit 64313e86133a (arm/cubieboard: use memdev for RAM)
11/80 Checking commit 6e9dc93c1ae2 (arm/digic_boards: use memdev for RAM)
12/80 Checking commit af2dbf980370 (arm/highbank: use memdev for RAM)
13/80 Checking commit 021caf507b43 (arm/imx25_pdk: drop RAM size fixup)
14/80 Checking commit 0893e7d219c7 (arm/imx25_pdk: use memdev for RAM)
15/80 Checking commit ca13b699384c (arm/integratorcp: use memdev for RAM)
16/80 Checking commit 90a7cd27125c (arm/kzm: drop RAM size fixup)
17/80 Checking commit 395bc059e5e6 (arm/kzm: use memdev for RAM)
18/80 Checking commit a44bded9b399 (arm/mcimx6ul-evk: use memdev for RAM)
19/80 Checking commit 0abbf178464e (arm/mcimx7d-sabre: use memdev for RAM)
20/80 Checking commit e032a25b1bdf (arm/mps2-tz: use memdev for RAM)
21/80 Checking commit cc5a04303320 (arm/mps2: use memdev for RAM)
22/80 Checking commit 310bbb26a5d0 (arm/musicpal: use memdev for RAM)
23/80 Checking commit 44b7506173d1 (arm/nseries: use memdev for RAM)
24/80 Checking commit e5875912377a (arm/omap_sx1: use memdev for RAM)
25/80 Checking commit 85cd73342f55 (arm/palm: use memdev for RAM)
26/80 Checking commit 33a4e2b7e025 (arm/raspi: use memdev for RAM)
27/80 Checking commit 10babd50e8f7 (arm/sabrelite: use memdev for RAM)
28/80 Checking commit 6b6397ae93b6 (arm/sbsa-ref: use memdev for RAM)
29/80 Checking commit 9dfd635f4a05 (arm/versatilepb: use memdev for RAM)
30/80 Checking commit a03708e51b2d (arm/vexpress: use memdev for RAM)
31/80 Checking commit c73467dcc7bd (arm/virt: use memdev for RAM)
32/80 Checking commit ec3ff8eaf9c7 (arm/xilinx_zynq: drop RAM size fixup)
33/80 Checking commit 07e35dd85c30 (arm/xilinx_zynq: use memdev for RAM)
34/80 Checking commit 478a2a976000 (arm/xlnx-versal-virt: use memdev for RAM)
35/80 Checking commit 364133212cca (arm/xlnx-zcu102: use memdev for RAM)
36/80 Checking commit 21613ae37fe5 (s390x/s390-virtio-ccw: use memdev for RAM)
37/80 Checking commit 0bf39f2f5bfd (null-machine: use memdev for RAM)
38/80 Checking commit 1220207531bd (cris/axis_dev88: use memdev for RAM)
39/80 Checking commit f45186045981 (hw/hppa/machine: Correctly check the firmware is in PDC range) 40/80 Checking commit ce86cda1a8e7 (hw/hppa/machine: Restrict the total memory size to 3GB) 41/80 Checking commit a2a538392cf6 (hw/hppa/machine: Map the PDC memory region with higher priority) 42/80 Checking commit f420b0e2cd93 (hppa: use memdev for RAM)
43/80 Checking commit 0628c4d5d8be (x86/microvm: use memdev for RAM)
44/80 Checking commit 1d97c07c047f (x86/pc: use memdev for RAM)
45/80 Checking commit 5d13e105726d (lm32/lm32_boards: use memdev for RAM)
46/80 Checking commit 2bafeaab1467 (lm32/milkymist: use memdev for RAM)
47/80 Checking commit 0ed8640372a0 (m68k/an5206: use memdev for RAM)
48/80 Checking commit d664fdabf784 (m68k/mcf5208: use memdev for RAM)
49/80 Checking commit 288b0f9f7c1a (m68k/next-cube: use memdev for RAM)
50/80 Checking commit 2349c09ed98b (mips/boston-cube: use memdev for RAM)
51/80 Checking commit f7ef86f11f0b (mips/mips_fulong2e: drop RAM size fixup)
52/80 Checking commit b4e5189ba317 (mips/mips_fulong2e: use memdev for RAM)
53/80 Checking commit 49962bea6cb5 (mips/mips_jazz: use memdev for RAM)
54/80 Checking commit 74f382e62b3c (mips/mips_malta: use memdev for RAM)
55/80 Checking commit 6c48078f9a68 (mips/mips_mipssim: use memdev for RAM)
56/80 Checking commit 06ffc734cd43 (mips/mips_r4k: use memdev for RAM)
57/80 Checking commit 8f3183989d32 (ppc/e500: drop RAM size fixup)
58/80 Checking commit 281b13dcac57 (ppc/e500: use memdev for RAM)
59/80 Checking commit 46e62170c054 (ppc/mac_newworld: use memdev for RAM)
60/80 Checking commit 3bec0ee0a72c (ppc/mac_oldworld: use memdev for RAM)
61/80 Checking commit fe790ac8de76 (ppc/pnv: use memdev for RAM)
62/80 Checking commit 9741a0e38c44 (ppc/ppc405_boards: add RAM size checks)
63/80 Checking commit dd1098217df9 (ppc/ppc405_boards: use memdev for RAM)
64/80 Checking commit d02eb66b089e (ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup) 65/80 Checking commit 4f02b90b6cec (ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM)
WARNING: Block comments use a leading /* on a separate line
#48: FILE: hw/ppc/ppc4xx_devs.c:669:
+/* Split RAM between SDRAM banks.
total: 0 errors, 1 warnings, 103 lines checked
Patch 65/80 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
66/80 Checking commit d5ec039191e8 (ppc/prep: use memdev for RAM)
67/80 Checking commit 7f5e309237cf (ppc/spapr: use memdev for RAM)
68/80 Checking commit 2b9aeb4d5e28 (ppc/virtex_ml507: remove unused arguments)
69/80 Checking commit c35345cc9c8e (ppc/virtex_ml507: use memdev for RAM)
70/80 Checking commit 6c883537133c (sparc/leon3: use memdev for RAM)
71/80 Checking commit 6b50ac9a623d (sparc/sun4m: use memdev for RAM)
72/80 Checking commit 6a13317c51a2 (sparc/niagara: use memdev for RAM)
73/80 Checking commit 294588be8a80 (remove no longer used memory_region_allocate_system_memory()) 74/80 Checking commit 937af3df4f2d (exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()) 75/80 Checking commit cac70772ccef (exec: drop bogus mem_path from qemu_ram_alloc_from_fd()) 76/80 Checking commit a0a8b7fc4f32 (make mem_path local variable)
77/80 Checking commit 339ae3c25248 (hostmem: introduce "prealloc-threads" property)
78/80 Checking commit e6ea9bb4c870 (hostmem: fix strict bind policy)
79/80 Checking commit 64e4393761e9 (tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups) 80/80 Checking commit 28f0d4235892 (tests:numa-test: use explicit memdev to specify node RAM) === OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]
Le 23/01/2020 à 12:37, Igor Mammedov a écrit :
Quoted 204 lines
v3:
- due to libvirt not being ready, postpone till 5.1
* [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types and depended
[PATCH v2 86/86] numa: remove deprecated implicit RAM distribution between nodes
- drop as not related "[PATCH v2 85/86] numa: makeexit()usage consistent"
- drop "[PATCH v2 76/86] post conversiondefault_ram_idcleanup"
so that default memory-backedend won't be created for boards that do not care about -m. Which makes -m optin feature. We should decide what do in case board doesn't use -m (but that's out of scope of this series)
- useobject_register_sugar_prop()instead of hacking compat props directly
- simplified/reworked aspeed patches
- s/RAM_ADDR_FMT/size_to_str()/
- rename 'ram-memdev' property to 'memory-backend'
- minor fixes to numa-test
- fixes for issues noticed during review of[PATCH v2 66/86] ppc/{ppc440_bamboo,sam460x}: drop RAM size fixupv2:
- fix compile errors on mingw32 host by introducingRAM_ADDR_UFMT[11/86]
- replace "[PATCH 43/86] hppa: drop RAM size fixup" with alternative patches made by Philippe (which effectively do the same thing but other way around)
- ppc440: fix crash and add suggested valid RAM size in error output. s/ppc4xx_sdram_adjust/ppc4xx_sdram_prep/ and simplify it by removing not necessary nested loop
- rebase on current master due to new conflictsSeries removes ad hoc RAM allocation API (
memory_region_allocate_system_memory)
and consolidates it around hostmem backend. It allows to
* resolve conflicts between global -mem-prealloc and hostmem's "policy" option fixing premature allocation before binding policy is applied
* simplify complicated memory allocation routines which had to deal with 2 ways
to allocate RAM.
* it allows to reuse hostmem backends of a choice for main RAM without adding
extra CLI options to duplicate hostmem features.
Recent case was -mem-shared, to enable vhost-user on targets that don't
support hostmem backends [1] (ex: s390)
* move RAM allocation from individual boards into generic machine code and
provide them with prepared MemoryRegion.
* clean up deprecated NUMA features which were tied to the old API (see patches)
- "numa: remove deprecated -mem-path fallback to anonymous RAM"
- (POSTPONED, waiting on libvirt side) "forbid '-numa node,mem' for 5.0 and newer machine types"
- (POSTPONED) "numa: remove deprecated implicit RAM distribution between nodes"Conversion introduces a new machine.memory-backend property and wrapper code that aliases global -mem-path and -mem-alloc into automatically created hostmem backend properties (provided memory-backend was not set explicitly given by user). And then follows bulk of trivial patches that incrementally convert individual boards to using machine.memory-backend provided MemoryRegion.
Board conversion typically involves:
* providingMachineClass::default_ram_sizeandMachineClass::default_ram_idso generic code could create default backend if user didn't explicitly provide memory-backend or -m options
* droppingmemory_region_allocate_system_memory()call
* using convenienceMachineState::ramMemoryRegion, which points to MemoryRegion allocated by ram-memdev
On top of that for some boards:
* added missingram_sizechecks (typically it were boards with fixed ram size)
*ram_sizefixups were replaced by checks and hard errors, forcing user to provide correct "-m" values instead of ignoring it and continuing running.After all boards are converted the old API is removed and memory allocation routines are cleaned up.
git tree for testing:
https://github.com/imammedo/qemuconvert_main_ram_to_memdev_v3previous rev:
https://github.com/imammedo/qemuconvert_main_ram_to_memdev_v2
https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02960.htmlIgor Mammedov (77):
numa: remove deprecated -mem-path fallback to anonymous RAM
machine: introduce memory-backend property
machine: alias -mem-path and -mem-prealloc into memory-foo backend
machine: introduce convenienceMachineState::raminitializeMachineState::ramin NUMA case
alpha:dp264: use memdev for RAM
arm/aspeed: actually check RAM size
arm/aspeed: use memdev for RAM
arm/collie: use memdev for RAM
arm/cubieboard: use memdev for RAM
arm/digic_boards: use memdev for RAM
arm/highbank: use memdev for RAM
arm/imx25_pdk: drop RAM size fixup
arm/imx25_pdk: use memdev for RAM
arm/integratorcp: use memdev for RAM
arm/kzm: drop RAM size fixup
arm/kzm: use memdev for RAM
arm/mcimx6ul-evk: use memdev for RAM
arm/mcimx7d-sabre: use memdev for RAM
arm/mps2-tz: use memdev for RAM
arm/mps2: use memdev for RAM
arm/musicpal: use memdev for RAM
arm/nseries: use memdev for RAM
arm/omap_sx1: use memdev for RAM
arm/palm: use memdev for RAM
arm/raspi: use memdev for RAM
arm/sabrelite: use memdev for RAM
arm/sbsa-ref: use memdev for RAM
arm/versatilepb: use memdev for RAM
arm/vexpress: use memdev for RAM
arm/virt: use memdev for RAM
arm/xilinx_zynq: drop RAM size fixup
arm/xilinx_zynq: use memdev for RAM arm/xlnx-versal-virt: use memdev for RAM arm/xlnx-zcu102: use memdev for RAM s390x/s390-virtio-ccw: use memdev for RAM
null-machine: use memdev for RAM
cris/axis_dev88: use memdev for RAM
hppa: use memdev for RAM
x86/microvm: use memdev for RAM
x86/pc: use memdev for RAM
lm32/lm32_boards: use memdev for RAM
lm32/milkymist: use memdev for RAM
m68k/an5206: use memdev for RAM
m68k/mcf5208: use memdev for RAM
m68k/next-cube: use memdev for RAM
mips/boston-cube: use memdev for RAM mips/mips_fulong2e: drop RAM size fixup mips/mips_fulong2e: use memdev for RAM
mips/mips_jazz: use memdev for RAM
mips/mips_malta: use memdev for RAM
mips/mips_mipssim: use memdev for RAM
mips/mips_r4k: use memdev for RAM
ppc/e500: drop RAM size fixup
ppc/e500: use memdev for RAM
ppc/mac_newworld: use memdev for RAM
ppc/mac_oldworld: use memdev for RAM
ppc/pnv: use memdev for RAM
ppc/ppc405_boards: add RAM size checks ppc/ppc405_boards: use memdev for RAM ppc/{ppc440_bamboo,sam460ex}: drop RAM size fixup ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM ppc/prep: use memdev for RAM
ppc/spapr: use memdev for RAM
ppc/virtex_ml507: remove unused arguments ppc/virtex_ml507: use memdev for RAM
sparc/leon3: use memdev for RAM
sparc/sun4m: use memdev for RAM
sparc/niagara: use memdev for RAM
remove no longer usedmemory_region_allocate_system_memory()
exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
exec: drop bogusmem_pathfromqemu_ram_alloc_from_fd()makemem_pathlocal variable
hostmem: introduce "prealloc-threads" property
hostmem: fix strict bind policy
tests:numa-test: make top level args dynamic andg_autofree(cli)
cleanups
tests:numa-test: use explicit memdev to specify node RAMPhilippe Mathieu-Daudé (3):
hw/hppa/machine: Correctly check the firmware is in PDC range hw/hppa/machine: Restrict the total memory size to 3GB hw/hppa/machine: Map the PDC memory region with higher priorityhw/alpha/alpha_sys.h | 2 +- include/hw/boards.h | 48 +++++---------- include/hw/misc/aspeed_sdmc.h | 1 + include/hw/ppc/ppc4xx.h | 9 ++- include/sysemu/hostmem.h | 20 +++++- include/sysemu/numa.h | 1 + include/sysemu/sysemu.h | 2 - backends/hostmem-file.c | 8 --- backends/hostmem-memfd.c | 1 - backends/hostmem-ram.c | 2 - backends/hostmem.c | 53 +++++++++++----- exec.c | 66 +++----------------- hw/alpha/dp264.c | 3 +- hw/alpha/typhoon.c | 8 +-- hw/arm/aspeed.c | 18 +++--- hw/arm/collie.c | 17 ++++-- hw/arm/cubieboard.c | 25 +++----- hw/arm/digic_boards.c | 40 ++++++------ hw/arm/highbank.c | 10 ++- hw/arm/imx25_pdk.c | 13 ++-- hw/arm/integratorcp.c | 9 ++- hw/arm/kzm.c | 18 +++--- hw/arm/mcimx6ul-evk.c | 25 +++----- hw/arm/mcimx7d-sabre.c | 25 +++----- hw/arm/mps2-tz.c | 15 +++-- hw/arm/mps2.c | 15 +++-- hw/arm/musicpal.c | 18 ++++-- hw/arm/nseries.c | 32 ++++++---- hw/arm/omap_sx1.c | 20 ++++-- hw/arm/palm.c | 20 ++++-- hw/arm/raspi.c | 34 ++++------- hw/arm/sabrelite.c | 23 +++---- hw/arm/sbsa-ref.c | 7 +-- hw/arm/versatilepb.c | 7 +-- hw/arm/vexpress.c | 14 ++--- hw/arm/virt.c | 7 +-- hw/arm/xilinx_zynq.c | 20 +++--- hw/arm/xlnx-versal-virt.c | 7 +-- hw/arm/xlnx-zcu102.c | 7 +-- hw/core/machine.c | 30 +++++++++ hw/core/null-machine.c | 8 +-- hw/core/numa.c | 101 +++++++++---------------------- hw/cris/axis_dev88.c | 8 +--
Quoted 8 lines
hw/hppa/machine.c | 19 +++--- hw/i386/microvm.c | 12 ++-- hw/i386/pc.c | 19 +++--- hw/lm32/lm32_boards.c | 39 ++++++++---- hw/lm32/milkymist.c | 21 ++++--- hw/m68k/an5206.c | 5 +- hw/m68k/mcf5208.c | 5 +- hw/m68k/next-cube.c | 5 +-
Could you add hw/m68k/q800.c ?
Thanks,
Laurent
[PATCH v4 81/80] m68k/q800: use memdev for RAM
Switch to using generic main RAM allocation. To do this set MachineClass::default_ram_id to m68k_mac.ram and use MachineState::ram instead of manually initializing RAM memory region.
---
CC: [email protected]
--- hw/m68k/q800.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
hw/m68k/q800.c +2 -4
@@ -160,7 +160,6 @@ static void q800_init(MachineState *machine)ram_addr_t initrd_base;int32_t initrd_size;MemoryRegion *rom; -MemoryRegion *ram;MemoryRegion *io;const int io_slice_nb = (IO_SIZE /IO_SLICE ) -1 ;int i;
@@ -194,9 +193,7 @@ static void q800_init(MachineState *machine)qemu_register_reset (main_cpu_reset, cpu);/* RAM */ - ram =g_malloc (sizeof (*ram)); -memory_region_init_ram (ram,NULL ,"m68k_mac.ram" , ram_size, &error_abort); -memory_region_add_subregion (get_system_memory (),0 , ram); +memory_region_add_subregion (get_system_memory (),0 , machine->ram);/* * Memory from IO_BASE to IO_BASE + IO_SLICE is repeated
@@ -443,6 +440,7 @@ static void q800_machine_class_init(ObjectClass *oc, void *data) mc->max_cpus =1 ; mc->is_default =0 ; mc->block_default_type =IF_SCSI ; + mc->default_ram_id ="m68k_mac.ram" ; }static const TypeInfo q800_machine_typeinfo = {
Signature · 1 line
2.7.4
Laurent Vivier
Acked-byRe: [PATCH v4 81/80] m68k/q800: use memdev for RAM
Le 23/01/2020 à 17:14, Igor Mammedov a écrit :
Quoted 5 lines
Switch to using generic main RAM allocation. To do this set
MachineClass::default_ram_idto m68k_mac.ram and useMachineState::raminstead of manually initializing RAM memory region.
Quoted 7 lines
Signed-off-by Igor Mammedov <[email protected]>---
CC: [email protected]--- hw/m68k/q800.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)