Skip to contentSkip to conversation

scsi: Delete scsi_use_blk_mq

PATCH Applied John Garry 4 participants 6 messages Feb 10, 2020 – Feb 13, 2020 SCSI

lore
Share & tools
lore

John Garry

author
#0 lore raw

PATCH 1/1 scsi: Delete scsi_use_blk_mq

Module param scsi_use_blk_mq has not been referenced for some time, so zap it.

drivers/scsi/scsi.c +0 -4
index 930e4803d888..4b9fdfab77d9 100644
@@ -764,10 +764,6 @@ MODULE_LICENSE("GPL");
 module_param(scsi_logging_level, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(scsi_logging_level, "a bit mask of logging levels");
 
-/* This should go away in the future, it doesn't do anything anymore */
-bool scsi_use_blk_mq = true;
-module_param_named(use_blk_mq, scsi_use_blk_mq, bool, S_IWUSR | S_IRUGO);
-
 static int __init init_scsi(void)
 {
 	int error;
drivers/scsi/scsi_priv.h +0 -1
index 3bff9f7aa684..25b0aaaf5ae8 100644
@@ -29,7 +29,6 @@ extern int scsi_init_hosts(void);
 extern void scsi_exit_hosts(void);
 
 /* scsi.c */
-extern bool scsi_use_blk_mq;
 int scsi_init_sense_cache(struct Scsi_Host *shost);
 void scsi_init_command(struct scsi_device *dev, struct scsi_cmnd *cmd);
 #ifdef CONFIG_SCSI_LOGGING
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · John Garry

-module_param_named(use_blk_mq, scsi_use_blk_mq, bool, S_IWUSR | S_IRUGO);

Will this change cause trouble to shell scripts that set or read this parameter (/sys/module/scsi_mod/parameters/use_blk_mq)? What will the impact be on systems where scsi_mod.use_blk_mq=Y is passed by GRUB to the kernel at boot time, e.g. because it has been set in the GRUB_CMDLINE_LINUX variable in /etc/default/grub?

Thanks,

Bart.

author
#2 lore raw
Quoted 4 lines · Bart Van Assche
Quoted 2 lines · John Garry

-module_param_named(use_blk_mq, scsi_use_blk_mq, bool, S_IWUSR | S_IRUGO);

Hi Bart,

Quoted 1 line

Will this change cause trouble to shell scripts that set or read this parameter (/sys/module/scsi_mod/parameters/use_blk_mq)?

The entry in Documentation/admin-guide/kernel-parameters.txt is gone for 2 years now.

And it is not an archaic module param, it was introduced 6 years ago. As such, I'd say that if a shell script was setup to access this parameter, then it would prob also pre-check if it exists and gracefully accept that it may not.

I will also note that there is still scsi_sysfs.c:show_use_blk_mq(), which would stay.

What will the

Quoted 1 line

impact be on systems where scsi_mod.use_blk_mq=Y is passed by GRUB to the kernel at boot time, e.g. because it has been set in the GRUB_CMDLINE_LINUX variable in /etc/default/grub?

The kernel should any params that does not recognize.

Quoted 1 line

Having said all that, I don't feel too strongly about deleting this - it's only some tidy-up.

Thanks,
John

author
#3 lore raw
Quoted 12 lines · John Garry
Quoted 4 lines · Bart Van Assche
Quoted 2 lines · John Garry

-module_param_named(use_blk_mq, scsi_use_blk_mq, bool, S_IWUSR | S_IRUGO);

Hi Bart,

Quoted 1 line

Will this change cause trouble to shell scripts that set or read this parameter (/sys/module/scsi_mod/parameters/use_blk_mq)?

The entry in Documentation/admin-guide/kernel-parameters.txt is gone for 2 years now.

Quoted 8 lines

And it is not an archaic module param, it was introduced 6 years ago. As such, I'd say that if a shell script was setup to access this parameter, then it would prob also pre-check if it exists and gracefully accept that it may not.

I will also note that there is still scsi_sysfs.c:show_use_blk_mq(), which would stay.

What will the

Quoted 1 line

impact be on systems where scsi_mod.use_blk_mq=Y is passed by GRUB to the kernel at boot time, e.g. because it has been set in the GRUB_CMDLINE_LINUX variable in /etc/default/grub?

The kernel should any params that does not recognize.

^ ignore

Quoted 9 lines
Quoted 2 lines

Having said all that, I don't feel too strongly about deleting this - it's only some tidy-up.

Thanks,
John

.

#4 lore raw
In reply to John Garry
Quoted 26 lines · John Garry
Quoted 3 lines · Bart Van Assche
Quoted 2 lines · John Garry

-module_param_named(use_blk_mq, scsi_use_blk_mq, bool, S_IWUSR | S_IRUGO);

Hi Bart,

Quoted 2 lines

Will this change cause trouble to shell scripts that set or read this parameter (/sys/module/scsi_mod/parameters/use_blk_mq)?

The entry in Documentation/admin-guide/kernel-parameters.txt is gone for 2 years now.

And it is not an archaic module param, it was introduced 6 years ago. As such, I'd say that if a shell script was setup to access this parameter, then it would prob also pre-check if it exists and gracefully accept that it may not.

I will also note that there is still scsi_sysfs.c:show_use_blk_mq(), which would stay.

What will the

Quoted 3 lines

impact be on systems where scsi_mod.use_blk_mq=Y is passed by GRUB to the kernel at boot time, e.g. because it has been set in the GRUB_CMDLINE_LINUX variable in /etc/default/grub?

Quoted 9 lines

The kernel should any params that does not recognize.

Having said all that, I don't feel too strongly about deleting this - it's only some tidy-up.

Thanks,
John

I think we should remove it. It is not good to have a kernel parameter that people used to be able to set to "N" that no longer does that.

-Ewan

#5 lore raw
In reply to John Garry

John,

Quoted 2 lines

Module param scsi_use_blk_mq has not been referenced for some time, so zap it.

Applied to 5.7/scsi-queue, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering