Skip to contentSkip to conversation

Add mt7629 pwm support

PATCH RESEND Superseded Sam Shih 2 participants 4 messages Feb 12, 2020 – May 16, 2020

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Sam Shih

author
#0 lore raw

v2 cover Add mt7629 pwm support

A gentle ping on this whole patch series

This adds pwm support for MT7629.

Change since v1:
remove unused property num-pwm

Used:
https://patchwork.kernel.org/patch/11160851/

Related dependent driver updates have been merged into maintainer's kernel source tree.

Sam Shih (1):
arm: dts: mediatek: add mt7629 pwm support

 arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH RESEND v2 1/1 arm: dts: mediatek: add mt7629 pwm support

This adds pwm support for MT7629.
Used:
https://patchwork.kernel.org/patch/11160851/

Change since v1:
remove unused property num-pwm

---
 arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/mt7629.dtsi +14 -0
index 867b88103b9d..ce2a30a24017 100644
@@ -241,6 +241,20 @@
 			status = "disabled";
 		};
 
+		pwm: pwm@11006000 {
+			compatible = "mediatek,mt7629-pwm";
+			reg = <0x11006000 0x1000>;
+			interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&topckgen CLK_TOP_PWM_SEL>,
+				 <&pericfg CLK_PERI_PWM_PD>,
+				 <&pericfg CLK_PERI_PWM1_PD>;
+			clock-names = "top", "main", "pwm1";
+			assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
+			assigned-clock-parents =
+					<&topckgen CLK_TOP_UNIVPLL2_D4>;
+			status = "disabled";
+		};
+
 		i2c: i2c@11007000 {
 			compatible = "mediatek,mt7629-i2c",
 				     "mediatek,mt2712-i2c";
Signature · 5 lines
2.17.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#2 lore raw

Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support

Quoted 1 line · Sam Shih

This adds pwm support for MT7629.

The information below should not be part of the commit message, the next time please put it below the line "---".

Quoted 23 lines

Used:
https://patchwork.kernel.org/patch/11160851/

Change since v1:
remove unused property num-pwm

---
 arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/mt7629.dtsi +4 -0
index 867b88103b9d..ce2a30a24017 100644
@@ -241,6 +241,20 @@
 			status = "disabled";
 		};
 
+		pwm: pwm@11006000 {
+			compatible = "mediatek,mt7629-pwm";
+			reg = <0x11006000 0x1000>;
+			interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;

arch/arm/boot/dts/mt7629.dtsi line 257

Quoted 10 lines
arch/arm/boot/dts/mt7629.dtsi +10 -0
+			clocks = <&topckgen CLK_TOP_PWM_SEL>,
+				 <&pericfg CLK_PERI_PWM_PD>,
+				 <&pericfg CLK_PERI_PWM1_PD>;
+			clock-names = "top", "main", "pwm1";
+			assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
+			assigned-clock-parents =
+					<&topckgen CLK_TOP_UNIVPLL2_D4>;
+			status = "disabled";
+		};
+

This does not match the binding description.
Please fix that.

Quoted 4 lines
arch/arm/boot/dts/mt7629.dtsi +0 -0
 		i2c: i2c@11007000 {
 			compatible = "mediatek,mt7629-i2c",
 				     "mediatek,mt2712-i2c";
maintainer
#3 lore raw

Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support

In reply to Sam Shih
Quoted 8 lines · Sam Shih

This adds pwm support for MT7629.
Used:
https://patchwork.kernel.org/patch/11160851/

Change since v1:
remove unused property num-pwm

Applied now to v5.7-next/dts32

Thanks!

Quoted 30 lines
---
 arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/mt7629.dtsi +14 -0
index 867b88103b9d..ce2a30a24017 100644
@@ -241,6 +241,20 @@
 			status = "disabled";
 		};
 
+		pwm: pwm@11006000 {
+			compatible = "mediatek,mt7629-pwm";
+			reg = <0x11006000 0x1000>;
+			interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&topckgen CLK_TOP_PWM_SEL>,
+				 <&pericfg CLK_PERI_PWM_PD>,
+				 <&pericfg CLK_PERI_PWM1_PD>;
+			clock-names = "top", "main", "pwm1";
+			assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
+			assigned-clock-parents =
+					<&topckgen CLK_TOP_UNIVPLL2_D4>;
+			status = "disabled";
+		};
+
 		i2c: i2c@11007000 {
 			compatible = "mediatek,mt7629-i2c",
 				     "mediatek,mt2712-i2c";