Skip to contentSkip to conversation

scsi: core: fix a typo of coding format

PATCH In review [email protected] 2 participants 2 messages Feb 15, 2020 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: core: fix a typo of coding format

From: chenqiwu <[email protected]>

Fix a typo of coding format.

---
 drivers/scsi/scsi_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_lib.c +1 -1
index 610ee41..a89cfaf 100644
@@ -1563,7 +1563,7 @@ static int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
 	}
 
 	return rtn;
- done:
+done:
 	cmd->scsi_done(cmd);
 	return 0;
 }
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · On Sat, 15 Feb 2020, [email protected] wrote:

From: chenqiwu <[email protected]>

Fix a typo of coding format.

It isn't a 'typo' as it appears to be a deliberate choice.

git grep '^ [a-z_0-9]+:$' -- drivers/scsi/

I can't find anything in Documentation/process that bans indentation of goto labels. Am I missing something? What do you gain?

If there's nothing in the style guide to mandate churn like this patch, then we might expect more churn when someone else patches the whitespace back in (for consistency, taste, fame and fortune, whatever).

Quoted 19 lines
---
 drivers/scsi/scsi_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_lib.c +1 -1
index 610ee41..a89cfaf 100644
@@ -1563,7 +1563,7 @@ static int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
 	}
 
 	return rtn;
- done:
+done:
 	cmd->scsi_done(cmd);
 	return 0;
 }