RDMA/hns: Initialize all fields of doorbells to zero
Subsystems (2)
PATCH 1/1 RDMA/hns: Initialize all fields of doorbells to zero
From: Lang Cheng <[email protected]>
Prevent uninitialized fields when new fields are added, and make code look simpler.
Signed-off-by Lang Cheng <[email protected]>
Signed-off-by Weihang Li <[email protected]>
--- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 9 ++------- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 5 +---- 2 files changed, 3 insertions(+), 11 deletions(-)
drivers/infiniband/hw/hns/hns_roce_hw_v1.c +2 -7
@@ -69,7 +69,7 @@ static int hns_roce_v1_post_send(struct ib_qp *ibqp,struct hns_roce_wqe_data_seg *dseg =NULL ;struct hns_roce_qp *qp =to_hr_qp (ibqp);struct device *dev = &hr_dev->pdev->dev; -struct hns_roce_sq_db sq_db; +struct hns_roce_sq_db sq_db = {};int ps_opcode =0 , i =0 ;unsigned long flags =0 ;void *wqe =NULL ;
@@ -318,8 +318,6 @@ static int hns_roce_v1_post_send(struct ib_qp *ibqp,/* Memory barrier */ wmb (); - sq_db.u32_4 =0 ; - sq_db.u32_8 =0 ;roce_set_field (sq_db.u32_4,SQ_DOORBELL_U32_4_SQ_HEAD_M ,SQ_DOORBELL_U32_4_SQ_HEAD_S , (qp->sq.head & ((qp->sq.wqe_cnt <<1 ) -1 )));
@@ -351,7 +349,7 @@ static int hns_roce_v1_post_recv(struct ib_qp *ibqp,struct hns_roce_qp *hr_qp =to_hr_qp (ibqp);struct hns_roce_dev *hr_dev =to_hr_dev (ibqp->device);struct device *dev = &hr_dev->pdev->dev; -struct hns_roce_rq_db rq_db; +struct hns_roce_rq_db rq_db = {};__le32 doorbell[2 ] = {0 };unsigned long flags =0 ;unsigned int wqe_idx;
@@ -418,9 +416,6 @@ static int hns_roce_v1_post_recv(struct ib_qp *ibqp,ROCEE_QP1C_CFG3_0_REG + QP1C_CFGN_OFFSET * hr_qp->phy_port, reg_val); }else { - rq_db.u32_4 =0 ; - rq_db.u32_8 =0 ; -roce_set_field (rq_db.u32_4,RQ_DOORBELL_U32_4_RQ_HEAD_M ,RQ_DOORBELL_U32_4_RQ_HEAD_S , hr_qp->rq.head);
drivers/infiniband/hw/hns/hns_roce_hw_v2.c +1 -4
@@ -260,7 +260,7 @@ static int hns_roce_v2_post_send(struct ib_qp *ibqp,struct hns_roce_qp *qp =to_hr_qp (ibqp);struct hns_roce_wqe_frmr_seg *fseg;struct device *dev = hr_dev->dev; -struct hns_roce_v2_db sq_db; +struct hns_roce_v2_db sq_db = {};struct ib_qp_attr attr;unsigned int owner_bit;unsigned int sge_idx;
@@ -590,9 +590,6 @@ static int hns_roce_v2_post_send(struct ib_qp *ibqp,/* Memory barrier */ wmb (); - sq_db.byte_4 =0 ; - sq_db.parameter =0 ; -roce_set_field (sq_db.byte_4,V2_DB_BYTE_4_TAG_M ,V2_DB_BYTE_4_TAG_S , qp->doorbell_qpn); roce_set_field(sq_db.byte_4, V2_DB_BYTE_4_CMD_M,
Signature · 1 line
2.8.1
Quoted 11 lines · Weihang Li
From: Lang Cheng <[email protected]>
Prevent uninitialized fields when new fields are added, and make code look simpler.
Signed-off-by Lang Cheng <[email protected]>Signed-off-by Weihang Li <[email protected]>--- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 9 ++------- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 5 +---- 2 files changed, 3 insertions(+), 11 deletions(-)
This doesn't apply, please resend
Jason
Quoted 13 lines · Jason Gunthorpe
Quoted 11 lines · Weihang Li
From: Lang Cheng <[email protected]>
Prevent uninitialized fields when new fields are added, and make code look simpler.
Signed-off-by Lang Cheng <[email protected]>Signed-off-by Weihang Li <[email protected]>--- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 9 ++------- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 5 +---- 2 files changed, 3 insertions(+), 11 deletions(-)
Quoted 5 lines
This doesn't apply, please resend
Jason
OK, will resend, thank you.
Weihang