Skip to contentSkip to conversation

PATCH David Howells 1 participant 1 message Apr 21, 2023

Subsystems (2)
lore
Share & tools
lore

David Howells

author maintainer
#0 lore raw

Hi Linus,

Can you apply this, please? It can probably wait for the merge window if you don't want to apply it now as it only affects building the kernel.

Thanks,
David
---
From: Ekaterina Orlova <[email protected]>

ASN.1: Fix check for strdup() success

It seems there is a misprint in the check of strdup() return code that can lead to NULL pointer dereference.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes 4520c6a49af8 ("X.509: Add simple ASN.1 grammar compiler")
cc David Woodhouse <[email protected]>
cc James Bottomley <[email protected]>
cc Jarkko Sakkinen <[email protected]>
---
 scripts/asn1_compiler.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/asn1_compiler.c +1 -1
index 7b6756a8c15d..4c3f645065a4 100644
@@ -625,7 +625,7 @@ int main(int argc, char **argv)
 	p = strrchr(argv[1], '/');
 	p = p ? p + 1 : argv[1];
 	grammar_name = strdup(p);
-	if (!p) {
+	if (!grammar_name) {
 		perror(NULL);
 		exit(1);
 	}