Skip to contentSkip to conversation

net/vmxnet3: fix RSS setting on v4

PATCH Superseded Eduard Serra Miralles 3 participants 8 messages Aug 21, 2019 – Mar 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/vmxnet3: fix RSS setting on v4

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.
- An additional check has been added to dodge RSS configuration altogether unless MQ_RSS has been requested, similar to v3.

The alternative (returning error) was considered, the intent is to ease the task of setting up and running vmxnet3 in situations where it's supposted to be most strightforward (testpmd, pktgen).

---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-
 drivers/net/vmxnet3/vmxnet3_ethdev.h | 4 ++++
 drivers/net/vmxnet3/vmxnet3_rxtx.c   | 8 ++++++++
 3 files changed, 14 insertions(+), 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_ethdev.c +2 -1
index 57feb37..0a7047e 100644
@@ -769,7 +769,8 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
 		PMD_INIT_LOG(DEBUG, "Failed to setup memory region\n");
 	}
 
-	if (VMXNET3_VERSION_GE_4(hw)) {
+	if (VMXNET3_VERSION_GE_4(hw) &&
+	    dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
 		/* Check for additional RSS  */
 		ret = vmxnet3_v4_rss_configure(dev);
 		if (ret != VMXNET3_SUCCESS) {
drivers/net/vmxnet3/vmxnet3_ethdev.h +4 -0
index 8c2b6f8..6e3ce7d 100644
@@ -38,6 +38,10 @@
 	ETH_RSS_NONFRAG_IPV4_UDP | \
 	ETH_RSS_NONFRAG_IPV6_UDP)
 
+#define VMXNET3_MANDATORY_V4_RSS ( \
+	ETH_RSS_NONFRAG_IPV4_TCP | \
+	ETH_RSS_NONFRAG_IPV6_TCP)
+
 /* RSS configuration structure - shared with device through GPA */
 typedef struct VMXNET3_RSSConf {
 	uint16_t   hashType;
drivers/net/vmxnet3/vmxnet3_rxtx.c +8 -0
index 7794d74..dd99684 100644
@@ -1311,6 +1311,14 @@ vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)
 
 	cmdInfo->setRSSFields = 0;
 	port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
+
+	if ((port_rss_conf->rss_hf & VMXNET3_MANDATORY_V4_RSS) !=
+	    VMXNET3_MANDATORY_V4_RSS) {
+		PMD_INIT_LOG(WARNING, "RSS: IPv4/6 TCP is required for vmxnet3 v4 RSS,"
+			     "automatically setting it");
+		port_rss_conf->rss_hf |= VMXNET3_MANDATORY_V4_RSS;
+	}
+
 	rss_hf = port_rss_conf->rss_hf &
 		(VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);
 
Signature · 1 line
2.7.4
#1 lore raw

-----Original Message-----
From: Eduard Serra Miralles <[email protected]>
Date: Wednesday, August 21, 2019 at 9:37 AM
To: Yong Wang <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: [PATCH] net/vmxnet3: fix RSS setting on v4

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.

Why we are enforcing TCP RSS? I would think it's up to the user to decide what to request based on their specific needs and we should support RSS even when it does not request TCP RSS.

    - An additional check has been added to dodge RSS configuration
    altogether unless MQ_RSS has been requested, similar to v3.
    
    The alternative (returning error) was considered, the intent
    is to ease the task of setting up and running vmxnet3 in situations
    where it's supposted to be most strightforward (testpmd, pktgen).
    
    Signed-off-by: Eduard Serra <[email protected]>
    ---
     drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-
     drivers/net/vmxnet3/vmxnet3_ethdev.h | 4 ++++
     drivers/net/vmxnet3/vmxnet3_rxtx.c   | 8 ++++++++
     3 files changed, 14 insertions(+), 1 deletion(-)
    
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 57feb37..0a7047e 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -769,7 +769,8 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
     		PMD_INIT_LOG(DEBUG, "Failed to setup memory region\n");
     	}
     
    -	if (VMXNET3_VERSION_GE_4(hw)) {
    +	if (VMXNET3_VERSION_GE_4(hw) &&
    +	    dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
     		/* Check for additional RSS  */
     		ret = vmxnet3_v4_rss_configure(dev);
     		if (ret != VMXNET3_SUCCESS) {
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h
    index 8c2b6f8..6e3ce7d 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.h
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h
    @@ -38,6 +38,10 @@
     	ETH_RSS_NONFRAG_IPV4_UDP | \
     	ETH_RSS_NONFRAG_IPV6_UDP)
     
    +#define VMXNET3_MANDATORY_V4_RSS ( \
    +	ETH_RSS_NONFRAG_IPV4_TCP | \
    +	ETH_RSS_NONFRAG_IPV6_TCP)
    +
     /* RSS configuration structure - shared with device through GPA */
     typedef struct VMXNET3_RSSConf {
     	uint16_t   hashType;
    diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    index 7794d74..dd99684 100644
    --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
    +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    @@ -1311,6 +1311,14 @@ vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)
     
     	cmdInfo->setRSSFields = 0;
     	port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
    +
    +	if ((port_rss_conf->rss_hf & VMXNET3_MANDATORY_V4_RSS) !=
    +	    VMXNET3_MANDATORY_V4_RSS) {
    +		PMD_INIT_LOG(WARNING, "RSS: IPv4/6 TCP is required for vmxnet3 v4 RSS,"
    +			     "automatically setting it");
    +		port_rss_conf->rss_hf |= VMXNET3_MANDATORY_V4_RSS;
    +	}
    +
     	rss_hf = port_rss_conf->rss_hf &
     		(VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);
     
    -- 
    2.7.4
#2 lore raw

I think so too. Apparently however, ESX is mandatorily expecting that underneath. If not set, config will fail.

________________________________
From: Yong Wang <[email protected]>
Sent: Friday, September 13, 2019 11:44:38 AM
To: Eduard Serra Miralles <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] net/vmxnet3: fix RSS setting on v4

-----Original Message-----
From: Eduard Serra Miralles <[email protected]>
Date: Wednesday, August 21, 2019 at 9:37 AM
To: Yong Wang <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: [PATCH] net/vmxnet3: fix RSS setting on v4

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.

Why we are enforcing TCP RSS? I would think it's up to the user to decide what to request based on their specific needs and we should support RSS even when it does not request TCP RSS.

    - An additional check has been added to dodge RSS configuration
    altogether unless MQ_RSS has been requested, similar to v3.

    The alternative (returning error) was considered, the intent
    is to ease the task of setting up and running vmxnet3 in situations
    where it's supposted to be most strightforward (testpmd, pktgen).

    Signed-off-by: Eduard Serra <[email protected]>
    ---
     drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-
     drivers/net/vmxnet3/vmxnet3_ethdev.h | 4 ++++
     drivers/net/vmxnet3/vmxnet3_rxtx.c   | 8 ++++++++
     3 files changed, 14 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 57feb37..0a7047e 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -769,7 +769,8 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
                 PMD_INIT_LOG(DEBUG, "Failed to setup memory region\n");
         }

    -   if (VMXNET3_VERSION_GE_4(hw)) {
    +   if (VMXNET3_VERSION_GE_4(hw) &&
    +       dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
                 /* Check for additional RSS  */
                 ret = vmxnet3_v4_rss_configure(dev);
                 if (ret != VMXNET3_SUCCESS) {
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h
    index 8c2b6f8..6e3ce7d 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.h
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h
    @@ -38,6 +38,10 @@
         ETH_RSS_NONFRAG_IPV4_UDP | \
         ETH_RSS_NONFRAG_IPV6_UDP)

    +#define VMXNET3_MANDATORY_V4_RSS ( \
    +   ETH_RSS_NONFRAG_IPV4_TCP | \
    +   ETH_RSS_NONFRAG_IPV6_TCP)
    +
     /* RSS configuration structure - shared with device through GPA */
     typedef struct VMXNET3_RSSConf {
         uint16_t   hashType;
    diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    index 7794d74..dd99684 100644
    --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
    +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    @@ -1311,6 +1311,14 @@ vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)

         cmdInfo->setRSSFields = 0;
         port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
    +
    +   if ((port_rss_conf->rss_hf & VMXNET3_MANDATORY_V4_RSS) !=
    +       VMXNET3_MANDATORY_V4_RSS) {
    +           PMD_INIT_LOG(WARNING, "RSS: IPv4/6 TCP is required for vmxnet3 v4 RSS,"
    +                        "automatically setting it");
    +           port_rss_conf->rss_hf |= VMXNET3_MANDATORY_V4_RSS;
    +   }
    +
         rss_hf = port_rss_conf->rss_hf &
                 (VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);

    --
    2.7.4
Acked-by
#3 lore raw

From: Eduard Serra Miralles <[email protected]>
Date: Friday, September 13, 2019 at 1:10 PM
To: Yong Wang <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: RE: [PATCH] net/vmxnet3: fix RSS setting on v4

I think so too. Apparently however, ESX is mandatorily expecting that underneath. If not set, config will fail.

________________________________
From: Yong Wang <[email protected]>
Sent: Friday, September 13, 2019 11:44:38 AM
To: Eduard Serra Miralles <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] net/vmxnet3: fix RSS setting on v4

-----Original Message-----
From: Eduard Serra Miralles <[email protected]>
Date: Wednesday, August 21, 2019 at 9:37 AM
To: Yong Wang <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: [PATCH] net/vmxnet3: fix RSS setting on v4

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.

Why we are enforcing TCP RSS? I would think it's up to the user to decide what to request based on their specific needs and we should support RSS even when it does not request TCP RSS.

- An additional check has been added to dodge RSS configuration altogether unless MQ_RSS has been requested, similar to v3.

The alternative (returning error) was considered, the intent is to ease the task of setting up and running vmxnet3 in situations where it's supposted to be most strightforward (testpmd, pktgen).

---

     drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-
     drivers/net/vmxnet3/vmxnet3_ethdev.h | 4 ++++
     drivers/net/vmxnet3/vmxnet3_rxtx.c   | 8 ++++++++
     3 files changed, 14 insertions(+), 1 deletion(-)
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 57feb37..0a7047e 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -769,7 +769,8 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
                 PMD_INIT_LOG(DEBUG, "Failed to setup memory region\n");
         }

    -   if (VMXNET3_VERSION_GE_4(hw)) {
    +   if (VMXNET3_VERSION_GE_4(hw) &&
    +       dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
                 /* Check for additional RSS  */
                 ret = vmxnet3_v4_rss_configure(dev);
                 if (ret != VMXNET3_SUCCESS) {
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h
    index 8c2b6f8..6e3ce7d 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.h
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h
    @@ -38,6 +38,10 @@
         ETH_RSS_NONFRAG_IPV4_UDP | \
         ETH_RSS_NONFRAG_IPV6_UDP)

    +#define VMXNET3_MANDATORY_V4_RSS ( \
    +   ETH_RSS_NONFRAG_IPV4_TCP | \
    +   ETH_RSS_NONFRAG_IPV6_TCP)
    +
     /* RSS configuration structure - shared with device through GPA */
     typedef struct VMXNET3_RSSConf {
         uint16_t   hashType;
    diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    index 7794d74..dd99684 100644
    --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
    +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    @@ -1311,6 +1311,14 @@ vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)

         cmdInfo->setRSSFields = 0;
         port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
    +
    +   if ((port_rss_conf->rss_hf & VMXNET3_MANDATORY_V4_RSS) !=
    +       VMXNET3_MANDATORY_V4_RSS) {
    +           PMD_INIT_LOG(WARNING, "RSS: IPv4/6 TCP is required for vmxnet3 v4 RSS,"
    +                        "automatically setting it");
    +           port_rss_conf->rss_hf |= VMXNET3_MANDATORY_V4_RSS;
    +   }
    +
         rss_hf = port_rss_conf->rss_hf &
                 (VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);

    --
    2.7.4
#4 lore raw
Quoted 41 lines · Yong Wang

From: Eduard Serra Miralles <[email protected]>
Date: Friday, September 13, 2019 at 1:10 PM
To: Yong Wang <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: RE: [PATCH] net/vmxnet3: fix RSS setting on v4

I think so too. Apparently however, ESX is mandatorily expecting that underneath. If not set, config will fail.

________________________________
From: Yong Wang <[email protected]>
Sent: Friday, September 13, 2019 11:44:38 AM
To: Eduard Serra Miralles <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] net/vmxnet3: fix RSS setting on v4

-----Original Message-----
From: Eduard Serra Miralles <[email protected]>
Date: Wednesday, August 21, 2019 at 9:37 AM
To: Yong Wang <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: [PATCH] net/vmxnet3: fix RSS setting on v4

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.

Why we are enforcing TCP RSS? I would think it's up to the user to decide what to request based on their specific needs and we should support RSS even when it does not request TCP RSS.

- An additional check has been added to dodge RSS configuration altogether unless MQ_RSS has been requested, similar to v3.

Quoted 7 lines

The alternative (returning error) was considered, the intent is to ease the task of setting up and running vmxnet3 in situations where it's supposted to be most strightforward (testpmd, pktgen).

---

Sorry I missed your ack here, since it was not quoted patchwork also missed it.

Eduard,
Can you please provide a Fixes tag, that will be useful to backport fix to the stable trees?

Thanks,
ferruh

#5 lore raw

PATCH v2 1/1 net/vmxnet3: fix RSS setting on v4

In reply to Eduard Serra Miralles

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.
- An additional check has been added to dodge RSS configuration altogether unless MQ_RSS has been requested, similar to v3.

The alternative (returning error) was considered, the intent is to ease the task of setting up and running vmxnet3 in situations where it's supposted to be most strightforward (testpmd, pktgen).

---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-
 drivers/net/vmxnet3/vmxnet3_ethdev.h | 4 ++++
 drivers/net/vmxnet3/vmxnet3_rxtx.c   | 8 ++++++++
 3 files changed, 14 insertions(+), 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_ethdev.c +2 -1
index 6e6efa9..705e976 100644
@@ -771,7 +771,8 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
 		PMD_INIT_LOG(DEBUG, "Failed to setup memory region\n");
 	}
 
-	if (VMXNET3_VERSION_GE_4(hw)) {
+	if (VMXNET3_VERSION_GE_4(hw) &&
+	    dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
 		/* Check for additional RSS  */
 		ret = vmxnet3_v4_rss_configure(dev);
 		if (ret != VMXNET3_SUCCESS) {
drivers/net/vmxnet3/vmxnet3_ethdev.h +4 -0
index 8c2b6f8..dd685b0 100644
@@ -38,6 +38,10 @@
 	ETH_RSS_NONFRAG_IPV4_UDP | \
 	ETH_RSS_NONFRAG_IPV6_UDP)
 
+#define VMXNET3_MANDATORY_V4_RSS ( \
+	ETH_RSS_NONFRAG_IPV4_TCP | \
+	ETH_RSS_NONFRAG_IPV6_TCP)
+
 /* RSS configuration structure - shared with device through GPA */
 typedef struct VMXNET3_RSSConf {
 	uint16_t   hashType;
drivers/net/vmxnet3/vmxnet3_rxtx.c +8 -0
index 7794d74..dd99684 100644
@@ -1311,6 +1311,14 @@ vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)
 
 	cmdInfo->setRSSFields = 0;
 	port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
+
+	if ((port_rss_conf->rss_hf & VMXNET3_MANDATORY_V4_RSS) !=
+	    VMXNET3_MANDATORY_V4_RSS) {
+		PMD_INIT_LOG(WARNING, "RSS: IPv4/6 TCP is required for vmxnet3 v4 RSS,"
+			     "automatically setting it");
+		port_rss_conf->rss_hf |= VMXNET3_MANDATORY_V4_RSS;
+	}
+
 	rss_hf = port_rss_conf->rss_hf &
 		(VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);
 
Signature · 1 line
2.7.4
#6 lore raw

PATCH v3 1/1 net/vmxnet3: fix RSS setting on v4

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.
- An additional check has been added to dodge RSS configuration altogether unless MQ_RSS has been requested, similar to v3.

The alternative (returning error) was considered, the intent is to ease the task of setting up and running vmxnet3 in situations where it's supposted to be most strightforward (testpmd, pktgen).

Open bug for this:
https://bugs.dpdk.org/show_bug.cgi?id=400

Fixes 643fba770705 ("net/vmxnet3: v4 boot and guest UDP RSS configuration")
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-
 drivers/net/vmxnet3/vmxnet3_ethdev.h | 4 ++++
 drivers/net/vmxnet3/vmxnet3_rxtx.c   | 8 ++++++++
 3 files changed, 14 insertions(+), 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_ethdev.c +2 -1
index 6e6efa9..705e976 100644
@@ -771,7 +771,8 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
 		PMD_INIT_LOG(DEBUG, "Failed to setup memory region\n");
 	}
 
-	if (VMXNET3_VERSION_GE_4(hw)) {
+	if (VMXNET3_VERSION_GE_4(hw) &&
+	    dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
 		/* Check for additional RSS  */
 		ret = vmxnet3_v4_rss_configure(dev);
 		if (ret != VMXNET3_SUCCESS) {
drivers/net/vmxnet3/vmxnet3_ethdev.h +4 -0
index 8c2b6f8..dd685b0 100644
@@ -38,6 +38,10 @@
 	ETH_RSS_NONFRAG_IPV4_UDP | \
 	ETH_RSS_NONFRAG_IPV6_UDP)
 
+#define VMXNET3_MANDATORY_V4_RSS ( \
+	ETH_RSS_NONFRAG_IPV4_TCP | \
+	ETH_RSS_NONFRAG_IPV6_TCP)
+
 /* RSS configuration structure - shared with device through GPA */
 typedef struct VMXNET3_RSSConf {
 	uint16_t   hashType;
drivers/net/vmxnet3/vmxnet3_rxtx.c +8 -0
index 7794d74..dd99684 100644
@@ -1311,6 +1311,14 @@ vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)
 
 	cmdInfo->setRSSFields = 0;
 	port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
+
+	if ((port_rss_conf->rss_hf & VMXNET3_MANDATORY_V4_RSS) !=
+	    VMXNET3_MANDATORY_V4_RSS) {
+		PMD_INIT_LOG(WARNING, "RSS: IPv4/6 TCP is required for vmxnet3 v4 RSS,"
+			     "automatically setting it");
+		port_rss_conf->rss_hf |= VMXNET3_MANDATORY_V4_RSS;
+	}
+
 	rss_hf = port_rss_conf->rss_hf &
 		(VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);
 
Signature · 1 line
2.7.4
Applied
#7 lore raw
Quoted 14 lines · Eduard Serra Miralles

When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning message is thrown to make sure we warn the application we are setting IPv4/6 TCP RSS when not set.
- An additional check has been added to dodge RSS configuration altogether unless MQ_RSS has been requested, similar to v3.

The alternative (returning error) was considered, the intent is to ease the task of setting up and running vmxnet3 in situations where it's supposted to be most strightforward (testpmd, pktgen).

Quoted 6 lines

Open bug for this:
https://bugs.dpdk.org/show_bug.cgi?id=400

Fixes 643fba770705 ("net/vmxnet3: v4 boot and guest UDP RSS configuration")

Bugzilla ID: 400

Fixes 643fba770705 ("net/vmxnet3: add v4 boot and guest UDP RSS config")

Applied to dpdk-next-net/master, thanks.