Skip to contentSkip to conversation

Added critical trip point Thermal-zones node

PATCH In review Rajeshwari 2 participants 3 messages Mar 4, 2020 – Mar 5, 2020

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support
lore
Share & tools
lore

Rajeshwari

author
#0 lore raw

cover Added critical trip point Thermal-zones node

Changes:
* Added critical trip point to all non CPU sensors.

Rajeshwari (1):
arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node

 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#1 lore raw

PATCH 1/1 arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node

To enable kernel critical shutdown feature added critical trip point to all non CPU sensors to perform shutdown in orderly manner.

Signed-off-by Rajeshwari <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +78 -0
index b8a72cf..7e5f14f 100644
@@ -1956,6 +1956,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				aoss0_crit: aoss0_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2011,6 +2017,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				gpuss0_crit: gpuss0_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2026,6 +2038,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				gpuss1_crit: gpuss1_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2041,6 +2059,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				aoss1_crit: aoss1_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2056,6 +2080,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				cwlan_crit: cwlan_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2071,6 +2101,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				audio_crit: audio_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2086,6 +2122,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				ddr_crit: ddr_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2101,6 +2143,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				q6_hvx_crit: q6_hvx_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2116,6 +2164,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				camera_crit: camera_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2131,6 +2185,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				mdm_crit: mdm_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2146,6 +2206,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				mdm_dsp_crit: mdm_dsp_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2161,6 +2227,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				npu_crit: npu_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 

@@ -2176,6 +2248,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				video_crit: video_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 	};
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
#2 lore raw

Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node

Quoted 1 line · Rajeshwari

To enable kernel critical shutdown feature added critical trip point to

s/added/add/
s/point/points/

Quoted 4 lines

all non CPU sensors to perform shutdown in orderly manner.

Signed-off-by Rajeshwari <[email protected]>

---

No need to provide a cover-letter for a single patch.

Quoted 8 lines
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index b8a72cf..7e5f14f 100644

arch/arm64/boot/dts/qcom/sc7180.dtsi line 1964

Quoted 9 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +6 -0
@@ -1956,6 +1956,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				aoss0_crit: aoss0_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };

The indentation of all but the initial line is off. Same with below hunks as well. Please correct this.

Regards,
Bjorn