Skip to contentSkip to conversation

build: mention -march in pkg-config description

PATCH Applied Luca Boccassi 4 participants 4 messages Jan 10, 2019 – Jan 28, 2019 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: mention -march in pkg-config description

Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers.

This might cause problems, especially in distributions, so add a note in the pkg-config description.

Fixes a25a650be5f0 ("build: add infrastructure for meson and ninja builds")

---
At the moment there are no adversely affected applications in Debian and Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder are stand-alone DPDK-specific binaries), but we thought that having an explicit notice would be good.

 meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meson.build +3 -1
index f87dc235f..35126106a 100644
@@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
 	libraries: dpdk_libraries,
 	libraries_private: dpdk_drivers + dpdk_static_libraries +
 			['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
-	description: 'The Data Plane Development Kit (DPDK)',
+	description: '''The Data Plane Development Kit (DPDK).
+Note that CFLAGS might contain an -march flag higher than typical baseline.
+This is required for a number of static inline functions in the public headers.''',
 	subdirs: [get_option('include_subdir_arch'), '.'],
 	extra_cflags: ['-include', 'rte_config.h'] + machine_args
 )
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 41 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Luca Boccassi
Sent: Friday, January 11, 2019 1:28 AM
To: [email protected]
Cc: [email protected]; [email protected]; Luca Boccassi <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config description

Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers.

This might cause problems, especially in distributions, so add a note in the pkg-config description.

Fixes a25a650be5f0 ("build: add infrastructure for meson and ninja builds")

---
At the moment there are no adversely affected applications in Debian and Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder are stand-alone DPDK-specific binaries), but we thought that having an explicit notice would be good.

 meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meson.build +3 -1
index f87dc235f..35126106a 100644
@@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
 libraries: dpdk_libraries,
 libraries_private: dpdk_drivers + dpdk_static_libraries +
 ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
-description: 'The Data Plane Development Kit (DPDK)',
+description: '''The Data Plane Development Kit (DPDK).
+Note that CFLAGS might contain an -march flag higher than typical baseline.
+This is required for a number of static inline functions in the public
Quoted 1 line

From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.

Quoted 6 lines

headers.''',
subdirs: [get_option('include_subdir_arch'), '.'],
extra_cflags: ['-include', 'rte_config.h'] + machine_args )
--
2.20.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

#2 lore raw
Quoted 42 lines · Gavin Hu (Arm Technology China)
Quoted 34 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Luca Boccassi
Sent: Friday, January 11, 2019 1:28 AM
To: [email protected]
Cc: [email protected]; [email protected]; Luca Boccassi <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config description

Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers.

This might cause problems, especially in distributions, so add a note in the pkg-config description.

Fixes a25a650be5f0 ("build: add infrastructure for meson and ninja builds")

---
At the moment there are no adversely affected applications in Debian and Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder are stand-alone DPDK-specific binaries), but we thought that having an explicit notice would be good.

 meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meson.build +0 -0
index f87dc235f..35126106a 100644

meson.build pkg.generate(name: meson.project_name(), · line 88

Quoted 7 lines
meson.build +3 -1
@@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
 libraries: dpdk_libraries,
 libraries_private: dpdk_drivers + dpdk_static_libraries +
 ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
-description: 'The Data Plane Development Kit (DPDK)',
+description: '''The Data Plane Development Kit (DPDK).
+Note that CFLAGS might contain an -march flag higher than typical baseline.
+This is required for a number of static inline functions in the public

From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.

Quoted 2 lines

No objection from me for more documentation.

#3 lore raw
Quoted 29 lines
Quoted 27 lines
Quoted 19 lines

Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers.

This might cause problems, especially in distributions, so add a note in the pkg-config description.

Fixes a25a650be5f0 ("build: add infrastructure for meson and ninja builds")

---
At the moment there are no adversely affected applications in Debian and Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder are stand-alone DPDK-specific binaries), but we thought that having an explicit notice would be good.

meson.build pkg.generate(name: meson.project_name(), · line 88

Quoted 7 lines
meson.build +3 -1
@@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
 libraries: dpdk_libraries,
 libraries_private: dpdk_drivers + dpdk_static_libraries +
 ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
-description: 'The Data Plane Development Kit (DPDK)',
+description: '''The Data Plane Development Kit (DPDK).
+Note that CFLAGS might contain an -march flag higher than typical baseline.
+This is required for a number of static inline functions in the public

From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.

Quoted 2 lines
Quoted 3 lines

No objection from me for more documentation.

Applied, thanks