Skip to contentSkip to conversation

pwm: tegra: Add support for Tegra194

PATCH In review Sandipan Patra 5 participants 5 messages Mar 5, 2020 – Mar 23, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pwm: tegra: Add support for Tegra194

Tegra194 has multiple PWM controllers with each having only one output.

Also the maxmimum frequency is higher than earlier SoCs.

Add support for Tegra194 and specify the number of PWM outputs and maximum supported frequency using device tree match data.

---
 Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 1 +
 drivers/pwm/pwm-tegra.c                                      | 6 ++++++
 2 files changed, 7 insertions(+)
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +1 -0
index 0a69ead..74c41e3 100644
@@ -9,6 +9,7 @@ Required properties:
   - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132
   - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210
   - "nvidia,tegra186-pwm": for Tegra186
+  - "nvidia,tegra194-pwm": for Tegra194
 - reg: physical base address and length of the controller's registers
 - #pwm-cells: should be 2. See pwm.yaml in this directory for a description of
   the cells format.
drivers/pwm/pwm-tegra.c +6 -0
index aa12fb3..d26ed8f 100644
@@ -282,9 +282,15 @@ static const struct tegra_pwm_soc tegra186_pwm_soc = {
 	.max_frequency = 102000000UL,
 };
 
+static const struct tegra_pwm_soc tegra194_pwm_soc = {
+	.num_channels = 1,
+	.max_frequency = 408000000UL,
+};
+
 static const struct of_device_id tegra_pwm_of_match[] = {
 	{ .compatible = "nvidia,tegra20-pwm", .data = &tegra20_pwm_soc },
 	{ .compatible = "nvidia,tegra186-pwm", .data = &tegra186_pwm_soc },
+	{ .compatible = "nvidia,tegra194-pwm", .data = &tegra194_pwm_soc },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, tegra_pwm_of_match);
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Sandipan Patra

Tegra194 has multiple PWM controllers with each having only one output.

Also the maxmimum frequency is higher than earlier SoCs.

Add support for Tegra194 and specify the number of PWM outputs and maximum supported frequency using device tree match data.

Looks good to me,

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Acked-by on v1 1/1
#2 lore raw
In reply to Sandipan Patra
Quoted 19 lines · Sandipan Patra

Tegra194 has multiple PWM controllers with each having only one output.

Also the maxmimum frequency is higher than earlier SoCs.

Add support for Tegra194 and specify the number of PWM outputs and maximum supported frequency using device tree match data.

---
  Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 1 +
  drivers/pwm/pwm-tegra.c                                      | 6 ++++++
  2 files changed, 7 insertions(+)
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +0 -0
index 0a69ead..74c41e3 100644

Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt Required properties: · line 15

Quoted 7 lines
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +1 -0
@@ -9,6 +9,7 @@ Required properties:
    - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132
    - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210
    - "nvidia,tegra186-pwm": for Tegra186
+  - "nvidia,tegra194-pwm": for Tegra194
  - reg: physical base address and length of the controller's registers
  - #pwm-cells: should be 2. See pwm.yaml in this directory for a description of
    the cells format.
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Sandipan Patra
Quoted 4 lines · Sandipan Patra

Tegra194 has multiple PWM controllers with each having only one output.

Also the maxmimum frequency is higher than earlier SoCs.

Quoted 9 lines

Add support for Tegra194 and specify the number of PWM outputs and maximum supported frequency using device tree match data.

---
 Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 1 +
 drivers/pwm/pwm-tegra.c                                      | 6 ++++++
 2 files changed, 7 insertions(+)
maintainer Acked-by on v1 1/1
#4 lore raw
In reply to Sandipan Patra
Quoted 36 lines · Sandipan Patra

Tegra194 has multiple PWM controllers with each having only one output.

Also the maxmimum frequency is higher than earlier SoCs.

Add support for Tegra194 and specify the number of PWM outputs and maximum supported frequency using device tree match data.

---
 Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 1 +
 drivers/pwm/pwm-tegra.c                                      | 6 ++++++
 2 files changed, 7 insertions(+)
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +1 -0
index 0a69ead..74c41e3 100644
@@ -9,6 +9,7 @@ Required properties:
   - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132
   - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210
   - "nvidia,tegra186-pwm": for Tegra186
+  - "nvidia,tegra194-pwm": for Tegra194
 - reg: physical base address and length of the controller's registers
 - #pwm-cells: should be 2. See pwm.yaml in this directory for a description of
   the cells format.
drivers/pwm/pwm-tegra.c +2 -0
index aa12fb3..d26ed8f 100644
@@ -282,9 +282,15 @@ static const struct tegra_pwm_soc tegra186_pwm_soc = {
 	.max_frequency = 102000000UL,
 };
 
+static const struct tegra_pwm_soc tegra194_pwm_soc = {
+	.num_channels = 1,

drivers/pwm/pwm-tegra.c static const struct tegra_pwm_soc tegra186_pwm_soc = { · line 296

Quoted 10 lines
drivers/pwm/pwm-tegra.c +4 -0
+	.max_frequency = 408000000UL,
+};
+
 static const struct of_device_id tegra_pwm_of_match[] = {
 	{ .compatible = "nvidia,tegra20-pwm", .data = &tegra20_pwm_soc },
 	{ .compatible = "nvidia,tegra186-pwm", .data = &tegra186_pwm_soc },
+	{ .compatible = "nvidia,tegra194-pwm", .data = &tegra194_pwm_soc },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, tegra_pwm_of_match);

Cheers
Jon

Signature · 1 line
nvpublic