Skip to contentSkip to conversation

mm/filemap.c: Remove unused argument from shrink_readahead_size_eio()

PATCH Applied Souptick Joarder 1 participant 1 message Mar 10, 2020

Subsystems (2)
Memory management Page cache
lore
Share & tools
lore

Souptick Joarder

author
#0 lore raw

PATCH 1/1 mm/filemap.c: Remove unused argument from shrink_readahead_size_eio()

The first argument of shrink_readahead_size_eio() is not used. Hence removed from function definition and from all the callers.

Signed-off-by Souptick Joarder <[email protected]>
---
 mm/filemap.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
mm/filemap.c +3 -4
index 1784478..98f3703 100644
@@ -1962,8 +1962,7 @@ unsigned find_get_pages_range_tag(struct address_space *mapping, pgoff_t *index,
  *
  * It is going insane. Fix it by quickly scaling down the readahead size.
  */
-static void shrink_readahead_size_eio(struct file *filp,
-					struct file_ra_state *ra)
+static void shrink_readahead_size_eio(struct file_ra_state *ra)
 {
 	ra->ra_pages /= 4;
 }

@@ -2188,7 +2187,7 @@ static ssize_t generic_file_buffered_read(struct kiocb *iocb,
 					goto find_page;
 				}
 				unlock_page(page);
-				shrink_readahead_size_eio(filp, ra);
+				shrink_readahead_size_eio(ra);
 				error = -EIO;
 				goto readpage_error;
 			}

@@ -2560,7 +2559,7 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
 		goto retry_find;
 
 	/* Things didn't work out. Return zero to tell the mm layer so. */
-	shrink_readahead_size_eio(file, ra);
+	shrink_readahead_size_eio(ra);
 	return VM_FAULT_SIGBUS;
 
 out_retry:
Signature · 1 line
1.9.1