crypto: drbg: DRBG should select SHA512
PATCH v2 1/2 crypto: drbg: DRBG should select SHA512
Since DRBG could use SHA384/SHA512, it should select it.
--- crypto/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
crypto/Kconfig +2 -0
@@ -1810,10 +1810,12 @@ config CRYPTO_DRBG_HMAC default y select CRYPTO_HMAC select CRYPTO_SHA256 + select CRYPTO_SHA512 config CRYPTO_DRBG_HASH bool "Enable Hash DRBG" select CRYPTO_SHA256 + select CRYPTO_SHA512 help Enable the Hash DRBG variant as defined in NIST SP800-90A.
Signature · 1 line
2.24.1
PATCH v2 2/2 crypto: drbg: DRBG_CTR should select CTR
if CRYPTO_DRBG_CTR is builtin and CTR is module, allocating such algo will fail.
DRBG: could not allocate CTR cipher TFM handle: ctr(aes)
alg: drbg: Failed to reset rng
alg: drbg: Test 0 failed for drbg_pr_ctr_aes128
DRBG: could not allocate CTR cipher TFM handle: ctr(aes)
alg: drbg: Failed to reset rng
alg: drbg: Test 0 failed for drbg_nopr_ctr_aes128
DRBG: could not allocate CTR cipher TFM handle: ctr(aes)
alg: drbg: Failed to reset rng
alg: drbg: Test 0 failed for drbg_nopr_ctr_aes192
DRBG: could not allocate CTR cipher TFM handle: ctr(aes)
alg: drbg: Failed to reset rng
ialg: drbg: Test 0 failed for drbg_nopr_ctr_aes256
Since setting DRBG_CTR=CTR lead to a recursive dependency, let's depends on CTR=y
Just selecting CTR lead also to a recursive dependency:
crypto/Kconfig:1800:error: recursive dependency detected!crypto/Kconfig:1800: symbol CRYPTO_DRBG_MENU is selected byCRYPTO_RNG_DEFAULTcrypto/Kconfig:83: symbol CRYPTO_RNG_DEFAULT is selected byCRYPTO_SEQIV
crypto/Kconfig:330: symbol CRYPTO_SEQIV is selected by CRYPTO_CTR crypto/Kconfig:370: symbol CRYPTO_CTR is selected by CRYPTO_DRBG_CTR crypto/Kconfig:1822: symbol CRYPTO_DRBG_CTR depends on
CRYPTO_DRBG_MENU
---
Changes since v1:
- Updated commit message with recursive dependency
crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
crypto/Kconfig +1 -1
@@ -1822,7 +1822,7 @@ config CRYPTO_DRBG_HASH config CRYPTO_DRBG_CTR bool "Enable CTR DRBG" select CRYPTO_AES - depends on CRYPTO_CTR + depends on CRYPTO_CTR=y help Enable the CTR DRBG variant as defined in NIST SP800-90A.
Signature · 1 line
2.24.1
Herbert Xu
maintainerRe: [PATCH v2 2/2] crypto: drbg: DRBG_CTR should select CTR
Quoted 11 lines · Corentin Labbe
Just selecting CTR lead also to a recursive dependency:
crypto/Kconfig:1800:error: recursive dependency detected!crypto/Kconfig:1800: symbolCRYPTO_DRBG_MENUis selected byCRYPTO_RNG_DEFAULTcrypto/Kconfig:83: symbolCRYPTO_RNG_DEFAULTis selected byCRYPTO_SEQIVcrypto/Kconfig:330: symbol CRYPTO_SEQIV is selected by CRYPTO_CTR crypto/Kconfig:370: symbol CRYPTO_CTR is selected by CRYPTO_DRBG_CTR crypto/Kconfig:1822: symbol CRYPTO_DRBG_CTR depends on
CRYPTO_DRBG_MENU
The SEQIV select from CTR is historical and no longer necessary. So let's just get rid of that and then DRBG can select CTR without running into loops.
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt