Skip to contentSkip to conversation

PowerTOP v2.8

Powertop Alexandra Yates 3 participants 3 messages Nov 6, 2015 – Nov 17, 2015

lore
Share & tools
lore

Alexandra Yates

author
#0 lore raw

PowerTOP v2.8 Release

We are pleased to announce the release of PowerTOP v2.8.

About PowerTOP
PowerTOP is a Linux tool to diagnose issues with power consumption and power management. In addition to being a diagnostic tool, PowerTOP also has an interactive mode you can use to experiment with various power management settings, for cases where the Linux distribution has not enabled those settings.
PowerTOP reports which components in the system are most likely to blame for higher-than-needed power consumption, ranging from software applications to active components in the system. Detailed screens are available for CPU C and P states, device activity, and software activity. For many years, PowerTOP has been used heavily by Intel, Linux distributors, and various parts of the open source community.

Highlights

Thank you to everyone who contributed to this release! Alexandra Yates (26):
Enable PowerTOP support for: BSW, BDW-H
bug-fix: added devices/devreq.h to Makefile Merge remote-tracking branch 'ext_pwd/master' Adding support to SKY platforms.
Merge branch 'ext_pwt'
Update internal repo with external mainline Android Support
Add C7- C10 support for Intel SKY
Merge branch 'pw_ext_gh'
Enabling Intel SKL support
PowerTOP v2.8-rc1
Intel Support BSW C-States
Added SKL C7 support
Update version to PowerTOP v2.8-rc2
Merge branch 'master' of github.com:fenrus75/powertop Revert "Assign line level based on linux name" Fix style bugs inherited from the header and menu PowerTOP v2.8-rc3
Transifex Update
Transifex Update
PowerTOP 2.8-rc4
Transifex Translations
PowerTOP v2.8

David E. Box (1):
Fix Powertop support for Intel Braswell SOC

Jaroslav Škarvada (3):
Patch: Add navigation hint
Use PATH_MAX from limits.h and snprintf instead of sprintf Improve handling of reporting filenames
More sprintf fixes

Lorenzo Pieralisi (1):
powertop: fix erroneous C state detection on ARM

Michael Mullin (1):

       Powertop crashes with 'powertop --auto-tune'

Nivedita Swaminathan (1):
Additional message printed to the powertop output

Romain Naour (2):
add missing sys/time.h header
add missing stdio.h header

Sami Kerola (15):
configure: require new enough automake version
configure: use autoconf-archive ax_pthread.m4
add missing space to --version print out csstoh.sh: check every single return value
configure: use AC_USE_SYSTEM_EXTENSIONS to determine features move variables to protected scope
make --quiet option to suppress various info messages add missing include
squeeze all extra bits from size of binary and html report fix typo in message
textual: add new line to a message
powertop.m4: GCC_FORTIFY_SOURCE_CC copy idea of macro from
Archlinux pacman
add timestamp to html report
main: fix incompatible operand type
configure: use autoconf-archive ax_cxx_compile_stdcxx_11.m4

Signature · 2 lines
Thank you,
<Alexandra>
#1 lore raw

[Powertop] powertop-2.8 Fedora compile fix

Hi,

thanks for the powertop-2.8 release. In Fedora we have ImplicitDSOLinking [1], so for pthreads usage it needs to link with the -lpthread. But the included ax_pthread.m4 macro find -pthreads CFLAGS, not LDFLAGS. From the GCC manual page:

Quoted 3 lines

-pthreads
Add support for multithreading using the POSIX threads library. This option sets flags for both the preprocessor and linker.

This means that you need to add the PTHREAD_CFLAGS in order to compile powertop on systems with ImplicitDSOLinking and recent GCC. The attached patch do it and fixed the problem for me in Fedora

thanks & regards

Jaroslav

[1] https://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking

src/Makefile.am +4 -2
index d7132c0..87d8469 100644
@@ -133,7 +133,8 @@ powertop_CXXFLAGS = \
 	$(GLIB2_CFLAGS) \
 	$(LIBNL_CFLAGS) \
 	$(NCURSES_CFLAGS) \
-	$(PCIUTILS_CFLAGS)
+	$(PCIUTILS_CFLAGS) \
+	$(PTHREAD_CFLAGS)
 
 
 powertop_CPPFLAGS = \
@@ -142,7 +143,8 @@ powertop_CPPFLAGS = \
 	$(LIBNL_CFLAGS) \
 	$(LIBZ_CFLAGS) \
 	$(NCURSES_CFLAGS) \
-	$(PCIUTILS_CFLAGS)
+	$(PCIUTILS_CFLAGS) \
+	$(PTHREAD_CFLAGS)
 
 powertop_LDADD = \
 	../traceevent/libtraceevnet.la
#2 lore raw

Re: [Powertop] powertop-2.8 Fedora compile fix

Thank you for sending your patch. Your patch has been added to the github repository.

Regards,
Nivedita

-----Original Message-----
From: PowerTop [mailto:powertop-bounces(a)lists.01.org] On Behalf Of Jaroslav Skarvada
Sent: Tuesday, November 10, 2015 7:02 AM
To: powertop(a)lists.01.org
Subject: [Powertop] powertop-2.8 Fedora compile fix

Hi,

thanks for the powertop-2.8 release. In Fedora we have ImplicitDSOLinking [1], so for pthreads usage it needs to link with the -lpthread. But the included ax_pthread.m4 macro find -pthreads CFLAGS, not LDFLAGS. From the GCC manual page:

Quoted 3 lines

-pthreads
Add support for multithreading using the POSIX threads library. This option sets flags for both the preprocessor and linker.

This means that you need to add the PTHREAD_CFLAGS in order to compile powertop on systems with ImplicitDSOLinking and recent GCC. The attached patch do it and fixed the problem for me in Fedora

thanks & regards

Jaroslav

[1] https://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking