Skip to contentSkip to conversation

scsi: hisi_sas: Use dev_err() in read_iost_itct_cache_v3_hw()

PATCH Applied John Garry 2 participants 2 messages Mar 11, 2020 – Mar 12, 2020

Subsystems (2)
lore
Share & tools
lore

John Garry

author
#0 lore raw

PATCH 1/1 scsi: hisi_sas: Use dev_err() in read_iost_itct_cache_v3_hw()

From: Luo Jiaxing <[email protected]>

The print of pr_err() does not come with device information, so replace it with dev_err(). Also improve the grammar in the message.

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +2 -1
index a2debe0c8185..374885aa8d77 100644
@@ -2938,6 +2938,7 @@ static void read_iost_itct_cache_v3_hw(struct hisi_hba *hisi_hba,
 {
 	u32 cache_dw_size = HISI_SAS_IOST_ITCT_CACHE_DW_SZ *
 			    HISI_SAS_IOST_ITCT_CACHE_NUM;
+	struct device *dev = hisi_hba->dev;
 	u32 *buf = cache;
 	u32 i, val;
 
@@ -2950,7 +2951,7 @@ static void read_iost_itct_cache_v3_hw(struct hisi_hba *hisi_hba,
 	}
 
 	if (val != 0xffffffff) {
-		pr_err("Issue occur when reading IOST/ITCT cache!\n");
+		dev_err(dev, "Issue occurred in reading IOST/ITCT cache!\n");
 		return;
 	}
 
Signature · 1 line
2.17.1
#1 lore raw

John,

Quoted 2 lines

The print of pr_err() does not come with device information, so replace it with dev_err(). Also improve the grammar in the message.

Applied to 5.7/scsi-queue, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering