Change in openvpn[master]: doc: Remove some explanations for pre-2.3 configurations
A message that is not in the archive (sent off-list or not yet received): gerrit.1775126506000.Ieaaf3a79642c8f7914f9bfc6762ad601c4f5695b@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email
to review the following change.
Change subject: doc: Remove some explanations for pre-2.3 configurations
......................................................................
doc: Remove some explanations for pre-2.3 configurations
Just streamline the documentation a bit.
---
M doc/man-sections/generic-options.rst
1 file changed, 7 insertions(+), 19 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/03/1603/1
doc/man-sections/generic-options.rst +7 -19
@@ -43,11 +43,11 @@ however complications can result when scripts or restarts are executed after the chroot operation. - Note: The SSL library will probably need /dev/urandom to be available + Note: The SSL library will probably need ``/dev/urandom`` to be available inside the chroot directory ``dir``. This is because SSL libraries occasionally need to collect fresh randomness. Newer linux kernels and some BSDs implement a getrandom() or getentropy() syscall that removes the - need for /dev/urandom to be available. + need for ``/dev/urandom`` to be available. --compat-mode version This option provides a convenient way to alter the defaults of OpenVPN
@@ -170,9 +170,7 @@ Note: as soon as OpenVPN has daemonized, it can not ask for usernames, passwords, or key pass phrases anymore. This has certain consequences, namely that using a password-protected private key will fail unless the - ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase - (this requirement is new in v2.3.7, and is a consequence of calling - daemon() before initializing the crypto layer). + ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase. Further, using ``--daemon`` together with ``--auth-user-pass`` (entered on console) and ``--auth-nocache`` will fail as soon as key
@@ -330,32 +328,22 @@ OpenVPN releases before v2.3 also supported a ``method`` flag which indicated how OpenVPN should call external commands and scripts. This could be either :code:`execve` or :code:`system`. As of OpenVPN 2.3, this - flag is no longer accepted. In most \*nix environments the execve() - approach has been used without any issues. + flag is no longer accepted. Some directives such as ``--up`` allow options to be passed to the external script. In these cases make sure the script name does not contain any spaces or the configuration parser will choke because it can't determine where the script name ends and script options start. - To run scripts in Windows in earlier OpenVPN versions you needed to - either add a full path to the script interpreter which can parse the - script or use the ``system`` flag to run these scripts. As of OpenVPN - 2.3 it is now a strict requirement to have full path to the script + On Windoes it is a strict requirement to have the full path to the script interpreter when running non-executables files. This is not needed for executable files, such as .exe, .com, .bat or .cmd files. For example, - if you have a Visual Basic script, you must use this syntax now: - - :: + if you have a Visual Basic script, you must use this syntax:: --up 'C:\\Windows\\System32\\wscript.exe C:\\Program\ Files\\OpenVPN\\config\\my-up-script.vbs' Please note the single quote marks and the escaping of the backslashes - (\\) and the space character. - - The reason the support for the :code:`system` flag was removed is due to - the security implications with shell expansions when executing scripts - via the :code:`system()` call. + (``\\``) and the space character. --setcon context Apply SELinux ``context`` after initialization. This essentially
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieaaf3a79642c8f7914f9bfc6762ad601c4f5695b
Gerrit-Change-Number: 1603
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email )
Change subject: doc: Remove some explanations for pre-2.3 configurations
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieaaf3a79642c8f7914f9bfc6762ad601c4f5695b
Gerrit-Change-Number: 1603
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 02 Apr 2026 11:26:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH 1/1 doc: Remove some explanations for pre-2.3 configurations
In reply to a message not in the archiveJust streamline the documentation a bit.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1603
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1603
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>
doc/man-sections/generic-options.rst +7 -19
@@ -43,11 +43,11 @@ however complications can result when scripts or restarts are executed after the chroot operation. - Note: The SSL library will probably need /dev/urandom to be available + Note: The SSL library will probably need ``/dev/urandom`` to be available inside the chroot directory ``dir``. This is because SSL libraries occasionally need to collect fresh randomness. Newer linux kernels and some BSDs implement a getrandom() or getentropy() syscall that removes the - need for /dev/urandom to be available. + need for ``/dev/urandom`` to be available. --compat-mode version This option provides a convenient way to alter the defaults of OpenVPN
@@ -170,9 +170,7 @@ Note: as soon as OpenVPN has daemonized, it can not ask for usernames, passwords, or key pass phrases anymore. This has certain consequences, namely that using a password-protected private key will fail unless the - ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase - (this requirement is new in v2.3.7, and is a consequence of calling - daemon() before initializing the crypto layer). + ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase. Further, using ``--daemon`` together with ``--auth-user-pass`` (entered on console) and ``--auth-nocache`` will fail as soon as key
@@ -330,32 +328,22 @@ OpenVPN releases before v2.3 also supported a ``method`` flag which indicated how OpenVPN should call external commands and scripts. This could be either :code:`execve` or :code:`system`. As of OpenVPN 2.3, this - flag is no longer accepted. In most \*nix environments the execve() - approach has been used without any issues. + flag is no longer accepted. Some directives such as ``--up`` allow options to be passed to the external script. In these cases make sure the script name does not contain any spaces or the configuration parser will choke because it can't determine where the script name ends and script options start. - To run scripts in Windows in earlier OpenVPN versions you needed to - either add a full path to the script interpreter which can parse the - script or use the ``system`` flag to run these scripts. As of OpenVPN - 2.3 it is now a strict requirement to have full path to the script + On Windoes it is a strict requirement to have the full path to the script interpreter when running non-executables files. This is not needed for executable files, such as .exe, .com, .bat or .cmd files. For example, - if you have a Visual Basic script, you must use this syntax now: - - :: + if you have a Visual Basic script, you must use this syntax:: --up 'C:\\Windows\\System32\\wscript.exe C:\\Program\ Files\\OpenVPN\\config\\my-up-script.vbs' Please note the single quote marks and the escaping of the backslashes - (\\) and the space character. - - The reason the support for the :code:`system` flag was removed is due to - the security implications with shell expansions when executing scripts - via the :code:`system()` call. + (``\\``) and the space character. --setcon context Apply SELinux ``context`` after initialization. This essentially
[Openvpn-devel] [PATCH applied] Re: doc: Remove some explanations for pre-2.3 configurations
Documentation encrustification is always good :-)
Your patch has been applied to the master and release/2.7 branch.
commit ecda555404d39de180317b1eaa2944b40869ff46 (master) commit 06a0d8bcb14b7b902297688541ec6a299f7e9904 (release/2.7)
Author: Frank Lichtenheld Date: Thu Apr 2 14:04:35 2026 +0200
doc: Remove some explanations for pre-2.3 configurations
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1603
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36434.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: doc: Remove some explanations for pre-2.3 configurations
......................................................................
doc: Remove some explanations for pre-2.3 configurations
Just streamline the documentation a bit.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1603
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36434.html
---
M doc/man-sections/generic-options.rst
1 file changed, 7 insertions(+), 19 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/03/1603/2
doc/man-sections/generic-options.rst +7 -19
@@ -43,11 +43,11 @@ however complications can result when scripts or restarts are executed after the chroot operation. - Note: The SSL library will probably need /dev/urandom to be available + Note: The SSL library will probably need ``/dev/urandom`` to be available inside the chroot directory ``dir``. This is because SSL libraries occasionally need to collect fresh randomness. Newer linux kernels and some BSDs implement a getrandom() or getentropy() syscall that removes the - need for /dev/urandom to be available. + need for ``/dev/urandom`` to be available. --compat-mode version This option provides a convenient way to alter the defaults of OpenVPN
@@ -170,9 +170,7 @@ Note: as soon as OpenVPN has daemonized, it can not ask for usernames, passwords, or key pass phrases anymore. This has certain consequences, namely that using a password-protected private key will fail unless the - ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase - (this requirement is new in v2.3.7, and is a consequence of calling - daemon() before initializing the crypto layer). + ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase. Further, using ``--daemon`` together with ``--auth-user-pass`` (entered on console) and ``--auth-nocache`` will fail as soon as key
@@ -330,32 +328,22 @@ OpenVPN releases before v2.3 also supported a ``method`` flag which indicated how OpenVPN should call external commands and scripts. This could be either :code:`execve` or :code:`system`. As of OpenVPN 2.3, this - flag is no longer accepted. In most \*nix environments the execve() - approach has been used without any issues. + flag is no longer accepted. Some directives such as ``--up`` allow options to be passed to the external script. In these cases make sure the script name does not contain any spaces or the configuration parser will choke because it can't determine where the script name ends and script options start. - To run scripts in Windows in earlier OpenVPN versions you needed to - either add a full path to the script interpreter which can parse the - script or use the ``system`` flag to run these scripts. As of OpenVPN - 2.3 it is now a strict requirement to have full path to the script + On Windoes it is a strict requirement to have the full path to the script interpreter when running non-executables files. This is not needed for executable files, such as .exe, .com, .bat or .cmd files. For example, - if you have a Visual Basic script, you must use this syntax now: - - :: + if you have a Visual Basic script, you must use this syntax:: --up 'C:\\Windows\\System32\\wscript.exe C:\\Program\ Files\\OpenVPN\\config\\my-up-script.vbs' Please note the single quote marks and the escaping of the backslashes - (\\) and the space character. - - The reason the support for the :code:`system` flag was removed is due to - the security implications with shell expansions when executing scripts - via the :code:`system()` call. + (``\\``) and the space character. --setcon context Apply SELinux ``context`` after initialization. This essentially
Signature · 12 lines
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ieaaf3a79642c8f7914f9bfc6762ad601c4f5695b Gerrit-Change-Number: 1603 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]...> Gerrit-Reviewer: plaisthos <[email protected]...> Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email )
Change subject: doc: Remove some explanations for pre-2.3 configurations
......................................................................
doc: Remove some explanations for pre-2.3 configurations
Just streamline the documentation a bit.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1603
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36434.html
---
M doc/man-sections/generic-options.rst
1 file changed, 7 insertions(+), 19 deletions(-)
doc/man-sections/generic-options.rst +7 -19
@@ -43,11 +43,11 @@ however complications can result when scripts or restarts are executed after the chroot operation. - Note: The SSL library will probably need /dev/urandom to be available + Note: The SSL library will probably need ``/dev/urandom`` to be available inside the chroot directory ``dir``. This is because SSL libraries occasionally need to collect fresh randomness. Newer linux kernels and some BSDs implement a getrandom() or getentropy() syscall that removes the - need for /dev/urandom to be available. + need for ``/dev/urandom`` to be available. --compat-mode version This option provides a convenient way to alter the defaults of OpenVPN
@@ -170,9 +170,7 @@ Note: as soon as OpenVPN has daemonized, it can not ask for usernames, passwords, or key pass phrases anymore. This has certain consequences, namely that using a password-protected private key will fail unless the - ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase - (this requirement is new in v2.3.7, and is a consequence of calling - daemon() before initializing the crypto layer). + ``--askpass`` option is used to tell OpenVPN to ask for the pass phrase. Further, using ``--daemon`` together with ``--auth-user-pass`` (entered on console) and ``--auth-nocache`` will fail as soon as key
@@ -330,32 +328,22 @@ OpenVPN releases before v2.3 also supported a ``method`` flag which indicated how OpenVPN should call external commands and scripts. This could be either :code:`execve` or :code:`system`. As of OpenVPN 2.3, this - flag is no longer accepted. In most \*nix environments the execve() - approach has been used without any issues. + flag is no longer accepted. Some directives such as ``--up`` allow options to be passed to the external script. In these cases make sure the script name does not contain any spaces or the configuration parser will choke because it can't determine where the script name ends and script options start. - To run scripts in Windows in earlier OpenVPN versions you needed to - either add a full path to the script interpreter which can parse the - script or use the ``system`` flag to run these scripts. As of OpenVPN - 2.3 it is now a strict requirement to have full path to the script + On Windoes it is a strict requirement to have the full path to the script interpreter when running non-executables files. This is not needed for executable files, such as .exe, .com, .bat or .cmd files. For example, - if you have a Visual Basic script, you must use this syntax now: - - :: + if you have a Visual Basic script, you must use this syntax:: --up 'C:\\Windows\\System32\\wscript.exe C:\\Program\ Files\\OpenVPN\\config\\my-up-script.vbs' Please note the single quote marks and the escaping of the backslashes - (\\) and the space character. - - The reason the support for the :code:`system` flag was removed is due to - the security implications with shell expansions when executing scripts - via the :code:`system()` call. + (``\\``) and the space character. --setcon context Apply SELinux ``context`` after initialization. This essentially
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1603?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieaaf3a79642c8f7914f9bfc6762ad601c4f5695b
Gerrit-Change-Number: 1603
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>