Skip to contentSkip to conversation

rtc: snvs: remove redundant error message

PATCH In review Anson Huang 2 participants 2 messages Mar 15, 2020 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: snvs: remove redundant error message

The RTC core already has error message for registration failure, no need to have error message in the driver again.

---
 drivers/rtc/rtc-snvs.c | 2 --
 1 file changed, 2 deletions(-)
drivers/rtc/rtc-snvs.c +0 -2
index 319ed1d..36f4961 100644
@@ -354,8 +354,6 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	data->rtc->ops = &snvs_rtc_ops;
 	data->rtc->range_max = U32_MAX;
 	ret = rtc_register_device(data->rtc);
-	if (ret)
-		dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);
 
 	return ret;
 }
Signature · 1 line
2.7.4
#1 lore raw

Hi,

Quoted 8 lines · Anson Huang

The RTC core already has error message for registration failure, no need to have error message in the driver again.

---
 drivers/rtc/rtc-snvs.c | 2 --
 1 file changed, 2 deletions(-)

I squashed that one in your previous patch.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com