Skip to contentSkip to conversation

media: cec: ch7322: drop of_match_ptr for ID table

PATCH In review Krzysztof Kozlowski 14 participants 72 messages Mar 12, 2023 – Jul 26, 2023

Subsystems (27)
lore
Share & tools
lore
#0 lore raw

PATCH 1/28 media: cec: ch7322: drop of_match_ptr for ID table

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/cec/i2c/ch7322.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/i2c/ch7322.c +1 -1
index 34fad7123704..3c6e6496a001 100644
@@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
 static struct i2c_driver ch7322_i2c_driver = {
 	.driver = {
 		.name = "ch7322",
-		.of_match_table = of_match_ptr(ch7322_of_match),
+		.of_match_table = ch7322_of_match,
 	},
 	.probe_new	= ch7322_probe,
 	.remove		= ch7322_remove,
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/28 media: cec: meson: drop of_match_ptr for ID table

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/platform/meson/ao-cec.c:711:34: error: ‘meson_ao_cec_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/cec/platform/meson/ao-cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/platform/meson/ao-cec.c +1 -1
index 6b440f0635d9..223c092dbb6a 100644
@@ -719,7 +719,7 @@ static struct platform_driver meson_ao_cec_driver = {
 	.remove  = meson_ao_cec_remove,
 	.driver  = {
 		.name = "meson-ao-cec",
-		.of_match_table = of_match_ptr(meson_ao_cec_of_match),
+		.of_match_table = meson_ao_cec_of_match,
 	},
 };
 
Signature · 1 line
2.34.1
reviewer Acked-by on v1 2/28
#2 lore raw

Re: [PATCH 02/28] media: cec: meson: drop of_match_ptr for ID table

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/platform/meson/ao-cec.c:711:34: error: ‘meson_ao_cec_of_match’ defined but not used [-Werror=unused-const-variable=]

Reviewed-by on v1 2/28
#3 lore raw

Re: [PATCH 02/28] media: cec: meson: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/platform/meson/ao-cec.c:711:34: error: ‘meson_ao_cec_of_match’ defined but not used [-Werror=unused-const-variable=]

Thanks!

Hans

Quoted 17 lines
---
 drivers/media/cec/platform/meson/ao-cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/platform/meson/ao-cec.c +1 -1
index 6b440f0635d9..223c092dbb6a 100644
@@ -719,7 +719,7 @@ static struct platform_driver meson_ao_cec_driver = {
 	.remove  = meson_ao_cec_remove,
 	.driver  = {
 		.name = "meson-ao-cec",
-		.of_match_table = of_match_ptr(meson_ao_cec_of_match),
+		.of_match_table = meson_ao_cec_of_match,
 	},
 };
 
#4 lore raw

PATCH 3/28 media: cec: tegra: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/cec/platform/tegra/tegra_cec.c:457:34: error: ‘tegra_cec_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/cec/platform/tegra/tegra_cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/platform/tegra/tegra_cec.c +1 -1
index 5e907395ca2e..7115636ca748 100644
@@ -464,7 +464,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
 static struct platform_driver tegra_cec_driver = {
 	.driver = {
 		.name = TEGRA_CEC_NAME,
-		.of_match_table = of_match_ptr(tegra_cec_of_match),
+		.of_match_table = tegra_cec_of_match,
 	},
 	.probe = tegra_cec_probe,
 	.remove = tegra_cec_remove,
Signature · 1 line
2.34.1
Reviewed-by on v1 3/28
#5 lore raw

Re: [PATCH 03/28] media: cec: tegra: drop of_match_ptr for ID table

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/cec/platform/tegra/tegra_cec.c:457:34: error: ‘tegra_cec_of_match’ defined but not used [-Werror=unused-const-variable=]

Thanks!

Hans

Quoted 17 lines
---
 drivers/media/cec/platform/tegra/tegra_cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/platform/tegra/tegra_cec.c +1 -1
index 5e907395ca2e..7115636ca748 100644
@@ -464,7 +464,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
 static struct platform_driver tegra_cec_driver = {
 	.driver = {
 		.name = TEGRA_CEC_NAME,
-		.of_match_table = of_match_ptr(tegra_cec_of_match),
+		.of_match_table = tegra_cec_of_match,
 	},
 	.probe = tegra_cec_probe,
 	.remove = tegra_cec_remove,
#6 lore raw

PATCH 4/28 media: rc: gpio-ir-recv: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/rc/gpio-ir-recv.c:197:34: error: ‘gpio_ir_recv_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/rc/gpio-ir-recv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/gpio-ir-recv.c +1 -1
index 8dbe780dae4e..ae1199cc73fd 100644
@@ -205,7 +205,7 @@ static struct platform_driver gpio_ir_recv_driver = {
 	.remove = gpio_ir_recv_remove,
 	.driver = {
 		.name   = KBUILD_MODNAME,
-		.of_match_table = of_match_ptr(gpio_ir_recv_of_match),
+		.of_match_table = gpio_ir_recv_of_match,
 #ifdef CONFIG_PM
 		.pm	= &gpio_ir_recv_pm_ops,
 #endif
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 4/28
#7 lore raw

Re: [PATCH 04/28] media: rc: gpio-ir-recv: drop of_match_ptr for ID table

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/rc/gpio-ir-recv.c:197:34: error: ‘gpio_ir_recv_of_match’ defined but not used [-Werror=unused-const-variable=]

Thanks
Sean

Quoted 19 lines
---
 drivers/media/rc/gpio-ir-recv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/gpio-ir-recv.c +1 -1
index 8dbe780dae4e..ae1199cc73fd 100644
@@ -205,7 +205,7 @@ static struct platform_driver gpio_ir_recv_driver = {
 	.remove = gpio_ir_recv_remove,
 	.driver = {
 		.name   = KBUILD_MODNAME,
-		.of_match_table = of_match_ptr(gpio_ir_recv_of_match),
+		.of_match_table = gpio_ir_recv_of_match,
 #ifdef CONFIG_PM
 		.pm	= &gpio_ir_recv_pm_ops,
 #endif
Signature · 1 line
2.34.1

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#8 lore raw

PATCH 5/28 media: rc: gpio-ir-tx: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/rc/gpio-ir-tx.c:24:34: error: ‘gpio_ir_tx_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/rc/gpio-ir-tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/gpio-ir-tx.c +1 -1
index 2b829c146db1..1a8fea357f14 100644
@@ -199,7 +199,7 @@ static struct platform_driver gpio_ir_tx_driver = {
 	.probe	= gpio_ir_tx_probe,
 	.driver = {
 		.name	= DRIVER_NAME,
-		.of_match_table = of_match_ptr(gpio_ir_tx_of_match),
+		.of_match_table = gpio_ir_tx_of_match,
 	},
 };
 module_platform_driver(gpio_ir_tx_driver);
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 5/28
#9 lore raw

Re: [PATCH 05/28] media: rc: gpio-ir-tx: drop of_match_ptr for ID table

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/rc/gpio-ir-tx.c:24:34: error: ‘gpio_ir_tx_of_match’ defined but not used [-Werror=unused-const-variable=]

Thanks
Sean

Quoted 19 lines
---
 drivers/media/rc/gpio-ir-tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/gpio-ir-tx.c +1 -1
index 2b829c146db1..1a8fea357f14 100644
@@ -199,7 +199,7 @@ static struct platform_driver gpio_ir_tx_driver = {
 	.probe	= gpio_ir_tx_probe,
 	.driver = {
 		.name	= DRIVER_NAME,
-		.of_match_table = of_match_ptr(gpio_ir_tx_of_match),
+		.of_match_table = gpio_ir_tx_of_match,
 	},
 };
 module_platform_driver(gpio_ir_tx_driver);
Signature · 1 line
2.34.1
#10 lore raw

PATCH 6/28 media: rc: ir-rx51: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/rc/ir-rx51.c:264:34: error: ‘ir_rx51_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/rc/ir-rx51.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/ir-rx51.c +1 -1
index adbbe639a261..13e81bf8005d 100644
@@ -275,7 +275,7 @@ static struct platform_driver ir_rx51_platform_driver = {
 	.resume		= ir_rx51_resume,
 	.driver		= {
 		.name	= KBUILD_MODNAME,
-		.of_match_table = of_match_ptr(ir_rx51_match),
+		.of_match_table = ir_rx51_match,
 	},
 };
 module_platform_driver(ir_rx51_platform_driver);
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 6/28
#11 lore raw

Re: [PATCH 06/28] media: rc: ir-rx51: drop of_match_ptr for ID table

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/rc/ir-rx51.c:264:34: error: ‘ir_rx51_match’ defined but not used [-Werror=unused-const-variable=]

Thanks
Sean

Quoted 19 lines
---
 drivers/media/rc/ir-rx51.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/ir-rx51.c +1 -1
index adbbe639a261..13e81bf8005d 100644
@@ -275,7 +275,7 @@ static struct platform_driver ir_rx51_platform_driver = {
 	.resume		= ir_rx51_resume,
 	.driver		= {
 		.name	= KBUILD_MODNAME,
-		.of_match_table = of_match_ptr(ir_rx51_match),
+		.of_match_table = ir_rx51_match,
 	},
 };
 module_platform_driver(ir_rx51_platform_driver);
Signature · 1 line
2.34.1
#12 lore raw

PATCH 7/28 media: platform: allegro-dvt: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/allegro-dvt/allegro-core.c:3995:34: error: ‘allegro_dt_ids’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/allegro-dvt/allegro-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/allegro-dvt/allegro-core.c +1 -1
index 2423714afcb9..7fc197a02cc2 100644
@@ -4009,7 +4009,7 @@ static struct platform_driver allegro_driver = {
 	.remove = allegro_remove,
 	.driver = {
 		.name = "allegro",
-		.of_match_table = of_match_ptr(allegro_dt_ids),
+		.of_match_table = allegro_dt_ids,
 		.pm = &allegro_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 7/28
#13 lore raw

Re: [PATCH 07/28] media: platform: allegro-dvt: drop of_match_ptr for ID table

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/allegro-dvt/allegro-core.c:3995:34: error: ‘allegro_dt_ids’ defined but not used [-Werror=unused-const-variable=]

Quoted 21 lines
---
 drivers/media/platform/allegro-dvt/allegro-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/allegro-dvt/allegro-core.c +1 -1
index 2423714afcb9..7fc197a02cc2 100644
@@ -4009,7 +4009,7 @@ static struct platform_driver allegro_driver = {
 	.remove = allegro_remove,
 	.driver = {
 		.name = "allegro",
-		.of_match_table = of_match_ptr(allegro_dt_ids),
+		.of_match_table = allegro_dt_ids,
 		.pm = &allegro_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
#14 lore raw

PATCH 8/28 media: platform: intel: pxa: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/intel/pxa_camera.c:2449:34: error: ‘pxa_camera_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/intel/pxa_camera.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/intel/pxa_camera.c +1 -1
index 54270d6b6f50..f659abf1a22d 100644
@@ -2456,7 +2456,7 @@ static struct platform_driver pxa_camera_driver = {
 	.driver		= {
 		.name	= PXA_CAM_DRV_NAME,
 		.pm	= &pxa_camera_pm,
-		.of_match_table = of_match_ptr(pxa_camera_of_match),
+		.of_match_table = pxa_camera_of_match,
 	},
 	.probe		= pxa_camera_probe,
 	.remove		= pxa_camera_remove,
Signature · 1 line
2.34.1
#15 lore raw

PATCH 9/28 media: platform: samsung: s5p-jpeg: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:3124:34: error: ‘samsung_jpeg_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c +1 -1
index 55814041b8d8..8be8e3596e07 100644
@@ -3166,7 +3166,7 @@ static struct platform_driver s5p_jpeg_driver = {
 	.probe = s5p_jpeg_probe,
 	.remove = s5p_jpeg_remove,
 	.driver = {
-		.of_match_table	= of_match_ptr(samsung_jpeg_match),
+		.of_match_table	= samsung_jpeg_match,
 		.name		= S5P_JPEG_M2M_NAME,
 		.pm		= &s5p_jpeg_pm_ops,
 	},
Signature · 1 line
2.34.1
maintainer Acked-by on v1 9/28
#16 lore raw

Re: [PATCH 09/28] media: platform: samsung: s5p-jpeg: drop of_match_ptr for ID table

Hi,

W dniu 12.03.2023 o 14:12, Krzysztof Kozlowski pisze:

Quoted 8 lines

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:3124:34: error: ‘samsung_jpeg_match’ defined but not used [-Werror=unused-const-variable=]

Quoted 17 lines
---
  drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c +1 -1
index 55814041b8d8..8be8e3596e07 100644
@@ -3166,7 +3166,7 @@ static struct platform_driver s5p_jpeg_driver = {
  	.probe = s5p_jpeg_probe,
  	.remove = s5p_jpeg_remove,
  	.driver = {
-		.of_match_table	= of_match_ptr(samsung_jpeg_match),
+		.of_match_table	= samsung_jpeg_match,
  		.name		= S5P_JPEG_M2M_NAME,
  		.pm		= &s5p_jpeg_pm_ops,
  	},
#17 lore raw

PATCH 10/28 media: platform: sti: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1169:34: error: ‘c8sectpfe_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c +1 -1
index c38b62d4f1ae..67d4db0abd8a 100644
@@ -1175,7 +1175,7 @@ MODULE_DEVICE_TABLE(of, c8sectpfe_match);
 static struct platform_driver c8sectpfe_driver = {
 	.driver = {
 		.name = "c8sectpfe",
-		.of_match_table = of_match_ptr(c8sectpfe_match),
+		.of_match_table = c8sectpfe_match,
 	},
 	.probe	= c8sectpfe_probe,
 	.remove	= c8sectpfe_remove,
Signature · 1 line
2.34.1
#18 lore raw

PATCH 11/28 media: platform: ti: am437x: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/ti/am437x/am437x-vpfe.c:2620:34: error: ‘vpfe_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/ti/am437x/am437x-vpfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti/am437x/am437x-vpfe.c +1 -1
index 2dfae9bc0bba..fe89b8e250e7 100644
@@ -2629,7 +2629,7 @@ static struct platform_driver vpfe_driver = {
 	.driver = {
 		.name	= VPFE_MODULE_NAME,
 		.pm	= &vpfe_pm_ops,
-		.of_match_table = of_match_ptr(vpfe_of_match),
+		.of_match_table = vpfe_of_match,
 	},
 };
 
Signature · 1 line
2.34.1
Reviewed-by on v1 11/28
#19 lore raw

Re: [PATCH 11/28] media: platform: ti: am437x: drop of_match_ptr for ID table

Hi Krzysztof,

Thank you for the patch.

Quoted 3 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This

"might not be relevant" is a bit of an understatement in this case :-)

Quoted 3 lines

also fixes !CONFIG_OF error:

drivers/media/platform/ti/am437x/am437x-vpfe.c:2620:34: error: ‘vpfe_of_match’ defined but not used [-Werror=unused-const-variable=]

This driver should probably depend on CONFIG_OF, but that's a separate issue.

Quoted 1 line
Quoted 17 lines
---
 drivers/media/platform/ti/am437x/am437x-vpfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti/am437x/am437x-vpfe.c +1 -1
index 2dfae9bc0bba..fe89b8e250e7 100644
@@ -2629,7 +2629,7 @@ static struct platform_driver vpfe_driver = {
 	.driver = {
 		.name	= VPFE_MODULE_NAME,
 		.pm	= &vpfe_pm_ops,
-		.of_match_table = of_match_ptr(vpfe_of_match),
+		.of_match_table = vpfe_of_match,
 	},
 };
 
Signature · 3 lines
Regards,

Laurent Pinchart
maintainer Reviewed-by on v1 11/28
#20 lore raw

Re: [PATCH 11/28] media: platform: ti: am437x: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

Quoted 7 lines

drivers/media/platform/ti/am437x/am437x-vpfe.c:2620:34: error: ‘vpfe_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/ti/am437x/am437x-vpfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Cheers,
Prabhakar

Quoted 16 lines
drivers/media/platform/ti/am437x/am437x-vpfe.c +1 -2
index 2dfae9bc0bba..fe89b8e250e7 100644
@@ -2629,7 +2629,7 @@ static struct platform_driver vpfe_driver = {
        .driver = {
                .name   = VPFE_MODULE_NAME,
                .pm     = &vpfe_pm_ops,
-               .of_match_table = of_match_ptr(vpfe_of_match),
+               .of_match_table = vpfe_of_match,
        },
 };
 
--

2.34.1

#21 lore raw

PATCH 12/28 media: platform: verisilicon: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/verisilicon/hantro_drv.c:622:34: error: ‘of_hantro_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/verisilicon/hantro_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/verisilicon/hantro_drv.c +1 -1
index b0aeedae7b65..4041b5b38c4b 100644
@@ -1135,7 +1135,7 @@ static struct platform_driver hantro_driver = {
 	.remove = hantro_remove,
 	.driver = {
 		   .name = DRIVER_NAME,
-		   .of_match_table = of_match_ptr(of_hantro_match),
+		   .of_match_table = of_hantro_match,
 		   .pm = &hantro_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
#22 lore raw

PATCH 13/28 media: platform: marvell: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/marvell/mmp-driver.c:364:34: error: ‘mmpcam_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/marvell/mmp-driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/marvell/mmp-driver.c +1 -1
index ef22bf8f276c..b7747c7bae45 100644
@@ -372,7 +372,7 @@ static struct platform_driver mmpcam_driver = {
 	.remove		= mmpcam_platform_remove,
 	.driver = {
 		.name	= "mmp-camera",
-		.of_match_table = of_match_ptr(mmpcam_of_match),
+		.of_match_table = mmpcam_of_match,
 		.pm = &mmpcam_pm_ops,
 	}
 };
Signature · 1 line
2.34.1
#23 lore raw

PATCH 14/28 media: platform: mdp3: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:49:34: error: ‘mdp_of_ids’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c +1 -1
index 97edcd9d1c81..45a407e63c59 100644
@@ -349,7 +349,7 @@ static struct platform_driver mdp_driver = {
 	.driver = {
 		.name	= MDP_MODULE_NAME,
 		.pm	= &mdp_pm_ops,
-		.of_match_table = of_match_ptr(mdp_of_ids),
+		.of_match_table = mdp_of_ids,
 	},
 };
 
Signature · 1 line
2.34.1
#24 lore raw

PATCH 15/28 media: platform: mdp3: mark OF related data as maybe unused

In reply to Krzysztof Kozlowski

The driver can be compile tested with !CONFIG_OF making certain data unused:

drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:627:34: error: ‘mdp_sub_comp_dt_ids’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c +2 -2
index 091a68685590..817ba9660b5f 100644
@@ -604,7 +604,7 @@ static const struct mdp_comp_match mdp_comp_matches[MDP_MAX_COMP_COUNT] = {
 	[MDP_COMP_WDMA] =	{ MDP_COMP_TYPE_WDMA, 0 },
 };
 
-static const struct of_device_id mdp_comp_dt_ids[] = {
+static const struct of_device_id mdp_comp_dt_ids[] __maybe_unused = {
 	{
 		.compatible = "mediatek,mt8183-mdp3-rdma",
 		.data = (void *)MDP_COMP_TYPE_RDMA,
@@ -624,7 +624,7 @@ static const struct of_device_id mdp_comp_dt_ids[] = {
 	{}
 };
 
-static const struct of_device_id mdp_sub_comp_dt_ids[] = {
+static const struct of_device_id mdp_sub_comp_dt_ids[] __maybe_unused = {
 	{
 		.compatible = "mediatek,mt8183-mdp3-wdma",
 		.data = (void *)MDP_COMP_TYPE_PATH,
Signature · 1 line
2.34.1
#25 lore raw

PATCH 16/28 media: platform: sun6i-csi: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:401:34: error: ‘sun6i_csi_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c +1 -1
index e3e6650181c8..187a2419da96 100644
@@ -429,7 +429,7 @@ static struct platform_driver sun6i_csi_platform_driver = {
 	.remove	= sun6i_csi_remove,
 	.driver	= {
 		.name		= SUN6I_CSI_NAME,
-		.of_match_table	= of_match_ptr(sun6i_csi_of_match),
+		.of_match_table	= sun6i_csi_of_match,
 		.pm		= &sun6i_csi_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 16/28
#26 lore raw

Re: [PATCH 16/28] media: platform: sun6i-csi: drop of_match_ptr for ID table

Hi Krzysztof,

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:401:34: error: ‘sun6i_csi_of_match’ defined but not used [-Werror=unused-const-variable=]

Looks good to me:

Thanks !

Paul

Quoted 20 lines
---
 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c +1 -1
index e3e6650181c8..187a2419da96 100644
@@ -429,7 +429,7 @@ static struct platform_driver sun6i_csi_platform_driver = {
 	.remove	= sun6i_csi_remove,
 	.driver	= {
 		.name		= SUN6I_CSI_NAME,
-		.of_match_table	= of_match_ptr(sun6i_csi_of_match),
+		.of_match_table	= sun6i_csi_of_match,
 		.pm		= &sun6i_csi_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
Signature · 3 lines
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
maintainer Acked-by on v1 16/28
#27 lore raw

Re: [PATCH 16/28] media: platform: sun6i-csi: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

Dne nedelja, 12. marec 2023 ob 14:13:06 CET je Krzysztof Kozlowski napisal(a):

Quoted 10 lines

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:401:34: error:
‘sun6i_csi_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Best regards,
Jernej

drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c static struct platform_driver sun6i_csi_platform_driver · line 432

Quoted 13 lines
 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index e3e6650181c8..187a2419da96 100644

drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c +0 -1
@@ -429,7 +429,7 @@ static struct platform_driver sun6i_csi_platform_driver
 = { .remove	= sun6i_csi_remove,
 	.driver	= {
 		.name		= SUN6I_CSI_NAME,
-		.of_match_table	= 

of_match_ptr(sun6i_csi_of_match),

Quoted 4 lines
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c +1 -0
+		.of_match_table	= sun6i_csi_of_match,
 		.pm		= &sun6i_csi_pm_ops,
 	},
 };
#28 lore raw

PATCH 17/28 media: platform: sun6i-mipi-csi2: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:751:34: error: ‘sun6i_mipi_csi2_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c +1 -1
index a220ce849b41..0851b6b4e1ff 100644
@@ -759,7 +759,7 @@ static struct platform_driver sun6i_mipi_csi2_platform_driver = {
 	.remove	= sun6i_mipi_csi2_remove,
 	.driver	= {
 		.name		= SUN6I_MIPI_CSI2_NAME,
-		.of_match_table	= of_match_ptr(sun6i_mipi_csi2_of_match),
+		.of_match_table	= sun6i_mipi_csi2_of_match,
 		.pm		= &sun6i_mipi_csi2_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 17/28
#29 lore raw

Re: [PATCH 17/28] media: platform: sun6i-mipi-csi2: drop of_match_ptr for ID table

Hi Krzysztof,

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:751:34: error: ‘sun6i_mipi_csi2_of_match’ defined but not used [-Werror=unused-const-variable=]

Looks good to me:

Thanks !

Paul

Quoted 20 lines
---
 drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c +1 -1
index a220ce849b41..0851b6b4e1ff 100644
@@ -759,7 +759,7 @@ static struct platform_driver sun6i_mipi_csi2_platform_driver = {
 	.remove	= sun6i_mipi_csi2_remove,
 	.driver	= {
 		.name		= SUN6I_MIPI_CSI2_NAME,
-		.of_match_table	= of_match_ptr(sun6i_mipi_csi2_of_match),
+		.of_match_table	= sun6i_mipi_csi2_of_match,
 		.pm		= &sun6i_mipi_csi2_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
Signature · 3 lines
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

maintainer Acked-by on v1 17/28
#30 lore raw

Re: [PATCH 17/28] media: platform: sun6i-mipi-csi2: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

Dne nedelja, 12. marec 2023 ob 14:13:07 CET je Krzysztof Kozlowski napisal(a):

Quoted 5 lines

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

Quoted 8 lines

drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:751:34:
error: ‘sun6i_mipi_csi2_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Best regards,
Jernej

drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c static struct platform_driver · line 762

Quoted 11 lines
(quoted diff) +0 -0

b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c index a220ce849b41..0851b6b4e1ff 100644

drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c +0 -1
@@ -759,7 +759,7 @@ static struct platform_driver
 sun6i_mipi_csi2_platform_driver = { .remove	= sun6i_mipi_csi2_remove,
 	.driver	= {
 		.name		= SUN6I_MIPI_CSI2_NAME,
-		.of_match_table	= 

of_match_ptr(sun6i_mipi_csi2_of_match),

Quoted 4 lines
drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c +1 -0
+		.of_match_table	= sun6i_mipi_csi2_of_match,
 		.pm		= &sun6i_mipi_csi2_pm_ops,
 	},
 };
#31 lore raw

PATCH 18/28 media: platform: sun8i-a83t-mipi-csi2: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:818:34: error: ‘sun8i_a83t_mipi_csi2_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 .../platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +1 -1
index cd2e92ae2293..1f0cc7b1ba47 100644
@@ -826,7 +826,7 @@ static struct platform_driver sun8i_a83t_mipi_csi2_platform_driver = {
 	.remove	= sun8i_a83t_mipi_csi2_remove,
 	.driver	= {
 		.name		= SUN8I_A83T_MIPI_CSI2_NAME,
-		.of_match_table	= of_match_ptr(sun8i_a83t_mipi_csi2_of_match),
+		.of_match_table	= sun8i_a83t_mipi_csi2_of_match,
 		.pm		= &sun8i_a83t_mipi_csi2_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 18/28
#32 lore raw

Re: [PATCH 18/28] media: platform: sun8i-a83t-mipi-csi2: drop of_match_ptr for ID table

Hi Krzysztof,

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:818:34: error: ‘sun8i_a83t_mipi_csi2_of_match’ defined but not used [-Werror=unused-const-variable=]

Looks good to me:

Thanks !

Paul

Quoted 20 lines
---
 .../platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +1 -1
index cd2e92ae2293..1f0cc7b1ba47 100644
@@ -826,7 +826,7 @@ static struct platform_driver sun8i_a83t_mipi_csi2_platform_driver = {
 	.remove	= sun8i_a83t_mipi_csi2_remove,
 	.driver	= {
 		.name		= SUN8I_A83T_MIPI_CSI2_NAME,
-		.of_match_table	= of_match_ptr(sun8i_a83t_mipi_csi2_of_match),
+		.of_match_table	= sun8i_a83t_mipi_csi2_of_match,
 		.pm		= &sun8i_a83t_mipi_csi2_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
Signature · 3 lines
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
maintainer Acked-by on v1 18/28
#33 lore raw

Re: [PATCH 18/28] media: platform: sun8i-a83t-mipi-csi2: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

Dne nedelja, 12. marec 2023 ob 14:13:08 CET je Krzysztof Kozlowski napisal(a):

Quoted 6 lines

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

Quoted 9 lines

drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:81 8:34: error: ‘sun8i_a83t_mipi_csi2_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 .../platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Best regards,
Jernej

Quoted 11 lines

diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c index cd2e92ae2293..1f0cc7b1ba47 100644
---
a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c
+++
b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c

(quoted diff) +0 -0
@@ -826,7 +826,7 @@ static struct platform_driver

sun8i_a83t_mipi_csi2_platform_driver = { .remove =
sun8i_a83t_mipi_csi2_remove,

drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c static struct platform_driver sun8i_a83t_mipi_csi2_platform_driver = {

Quoted 3 lines
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +0 -1
 	.driver	= {
 		.name		= SUN8I_A83T_MIPI_CSI2_NAME,
-		.of_match_table	= 

of_match_ptr(sun8i_a83t_mipi_csi2_of_match),

Quoted 4 lines
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +1 -0
+		.of_match_table	= sun8i_a83t_mipi_csi2_of_match,
 		.pm		= &sun8i_a83t_mipi_csi2_pm_ops,
 	},
 };
#34 lore raw

PATCH 19/28 media: platform: mdp: mark OF related data as maybe unused

In reply to Krzysztof Kozlowski

The driver can be compile tested with !CONFIG_OF making certain data unused:

drivers/media/platform/mediatek/mdp/mtk_mdp_core.c:31:34: error: ‘mtk_mdp_comp_dt_ids’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/mediatek/mdp/mtk_mdp_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/mediatek/mdp/mtk_mdp_core.c +1 -1
index d83c4964eaf9..37f2dd08ecec 100644
@@ -28,7 +28,7 @@ EXPORT_SYMBOL(mtk_mdp_dbg_level);
 
 module_param(mtk_mdp_dbg_level, int, 0644);
 
-static const struct of_device_id mtk_mdp_comp_dt_ids[] = {
+static const struct of_device_id mtk_mdp_comp_dt_ids[] __maybe_unused = {
 	{
 		.compatible = "mediatek,mt8173-mdp-rdma",
 		.data = (void *)MTK_MDP_RDMA
Signature · 1 line
2.34.1
#35 lore raw

PATCH 20/28 media: platform: jpeg: always reference OF data

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error: ‘mtk8195_jpegdec_drvdata’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c +1 -3
index 969516a940ba..bd12e73492e5 100644
@@ -1898,7 +1898,6 @@ static const struct mtk_jpeg_variant mtk8195_jpegdec_drvdata = {
 	.cap_q_default_fourcc = V4L2_PIX_FMT_YUV420M,
 };
 
-#if defined(CONFIG_OF)
 static const struct of_device_id mtk_jpeg_match[] = {
 	{
 		.compatible = "mediatek,mt8173-jpgdec",
@@ -1924,14 +1923,13 @@ static const struct of_device_id mtk_jpeg_match[] = {
 };
 
 MODULE_DEVICE_TABLE(of, mtk_jpeg_match);
-#endif
 
 static struct platform_driver mtk_jpeg_driver = {
 	.probe = mtk_jpeg_probe,
 	.remove = mtk_jpeg_remove,
 	.driver = {
 		.name           = MTK_JPEG_NAME,
-		.of_match_table = of_match_ptr(mtk_jpeg_match),
+		.of_match_table = mtk_jpeg_match,
 		.pm             = &mtk_jpeg_pm_ops,
 	},
 };
Signature · 1 line
2.34.1
#36 lore raw

Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

Quoted 10 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:
‘mtk8195_jpegdec_drvdata’ defined but not used [-Werror=unused-const-variable=]

I see now that we both submitted the same patch, but now Hans merged a worse fix [1] without a changelog text.

Arnd

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=4ae47770d57bff01

#37 lore raw

Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

Quoted 6 lines · Arnd Bergmann
Quoted 5 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

Quoted 7 lines
Quoted 5 lines

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:
‘mtk8195_jpegdec_drvdata’ defined but not used [-Werror=unused-const-variable=]

I see now that we both submitted the same patch, but now Hans

We as you and me? I cannot find your patch on lore:
https://lore.kernel.org/all/?q=f%3Aarnd%40arndb.de

Quoted 5 lines

merged a worse fix [1] without a changelog text.

Arnd

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=4ae47770d57bff01

Uh, I can rebase my patchset.

Best regards,
Krzysztof

#38 lore raw

Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

Quoted 11 lines · Krzysztof Kozlowski
Quoted 10 lines · Arnd Bergmann
Quoted 9 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:
‘mtk8195_jpegdec_drvdata’ defined but not used [-Werror=unused-const-variable=]

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

I see now that we both submitted the same patch, but now Hans

We as you and me? I cannot find your patch on lore:
https://lore.kernel.org/all/?q=f%3Aarnd%40arndb.de

This is the one that I sent back in January:

https://lore.kernel.org/all/[email protected]

Arnd

#39 lore raw

Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

Quoted 14 lines · Arnd Bergmann
Quoted 13 lines · Krzysztof Kozlowski
Quoted 12 lines · Arnd Bergmann
Quoted 10 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:
‘mtk8195_jpegdec_drvdata’ defined but not used [-Werror=unused-const-variable=]

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

I see now that we both submitted the same patch, but now Hans

We as you and me? I cannot find your patch on lore:
https://lore.kernel.org/all/?q=f%3Aarnd%40arndb.de

This is the one that I sent back in January:

https://lore.kernel.org/all/[email protected]

Uh, that's from January! It's still waiting in Patchwork:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

Best regards,
Krzysztof

#40 lore raw

Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

Quoted 20 lines · Krzysztof Kozlowski
Quoted 19 lines · Arnd Bergmann
Quoted 17 lines · Krzysztof Kozlowski
Quoted 6 lines · Arnd Bergmann
Quoted 5 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

Quoted 7 lines
Quoted 5 lines

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:
‘mtk8195_jpegdec_drvdata’ defined but not used [-Werror=unused-const-variable=]

I see now that we both submitted the same patch, but now Hans

We as you and me? I cannot find your patch on lore:
https://lore.kernel.org/all/?q=f%3Aarnd%40arndb.de

Quoted 6 lines
Quoted 3 lines

This is the one that I sent back in January:

https://lore.kernel.org/all/[email protected]

Uh, that's from January! It's still waiting in Patchwork:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

Yes... this still makes sense, to remove of_match_ptr(). I rebased this, resulting in:

From 230cfaabcd2d5a5f0bc74e113fe84f95028bcdc5 Mon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Sun, 12 Mar 2023 14:13:10 +0100
Subject: [PATCH v2 20/28] media: platform: jpeg: always reference OF data

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

[Sakari Ailus: Rebased on media tree master, reword commit message.]
---
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c +1 -3
index 0051f372a66cf..8bcbaa9658bac 100644
@@ -1866,7 +1866,6 @@ static const struct dev_pm_ops mtk_jpeg_pm_ops = {
 	SET_RUNTIME_PM_OPS(mtk_jpeg_pm_suspend, mtk_jpeg_pm_resume, NULL)
 };
 
-#if defined(CONFIG_OF)
 static const struct mtk_jpeg_variant mt8173_jpeg_drvdata = {
 	.clks = mt8173_jpeg_dec_clocks,
 	.num_clks = ARRAY_SIZE(mt8173_jpeg_dec_clocks),
@@ -1949,14 +1948,13 @@ static const struct of_device_id mtk_jpeg_match[] = {
 };
 
 MODULE_DEVICE_TABLE(of, mtk_jpeg_match);
-#endif
 
 static struct platform_driver mtk_jpeg_driver = {
 	.probe = mtk_jpeg_probe,
 	.remove_new = mtk_jpeg_remove,
 	.driver = {
 		.name           = MTK_JPEG_NAME,
-		.of_match_table = of_match_ptr(mtk_jpeg_match),
+		.of_match_table = mtk_jpeg_match,
 		.pm             = &mtk_jpeg_pm_ops,
 	},
 };
Signature · 4 lines
2.30.2

-- 
Sakari Ailus
maintainer
#41 lore raw

PATCH v2 20/28 media: platform: jpeg: always reference OF data

In reply to Krzysztof Kozlowski

From: Krzysztof Kozlowski <[email protected]>

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

[Sakari Ailus: Rebased on media tree master, reword commit message,
drop additional #if defined(CONFIG_OF)/#endif's.]

---
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c   | 6 +-----
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c | 4 +---
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c | 4 +---
 3 files changed, 3 insertions(+), 11 deletions(-)
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c +1 -5
index 4768156181c99..40cb3cb87ba17 100644
@@ -28,7 +28,6 @@
 #include "mtk_jpeg_core.h"
 #include "mtk_jpeg_dec_parse.h"
 
-#if defined(CONFIG_OF)
 static struct mtk_jpeg_fmt mtk_jpeg_enc_formats[] = {
 	{
 		.fourcc		= V4L2_PIX_FMT_JPEG,
@@ -102,7 +101,6 @@ static struct mtk_jpeg_fmt mtk_jpeg_dec_formats[] = {
 		.flags		= MTK_JPEG_FMT_FLAG_CAPTURE,
 	},
 };
-#endif
 
 #define MTK_JPEG_ENC_NUM_FORMATS ARRAY_SIZE(mtk_jpeg_enc_formats)
 #define MTK_JPEG_DEC_NUM_FORMATS ARRAY_SIZE(mtk_jpeg_dec_formats)
@@ -1455,7 +1453,6 @@ static const struct dev_pm_ops mtk_jpeg_pm_ops = {
 	SET_RUNTIME_PM_OPS(mtk_jpeg_pm_suspend, mtk_jpeg_pm_resume, NULL)
 };
 
-#if defined(CONFIG_OF)
 static int mtk_jpegenc_get_hw(struct mtk_jpeg_ctx *ctx)
 {
 	struct mtk_jpegenc_comp_dev *comp_jpeg;
@@ -1951,14 +1948,13 @@ static const struct of_device_id mtk_jpeg_match[] = {
 };
 
 MODULE_DEVICE_TABLE(of, mtk_jpeg_match);
-#endif
 
 static struct platform_driver mtk_jpeg_driver = {
 	.probe = mtk_jpeg_probe,
 	.remove_new = mtk_jpeg_remove,
 	.driver = {
 		.name           = MTK_JPEG_NAME,
-		.of_match_table = of_match_ptr(mtk_jpeg_match),
+		.of_match_table = mtk_jpeg_match,
 		.pm             = &mtk_jpeg_pm_ops,
 	},
 };
drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c +1 -3
index 869068fac5e2f..baa7be58ce691 100644
@@ -39,7 +39,6 @@ enum mtk_jpeg_color {
 	MTK_JPEG_COLOR_400		= 0x00110000
 };
 
-#if defined(CONFIG_OF)
 static const struct of_device_id mtk_jpegdec_hw_ids[] = {
 	{
 		.compatible = "mediatek,mt8195-jpgdec-hw",
@@ -47,7 +46,6 @@ static const struct of_device_id mtk_jpegdec_hw_ids[] = {
 	{},
 };
 MODULE_DEVICE_TABLE(of, mtk_jpegdec_hw_ids);
-#endif
 
 static inline int mtk_jpeg_verify_align(u32 val, int align, u32 reg)
 {
@@ -653,7 +651,7 @@ static struct platform_driver mtk_jpegdec_hw_driver = {
 	.probe = mtk_jpegdec_hw_probe,
 	.driver = {
 		.name = "mtk-jpegdec-hw",
-		.of_match_table = of_match_ptr(mtk_jpegdec_hw_ids),
+		.of_match_table = mtk_jpegdec_hw_ids,
 	},
 };
 
drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c +1 -3
index 71e85b4bbf127..244018365b6f1 100644
@@ -46,7 +46,6 @@ static const struct mtk_jpeg_enc_qlt mtk_jpeg_enc_quality[] = {
 	{.quality_param = 97, .hardware_value = JPEG_ENC_QUALITY_Q97},
 };
 
-#if defined(CONFIG_OF)
 static const struct of_device_id mtk_jpegenc_drv_ids[] = {
 	{
 		.compatible = "mediatek,mt8195-jpgenc-hw",
@@ -54,7 +53,6 @@ static const struct of_device_id mtk_jpegenc_drv_ids[] = {
 	{},
 };
 MODULE_DEVICE_TABLE(of, mtk_jpegenc_drv_ids);
-#endif
 
 void mtk_jpeg_enc_reset(void __iomem *base)
 {
@@ -377,7 +375,7 @@ static struct platform_driver mtk_jpegenc_hw_driver = {
 	.probe = mtk_jpegenc_hw_probe,
 	.driver = {
 		.name = "mtk-jpegenc-hw",
-		.of_match_table = of_match_ptr(mtk_jpegenc_drv_ids),
+		.of_match_table = mtk_jpegenc_drv_ids,
 	},
 };
 
Signature · 1 line
2.39.2
#42 lore raw

PATCH 21/28 media: i2c: isl7998x: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/isl7998x.c:1557:34: error: ‘isl7998x_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/i2c/isl7998x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/isl7998x.c +1 -1
index ae7af2cc94f5..b2b351816b82 100644
@@ -1611,7 +1611,7 @@ static const struct dev_pm_ops isl7998x_pm_ops = {
 static struct i2c_driver isl7998x_i2c_driver = {
 	.driver = {
 		.name = "isl7998x",
-		.of_match_table = of_match_ptr(isl7998x_of_match),
+		.of_match_table = isl7998x_of_match,
 		.pm = &isl7998x_pm_ops,
 	},
 	.probe_new	= isl7998x_probe,
Signature · 1 line
2.34.1
#43 lore raw

PATCH 22/28 media: i2c: mt9m111: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/mt9m111.c:1370:34: error: ‘mt9m111_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/i2c/mt9m111.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/mt9m111.c +1 -1
index f5fe272d1205..20ed87d872c8 100644
@@ -1382,7 +1382,7 @@ MODULE_DEVICE_TABLE(i2c, mt9m111_id);
 static struct i2c_driver mt9m111_i2c_driver = {
 	.driver = {
 		.name = "mt9m111",
-		.of_match_table = of_match_ptr(mt9m111_of_match),
+		.of_match_table = mt9m111_of_match,
 	},
 	.probe_new	= mt9m111_probe,
 	.remove		= mt9m111_remove,
Signature · 1 line
2.34.1
Reviewed-by on v1 22/28
#44 lore raw

Re: [PATCH 22/28] media: i2c: mt9m111: drop of_match_ptr for ID table

Hi Krzysztof,

Thank you for the patch.

Quoted 8 lines · Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/mt9m111.c:1370:34: error: ‘mt9m111_of_match’ defined but not used [-Werror=unused-const-variable=]

Quoted 17 lines
---
 drivers/media/i2c/mt9m111.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/mt9m111.c +1 -1
index f5fe272d1205..20ed87d872c8 100644
@@ -1382,7 +1382,7 @@ MODULE_DEVICE_TABLE(i2c, mt9m111_id);
 static struct i2c_driver mt9m111_i2c_driver = {
 	.driver = {
 		.name = "mt9m111",
-		.of_match_table = of_match_ptr(mt9m111_of_match),
+		.of_match_table = mt9m111_of_match,
 	},
 	.probe_new	= mt9m111_probe,
 	.remove		= mt9m111_remove,
Signature · 3 lines
Regards,

Laurent Pinchart
#45 lore raw

PATCH 23/28 media: i2c: ov2640: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/ov2640.c:1290:34: error: ‘ov2640_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/i2c/ov2640.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov2640.c +1 -1
index 39d56838a4ef..a92c091356c5 100644
@@ -1296,7 +1296,7 @@ MODULE_DEVICE_TABLE(of, ov2640_of_match);
 static struct i2c_driver ov2640_i2c_driver = {
 	.driver = {
 		.name = "ov2640",
-		.of_match_table = of_match_ptr(ov2640_of_match),
+		.of_match_table = ov2640_of_match,
 	},
 	.probe_new = ov2640_probe,
 	.remove   = ov2640_remove,
Signature · 1 line
2.34.1
Reviewed-by on v1 23/28
#46 lore raw

Re: [PATCH 23/28] media: i2c: ov2640: drop of_match_ptr for ID table

Hi Krzysztof,

Thank you for the patch.

Quoted 8 lines · Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/ov2640.c:1290:34: error: ‘ov2640_of_match’ defined but not used [-Werror=unused-const-variable=]

Quoted 17 lines
---
 drivers/media/i2c/ov2640.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov2640.c +1 -1
index 39d56838a4ef..a92c091356c5 100644
@@ -1296,7 +1296,7 @@ MODULE_DEVICE_TABLE(of, ov2640_of_match);
 static struct i2c_driver ov2640_i2c_driver = {
 	.driver = {
 		.name = "ov2640",
-		.of_match_table = of_match_ptr(ov2640_of_match),
+		.of_match_table = ov2640_of_match,
 	},
 	.probe_new = ov2640_probe,
 	.remove   = ov2640_remove,
Signature · 3 lines
Regards,

Laurent Pinchart
#47 lore raw

PATCH 24/28 media: i2c: ov2680: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/ov2680.c:1149:34: error: ‘ov2680_dt_ids’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/i2c/ov2680.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov2680.c +1 -1
index 54153bf66bdd..4d8724952c5f 100644
@@ -1156,7 +1156,7 @@ static struct i2c_driver ov2680_i2c_driver = {
 	.driver = {
 		.name  = "ov2680",
 		.pm = &ov2680_pm_ops,
-		.of_match_table	= of_match_ptr(ov2680_dt_ids),
+		.of_match_table	= ov2680_dt_ids,
 	},
 	.probe_new	= ov2680_probe,
 	.remove		= ov2680_remove,
Signature · 1 line
2.34.1
Reviewed-by on v1 24/28
#48 lore raw

Re: [PATCH 24/28] media: i2c: ov2680: drop of_match_ptr for ID table

Hi Krzysztof,

Thank you for the patch.

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/ov2680.c:1149:34: error: ‘ov2680_dt_ids’ defined but not used [-Werror=unused-const-variable=]

Quoted 17 lines
---
 drivers/media/i2c/ov2680.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov2680.c +1 -1
index 54153bf66bdd..4d8724952c5f 100644
@@ -1156,7 +1156,7 @@ static struct i2c_driver ov2680_i2c_driver = {
 	.driver = {
 		.name  = "ov2680",
 		.pm = &ov2680_pm_ops,
-		.of_match_table	= of_match_ptr(ov2680_dt_ids),
+		.of_match_table	= ov2680_dt_ids,
 	},
 	.probe_new	= ov2680_probe,
 	.remove		= ov2680_remove,
Signature · 3 lines
Regards,

Laurent Pinchart
#49 lore raw

PATCH 25/28 media: i2c: ov7740: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/ov7740.c:1203:34: error: ‘ov7740_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/i2c/ov7740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov7740.c +1 -1
index c9fd9b0bc54a..42121916d25f 100644
@@ -1210,7 +1210,7 @@ static struct i2c_driver ov7740_i2c_driver = {
 	.driver = {
 		.name = "ov7740",
 		.pm = &ov7740_pm_ops,
-		.of_match_table = of_match_ptr(ov7740_of_match),
+		.of_match_table = ov7740_of_match,
 	},
 	.probe_new = ov7740_probe,
 	.remove   = ov7740_remove,
Signature · 1 line
2.34.1
Reviewed-by on v1 25/28
#50 lore raw

Re: [PATCH 25/28] media: i2c: ov7740: drop of_match_ptr for ID table

Hi Krzysztof,

Thank you for the patch.

Quoted 8 lines · Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/ov7740.c:1203:34: error: ‘ov7740_of_match’ defined but not used [-Werror=unused-const-variable=]

Quoted 17 lines
---
 drivers/media/i2c/ov7740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov7740.c +1 -1
index c9fd9b0bc54a..42121916d25f 100644
@@ -1210,7 +1210,7 @@ static struct i2c_driver ov7740_i2c_driver = {
 	.driver = {
 		.name = "ov7740",
 		.pm = &ov7740_pm_ops,
-		.of_match_table = of_match_ptr(ov7740_of_match),
+		.of_match_table = ov7740_of_match,
 	},
 	.probe_new = ov7740_probe,
 	.remove   = ov7740_remove,
Signature · 3 lines
Regards,

Laurent Pinchart
#51 lore raw

PATCH 26/28 media: i2c: imx290: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/imx290.c:1354:34: error: ‘imx290_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/i2c/imx290.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/imx290.c +1 -1
index 49d6c8bdec41..3c9470fbfd53 100644
@@ -1363,7 +1363,7 @@ static struct i2c_driver imx290_i2c_driver = {
 	.driver = {
 		.name  = "imx290",
 		.pm = &imx290_pm_ops,
-		.of_match_table = of_match_ptr(imx290_of_match),
+		.of_match_table = imx290_of_match,
 	},
 };
 
Signature · 1 line
2.34.1
Reviewed-by on v1 26/28
#52 lore raw

Re: [PATCH 26/28] media: i2c: imx290: drop of_match_ptr for ID table

Hi Krzysztof,

Thank you for the patch.

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/imx290.c:1354:34: error: ‘imx290_of_match’ defined but not used [-Werror=unused-const-variable=]

Quoted 17 lines
---
 drivers/media/i2c/imx290.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/imx290.c +1 -1
index 49d6c8bdec41..3c9470fbfd53 100644
@@ -1363,7 +1363,7 @@ static struct i2c_driver imx290_i2c_driver = {
 	.driver = {
 		.name  = "imx290",
 		.pm = &imx290_pm_ops,
-		.of_match_table = of_match_ptr(imx290_of_match),
+		.of_match_table = imx290_of_match,
 	},
 };
 
Signature · 3 lines
Regards,

Laurent Pinchart
#53 lore raw

PATCH 27/28 media: i2c: max9286: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/max9286.c:1707:34: error: ‘max9286_dt_ids’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/i2c/max9286.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/max9286.c +1 -1
index 701038d6d19b..ed932ff9ec74 100644
@@ -1713,7 +1713,7 @@ MODULE_DEVICE_TABLE(of, max9286_dt_ids);
 static struct i2c_driver max9286_i2c_driver = {
 	.driver	= {
 		.name		= "max9286",
-		.of_match_table	= of_match_ptr(max9286_dt_ids),
+		.of_match_table	= max9286_dt_ids,
 	},
 	.probe_new	= max9286_probe,
 	.remove		= max9286_remove,
Signature · 1 line
2.34.1
Reviewed-by on v1 27/28
#54 lore raw

Re: [PATCH 27/28] media: i2c: max9286: drop of_match_ptr for ID table

Hi Krzysztof,

Thank you for the patch.

Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/i2c/max9286.c:1707:34: error: ‘max9286_dt_ids’ defined but not used [-Werror=unused-const-variable=]

Quoted 17 lines
---
 drivers/media/i2c/max9286.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/max9286.c +1 -1
index 701038d6d19b..ed932ff9ec74 100644
@@ -1713,7 +1713,7 @@ MODULE_DEVICE_TABLE(of, max9286_dt_ids);
 static struct i2c_driver max9286_i2c_driver = {
 	.driver	= {
 		.name		= "max9286",
-		.of_match_table	= of_match_ptr(max9286_dt_ids),
+		.of_match_table	= max9286_dt_ids,
 	},
 	.probe_new	= max9286_probe,
 	.remove		= max9286_remove,
Signature · 3 lines
Regards,

Laurent Pinchart
#55 lore raw

PATCH 28/28 media: dvb: mn88443x: drop of_match_ptr for ID table

In reply to Krzysztof Kozlowski

The driver will match mostly by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error:

drivers/media/dvb-frontends/mn88443x.c:782:34: error: ‘mn88443x_of_match’ defined but not used [-Werror=unused-const-variable=]

---
 drivers/media/dvb-frontends/mn88443x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/mn88443x.c +1 -1
index 1f1753f2ab1a..0782f8377eb2 100644
@@ -798,7 +798,7 @@ MODULE_DEVICE_TABLE(i2c, mn88443x_i2c_id);
 static struct i2c_driver mn88443x_driver = {
 	.driver = {
 		.name = "mn88443x",
-		.of_match_table = of_match_ptr(mn88443x_of_match),
+		.of_match_table = mn88443x_of_match,
 	},
 	.probe_new = mn88443x_probe,
 	.remove   = mn88443x_remove,
Signature · 1 line
2.34.1
Reviewed-by on v1 1/28
#56 lore raw
In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

I assume you want to take this series, but if you prefer to have us do it, then just let me know.

Thanks!

Hans

Quoted 17 lines
---
 drivers/media/cec/i2c/ch7322.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/i2c/ch7322.c +1 -1
index 34fad7123704..3c6e6496a001 100644
@@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
 static struct i2c_driver ch7322_i2c_driver = {
 	.driver = {
 		.name = "ch7322",
-		.of_match_table = of_match_ptr(ch7322_of_match),
+		.of_match_table = ch7322_of_match,
 	},
 	.probe_new	= ch7322_probe,
 	.remove		= ch7322_remove,
#57 lore raw
Quoted 5 lines · Hans Verkuil
Quoted 4 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

Quoted 8 lines
Quoted 3 lines

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

I assume you want to take this series, but if you prefer to have us do it, then just let me know.

I prefer if you to take it. Please grab it! :)

Best regards,
Krzysztof

Reviewed-by on v1 1/28
#58 lore raw
In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

FWIW: There is also
https://patches.linaro.org/project/linux-media/patch/[email protected]/

The lack of ACPI support is a real problem and very relevant.

Guenter

Quoted 17 lines
---
 drivers/media/cec/i2c/ch7322.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/i2c/ch7322.c +1 -1
index 34fad7123704..3c6e6496a001 100644
@@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
 static struct i2c_driver ch7322_i2c_driver = {
 	.driver = {
 		.name = "ch7322",
-		.of_match_table = of_match_ptr(ch7322_of_match),
+		.of_match_table = ch7322_of_match,
 	},
 	.probe_new	= ch7322_probe,
 	.remove		= ch7322_remove,
#59 lore raw
Quoted 5 lines · Guenter Roeck
Quoted 4 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

Quoted 8 lines
Quoted 3 lines

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

FWIW: There is also
https://patches.linaro.org/project/linux-media/patch/[email protected]/

I superseded that patch in patchwork in favor of this patch since this is part of a larger series.

Krzysztof, please let me know if you will take this series yourself or want me to make a PR for it.

Regards,

Hans

Quoted 22 lines

The lack of ACPI support is a real problem and very relevant.

Guenter

Quoted 17 lines
---
 drivers/media/cec/i2c/ch7322.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/i2c/ch7322.c +1 -1
index 34fad7123704..3c6e6496a001 100644
@@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
 static struct i2c_driver ch7322_i2c_driver = {
 	.driver = {
 		.name = "ch7322",
-		.of_match_table = of_match_ptr(ch7322_of_match),
+		.of_match_table = ch7322_of_match,
 	},
 	.probe_new	= ch7322_probe,
 	.remove		= ch7322_remove,
#60 lore raw
Quoted 10 lines · Hans Verkuil
Quoted 9 lines · Guenter Roeck
Quoted 7 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

Quoted 7 lines
Quoted 4 lines

FWIW: There is also
https://patches.linaro.org/project/linux-media/patch/[email protected]/

I superseded that patch in patchwork in favor of this patch since this is part of a larger series.

I am personally fan of FIFO, so Guenter's patch should go in.

Quoted 3 lines

Krzysztof, please let me know if you will take this series yourself or want me to make a PR for it.

I prefer if you take entire patchset.

Best regards,
Krzysztof

#61 lore raw
Quoted 13 lines · Krzysztof Kozlowski
Quoted 12 lines · Hans Verkuil
Quoted 11 lines · Guenter Roeck
Quoted 7 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

FWIW: There is also
https://patches.linaro.org/project/linux-media/patch/[email protected]/

I superseded that patch in patchwork in favor of this patch since this is part of a larger series.

I am personally fan of FIFO, so Guenter's patch should go in.

FWIW, I do not care either way, I just wanted to point out that this patch _is_ both relevant and needed, and that it (or, rather, the original version) has been reviewed and tested.

Thanks,
Guenter

#62 lore raw
In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

but it seems it was not applied.

Best regards,
Krzysztof

#63 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Quoted 6 lines

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

but it seems it was not applied.

I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series.

Sakari, did something go wrong?

Regards,

Hans

Quoted 4 lines

Best regards,
Krzysztof

#64 lore raw

Hi Hans,

Quoted 16 lines · Hans Verkuil
Quoted 15 lines · Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

Quoted 6 lines
Quoted 1 line

but it seems it was not applied.

I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series.

Sakari, did something go wrong?

I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for this --- I intended to take these but I think I must have missed something important in the process. I'll take them now.

Thanks.

Signature · 3 lines
Kind regards,

Sakari Ailus
#65 lore raw

Hi folks,

Quoted 24 lines · Sakari Ailus

Hi Hans,

Quoted 21 lines · Hans Verkuil
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Quoted 6 lines

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

but it seems it was not applied.

I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series.

Quoted 7 lines
Quoted 1 line

Sakari, did something go wrong?

I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for this --- I intended to take these but I think I must have missed something important in the process. I'll take them now.

Thanks.

This no longer applied cleanly. Mostly there was fuzz near .of_match_table changes as probe_new (and remove_new?) changes have been recently merged. There were other issues as well, I marked a few patches in the set "not applicable" as other patches had already done equivalent changes earlier.

There were substance-changing changes in the 20th patch, replied to the disuccsion there.

I've pushed the result here and intend to send PR to Mauro soon if there are no issues:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr>

Signature · 3 lines
Kind regards,

Sakari Ailus
#66 lore raw
Quoted 40 lines · Sakari Ailus

Hi folks,

Quoted 24 lines · Sakari Ailus

Hi Hans,

Quoted 21 lines · Hans Verkuil
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Quoted 6 lines

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

but it seems it was not applied.

I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series.

Quoted 7 lines
Quoted 1 line

Sakari, did something go wrong?

I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for this --- I intended to take these but I think I must have missed something important in the process. I'll take them now.

Thanks.

This no longer applied cleanly. Mostly there was fuzz near .of_match_table changes as probe_new (and remove_new?) changes have been recently merged. There were other issues as well, I marked a few patches in the set "not applicable" as other patches had already done equivalent changes earlier.

Quoted 7 lines

There were substance-changing changes in the 20th patch, replied to the disuccsion there.

I've pushed the result here and intend to send PR to Mauro soon if there are no issues:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr>

One month later, I still don't see this set in the linux-next. What's happening here?

Best regards,
Krzysztof

#67 lore raw
Quoted 44 lines · Krzysztof Kozlowski
Quoted 43 lines · Sakari Ailus

Hi folks,

Quoted 24 lines · Sakari Ailus

Hi Hans,

Quoted 21 lines · Hans Verkuil
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Quoted 6 lines

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

but it seems it was not applied.

I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series.

Quoted 7 lines
Quoted 1 line

Sakari, did something go wrong?

I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for this --- I intended to take these but I think I must have missed something important in the process. I'll take them now.

Thanks.

This no longer applied cleanly. Mostly there was fuzz near .of_match_table changes as probe_new (and remove_new?) changes have been recently merged. There were other issues as well, I marked a few patches in the set "not applicable" as other patches had already done equivalent changes earlier.

There were substance-changing changes in the 20th patch, replied to the disuccsion there.

Quoted 8 lines
Quoted 4 lines

I've pushed the result here and intend to send PR to Mauro soon if there are no issues:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr>

One month later, I still don't see this set in the linux-next. What's happening here?

I don't think this was merged in v6.5-rc1. It's not in linux-next, either. Another month passed...

Best regards,
Krzysztof

#68 lore raw
Quoted 48 lines · Krzysztof Kozlowski
Quoted 47 lines · Krzysztof Kozlowski
Quoted 46 lines · Sakari Ailus

Hi folks,

Quoted 24 lines · Sakari Ailus

Hi Hans,

Quoted 21 lines · Hans Verkuil
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Quoted 6 lines

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

but it seems it was not applied.

I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series.

Quoted 7 lines
Quoted 1 line

Sakari, did something go wrong?

I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for this --- I intended to take these but I think I must have missed something important in the process. I'll take them now.

Thanks.

This no longer applied cleanly. Mostly there was fuzz near .of_match_table changes as probe_new (and remove_new?) changes have been recently merged. There were other issues as well, I marked a few patches in the set "not applicable" as other patches had already done equivalent changes earlier.

There were substance-changing changes in the 20th patch, replied to the disuccsion there.

I've pushed the result here and intend to send PR to Mauro soon if there are no issues:

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr>

One month later, I still don't see this set in the linux-next. What's happening here?

I don't think this was merged in v6.5-rc1. It's not in linux-next, either. Another month passed...

I'm really hopeful it will be merged very soon. As you may have noticed (!) we have problems with maintaining the media subsystem (too many patches, not enough maintainers). We had a meeting about that a few weeks ago and are working on it.

The core problem for this particular series was that the PR containing this series was posted much too late (as in three months too late!), and it came in too late for 6.5.

Regards,

Hans

#69 lore raw
In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 48 lines · Krzysztof Kozlowski
Quoted 47 lines · Krzysztof Kozlowski
Quoted 46 lines · Sakari Ailus

Hi folks,

Quoted 24 lines · Sakari Ailus

Hi Hans,

Quoted 21 lines · Hans Verkuil
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

---

Quoted 6 lines

Hans, Sakari,

Can you pick up the patchset? There was positive feedback:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

but it seems it was not applied.

I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series.

Quoted 7 lines
Quoted 1 line

Sakari, did something go wrong?

I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for this --- I intended to take these but I think I must have missed something important in the process. I'll take them now.

Thanks.

This no longer applied cleanly. Mostly there was fuzz near .of_match_table changes as probe_new (and remove_new?) changes have been recently merged. There were other issues as well, I marked a few patches in the set "not applicable" as other patches had already done equivalent changes earlier.

There were substance-changing changes in the 20th patch, replied to the disuccsion there.

I've pushed the result here and intend to send PR to Mauro soon if there are no issues:

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr>

One month later, I still don't see this set in the linux-next. What's happening here?

I don't think this was merged in v6.5-rc1. It's not in linux-next, either. Another month passed...

These are now in the media-stage tree <URL:https://git.linuxtv.org/media_stage.git/log/>. Assuming nothing goes wrong, these should end up in Linus's tree for 6.6.

The issues related to media tree maintenance are being addressed as we're changing the process how the tree is maintained. The patches will eventually get in still, also expect this to improve in the future.

Signature · 3 lines
Regards,

Sakari Ailus
#70 lore raw
Quoted 7 lines · Sakari Ailus
Quoted 3 lines

I don't think this was merged in v6.5-rc1. It's not in linux-next, either. Another month passed...

These are now in the media-stage tree <URL:https://git.linuxtv.org/media_stage.git/log/>. Assuming nothing goes wrong, these should end up in Linus's tree for 6.6.

Great, thank you!

Best regards,
Krzysztof

#71 lore raw
In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here).

drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]

What happened wit hthis patch ? I still don't see it applied.

FWIW:

Reviewed-and-tested-by Guenter Roeck <[email protected]>

Thanks,
Guenter

Quoted 20 lines
---
 drivers/media/cec/i2c/ch7322.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/cec/i2c/ch7322.c +1 -1
index 34fad7123704..3c6e6496a001 100644
@@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
 static struct i2c_driver ch7322_i2c_driver = {
 	.driver = {
 		.name = "ch7322",
-		.of_match_table = of_match_ptr(ch7322_of_match),
+		.of_match_table = ch7322_of_match,
 	},
 	.probe_new	= ch7322_probe,
 	.remove		= ch7322_remove,
Signature · 1 line
2.34.1