Skip to contentSkip to conversation

mm/memory_hotplug: use __pfn_to_section() instead of open-coding

PATCH Applied [email protected] 2 participants 2 messages Mar 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/memory_hotplug: use __pfn_to_section() instead of open-coding

From: chenqiwu <[email protected]>

Use __pfn_to_section() API instead of open-coding or better code readability.

---
 mm/memory_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory_hotplug.c +1 -1
index 19389cd..62e9c66 100644
@@ -494,7 +494,7 @@ static void __remove_section(unsigned long pfn, unsigned long nr_pages,
 			     unsigned long map_offset,
 			     struct vmem_altmap *altmap)
 {
-	struct mem_section *ms = __nr_to_section(pfn_to_section_nr(pfn));
+	struct mem_section *ms = __pfn_to_section(pfn);
 
 	if (WARN_ON_ONCE(!valid_section(ms)))
 		return;
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · On 16.03.20 08:52, [email protected] wrote:

From: chenqiwu <[email protected]>

Use __pfn_to_section() API instead of open-coding or better

s/or/for/

Quoted 13 lines

code readability.

---
 mm/memory_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory_hotplug.c +0 -0
index 19389cd..62e9c66 100644

mm/memory_hotplug.c static void __remove_section(unsigned long pfn, unsigned long nr_pages, · line 500

Quoted 8 lines
mm/memory_hotplug.c +1 -1
@@ -494,7 +494,7 @@ static void __remove_section(unsigned long pfn, unsigned long nr_pages,
 			     unsigned long map_offset,
 			     struct vmem_altmap *altmap)
 {
-	struct mem_section *ms = __nr_to_section(pfn_to_section_nr(pfn));
+	struct mem_section *ms = __pfn_to_section(pfn);
 
 	if (WARN_ON_ONCE(!valid_section(ms)))
 		return;
Signature · 3 lines
Thanks,

David / dhildenb