Skip to contentSkip to conversation

soc: imx8m: No need to put node when of_find_compatible_node() failed

PATCH Applied Anson Huang 2 participants 2 messages Mar 17, 2020 – Apr 14, 2020 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: imx8m: No need to put node when of_find_compatible_node() failed

No need to put node when of_find_compatible_node() failed, return immediately to simplify the code.

---
 drivers/soc/imx/soc-imx8m.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/soc/imx/soc-imx8m.c +3 -4
index 719e1f18..7b0759a 100644
@@ -53,11 +53,11 @@ static u32 __init imx8mq_soc_revision(void)
 	struct device_node *np;
 	void __iomem *ocotp_base;
 	u32 magic;
-	u32 rev = 0;
+	u32 rev;
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-ocotp");
 	if (!np)
-		goto out;
+		return 0;
 
 	ocotp_base = of_iomap(np, 0);
 	WARN_ON(!ocotp_base);
@@ -78,9 +78,8 @@ static u32 __init imx8mq_soc_revision(void)
 	soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW);
 
 	iounmap(ocotp_base);
-
-out:
 	of_node_put(np);
+
 	return rev;
 }
 
Signature · 1 line
2.7.4