Skip to contentSkip to conversation

t210: pinmux: Remove pinmux/GPIO init from T210 boards

PATCH New twarren at nvidia.com 2 participants 3 messages Mar 17, 2020 – Mar 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t210: pinmux: Remove pinmux/GPIO init from T210 boards

From: Tom Warren <[email protected]>

T210 CBoot is now doing the full pinmux and GPIO init, based on the DTB tables. Remove pinmux/GPIO init tables & code from all T210-based builds below:

p2371-2180 aka TX1
p2371-0000
e2220-1170
p2571

---
 board/nvidia/e2220-1170/e2220-1170.c               |  21 +-
 board/nvidia/e2220-1170/pinmux-config-e2220-1170.h | 276 --------------------
 board/nvidia/p2371-0000/p2371-0000.c               |  21 +-
 board/nvidia/p2371-0000/pinmux-config-p2371-0000.h | 267 --------------------
 board/nvidia/p2371-2180/p2371-2180.c               |  21 +-
 board/nvidia/p2371-2180/pinmux-config-p2371-2180.h | 278 ---------------------
 board/nvidia/p2571/p2571.c                         |  21 +-
 board/nvidia/p2571/pinmux-config-p2571.h           | 242 ------------------
 8 files changed, 4 insertions(+), 1143 deletions(-)
 delete mode 100644 board/nvidia/e2220-1170/pinmux-config-e2220-1170.h
 delete mode 100644 board/nvidia/p2371-0000/pinmux-config-p2371-0000.h
 delete mode 100644 board/nvidia/p2371-2180/pinmux-config-p2371-2180.h
 delete mode 100644 board/nvidia/p2571/pinmux-config-p2571.h
board/nvidia/e2220-1170/e2220-1170.c +1 -20
index 8baaf2c..5aac040 100644
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * (C) Copyright 2013-2015
+ * (C) Copyright 2013-2019
  * NVIDIA Corporation <www.nvidia.com>
  */
 
@@ -9,7 +9,6 @@
 #include <asm/arch/gpio.h>
 #include <asm/arch/pinmux.h>
 #include "../p2571/max77620_init.h"
-#include "pinmux-config-e2220-1170.h"
 
 void pin_mux_mmc(void)
 {
@@ -30,21 +29,3 @@ void pin_mux_mmc(void)
 	if (ret)
 		printf("i2c_write 0 0x3c 0x27 failed: %d\n", ret);
 }
-
-/*
- * Routine: pinmux_init
- * Description: Do individual peripheral pinmux configs
- */
-void pinmux_init(void)
-{
-	pinmux_clear_tristate_input_clamping();
-
-	gpio_config_table(e2220_1170_gpio_inits,
-			  ARRAY_SIZE(e2220_1170_gpio_inits));
-
-	pinmux_config_pingrp_table(e2220_1170_pingrps,
-				   ARRAY_SIZE(e2220_1170_pingrps));
-
-	pinmux_config_drvgrp_table(e2220_1170_drvgrps,
-				   ARRAY_SIZE(e2220_1170_drvgrps));
-}
board/nvidia/e2220-1170/pinmux-config-e2220-1170.h deleted +0 -276

276 lines not on this page · raw message

board/nvidia/p2371-0000/p2371-0000.c +1 -20
index e0c907b..5aac040 100644
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * (C) Copyright 2013-2015
+ * (C) Copyright 2013-2019
  * NVIDIA Corporation <www.nvidia.com>
  */
 
@@ -9,7 +9,6 @@
 #include <asm/arch/gpio.h>
 #include <asm/arch/pinmux.h>
 #include "../p2571/max77620_init.h"
-#include "pinmux-config-p2371-0000.h"
 
 void pin_mux_mmc(void)
 {
@@ -30,21 +29,3 @@ void pin_mux_mmc(void)
 	if (ret)
 		printf("i2c_write 0 0x3c 0x27 failed: %d\n", ret);
 }
-
-/*
- * Routine: pinmux_init
- * Description: Do individual peripheral pinmux configs
- */
-void pinmux_init(void)
-{
-	pinmux_clear_tristate_input_clamping();
-
-	gpio_config_table(p2371_0000_gpio_inits,
-			  ARRAY_SIZE(p2371_0000_gpio_inits));
-
-	pinmux_config_pingrp_table(p2371_0000_pingrps,
-				   ARRAY_SIZE(p2371_0000_pingrps));
-
-	pinmux_config_drvgrp_table(p2371_0000_drvgrps,
-				   ARRAY_SIZE(p2371_0000_drvgrps));
-}
board/nvidia/p2371-0000/pinmux-config-p2371-0000.h deleted +0 -267

267 lines not on this page · raw message

board/nvidia/p2371-2180/p2371-2180.c +1 -20
index fa5288b..1756bbc 100644
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * (C) Copyright 2013-2015
+ * (C) Copyright 2013-2019
  * NVIDIA Corporation <www.nvidia.com>
  */
 
@@ -13,7 +13,6 @@
 #include <asm/arch/pinmux.h>
 #include <asm/arch-tegra/cboot.h>
 #include "../p2571/max77620_init.h"
-#include "pinmux-config-p2371-2180.h"
 
 void pin_mux_mmc(void)
 {
@@ -57,24 +56,6 @@ void pin_mux_mmc(void)
 	}
 }
 
-/*
- * Routine: pinmux_init
- * Description: Do individual peripheral pinmux configs
- */
-void pinmux_init(void)
-{
-	pinmux_clear_tristate_input_clamping();
-
-	gpio_config_table(p2371_2180_gpio_inits,
-			  ARRAY_SIZE(p2371_2180_gpio_inits));
-
-	pinmux_config_pingrp_table(p2371_2180_pingrps,
-				   ARRAY_SIZE(p2371_2180_pingrps));
-
-	pinmux_config_drvgrp_table(p2371_2180_drvgrps,
-				   ARRAY_SIZE(p2371_2180_drvgrps));
-}
-
 #ifdef CONFIG_PCI_TEGRA
 int tegra_pcie_board_init(void)
 {
board/nvidia/p2371-2180/pinmux-config-p2371-2180.h deleted +0 -278

278 lines not on this page · raw message

board/nvidia/p2571/p2571.c +1 -20
index dba3579..a9e4d21 100644
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * (C) Copyright 2013-2015
+ * (C) Copyright 2013-2019
  * NVIDIA Corporation <www.nvidia.com>
  */
 
@@ -10,7 +10,6 @@
 #include <asm/arch/pinmux.h>
 #include <asm/gpio.h>
 #include "max77620_init.h"
-#include "pinmux-config-p2571.h"
 
 void pin_mux_mmc(void)
 {
@@ -33,24 +32,6 @@ void pin_mux_mmc(void)
 }
 
 /*
- * Routine: pinmux_init
- * Description: Do individual peripheral pinmux configs
- */
-void pinmux_init(void)
-{
-	pinmux_clear_tristate_input_clamping();
-
-	gpio_config_table(p2571_gpio_inits,
-			  ARRAY_SIZE(p2571_gpio_inits));
-
-	pinmux_config_pingrp_table(p2571_pingrps,
-				   ARRAY_SIZE(p2571_pingrps));
-
-	pinmux_config_drvgrp_table(p2571_drvgrps,
-				   ARRAY_SIZE(p2571_drvgrps));
-}
-
-/*
  * Routine: start_cpu_fan
  * Description: Enable/start PWM CPU fan on P2571
  */
board/nvidia/p2571/pinmux-config-p2571.h deleted +0 -242

242 lines not on this page · raw message

Signature · 9 lines
1.8.2.1.610.g562af5b


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
#1 lore raw

PATCH 1/1 t210: pinmux: Remove pinmux/GPIO init from T210 boards

Quoted 10 lines · twarren at nvidia.com

From: Tom Warren <[email protected]>

T210 CBoot is now doing the full pinmux and GPIO init, based on the DTB tables. Remove pinmux/GPIO init tables & code from all T210-based builds below:

p2371-2180 aka TX1
p2371-0000
e2220-1170
p2571

It may be worth updating the commit description to mention explicitly which L4T release's FW is required when using a U-Boot that has this patch applied.

Can we remove the T210 pinmux driver from U-Boot with this patch applied?

author
#2 lore raw

PATCH 1/1 t210: pinmux: Remove pinmux/GPIO init from T210 boards

-----Original Message-----
From: Stephen Warren <[email protected]>
Sent: Wednesday, March 18, 2020 4:14 PM
To: Tom Warren <[email protected]>
Cc: u-boot at lists.denx.de; Stephen Warren <[email protected]>; Thierry Reding <[email protected]>; Jonathan Hunter <[email protected]>; tomcwarren3959 at gmail.com
Subject: Re: [PATCH] t210: pinmux: Remove pinmux/GPIO init from T210 boards

External email: Use caution opening links or attachments

Quoted 11 lines · twarren at nvidia.com

From: Tom Warren <[email protected]>

T210 CBoot is now doing the full pinmux and GPIO init, based on the DTB tables. Remove pinmux/GPIO init tables & code from all T210-based builds
below:

p2371-2180 aka TX1
p2371-0000
e2220-1170
p2571

It may be worth updating the commit description to mention explicitly which L4T release's FW is required when using a U-Boot that has this patch applied. [Tom] I'll do that for v2, thanks.

Can we remove the T210 pinmux driver from U-Boot with this patch applied?
[Tom] Good idea, I'll look at it. Seems like it should work if I excise arch/arm/mach-tegra/pinmux.c.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------