Skip to contentSkip to conversation

phy: tegra: should select USB_PHY

PATCH In review Corentin Labbe 2 participants 2 messages Mar 18, 2020 – Mar 23, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: tegra: should select USB_PHY

I have hit the following build error:
armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_port_unregister':
xusb.c:(.text+0x2ac): undefined reference to usb_remove_phy' armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function tegra_xusb_setup_ports':
xusb.c:(.text+0xf30): undefined reference to `usb_add_phy_dev'

PHY_TEGRA_XUSB should select USB_PHY

Fixes 23babe30fb45d ("phy: tegra: xusb: Add usb-phy support")
Cc stable <[email protected]>
---
 drivers/phy/tegra/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/tegra/Kconfig +1 -0
index df07c4dea059..a208aca4ba7b 100644
@@ -3,6 +3,7 @@ config PHY_TEGRA_XUSB
 	tristate "NVIDIA Tegra XUSB pad controller driver"
 	depends on ARCH_TEGRA
 	select USB_CONN_GPIO
+	select USB_PHY
 	help
 	  Choose this option if you have an NVIDIA Tegra SoC.
 
Signature · 1 line
2.24.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 33 lines · Corentin Labbe

External email: Use caution opening links or attachments

I have hit the following build error:
armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_port_unregister':
xusb.c:(.text+0x2ac): undefined reference to usb_remove_phy' armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function tegra_xusb_setup_ports':
xusb.c:(.text+0xf30): undefined reference to `usb_add_phy_dev'

PHY_TEGRA_XUSB should select USB_PHY

Fixes 23babe30fb45d ("phy: tegra: xusb: Add usb-phy support")
Cc stable <[email protected]>
---
  drivers/phy/tegra/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/phy/tegra/Kconfig +1 -1
index df07c4dea059..a208aca4ba7b 100644
@@ -3,6 +3,7 @@ config PHY_TEGRA_XUSB
         tristate "NVIDIA Tegra XUSB pad controller driver"
         depends on ARCH_TEGRA
         select USB_CONN_GPIO
+       select USB_PHY
         help
           Choose this option if you have an NVIDIA Tegra SoC.
 
--

2.24.1