Skip to contentSkip to conversation

PCI: dwc: fix compile err for pcie-tagra194

PATCH In review Qiujun Huang 2 participants 2 messages Mar 20, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 PCI: dwc: fix compile err for pcie-tagra194

make allmodconfig
ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2

need to export the symbols.

---
 drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/pci/controller/dwc/pcie-designware-ep.c +4 -0
index 4233c43..1cdcbd1 100644
@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
 
 	pci_epc_linkup(epc);
 }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
 
 void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
 {
@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
 
 	pci_epc_init_notify(epc);
 }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
 
 static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
 				   int flags)
@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);
 
 int dw_pcie_ep_init(struct dw_pcie_ep *ep)
 {
@@ -629,3 +632,4 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
 
 	return dw_pcie_ep_init_complete(ep);
 }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init);
Signature · 1 line
1.8.3.1
Reviewed-by Tested-by on v2 1/1
#1 lore raw
Quoted 53 lines · Qiujun Huang

External email: Use caution opening links or attachments

make allmodconfig
ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2

need to export the symbols.

---
  drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/pci/controller/dwc/pcie-designware-ep.c +4 -1
index 4233c43..1cdcbd1 100644
@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
 
         pci_epc_linkup(epc);
  }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
 
  void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
  {
@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
 
         pci_epc_init_notify(epc);
  }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
 
  static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
                                    int flags)
@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
 
         return 0;
  }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);
 
  int dw_pcie_ep_init(struct dw_pcie_ep *ep)
  {
@@ -629,3 +632,4 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
 
         return dw_pcie_ep_init_complete(ep);
  }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init);
--
Quoted 2 lines

1.8.3.1

Thanks for the change Qiujun.