Skip to contentSkip to conversation

librte_eal: ease init in a docker container

PATCH Superseded Nicolas Dichtel 4 participants 9 messages May 22, 2019 – Jun 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 librte_eal: ease init in a docker container

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

---
 lib/librte_eal/linux/eal/eal_memalloc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
lib/librte_eal/linux/eal/eal_memalloc.c +7 -3
index 1e9ebb86dd1b..438faa0ab168 100644
@@ -600,9 +600,13 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
 	}
 
 #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES
-	move_pages(getpid(), 1, &addr, NULL, &cur_socket_id, 0);
-
-	if (cur_socket_id != socket_id) {
+	ret = get_mempolicy(&cur_socket_id, NULL, 0, addr,
+			    MPOL_F_NODE | MPOL_F_ADDR);
+	if (ret < 0) {
+		RTE_LOG(DEBUG, EAL, "%s(): get_mempolicy: %s\n",
+			__func__, strerror(errno));
+		goto mapped;
+	} else if (cur_socket_id != socket_id) {
 		RTE_LOG(DEBUG, EAL,
 				"%s(): allocation happened on wrong socket (wanted %d, got %d)\n",
 			__func__, socket_id, cur_socket_id);
Signature · 1 line
2.21.0
#1 lore raw
Quoted 6 lines · Nicolas Dichtel

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Quoted 7 lines

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

---

I can see the check for move_pages and it's a good fix, but what is the relation to docker init here? The patch by itself only enables handling of move_pages() failure and adds nothing else. The commit message doesn't match the patch in question IMO.

Also, Cc: stable and Fixes: ?

Signature · 2 lines
Thanks,
Anatoly
#2 lore raw

Le 22/05/2019 à 17:57, Burakov, Anatoly a écrit :

Quoted 15 lines · Nicolas Dichtel
Quoted 6 lines

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Quoted 7 lines

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

---

Quoted 4 lines

I can see the check for move_pages and it's a good fix, but what is the relation to docker init here? The patch by itself only enables handling of move_pages() failure and adds nothing else. The commit message doesn't match the patch in question IMO.

I'm not sure to understand your comment. The call to move_pages() is replaced by a call to get_mempolicy().
What am I missing?

Regards,
Nicolas

#3 lore raw
Quoted 17 lines · Nicolas Dichtel

Le 22/05/2019 à 17:57, Burakov, Anatoly a écrit :

Quoted 15 lines · Nicolas Dichtel
Quoted 13 lines

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

---

Quoted 8 lines
Quoted 4 lines

I can see the check for move_pages and it's a good fix, but what is the relation to docker init here? The patch by itself only enables handling of move_pages() failure and adds nothing else. The commit message doesn't match the patch in question IMO.

I'm not sure to understand your comment. The call to move_pages() is replaced by a call to get_mempolicy().
What am I missing?

Oh, apologies, i misread the patch. It is i who was missing something :)

Quoted 4 lines

Regards,
Nicolas

Signature · 2 lines
Thanks,
Anatoly
Acked-by on v1 1/1
#4 lore raw
In reply to Nicolas Dichtel
Quoted 6 lines · Nicolas Dichtel

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Quoted 7 lines

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

---

Still, should at least specify Cc: stable, if not Fixes tag too (since ignoring return value of move_pages() is technically a bug).

Signature · 2 lines
Thanks,
Anatoly
#5 lore raw

s/librte_eal/mem/ for the title prefix.

Quoted 16 lines · Anatoly
Quoted 2 lines · Nicolas Dichtel

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update

of

Quoted 11 lines

the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

---

Quoted 5 lines

Still, should at least specify Cc: stable, if not Fixes tag too (since ignoring return value of move_pages() is technically a bug).

+1
At first I was wondering if we should separate the fix from the enhancement, but I suppose backporting both things as one patch is fine too.

Signature · 1 line
David Marchand
#6 lore raw

PATCH v2 1/1 mem: ease init in a docker container

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

Fixes 582bed1e1d1d ("mem: support mapping hugepages at runtime")

---

v2: add fixes tag + cc stable
fix title prefix

 lib/librte_eal/linux/eal/eal_memalloc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
lib/librte_eal/linux/eal/eal_memalloc.c +7 -3
index 1e9ebb86dd1b..438faa0ab168 100644
@@ -600,9 +600,13 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
 	}
 
 #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES
-	move_pages(getpid(), 1, &addr, NULL, &cur_socket_id, 0);
-
-	if (cur_socket_id != socket_id) {
+	ret = get_mempolicy(&cur_socket_id, NULL, 0, addr,
+			    MPOL_F_NODE | MPOL_F_ADDR);
+	if (ret < 0) {
+		RTE_LOG(DEBUG, EAL, "%s(): get_mempolicy: %s\n",
+			__func__, strerror(errno));
+		goto mapped;
+	} else if (cur_socket_id != socket_id) {
 		RTE_LOG(DEBUG, EAL,
 				"%s(): allocation happened on wrong socket (wanted %d, got %d)\n",
 			__func__, socket_id, cur_socket_id);
Signature · 1 line
2.21.0
Reviewed-by on v2 1/1
#7 lore raw

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: ease init in a docker container

Quoted 46 lines · Nicolas Dichtel

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

Fixes 582bed1e1d1d ("mem: support mapping hugepages at runtime")

---

v2: add fixes tag + cc stable
fix title prefix

 lib/librte_eal/linux/eal/eal_memalloc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
lib/librte_eal/linux/eal/eal_memalloc.c +7 -3
index 1e9ebb86dd1b..438faa0ab168 100644
@@ -600,9 +600,13 @@ alloc_seg(struct rte_memseg *ms, void *addr, int
 socket_id,
        }
 
 #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES
-       move_pages(getpid(), 1, &addr, NULL, &cur_socket_id, 0);
-
-       if (cur_socket_id != socket_id) {
+       ret = get_mempolicy(&cur_socket_id, NULL, 0, addr,
+                           MPOL_F_NODE | MPOL_F_ADDR);
+       if (ret < 0) {
+               RTE_LOG(DEBUG, EAL, "%s(): get_mempolicy: %s\n",
+                       __func__, strerror(errno));
+               goto mapped;
+       } else if (cur_socket_id != socket_id) {
                RTE_LOG(DEBUG, EAL,
                                "%s(): allocation happened on wrong socket

(wanted %d, got %d)\n",

Quoted 5 lines
                        __func__, socket_id, cur_socket_id);

--
2.21.0

Signature · 1 line
David Marchand
#8 lore raw

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: ease init in a docker container

23/05/2019 16:29, David Marchand:

Quoted 12 lines
Quoted 9 lines · Nicolas Dichtel

move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile).
get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile.

Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0).

Quoted 7 lines
Quoted 6 lines
Fixes 582bed1e1d1d ("mem: support mapping hugepages at runtime")

Applied, thanks Nico