Skip to contentSkip to conversation

arm: dts: rockchip: rk3399-roc-pc: Enable FE1.1 USB 2.0 HUB on roc-rk3399-pc

PATCH New sunil at amarulasolutions.com 4 participants 6 messages Mar 25, 2020 – Apr 25, 2020 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: rockchip: rk3399-roc-pc: Enable FE1.1 USB 2.0 HUB on roc-rk3399-pc

From: Suniel Mahesh <[email protected]>

roc-rk3399-pc has an FE1.1 USB 2.0 HUB which connects two USB ports (HOST1 and HOST2). For end devices to work we need to enable USB hub so that HOST detects there presence and enumerates them accordingly. This requires explicit pinctrl within gpio enablement.

---
Note:
1. tested this on roc-rk3399-pc board version roc-rk3399-pc-v1.1-a 2018-9-25
2. after this changeset, HOST1 works but HOST2 still doesnt work. I have tested them with linux-next, linux-rockchip and Firefly's source (both u-boot and kernel), HOST2 doesn't work.
3. Request to test this changetest who have access to target and please advice on HOST2

---
 arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +10 -0
index 5746442..598e0e2 100644
@@ -14,6 +14,16 @@
 	chosen {
 		u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
 	};
+
+	vcc_hub_en: vcc_hub_en-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hub_rst>;
+		regulator-name = "vcc_hub_en";
+		regulator-always-on;
+	};
 };
 
 &vdd_log {
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 arm: dts: rockchip: rk3399-roc-pc: Enable FE1.1 USB 2.0 HUB on roc-rk3399-pc

Quoted 8 lines · sunil at amarulasolutions.com

From: Suniel Mahesh <[email protected]>

roc-rk3399-pc has an FE1.1 USB 2.0 HUB which connects two USB ports (HOST1 and HOST2). For end devices to work we need to enable USB hub so that HOST detects there presence and enumerates them accordingly. This requires explicit pinctrl within gpio enablement.

Thanks,
- Kever

Quoted 33 lines

---
Note:
1. tested this on roc-rk3399-pc board version roc-rk3399-pc-v1.1-a 2018-9-25
2. after this changeset, HOST1 works but HOST2 still doesnt work. I have tested them with linux-next, linux-rockchip and Firefly's source (both u-boot and kernel), HOST2 doesn't work.
3. Request to test this changetest who have access to target and please advice on HOST2

---
  arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)
arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +10 -0
index 5746442..598e0e2 100644
@@ -14,6 +14,16 @@
  	chosen {
  		u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
  	};
+
+	vcc_hub_en: vcc_hub_en-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hub_rst>;
+		regulator-name = "vcc_hub_en";
+		regulator-always-on;
+	};
  };
 
  &vdd_log {
#2 lore raw

PATCH 1/1 arm: dts: rockchip: rk3399-roc-pc: Enable FE1.1 USB 2.0 HUB on roc-rk3399-pc

Quoted 9 lines · Kever Yang
Quoted 7 lines · sunil at amarulasolutions.com

From: Suniel Mahesh <[email protected]>

roc-rk3399-pc has an FE1.1 USB 2.0 HUB which connects two USB ports (HOST1 and HOST2). For end devices to work we need to enable USB hub so that HOST detects there presence and enumerates them accordingly. This requires explicit pinctrl within gpio enablement.

Quoted 5 lines
Quoted 1 line

Hi Kever,
This is patch is reviewed but not applied to mainline. please let me know if you need any more changes.

Thanks
Suniel

Quoted 43 lines

Thanks,
- Kever

Quoted 3 lines

---
Note:
1. tested this on roc-rk3399-pc board version roc-rk3399-pc-v1.1-a

2018-9-25

Quoted 2 lines

2. after this changeset, HOST1 works but HOST2 still doesnt work. I have tested them with linux-next, linux-rockchip and Firefly's source (both

u-boot

Quoted 2 lines

and kernel), HOST2 doesn't work.
3. Request to test this changetest who have access to target and please

advice

Review

Quoted 6 lines

on HOST2

---
  arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/rk3399-roc-pc-u-boot.dtsi

Quoted 20 lines

index 5746442..598e0e2 100644

arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +10 -0
@@ -14,6 +14,16 @@
      chosen {
              u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
      };
+
+     vcc_hub_en: vcc_hub_en-regulator {
+             compatible = "regulator-fixed";
+             enable-active-high;
+             gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
+             pinctrl-names = "default";
+             pinctrl-0 = <&hub_rst>;
+             regulator-name = "vcc_hub_en";
+             regulator-always-on;
+     };
  };
 
  &vdd_log {
#3 lore raw

PATCH RESEND 1/1 arm: dts: rockchip: rk3399-roc-pc: Enable FE1.1 USB 2.0 HUB on roc-rk3399-pc

In reply to Kever Yang

From: Suniel Mahesh <[email protected]>

roc-rk3399-pc has an FE1.1 USB 2.0 HUB which connects two USB ports (HOST1 and HOST2). For end devices to work we need to enable USB hub so that HOST detects there presence and enumerates them accordingly. This requires explicit pinctrl within gpio enablement.

---
Note:
1. patch was reviewed, but not committed to mainline
2. tested this on roc-rk3399-pc board version roc-rk3399-pc-v1.1-a 2018-9-25

---
 arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +10 -0
index 5746442..598e0e2 100644
@@ -14,6 +14,16 @@
 	chosen {
 		u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
 	};
+
+	vcc_hub_en: vcc_hub_en-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hub_rst>;
+		regulator-name = "vcc_hub_en";
+		regulator-always-on;
+	};
 };
 
 &vdd_log {
Signature · 1 line
2.7.4
#4 lore raw

PATCH 1/1 arm: dts: rockchip: rk3399-roc-pc: Enable FE1.1 USB 2.0 HUB on roc-rk3399-pc

In reply to sunil at amarulasolutions.com

Hi Markus and Levin,

Quoted 30 lines · On Wed, Mar 25, 2020 at 9:08 PM <[email protected]> wrote:

From: Suniel Mahesh <[email protected]>

roc-rk3399-pc has an FE1.1 USB 2.0 HUB which connects two USB ports (HOST1 and HOST2). For end devices to work we need to enable USB hub so that HOST detects there presence and enumerates them accordingly. This requires explicit pinctrl within gpio enablement.

---
Note:
1. tested this on roc-rk3399-pc board version roc-rk3399-pc-v1.1-a 2018-9-25
2. after this changeset, HOST1 works but HOST2 still doesnt work. I have tested them with linux-next, linux-rockchip and Firefly's source (both u-boot and kernel), HOST2 doesn't work.
3. Request to test this changetest who have access to target and please advice on HOST2

---
 arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +1 -0
index 5746442..598e0e2 100644
@@ -14,6 +14,16 @@
        chosen {
                u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
        };
+

arch/arm/dts/rk3399-roc-pc-u-boot.dtsi line 27

Quoted 10 lines
arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +9 -0
+       vcc_hub_en: vcc_hub_en-regulator {
+               compatible = "regulator-fixed";
+               enable-active-high;
+               gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
+               pinctrl-names = "default";
+               pinctrl-0 = <&hub_rst>;
+               regulator-name = "vcc_hub_en";
+               regulator-always-on;
+       };
 };

Can you please confirm the tests from your side? not sure why would an explicit vbus_hub_en required here since the vcc5v0_host has it, but without pinctrl.

Jagan

#5 lore raw

PATCH 1/1 arm: dts: rockchip: rk3399-roc-pc: Enable FE1.1 USB 2.0 HUB on roc-rk3399-pc

Hi Jagan,

My boards are -V1.0-A 2018-07-12.

With this patch below, both HOST1 and HOST2 (and of course HOST0) detect an USB stick in current U-Boot.

Without this patch below, only HOST0
detects an USB stick.

I suspect, your HOST2 HW is broken.

Gru?,
--
Markus

Am 27.03.20 um 10:43 schrieb Jagan Teki:

Quoted 50 lines

Hi Markus and Levin,

Quoted 30 lines · On Wed, Mar 25, 2020 at 9:08 PM <[email protected]> wrote:

From: Suniel Mahesh <[email protected]>

roc-rk3399-pc has an FE1.1 USB 2.0 HUB which connects two USB ports (HOST1 and HOST2). For end devices to work we need to enable USB hub so that HOST detects there presence and enumerates them accordingly. This requires explicit pinctrl within gpio enablement.

---
Note:
1. tested this on roc-rk3399-pc board version roc-rk3399-pc-v1.1-a 2018-9-25
2. after this changeset, HOST1 works but HOST2 still doesnt work. I have tested them with linux-next, linux-rockchip and Firefly's source (both u-boot and kernel), HOST2 doesn't work.
3. Request to test this changetest who have access to target and please advice on HOST2

---
 arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +1 -0
index 5746442..598e0e2 100644
@@ -14,6 +14,16 @@
        chosen {
                u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
        };
+

arch/arm/dts/rk3399-roc-pc-u-boot.dtsi line 27

Quoted 10 lines
arch/arm/dts/rk3399-roc-pc-u-boot.dtsi +9 -0
+       vcc_hub_en: vcc_hub_en-regulator {
+               compatible = "regulator-fixed";
+               enable-active-high;
+               gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
+               pinctrl-names = "default";
+               pinctrl-0 = <&hub_rst>;
+               regulator-name = "vcc_hub_en";
+               regulator-always-on;
+       };
 };

Can you please confirm the tests from your side? not sure why would an explicit vbus_hub_en required here since the vcc5v0_host has it, but without pinctrl.

Jagan