ima-evm-utils: Add some tests for evmctl

Quoted 1 line · Vitaly Chikunov

Run `make check' to execute the tests.

autogen.sh followed by configure need to be run. Could you please add that in the patch description?

tests/functions.sh line 2

Quoted 8 lines

tests/functions.sh new file +2 -0

new file mode 100755
index 0000000..16c8d89
@@ -0,0 +1,272 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0

In some source files in the kernel repo I have seen the following:

    // SPDX-License-Identifier: GPL-2.0+

Not sure if it is applicable here.

tests/functions.sh line 9

Quoted 7 lines

tests/functions.sh new file +7 -0

+check() {
+  local alg=$1 pref=$2 chash=$3 hash
+  local file=$alg-hash.txt
+
+  rm -f $file
+  touch $file
+  # Generate hash with openssl, if it's failed skip test,

"if it failed skip test"

Quoted 4 lines

tests/functions.sh new file +4 -0

+  # unless it's negative test, then pass to evmctl
+  cmd="openssl dgst $OPENSSL_ENGINE -$alg $file"
+}
+

tests/functions.sh line 16

Quoted 3 lines

tests/functions.sh new file +3 -0

+# check args: algo hdr-prefix canonic-hash
+expect_pass check  md4        0x01 31d6cfe0d16ae931b73c59d7e0c089c0
+expect_pass check  md5        0x01 d41d8cd98f00b204e9800998ecf8427e

Is MD4 and MD5 tests still needed?

 -lakshmi

Quoted 6 lines · Lakshmi Ramasubramanian

Quoted 1 line · Vitaly Chikunov

Run `make check' to execute the tests.

autogen.sh followed by configure need to be run. Could you please add that in the patch description?

Quoted 11 lines

tests/functions.sh line 2

Quoted 8 lines

tests/functions.sh new file +2 -0

new file mode 100755
index 0000000..16c8d89
@@ -0,0 +1,272 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0

In some source files in the kernel repo I have seen the following:

Quoted 3 lines

    // SPDX-License-Identifier: GPL-2.0+

Not sure if it is applicable here.

Quoted 16 lines

tests/functions.sh line 9

Quoted 8 lines

tests/functions.sh new file +7 -0

+check() {
+  local alg=$1 pref=$2 chash=$3 hash
+  local file=$alg-hash.txt
+
+  rm -f $file
+  touch $file
+  # Generate hash with openssl, if it's failed skip test,

"if it failed skip test"

Quoted 4 lines

tests/functions.sh new file +4 -0

+  # unless it's negative test, then pass to evmctl
+  cmd="openssl dgst $OPENSSL_ENGINE -$alg $file"
+}
+

Quoted 4 lines

tests/functions.sh line 16

Quoted 3 lines

tests/functions.sh new file +3 -0

+# check args: algo hdr-prefix canonic-hash
+expect_pass check  md4        0x01 31d6cfe0d16ae931b73c59d7e0c089c0
+expect_pass check  md5        0x01 d41d8cd98f00b204e9800998ecf8427e

Is MD4 and MD5 tests still needed?

Quoted 3 lines

 -lakshmi

+ Mimi and linux-integrity

Run `make check' to execute the tests.
This commit only adds ima_hash test.

Signed-off-by Vitaly Chikunov <[email protected]>

tests/functions.sh new file +25 -0

new file mode 100755
index 0000000..16c8d89
@@ -0,0 +1,272 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+#
+# ima-evm-utils tests bash functions
+#
+# Copyright (C) 2019 Vitaly Chikunov <[email protected]>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# Tests accounting
+declare -i testspass=0 testsfail=0 testsskip=0
+
+# Exit codes (compatible with automake)
+declare -r OK=0
+declare -r FAIL=1
+declare -r HARDFAIL=99 # hard failure no matter testing mode
+declare -r SKIP=77

tests/functions.sh new file +36 -0

+    exit $1
+  fi
+}
+
+# Require particular executables to be present
+_require() {
+  ret=
+  for i; do
+    if ! type $i; then
+      echo "$i is required for test"
+      ret=1
+    fi
+  done
+  [ $ret ] && exit $HARDFAIL
+}
+
+# Only allow color output on tty
+if [ -t 1 ]; then
+     RED=$'\e[1;31m'
+   GREEN=$'\e[1;32m'
+  YELLOW=$'\e[1;33m'
+    BLUE=$'\e[1;34m'
+    CYAN=$'\e[1;36m'
+    NORM=$'\e[m'
+fi
+
+# Test mode determined by TFAIL variable:
+#   undefined: to success testing
+#   defined: failure testing
+TFAIL=
+TMODE=+ # mode character to prepend running command in log
+declare -i TNESTED=0 # just for sanity checking
+
+# Run positive test (one that should pass) and account its result
+expect_pass() {
+  local ret

tests/functions.sh new file +56 -0

+  "$@"
+  ret=$?
+  [[ "$VERBOSE" -gt 1 ]] && echo "^^^^ STOP ($ret) positive test: $@"
+  TNESTED+=-1
+  case $ret in
+    0)  testspass+=1 ;;
+    77) testsskip+=1 ;;
+    99) testsfail+=1; exit_early 1 ;;
+    *)  testsfail+=1; exit_early 2 ;;
+  esac
+  return $ret
+}
+
+# Eval negative test (one that should fail) and account its result
+expect_fail() {
+  local ret
+
+  if [ $TNESTED -gt 0 ]; then
+    echo $RED"expect_fail should not be run nested"$NORM
+    testsfail+=1
+    exit $HARDFAIL
+  fi
+
+  TFAIL=yes
+  TMODE=-
+  TNESTED+=1
+  [[ "$VERBOSE" -gt 1 ]] && echo "____ START negative test: $@"
+  "$@"
+  ret=$?
+  [[ "$VERBOSE" -gt 1 ]] && echo "^^^^ STOP ($ret) negative test: $@"
+  TNESTED+=-1
+  case $ret in
+    0)  testsfail+=1; exit_early 3 ;;
+    77) testsskip+=1 ;;
+    99) testsfail+=1; exit_early 4 ;;
+    *)  testspass+=1 ;;
+  esac
+  # Restore defaults (as in positive tests)
+  # for tests to run without wrappers
+  TFAIL=
+  TMODE=+
+  return $ret
+}
+
+# return true if current test is positive
+_is_expect_pass() {
+  [ ! $TFAIL ]
+}
+
+# return true if current test is negative
+_is_expect_fail() {
+  [ $TFAIL ]
+}
+
+# Show blank line and color following text to red
+# if it's real error (ie we are in expect_pass mode).

tests/functions.sh new file +84 -0

+  COLOR_RESTORE=1
+}
+
+color_restore() {
+  [ $COLOR_RESTORE ] && echo $@ $NORM
+  COLOR_RESTORE=
+}
+
+ADD_DEL=
+ADD_TEXT_FOR=
+# _evmctl_run should be run as `_evmctl_run ... || return'
+_evmctl_run() {
+  local op=$1 out=$1-$$.out
+  local text_for=${FOR:+for $ADD_TEXT_FOR}
+  # Additional parameters:
+  # ADD_DEL: additional files to rm on failure
+  # ADD_TEXT_FOR: append to text as 'for $ADD_TEXT_FOR'
+
+  cmd="evmctl $V $EVMCTL_ENGINE $@"
+  echo $YELLOW$TMODE $cmd$NORM
+  $cmd >$out 2>&1
+  ret=$?
+
+  # Shell special and signal exit codes (except 255)
+  if [ $ret -ge 126 -a $ret -lt 255 ]; then
+    red_always
+    echo "evmctl $op failed hard with ($ret) $text_for"
+    sed 's/^/  /' $out
+    color_restore
+    rm $out $ADD_DEL
+    ADD_DEL=
+    ADD_TEXT_FOR=
+    return $HARDFAIL
+  elif [ $ret -gt 0 ]; then
+    red_if_failure
+    echo "evmctl $op failed" ${TFAIL:+properly} "with ($ret) $text_for"
+    # Show evmctl output only in verbose mode or if real failure.
+    if _is_expect_pass || [ "$VERBOSE" ]; then
+      sed 's/^/  /' $out
+    fi
+    color_restore
+    rm $out $ADD_DEL
+    ADD_DEL=
+    ADD_TEXT_FOR=
+    return $FAIL
+  elif _is_expect_fail; then
+    red_always
+    echo "evmctl $op wrongly succeeded $text_for"
+    sed 's/^/  /' $out
+    color_restore
+  else
+    [ "$VERBOSE" ] && sed 's/^/  /' $out
+  fi
+  rm $out
+  ADD_DEL=
+  ADD_TEXT_FOR=
+  return $OK
+}
+
+# Extract xattr $attr from $file into $out file skipping $pref'ix
+_extract_xattr() {
+  local file=$1 attr=$2 out=$3 pref=$4
+
+  getfattr -n $attr -e hex $file \
+    | grep "^$attr=" \
+    | sed "s/^$attr=$pref//" \
+    | xxd -r -p > $out
+}
+
+# Test if xattr $attr in $file matches $pref'ix
+# Show error and fail otherwise.
+_test_xattr() {
+  local file=$1 attr=$2 pref=$3
+  local text_for=${ADD_TEXT_FOR:+ for $ADD_TEXT_FOR}
+
+  if ! getfattr -n $attr -e hex $file | egrep -qx "$attr=$pref"; then
+    red_if_failure
+    echo "Did not find expected hash$text_for:"
+    echo "    $attr=$pref"
+    echo ""
+    echo "Actual output below:"
+    getfattr -n $attr -e hex $file | sed 's/^/    /'
+    color_restore
+    rm $file

tests/functions.sh new file +31 -0

+    && openssl engine gost >/dev/null 2>&1; then
+    EVMCTL_ENGINE="--engine gost"
+    OPENSSL_ENGINE="-engine gost"
+  fi
+}
+
+# Show test stats and exit into automake test system
+# with proper exit code (same as ours).
+_report_exit() {
+  if [ $testsfail -gt 0 ]; then
+    echo "================================="
+    echo " Run with FAILEARLY=1 $0 $@"
+    echo " To stop after first failure"
+    echo "================================="
+  fi
+  [ $testspass -gt 0 ] && echo -n $GREEN || echo -n $NORM
+  echo -n "PASS: $testspass"
+  [ $testsskip -gt 0 ] && echo -n $YELLOW || echo -n $NORM
+  echo -n " SKIP: $testsskip"
+  [ $testsfail -gt 0 ] && echo -n $RED || echo -n $NORM
+  echo " FAIL: $testsfail"
+  echo $NORM
+  if [ $testsfail -gt 0 ]; then
+    exit $FAIL
+  elif [ $testspass -gt 0 ]; then
+    exit $OK
+  else
+    exit $SKIP
+  fi
+}
+

tests/ima_hash.test new file +33 -0

new file mode 100755
index 0000000..30aec19
@@ -0,0 +1,80 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+#
+# evmctl ima_hash tests
+#
+# Copyright (C) 2019 Vitaly Chikunov <[email protected]>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+cd $(dirname $0)
+PATH=../src:$PATH
+source ./functions.sh
+_require evmctl openssl getfattr
+
+trap _report_exit EXIT
+set -f # disable globbing
+
+check() {
+  local alg=$1 pref=$2 chash=$3 hash
+  local file=$alg-hash.txt
+
+  rm -f $file
+  touch $file
+  # Generate hash with openssl, if it's failed skip test,
+  # unless it's negative test, then pass to evmctl

tests/ima_hash.test new file +27 -0

+    echo "Invalid hash for $alg from openssl"
+    echo "Expected: $chash"
+    echo "Returned: $hash"
+    color_restore
+    rm $file
+    return $HARDFAIL
+  fi
+
+  ADD_TEXT_FOR=$alg ADD_DEL=$file \
+    _evmctl_run ima_hash --hashalgo $alg --xattr-user $file || return
+  ADD_TEXT_FOR=$alg \
+    _test_xattr $file user.ima $pref$hash || return
+  rm $file
+  return $OK
+}
+
+# check args: algo hdr-prefix canonic-hash
+expect_pass check  md4        0x01 31d6cfe0d16ae931b73c59d7e0c089c0
+expect_pass check  md5        0x01 d41d8cd98f00b204e9800998ecf8427e
+expect_pass check  sha1       0x01 da39a3ee5e6b4b0d3255bfef95601890afd80709
+expect_fail check  SHA1       0x01 # uppercase
+expect_fail check  sha512-224 0x01 # valid for pkcs1
+expect_fail check  sha512-256 0x01 # valid for pkcs1
+expect_fail check  unknown    0x01 # nonexistent
+expect_pass check  sha224     0x0407 d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f
+expect_pass check  sha256     0x0404 e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
+expect_pass check  sha384     0x0405 38b060a751ac96384cd9327eb1b1e36a21fdb71114be07434c0cc7bf63f6e1da274edebfe76f65fbd51ad2f14898b95b

tests/functions.sh line 147

Quoted 3 lines

tests/functions.sh new file +3 -0

+# For hard errors
+red_always() {
+  echo $@ $RED

A few functions - "red_always", "red_if_failure", "color_restore" - use "$@", but none of the function callers pass any parameters.  Is there a reason for the "$@" or just something left over from debugging?

tests/ima_hash.test line 43

Quoted 2 lines

tests/ima_hash.test new file +2 -0

+  if [ "$chash" ] && [ "$chash" != "$hash" ]; then
+    red_always

Only when "ima_hash.test" is invoked directly, the output is colored red.  Really confusing.

Nice!  The code is very concisely written.

Reviewing this patch would be a lot easier, if it was broken up into smaller pieces.  For example, and this is only an example, the initial patch could define the base ima_hash.test, a subsequent patch could add coloring for the base ima_hash.test, another patch could introduce "make check" and add its coloring.  There's all sorts of ways to break up this patch to simplify review.

Mimi

Mimi,

Quoted 8 lines · Mimi Zohar

tests/functions.sh line 147

Quoted 3 lines

tests/functions.sh new file +3 -0

+# For hard errors
+red_always() {
+  echo $@ $RED

A few functions - "red_always", "red_if_failure", "color_restore" - use "$@", but none of the function callers pass any parameters.  Is there a reason for the "$@" or just something left over from debugging?

It was to pass -n I think, but it is never needed in the end.

Quoted 5 lines

tests/ima_hash.test line 43

Quoted 2 lines

tests/ima_hash.test new file +2 -0

+  if [ "$chash" ] && [ "$chash" != "$hash" ]; then
+    red_always

Only when "ima_hash.test" is invoked directly, the output is colored red.  Really confusing.

Non-TTY output is never colored to not clutter log files. But logic is to color the errors in red.

So it thought as 'always red', _when_ there is colored output (TTY).

And it's "always" in contract to "red if failure" - which make text red only when the test is expected to pass (thus, this is real error condition), when the test is expected to fail there is no point to color it red, because it's not real error (to not confuse user).

Because it is unconditional (in that sense) is it named "red always".

I can rename it to something like color_red'. And rename red_if_failure' to `color_red_on_failure'.

Quoted 9 lines

Nice!  The code is very concisely written.

Reviewing this patch would be a lot easier, if it was broken up into smaller pieces.  For example, and this is only an example, the initial patch could define the base ima_hash.test, a subsequent patch could add coloring for the base ima_hash.test, another patch could introduce "make check" and add its coloring.  There's all sorts of ways to break up this patch to simplify review.

This would make following commits to change code which is already committed in previous commits.

This would make editing code extra hard.
Especially, when tests was reworked a lot.

Also, I don't think splitting coloring into separate patch improves review. Instead, we can just remember the rule that (real) errors are going to be printed in red.

For example, if we prefix every error message with word "ERROR:" - why it would be easier to review if we split adding this prefix to every message in a separate commit?

Red color, similarly to uppercase "ERROR", just improves visibility of errors. (Which is useful, because there is really a lot of tests).

tests/gen-keys.sh line 2

Quoted 5 lines · Vitaly Chikunov

tests/gen-keys.sh new file +2 -0

@@ -0,0 +1,97 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0

Should this be "# SPDX-License-Identifier: GPL-2.0+"

tests/sign_verify.test line 2

Quoted 12 lines

tests/gen-keys.sh new file +1 -0

+# This script leaves test-ca.conf, *.cer, *.pub, *.key files for 

sing/verify tests.

tests/gen-keys.sh new file +2 -0

+# They are never deleted except by `make distclean'.
+

tests/sign_verify.test new file +2 -0

new file mode 100755
index 0000000..190b23a
@@ -0,0 +1,364 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0

Same comment as above.

tests/sign_verify.test line 80

Quoted 9 lines

tests/sign_verify.test new file +9 -0

+# Check that detached signature matches xattr signature
+_test_sigfile() {
+  local file=$1 attr=$2 file_sig=$3 file_sig2=$4
+
+  if [ ! -e $file_sig ]; then
+    red_always
+    echo "evmctl ima_sign: no detached signature $file_sig"
+    color_restore
+    rm $file

Should the file be not deleted in case of failure, so that one can check the file manually?

Quoted 10 lines

tests/sign_verify.test new file +7 -0

+    return $FAIL
+  fi
+
+  _extract_xattr $file $attr $file_sig2
+  if ! cmp -bl $file_sig $file_sig2; then
+    red_always
+    echo "evmctl ima_sign: xattr signature on $file differ from 

detached $file_sig"
+    color_restore
+    rm $file $file_sig $file_sig2

Same as above - should the files be not deleted in case of failure?

thanks,
 -lakshmi

Quoted 46 lines · Lakshmi Ramasubramanian

tests/gen-keys.sh line 2

Quoted 5 lines · Vitaly Chikunov

tests/gen-keys.sh new file +2 -0

@@ -0,0 +1,97 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0

Should this be "# SPDX-License-Identifier: GPL-2.0+"

tests/sign_verify.test line 2

Quoted 12 lines

tests/gen-keys.sh new file +1 -0

+# This script leaves test-ca.conf, *.cer, *.pub, *.key files for

sing/verify tests.

tests/gen-keys.sh new file +2 -0

+# They are never deleted except by `make distclean'.
+

tests/sign_verify.test new file +2 -0

new file mode 100755
index 0000000..190b23a
@@ -0,0 +1,364 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0

Same comment as above.

tests/sign_verify.test line 80

Quoted 9 lines

tests/sign_verify.test new file +9 -0

+# Check that detached signature matches xattr signature
+_test_sigfile() {
+  local file=$1 attr=$2 file_sig=$3 file_sig2=$4
+
+  if [ ! -e $file_sig ]; then
+    red_always
+    echo "evmctl ima_sign: no detached signature $file_sig"
+    color_restore
+    rm $file

Should the file be not deleted in case of failure, so that one can check the file manually?

Quoted 10 lines

tests/sign_verify.test new file +7 -0

+    return $FAIL
+  fi
+
+  _extract_xattr $file $attr $file_sig2
+  if ! cmp -bl $file_sig $file_sig2; then
+    red_always
+    echo "evmctl ima_sign: xattr signature on $file differ from

detached $file_sig"
+    color_restore
+    rm $file $file_sig $file_sig2

Quoted 1 line

Same as above - should the files be not deleted in case of failure?

Quoted 3 lines

thanks,
 -lakshmi

+ Mimi and linux-integrity

tests/sign_verify.test new file +15 -0

+# Perform sign and verify ima and evm testing
+sign_verify() {
+  local key=$1 alg=$2 pref="$3" opts="$4"
+  local file=$alg.txt
+
+  # Set defaults:
+  # Public key is different for v1 and v2 (where x509 cert is used).
+  if [[ $opts =~ --rsa ]]; then
+    KEY=test-$key.pub
+  else
+    KEY=test-$key.cer
+  fi
+  ALG=$alg
+  PREF=$pref
+  OPTS=$opts

tests/sign_verify.test new file +20 -0

+  fi
+
+  TYPE=evm
+  # Avoid running blkid for evm tests which may require root
+  # No generation on overlayfs:
+  # ioctl(3, FS_IOC_GETVERSION, 0x7ffd8e0bd628) = -1 ENOTTY (Inappropriate ioctl for device)
+  OPTS="$opts --uuid --generation 0"
+  if expect_pass check_sign; then
+
+    # Normal verify with proper key
+    expect_pass check_verify
+
+    # Verify with wrong key
+    expect_fail check_verify KEY=rsa2048
+  fi
+
+  # Note: Leaving TYPE=evm and file is evm signed
+}
+
+# Test --keys

tests/sign_verify.test new file +23 -0

+  fi
+
+  # Try key that is not used for signing
+  expect_fail check_verify KEY=rsa2048
+
+  # Try completely wrong key files
+  expect_fail check_verify KEY=/dev/null
+  expect_fail check_verify KEY=/dev/zero
+}
+
+try_different_sigs() {
+  # TYPE=evm and file is evm signed
+
+  # Test --imasig
+  if expect_pass check_sign OPTS="$OPTS --imasig"; then
+
+    # Verify both evm and ima sigs
+    expect_pass check_verify
+    expect_pass check_verify TYPE=ima
+  fi
+
+  # Test --imahash
+  if expect_pass check_sign OPTS="$OPTS --imahash"; then

On Fri, 2020-03-27 at 07:25 +0300, Vitaly Chikunov wrote:

<snip>

tests/sign_verify.test line 253

Quoted 2 lines

tests/sign_verify.test new file +2 -0

+    # Multiple files and some don't verify
+    expect_fail check_verify FILE=/dev/null,$file

The comment and the code don't seem to be in sync.  This seems to be a single file, for example, named "/dev/null,sha1.txt", which properly fails.

Quoted 7 lines

tests/sign_verify.test new file +7 -0

+# Test --keys
+try_different_keys() {
+  # This run after sign_verify which leaves
+  # TYPE=evm and file is evm signed
+
+  # v2 signing can work with multiple keys in --key option
+  if [[ ! $OPTS =~ --rsa ]]; then

tests/sign_verify.test line 283

Quoted 4 lines

tests/sign_verify.test new file +4 -0

+
+    # Have correct key in the key list
+    expect_pass check_verify KEY=test-rsa2048.cer,$KEY
+    expect_pass check_verify KEY=/dev/null,$KEY,

First test has multiple keys in the key list.  The key list with "/dev/null" obviously fails to add the first key, so it lands up being a single key on the list.

tests/sign_verify.test line 316

Quoted 4 lines

tests/sign_verify.test new file +4 -0

+
+  # Test --portable
+  expect_pass check_sign OPTS="$OPTS --portable" PREF=0x05
+  # Cannot be verified

True, evmctl does not support verifying portable signatures, but it should be possible not only locally, but remotely to verify a portable signature.  That's the whole point of having portable EVM signatures. The comment is a bit misleading and could say something to that effect - "todo: add support for evmctl portable signature verification".

Mimi

Quoted 11 lines

tests/sign_verify.test line 316

Quoted 4 lines

tests/sign_verify.test new file +4 -0

+
+  # Test --portable
+  expect_pass check_sign OPTS="$OPTS --portable" PREF=0x05
+  # Cannot be verified

True, evmctl does not support verifying portable signatures, but it should be possible not only locally, but remotely to verify a portable signature.  That's the whole point of having portable EVM signatures. The comment is a bit misleading and could say something to that effect - "todo: add support for evmctl portable signature verification".

Well, tests are not right place to note todos for other code. This todo would look like we need to add test case to the test, like test is missing something. While now it says that it impossible to test.

I will change text to something like "Cannot be verified for now, until that support is added to evmctl".

Quoted 1 line · Vitaly Chikunov

This series adds simple evmctl tests for hash, sign, and verify operations.

Could you please add the steps to initialize, configure, and run the tests in cover letter?

thanks,
 -lakshmi

Quoted 4 lines · Lakshmi Ramasubramanian

Quoted 2 lines · Vitaly Chikunov

This series adds simple evmctl tests for hash, sign, and verify operations.

Quoted 5 lines

Could you please add the steps to initialize, configure, and run the tests in cover letter?

thanks,
-lakshmi

Sorry - forgot to reply-all.