Skip to contentSkip to conversation

drm/qxl: Use correct notify port address when creating cursor ring

PATCH RESEND Applied Huacai Chen 2 participants 4 messages Mar 31, 2020 – Apr 24, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drm/qxl: Use correct notify port address when creating cursor ring

The command ring and cursor ring use different notify port addresses
definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. However, QEMU's behavior may be change in future, so let's fix it.

P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.

---
 drivers/gpu/drm/qxl/qxl_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_kms.c +1 -1
index bfc1631..9bdbe0d 100644
@@ -218,7 +218,7 @@ int qxl_device_init(struct qxl_device *qdev,
 				&(qdev->ram_header->cursor_ring_hdr),
 				sizeof(struct qxl_command),
 				QXL_CURSOR_RING_SIZE,
-				qdev->io_base + QXL_IO_NOTIFY_CMD,
+				qdev->io_base + QXL_IO_NOTIFY_CURSOR,
 				false,
 				&qdev->cursor_event);
 
Signature · 1 line
2.7.0
maintainer Applied
#1 lore raw
Quoted 7 lines · Huacai Chen

The command ring and cursor ring use different notify port addresses
definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. However, QEMU's behavior may be change in future, so let's fix it.

Quoted 5 lines

P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.

Pushed to drm-misc-next.

thanks,
Gerd

#2 lore raw

Hi, Gerd

Quoted 9 lines · Gerd Hoffmann
Quoted 7 lines · Huacai Chen

The command ring and cursor ring use different notify port addresses
definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. However, QEMU's behavior may be change in future, so let's fix it.

Quoted 7 lines
Quoted 5 lines

P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.

Pushed to drm-misc-next.

It seems that this patch hasn't appear in upstream.

Quoted 4 lines

thanks,
Gerd

Thanks,
Huacai

maintainer
#3 lore raw
Quoted 12 lines · Huacai Chen

Hi, Gerd

Quoted 9 lines · Gerd Hoffmann
Quoted 7 lines · Huacai Chen

The command ring and cursor ring use different notify port addresses
definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. However, QEMU's behavior may be change in future, so let's fix it.

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines

P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.

Pushed to drm-misc-next.

It seems that this patch hasn't appear in upstream.

Was probably to late for the 5.7 merge window, should land in 5.8

cheers,
Gerd