drm/qxl: Use correct notify port address when creating cursor ring
Subsystems (5)
PATCH RESEND 1/1 drm/qxl: Use correct notify port address when creating cursor ring
The command ring and cursor ring use different notify port addresses
definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. However, QEMU's behavior may be change in future, so let's fix it.
P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.
--- drivers/gpu/drm/qxl/qxl_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_kms.c +1 -1
@@ -218,7 +218,7 @@ int qxl_device_init(struct qxl_device *qdev, &(qdev->ram_header->cursor_ring_hdr),sizeof (struct qxl_command ),QXL_CURSOR_RING_SIZE , - qdev->io_base +QXL_IO_NOTIFY_CMD , + qdev->io_base +QXL_IO_NOTIFY_CURSOR , false, &qdev->cursor_event);
Signature · 1 line
2.7.0
Quoted 7 lines · Huacai Chen
The command ring and cursor ring use different notify port addresses
definition:QXL_IO_NOTIFY_CMDandQXL_IO_NOTIFY_CURSOR. However, inqxl_device_init()we useQXL_IO_NOTIFY_CMDto create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors onQXL_IO_NOTIFY_CMDandQXL_IO_NOTIFY_CURSORare the same. However, QEMU's behavior may be change in future, so let's fix it.
Quoted 5 lines
P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.Cc <[email protected]>Signed-off-by Huacai Chen <[email protected]>
Pushed to drm-misc-next.
thanks,
Gerd
Hi, Gerd
Quoted 9 lines · Gerd Hoffmann
Quoted 7 lines · Huacai Chen
The command ring and cursor ring use different notify port addresses
definition:QXL_IO_NOTIFY_CMDandQXL_IO_NOTIFY_CURSOR. However, inqxl_device_init()we useQXL_IO_NOTIFY_CMDto create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors onQXL_IO_NOTIFY_CMDandQXL_IO_NOTIFY_CURSORare the same. However, QEMU's behavior may be change in future, so let's fix it.
Quoted 7 lines
Quoted 5 lines
P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.Cc <[email protected]>Signed-off-by Huacai Chen <[email protected]>Pushed to drm-misc-next.
It seems that this patch hasn't appear in upstream.
Quoted 4 lines
thanks,
Gerd
Thanks,
Huacai
Gerd Hoffmann
maintainerQuoted 12 lines · Huacai Chen
Hi, Gerd
Quoted 9 lines · Gerd Hoffmann
Quoted 7 lines · Huacai Chen
The command ring and cursor ring use different notify port addresses
definition:QXL_IO_NOTIFY_CMDandQXL_IO_NOTIFY_CURSOR. However, inqxl_device_init()we useQXL_IO_NOTIFY_CMDto create both command ring and cursor ring. This doesn't cause any problems now, because QEMU's behaviors onQXL_IO_NOTIFY_CMDandQXL_IO_NOTIFY_CURSORare the same. However, QEMU's behavior may be change in future, so let's fix it.
Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
P.S.: In the X.org QXL driver, the notify port address of cursor ring
is correct.Cc <[email protected]>Signed-off-by Huacai Chen <[email protected]>Pushed to drm-misc-next.
It seems that this patch hasn't appear in upstream.
Was probably to late for the 5.7 merge window, should land in 5.8
cheers,
Gerd