Skip to contentSkip to conversation

configure RSS hash

PATCH Superseded Bernard Iremonger 5 participants 28 messages Mar 18, 2020 – Apr 16, 2020 1 message not in the archive Network drivers

lore
Share & tools
lore
#0 lore raw

cover configure RSS hash

Configure the RSS hash for the i40e PMD using the
rte_flow API RSS action.

Bernard Iremonger (3):
librte_ethdev: add RSS offload types for ESP and AH app/testpmd: handle RSS offload types ESP and AH net/i40e: configure RSS hash from RSS action

 app/test-pmd/cmdline.c         |  4 +++-
 app/test-pmd/config.c          |  2 ++
 drivers/net/i40e/i40e_flow.c   | 46 +++++++++++++++++++++++++++++++-----------
 lib/librte_ethdev/rte_ethdev.h |  2 ++
 4 files changed, 41 insertions(+), 13 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/3 librte_ethdev: add RSS offload types for ESP and AH

add ETH_RSS_ESP and ETH_RSS_AH macros

---
 lib/librte_ethdev/rte_ethdev.h | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_ethdev/rte_ethdev.h +2 -0
index d1a593a..113e953 100644
@@ -511,6 +511,8 @@ struct rte_eth_rss_conf {
 #define ETH_RSS_GENEVE             (1ULL << 20)
 #define ETH_RSS_NVGRE              (1ULL << 21)
 #define ETH_RSS_GTPU               (1ULL << 23)
+#define ETH_RSS_AH                 (1ULL << 24)
+#define ETH_RSS_ESP                (1ULL << 25)
 
 /*
  * We use the following macros to combine with above ETH_RSS_* for
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/3 app/testpmd: handle RSS offload types ESP and AH

In reply to Bernard Iremonger

parse RSS offload types ESP and AH
add printf for rss_hf

---
 app/test-pmd/cmdline.c | 4 +++-
 app/test-pmd/config.c  | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c +3 -1
index a037a55..997f063 100644
@@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
 				i, -diag, strerror(-diag));
 		}
 	}
-	if (all_updated && !use_default)
+	if (all_updated && !use_default) {
 		rss_hf = rss_conf.rss_hf;
+		printf("rss_hf %#"PRIx64"\n", rss_hf);
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port =
app/test-pmd/config.c +2 -0
index 8cf84cc..f7d6dd9 100644
@@ -106,6 +106,8 @@ const struct rss_type_info rss_type_table[] = {
 	{ "l3-dst-only", ETH_RSS_L3_DST_ONLY },
 	{ "l4-src-only", ETH_RSS_L4_SRC_ONLY },
 	{ "l4-dst-only", ETH_RSS_L4_DST_ONLY },
+	{ "esp", ETH_RSS_ESP },
+	{ "ah", ETH_RSS_AH },
 	{ NULL, 0 },
 };
 
Signature · 1 line
2.7.4
#3 lore raw

PATCH 3/3 net/i40e: configure RSS hash from RSS action

In reply to Bernard Iremonger

handle RSS offload types in RSS action
handle ipv4, ipv6 and udp RSS patterns
handle queue_num 0 in RSS action

---
 drivers/net/i40e/i40e_flow.c | 46 ++++++++++++++++++++++++++++++++------------
 1 file changed, 34 insertions(+), 12 deletions(-)
drivers/net/i40e/i40e_flow.c +34 -12
index d877ac2..b9a928c 100644
@@ -4461,6 +4461,12 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev,
 		case RTE_FLOW_ITEM_TYPE_ETH:
 			*action_flag = 1;
 			break;
+		case RTE_FLOW_ITEM_TYPE_IPV4:
+			break;
+		case RTE_FLOW_ITEM_TYPE_IPV6:
+			break;
+		case RTE_FLOW_ITEM_TYPE_UDP:
+			break;
 		case RTE_FLOW_ITEM_TYPE_VLAN:
 			vlan_spec = item->spec;
 			vlan_mask = item->mask;
@@ -4516,12 +4522,14 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 	struct i40e_rte_flow_rss_conf *rss_config =
 			&filter->rss_conf;
 	struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info;
+	struct rte_eth_rss_conf eth_rss_conf;
+	int ret;
 	uint16_t i, j, n, tmp;
 	uint32_t index = 0;
 	uint64_t hf_bit = 1;
+	uint64_t rss_hf;
 
 	NEXT_ITEM_OF_ACTION(act, actions, index);
-	rss = act->conf;
 
 	/**
 	 * rss only supports forwarding,
@@ -4535,6 +4543,23 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 		return -rte_errno;
 	}
 
+	rss = act->conf;
+	rss_hf = rss->types;
+
+	if (rss->queue_num == 0) {
+		memset(&eth_rss_conf, 0, sizeof(eth_rss_conf));
+		ret = rte_eth_dev_rss_hash_conf_get(dev->data->port_id,
+				&eth_rss_conf);
+		if (ret != 0)
+			return ret;
+
+		eth_rss_conf.rss_hf |= rss_hf;
+		ret = rte_eth_dev_rss_hash_update(dev->data->port_id,
+				&eth_rss_conf);
+		if (ret != 0)
+			return ret;
+	}
+
 	if (action_flag) {
 		for (n = 0; n < 64; n++) {
 			if (rss->types & (hf_bit << n)) {
@@ -4552,7 +4577,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 	 * continuous sequence and also to be part of RSS
 	 * queue index for this port.
 	 */
-	if (conf_info->queue_region_number) {
+	if (conf_info->queue_region_number && rss->queue_num > 0) {
 		for (i = 0; i < rss->queue_num; i++) {
 			for (j = 0; j < rss_info->conf.queue_num; j++) {
 				if (rss->queue[i] == rss_info->conf.queue[j])
@@ -4579,7 +4604,8 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 	}
 
 	/* Parse queue region related parameters from configuration */
-	for (n = 0; n < conf_info->queue_region_number; n++) {
+	for (n = 0; n < conf_info->queue_region_number &&
+		rss->queue_num > 0; n++) {
 		if (conf_info->region[n].user_priority_num ||
 				conf_info->region[n].flowtype_num) {
 			if (!((rte_is_power_of_2(rss->queue_num)) &&
@@ -4674,14 +4700,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 	if (rss_config->queue_region_conf)
 		return 0;
 
-	if (!rss || !rss->queue_num) {
-		rte_flow_error_set(error, EINVAL,
-				RTE_FLOW_ERROR_TYPE_ACTION,
-				act,
-				"no valid queues");
-		return -rte_errno;
-	}
-
 	for (n = 0; n < rss->queue_num; n++) {
 		if (rss->queue[n] >= dev->data->nb_rx_queues) {
 			rte_flow_error_set(error, EINVAL,
@@ -4692,7 +4710,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 		}
 	}
 
-	if (rss_info->conf.queue_num) {
+	if (rss_info->conf.queue_num && rss->queue_num) {
 		rte_flow_error_set(error, EINVAL,
 				RTE_FLOW_ERROR_TYPE_ACTION,
 				act,
@@ -4709,6 +4727,10 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 		return rte_flow_error_set
 			(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,
 			 "a nonzero RSS encapsulation level is not supported");
+	if (rss->types > ETH_RSS_ESP)
+		return rte_flow_error_set
+			(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,
+			 "pctype greater than max allowed");
 	if (rss->key_len && rss->key_len > RTE_DIM(rss_config->key))
 		return rte_flow_error_set
 			(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,
Signature · 1 line
2.7.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

Re: [dpdk-dev] [PATCH 3/3] net/i40e: configure RSS hash from RSS action

Hi Chenxu,

Quoted 166 lines

-----Original Message-----
From: Di, ChenxuX <[email protected]>
Sent: Monday, March 23, 2020 9:19 AM
To: Iremonger, Bernard <[email protected]>; [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: RE: [dpdk-dev] [PATCH 3/3] net/i40e: configure RSS hash from RSS action

Hi, Bernard
This patch conflicts with the patch(http://patchwork.dpdk.org/project/dpdk/list/?series=9005). In 20.05 release, there will be some changes for creating RSS flows to support more features and make it more flexible.
Changes for RSS flow:
- Configure the hash input set according to the packet type.
- Configure hash function.
- User can create more than one RSS flows and won't affect other rules when destory.
For example, if you want to enable rss for ipv4-tcp, the command looks like this:
flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss types ipv4-tcp end queues end / end

So, perhaps you need rework your feature depending on that patch.

Quoted 2 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Bernard

Iremonger

drivers/net/i40e/i40e_flow.c i40e_flow_parse_rss_pattern(__rte_unused

Quoted 23 lines

Sent: Wednesday, March 18, 2020 8:38 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [dpdk-dev] [PATCH 3/3] net/i40e: configure RSS hash from RSS action

handle RSS offload types in RSS action handle ipv4, ipv6 and udp RSS patterns handle queue_num 0 in RSS action

---
 drivers/net/i40e/i40e_flow.c | 46
++++++++++++++++++++++++++++++++-------
-----
 1 file changed, 34 insertions(+), 12 deletions(-)
(quoted diff) +0 -0

b/drivers/net/i40e/i40e_flow.c index d877ac2..b9a928c 100644

drivers/net/i40e/i40e_flow.c +0 -0
@@ -4461,6 +4461,12 @@ i40e_flow_parse_rss_pattern(__rte_unused

struct

drivers/net/i40e/i40e_flow.c i40e_flow_parse_rss_action(struct

Quoted 13 lines

rte_eth_dev *dev, case RTE_FLOW_ITEM_TYPE_ETH:
*action_flag = 1;
break;

drivers/net/i40e/i40e_flow.c +6 -0
+case RTE_FLOW_ITEM_TYPE_IPV4:
+break;
+case RTE_FLOW_ITEM_TYPE_IPV6:
+break;
+case RTE_FLOW_ITEM_TYPE_UDP:
+break;
 case RTE_FLOW_ITEM_TYPE_VLAN:
 vlan_spec = item->spec;
 vlan_mask = item->mask;
@@ -4516,12 +4522,14 @@ i40e_flow_parse_rss_action(struct

rte_eth_dev

Quoted 22 lines
drivers/net/i40e/i40e_flow.c +9 -0
 *dev,  struct i40e_rte_flow_rss_conf *rss_config =  &filter->rss_conf;
 struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info;
+struct rte_eth_rss_conf eth_rss_conf; int ret;
 uint16_t i, j, n, tmp;
 uint32_t index = 0;
 uint64_t hf_bit = 1;
+uint64_t rss_hf;
 
 NEXT_ITEM_OF_ACTION(act, actions, index); -rss = act->conf;
 
 /**
  * rss only supports forwarding,
@@ -4535,6 +4543,23 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
 *dev,  return -rte_errno;  }
 
+rss = act->conf;
+rss_hf = rss->types;
+
+if (rss->queue_num == 0) {
+memset(&eth_rss_conf, 0, sizeof(eth_rss_conf)); ret =
+rte_eth_dev_rss_hash_conf_get(dev->data->port_id,
+&eth_rss_conf);

drivers/net/i40e/i40e_flow.c i40e_flow_parse_rss_action(struct rte_eth_dev · line 4561

Quoted 10 lines
drivers/net/i40e/i40e_flow.c +10 -0
+if (ret != 0)
+return ret;
+
+eth_rss_conf.rss_hf |= rss_hf;
+ret = rte_eth_dev_rss_hash_update(dev->data->port_id,
+&eth_rss_conf);
+if (ret != 0)
+return ret;
+}
+

I don't think it is a good idea that update rss hash enable status in the parse function.
it will update status while send command flow validate xxxxxx which can't be destoried.

drivers/net/i40e/i40e_flow.c i40e_flow_parse_rss_action(struct rte_eth_dev

Quoted 4 lines
drivers/net/i40e/i40e_flow.c +0 -0
 if (action_flag) {
 for (n = 0; n < 64; n++) {
 if (rss->types & (hf_bit << n)) {
@@ -4552,7 +4577,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev

*dev,

Quoted 39 lines
drivers/net/i40e/i40e_flow.c +1 -1
  * continuous sequence and also to be part of RSS
  * queue index for this port.
  */
-if (conf_info->queue_region_number) {
+if (conf_info->queue_region_number && rss->queue_num > 0) {
 for (i = 0; i < rss->queue_num; i++) {  for (j = 0; j <

rss_info->conf.queue_num; j++) { if (rss->queue[i] == rss_info->conf.queue[j]) @@ -4579,7 +4604,8 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, }

/* Parse queue region related parameters from configuration */ -for
(n = 0; n < conf_info->queue_region_number; n++) {

drivers/net/i40e/i40e_flow.c +2 -0
+for (n = 0; n < conf_info->queue_region_number &&
+rss->queue_num > 0; n++) {
 if (conf_info->region[n].user_priority_num ||
 conf_info->region[n].flowtype_num) {
 if (!((rte_is_power_of_2(rss->queue_num)) && @@ -

4674,14 +4700,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, if (rss_config->queue_region_conf) return 0;

drivers/net/i40e/i40e_flow.c +0 -8
-if (!rss || !rss->queue_num) {
-rte_flow_error_set(error, EINVAL,
-RTE_FLOW_ERROR_TYPE_ACTION,
-act,
-"no valid queues");
-return -rte_errno;
-}
-
 for (n = 0; n < rss->queue_num; n++) {  if (rss->queue[n] >=

dev->data->nb_rx_queues) { rte_flow_error_set(error, EINVAL, @@ -4692,7 +4710,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, } }

drivers/net/i40e/i40e_flow.c +1 -1
-if (rss_info->conf.queue_num) {
+if (rss_info->conf.queue_num && rss->queue_num) {
 rte_flow_error_set(error, EINVAL,
 RTE_FLOW_ERROR_TYPE_ACTION,
 act,

drivers/net/i40e/i40e_flow.c i40e_flow_parse_rss_action(struct rte_eth_dev · line 4734

Quoted 8 lines
drivers/net/i40e/i40e_flow.c +4 -0
@@ -4709,6 +4727,10 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
 *dev,  return rte_flow_error_set  (error, ENOTSUP,
 RTE_FLOW_ERROR_TYPE_ACTION, act,
  "a nonzero RSS encapsulation level is not supported");
+if (rss->types > ETH_RSS_ESP)
+return rte_flow_error_set
+(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,
 act,
+ "pctype greater than max allowed");

At the patch(http://patchwork.dpdk.org/project/dpdk/list/?series=9005), the hash input set will be enable.
So rss->types may has the value ETH_RSS_L3_SRC_ONLY (1ULL << 63) and ETH_RSS_L3_DST_ONLY (1ULL << 62) and ETH_RSS_L4_SRC_ONLY (1ULL <<
61) and ETH_RSS_L4_DST_ONLY (1ULL << 60).

Quoted 6 lines

drivers/net/i40e/i40e_flow.c i40e_flow_parse_rss_action(struct rte_eth_dev · line 4736

Quoted 2 lines
drivers/net/i40e/i40e_flow.c +0 -0
 if (rss->key_len && rss->key_len > RTE_DIM(rss_config->key))  return
 rte_flow_error_set  (error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,

act,

Quoted 2 lines

--
2.7.4

Yes, I will need to rework this patch based on top of your patch.

Regards,

Bernard.

#6 lore raw

v2 cover configure RSS hash

In reply to Bernard Iremonger

Configure the RSS hash for the i40e PMD using the
rte_flow API RSS pattern.

The i40e patch depends on the following patch:
http://patches.dpdk.org/patch/67042/
[v5] net/i40e: implement hash function in rte flow API

Changes in v2:
--------------
i40e changes are based on http://patches.dpdk.org/patch/67042/
update i40e PMD user guide.
Add more types to testpmd patch

Bernard Iremonger (3):
librte_ethdev: add RSS offload types for ESP and AH app/testpmd: handle RSS offload types ESP and AH net/i40e: add ESP patterns

 app/test-pmd/cmdline.c         | 4 +++-
 app/test-pmd/config.c          | 6 ++++++
 doc/guides/nics/i40e.rst       | 3 ++-
 drivers/net/i40e/i40e_flow.c   | 4 ++++
 lib/librte_ethdev/rte_ethdev.h | 2 ++
 5 files changed, 17 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
#7 lore raw

v3 cover configure RSS hash

Configure the RSS hash for the i40e PMD using the
rte_flow API RSS pattern.

The i40e patch depends on the following patch:
http://patches.dpdk.org/patch/67398/
[v6] net/i40e: implement hash function in rte flow API

Changes in v3:
--------------
Reduce types in testpmd patch to esp and ah.

Changes in v2:
--------------
i40e changes are based on http://patches.dpdk.org/patch/67042/
update i40e PMD user guide.
Add more types to testpmd patch

Bernard Iremonger (3):
librte_ethdev: add RSS offload types for ESP and AH app/testpmd: handle RSS offload types ESP and AH net/i40e: add ESP patterns

 app/test-pmd/cmdline.c         | 4 +++-
 app/test-pmd/config.c          | 2 ++
 doc/guides/nics/i40e.rst       | 3 ++-
 drivers/net/i40e/i40e_flow.c   | 4 ++++
 lib/librte_ethdev/rte_ethdev.h | 2 ++
 5 files changed, 13 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
#8 lore raw

v4 cover configure RSS hash

Configure the RSS hash for the i40e PMD using the
rte_flow API RSS pattern.

The i40e patch depends on the following patch:
http://patches.dpdk.org/patch/68533/
[v9] net/i40e: enable hash configuration in RSS flow

Changes in v4:
--------------
Rebased to dpdk-next-net
Renumbered esp and ah in librte_ethdev patch.

Changes in v3:
--------------
Reduce types in testpmd patch to esp and ah.

Changes in v2:
--------------
i40e changes are based on http://patches.dpdk.org/patch/67042/
update i40e PMD user guide.
Add more types to testpmd patch

Bernard Iremonger (3):
librte_ethdev: add RSS offload types for ESP and AH app/testpmd: handle RSS offload types ESP and AH net/i40e: add ESP patterns

 app/test-pmd/cmdline.c         | 4 +++-
 app/test-pmd/config.c          | 2 ++
 doc/guides/nics/i40e.rst       | 3 ++-
 drivers/net/i40e/i40e_flow.c   | 4 ++++
 lib/librte_ethdev/rte_ethdev.h | 3 +++
 5 files changed, 14 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
#9 lore raw
Quoted 23 lines · Bernard Iremonger

Configure the RSS hash for the i40e PMD using the
rte_flow API RSS pattern.

The i40e patch depends on the following patch:
http://patches.dpdk.org/patch/68533/
[v9] net/i40e: enable hash configuration in RSS flow

Changes in v4:
--------------
Rebased to dpdk-next-net
Renumbered esp and ah in librte_ethdev patch.

Changes in v3:
--------------
Reduce types in testpmd patch to esp and ah.

Changes in v2:
--------------
i40e changes are based on http://patches.dpdk.org/patch/67042/
update i40e PMD user guide.
Add more types to testpmd patch

Quoted 5 lines

Bernard Iremonger (3):
librte_ethdev: add RSS offload types for ESP and AH app/testpmd: handle RSS offload types ESP and AH net/i40e: add ESP patterns

Series applied to dpdk-next-net/master, thanks.

#10 lore raw

PATCH v4 1/3 librte_ethdev: add RSS offload types for ESP and AH

In reply to Bernard Iremonger

add ETH_RSS_ESP and ETH_RSS_AH macros

---
 lib/librte_ethdev/rte_ethdev.h | 3 +++
 1 file changed, 3 insertions(+)
lib/librte_ethdev/rte_ethdev.h +3 -0
index d1a593a..26381a1 100644
@@ -511,6 +511,9 @@ struct rte_eth_rss_conf {
 #define ETH_RSS_GENEVE             (1ULL << 20)
 #define ETH_RSS_NVGRE              (1ULL << 21)
 #define ETH_RSS_GTPU               (1ULL << 23)
+#define ETH_RSS_ESP                (1ULL << 27)
+#define ETH_RSS_AH                 (1ULL << 28)
+
 
 /*
  * We use the following macros to combine with above ETH_RSS_* for
Signature · 1 line
2.7.4
Reviewed-by on v4 1/3
#11 lore raw

Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 33 lines

-----Original Message-----
From: Iremonger, Bernard <[email protected]>
Sent: Wednesday, April 15, 2020 7:14 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

add ETH_RSS_ESP and ETH_RSS_AH macros

---
 lib/librte_ethdev/rte_ethdev.h | 3 +++
 1 file changed, 3 insertions(+)
lib/librte_ethdev/rte_ethdev.h +3 -1
index d1a593a..26381a1 100644
@@ -511,6 +511,9 @@ struct rte_eth_rss_conf {
 #define ETH_RSS_GENEVE             (1ULL << 20)
 #define ETH_RSS_NVGRE              (1ULL << 21)
 #define ETH_RSS_GTPU               (1ULL << 23)
+#define ETH_RSS_ESP                (1ULL << 27)
+#define ETH_RSS_AH                 (1ULL << 28)
+
 
 /*
  * We use the following macros to combine with above ETH_RSS_* for
--
Quoted 1 line

2.7.4

Reviewed-by
#12 lore raw

Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 30 lines · Beilei
Quoted 30 lines

-----Original Message-----
From: Iremonger, Bernard <[email protected]>
Sent: Wednesday, April 15, 2020 7:14 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

add ETH_RSS_ESP and ETH_RSS_AH macros

---
 lib/librte_ethdev/rte_ethdev.h | 3 +++
 1 file changed, 3 insertions(+)
lib/librte_ethdev/rte_ethdev.h +3 -0
index d1a593a..26381a1 100644
@@ -511,6 +511,9 @@ struct rte_eth_rss_conf {
 #define ETH_RSS_GENEVE             (1ULL << 20)
 #define ETH_RSS_NVGRE              (1ULL << 21)
 #define ETH_RSS_GTPU               (1ULL << 23)
+#define ETH_RSS_ESP                (1ULL << 27)
+#define ETH_RSS_AH                 (1ULL << 28)
+
 
Quoted 7 lines
Quoted 4 lines
lib/librte_ethdev/rte_ethdev.h +0 -1
 /*
  * We use the following macros to combine with above ETH_RSS_* for
--

2.7.4

#13 lore raw

Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

In reply to Bernard Iremonger
Quoted 10 lines

-----Original Message-----
From: Iremonger, Bernard <[email protected]>
Sent: Wednesday, April 15, 2020 7:14 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 4 lines

add ETH_RSS_ESP and ETH_RSS_AH macros

---

The describe is too simple, more introduces can be added in code or commit log.

#14 lore raw

Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 10 lines · Dong Zhou
Quoted 10 lines

-----Original Message-----
From: Iremonger, Bernard <[email protected]>
Sent: Wednesday, April 15, 2020 7:14 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 7 lines
Quoted 4 lines

add ETH_RSS_ESP and ETH_RSS_AH macros

---

The describe is too simple, more introduces can be added in code or commit log.

Change is already simple, but if more details comes I can update them in next-net.

Thanks,
ferruh

#15 lore raw

Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

In reply to Dong Zhou

Hi Dong,

Quoted 21 lines

-----Original Message-----
From: Dong Zhou <[email protected]>
Sent: Thursday, April 16, 2020 2:26 PM
To: Iremonger, Bernard <[email protected]>
Cc: Xing, Beilei <[email protected]>; Doherty, Declan <[email protected]>; [email protected]; Ananyev, Konstantin <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 10 lines

-----Original Message-----
From: Iremonger, Bernard <[email protected]>
Sent: Wednesday, April 15, 2020 7:14 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 7 lines
Quoted 4 lines

add ETH_RSS_ESP and ETH_RSS_AH macros

---

The describe is too simple, more introduces can be added in code or commit log.

The patch is simple, and the commit messages describes what has been changed. What extra information would you like to see?

Regards,

Bernard.

#16 lore raw

PATCH v4 2/3 app/testpmd: handle RSS offload types ESP and AH

In reply to Bernard Iremonger

parse RSS offload types ESP and AH
add printf for rss_hf

---
 app/test-pmd/cmdline.c | 4 +++-
 app/test-pmd/config.c  | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c +3 -1
index 863b567..982322c 100644
@@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
 				i, -diag, strerror(-diag));
 		}
 	}
-	if (all_updated && !use_default)
+	if (all_updated && !use_default) {
 		rss_hf = rss_conf.rss_hf;
+		printf("rss_hf %#"PRIx64"\n", rss_hf);
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port =
app/test-pmd/config.c +2 -0
index 71aeb54..69c5633 100644
@@ -108,6 +108,8 @@ const struct rss_type_info rss_type_table[] = {
 	{ "l3-dst-only", ETH_RSS_L3_DST_ONLY },
 	{ "l4-src-only", ETH_RSS_L4_SRC_ONLY },
 	{ "l4-dst-only", ETH_RSS_L4_DST_ONLY },
+	{ "esp", ETH_RSS_ESP },
+	{ "ah", ETH_RSS_AH },
 	{ NULL, 0 },
 };
 
Signature · 1 line
2.7.4
#17 lore raw

PATCH v4 3/3 net/i40e: add ESP patterns

In reply to Bernard Iremonger

add ESP patterns to i40e_flow_parse_rss_pattern(). update i40e PMD user guide with download link for esp-ah.pkg file.

---
 doc/guides/nics/i40e.rst     | 3 ++-
 drivers/net/i40e/i40e_flow.c | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
doc/guides/nics/i40e.rst +2 -1
index f72a54b..416b390 100644
@@ -509,7 +509,8 @@ https://downloadcenter.intel.com/download/27587.
 PPPoE package is released, and it can be downloaded from
 https://downloadcenter.intel.com/download/28040.
 
-ESP-AH package is not released yet.
+ESP-AH package is released, and it can be downloaded from
+https://downloadcenter.intel.com/download/29446.
 
 Load a profile which supports GTP and store backup profile:
 
drivers/net/i40e/i40e_flow.c +4 -0
index 1d0eaf6..e65a07a 100644
@@ -4507,11 +4507,15 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev,
 		{ pattern_fdir_ipv4_tcp, ETH_RSS_NONFRAG_IPV4_TCP },
 		{ pattern_fdir_ipv4_udp, ETH_RSS_NONFRAG_IPV4_UDP },
 		{ pattern_fdir_ipv4_sctp, ETH_RSS_NONFRAG_IPV4_SCTP },
+		{ pattern_fdir_ipv4_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv4_udp_esp, ETH_RSS_ESP },
 		{ pattern_fdir_ipv6,
 			ETH_RSS_FRAG_IPV6 | ETH_RSS_NONFRAG_IPV6_OTHER },
 		{ pattern_fdir_ipv6_tcp, ETH_RSS_NONFRAG_IPV6_TCP },
 		{ pattern_fdir_ipv6_udp, ETH_RSS_NONFRAG_IPV6_UDP },
 		{ pattern_fdir_ipv6_sctp, ETH_RSS_NONFRAG_IPV6_SCTP },
+		{ pattern_fdir_ipv6_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv6_udp_esp, ETH_RSS_ESP },
 	};
 
 	p_info->types = I40E_RSS_TYPE_INVALID;
Signature · 1 line
2.7.4
Acked-by on v4 3/3
#18 lore raw

Re: [dpdk-dev] [PATCH v4 3/3] net/i40e: add ESP patterns

Quoted 55 lines

-----Original Message-----
From: Iremonger, Bernard <[email protected]>
Sent: Wednesday, April 15, 2020 7:14 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [PATCH v4 3/3] net/i40e: add ESP patterns

add ESP patterns to i40e_flow_parse_rss_pattern(). update i40e PMD user guide with download link for esp-ah.pkg file.

---
 doc/guides/nics/i40e.rst     | 3 ++-
 drivers/net/i40e/i40e_flow.c | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
doc/guides/nics/i40e.rst index renamed from doc/guides/nics/i40e.rst +0 -0

f72a54b..416b390 100644

doc/guides/nics/i40e.rst +0 -0
@@ -509,7 +509,8 @@ https://downloadcenter.intel.com/download/27587.
 PPPoE package is released, and it can be downloaded from

https://downloadcenter.intel.com/download/28040.

doc/guides/nics/i40e.rst +2 -1
-ESP-AH package is not released yet.
+ESP-AH package is released, and it can be downloaded from
+https://downloadcenter.intel.com/download/29446.
 
 Load a profile which supports GTP and store backup profile:
drivers/net/i40e/i40e_flow.c index renamed from drivers/net/i40e/i40e_flow.c +0 -0

1d0eaf6..e65a07a 100644

drivers/net/i40e/i40e_flow.c +4 -0
@@ -4507,11 +4507,15 @@ i40e_flow_parse_rss_pattern(__rte_unused
 struct rte_eth_dev *dev,
 		{ pattern_fdir_ipv4_tcp, ETH_RSS_NONFRAG_IPV4_TCP },
 		{ pattern_fdir_ipv4_udp, ETH_RSS_NONFRAG_IPV4_UDP },
 		{ pattern_fdir_ipv4_sctp, ETH_RSS_NONFRAG_IPV4_SCTP },
+		{ pattern_fdir_ipv4_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv4_udp_esp, ETH_RSS_ESP },
 		{ pattern_fdir_ipv6,
 			ETH_RSS_FRAG_IPV6 |
 ETH_RSS_NONFRAG_IPV6_OTHER },
 		{ pattern_fdir_ipv6_tcp, ETH_RSS_NONFRAG_IPV6_TCP },
 		{ pattern_fdir_ipv6_udp, ETH_RSS_NONFRAG_IPV6_UDP },
 		{ pattern_fdir_ipv6_sctp, ETH_RSS_NONFRAG_IPV6_SCTP },
+		{ pattern_fdir_ipv6_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv6_udp_esp, ETH_RSS_ESP },
 	};
Quoted 3 lines

p_info->types = I40E_RSS_TYPE_INVALID;
--
2.7.4

#19 lore raw

PATCH v3 1/3 librte_ethdev: add RSS offload types for ESP and AH

In reply to Bernard Iremonger

add ETH_RSS_ESP and ETH_RSS_AH macros

---
 lib/librte_ethdev/rte_ethdev.h | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_ethdev/rte_ethdev.h +2 -0
index d1a593a..113e953 100644
@@ -511,6 +511,8 @@ struct rte_eth_rss_conf {
 #define ETH_RSS_GENEVE             (1ULL << 20)
 #define ETH_RSS_NVGRE              (1ULL << 21)
 #define ETH_RSS_GTPU               (1ULL << 23)
+#define ETH_RSS_AH                 (1ULL << 24)
+#define ETH_RSS_ESP                (1ULL << 25)
 
 /*
  * We use the following macros to combine with above ETH_RSS_* for
Signature · 1 line
2.7.4
#20 lore raw

Re: [dpdk-dev] [PATCH v3 1/3] librte_ethdev: add RSS offload types for ESP and AH

Quoted 23 lines

-----Original Message-----
From: Iremonger, Bernard <[email protected]>
Sent: Tuesday, March 31, 2020 9:57 PM
To: [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Subject: [PATCH v3 1/3] librte_ethdev: add RSS offload types for ESP and AH

add ETH_RSS_ESP and ETH_RSS_AH macros

---
 lib/librte_ethdev/rte_ethdev.h | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_ethdev/rte_ethdev.h +0 -0
index d1a593a..113e953 100644

lib/librte_ethdev/rte_ethdev.h struct rte_eth_rss_conf { · line 515

Quoted 5 lines
lib/librte_ethdev/rte_ethdev.h +2 -0
@@ -511,6 +511,8 @@ struct rte_eth_rss_conf {
 #define ETH_RSS_GENEVE             (1ULL << 20)
 #define ETH_RSS_NVGRE              (1ULL << 21)
 #define ETH_RSS_GTPU               (1ULL << 23)
+#define ETH_RSS_AH                 (1ULL << 24)
+#define ETH_RSS_ESP                (1ULL << 25)

It's duplicate with patch http://patches.dpdk.org/patch/68423/.

Quoted 5 lines
lib/librte_ethdev/rte_ethdev.h +0 -1
 /*
  * We use the following macros to combine with above ETH_RSS_* for
--

2.7.4

#21 lore raw

PATCH v3 2/3 app/testpmd: handle RSS offload types ESP and AH

In reply to Bernard Iremonger

parse RSS offload types ESP and AH
add printf for rss_hf

---
 app/test-pmd/cmdline.c | 4 +++-
 app/test-pmd/config.c  | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c +3 -1
index a037a55..997f063 100644
@@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
 				i, -diag, strerror(-diag));
 		}
 	}
-	if (all_updated && !use_default)
+	if (all_updated && !use_default) {
 		rss_hf = rss_conf.rss_hf;
+		printf("rss_hf %#"PRIx64"\n", rss_hf);
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port =
app/test-pmd/config.c +2 -0
index 8cf84cc..f7d6dd9 100644
@@ -106,6 +106,8 @@ const struct rss_type_info rss_type_table[] = {
 	{ "l3-dst-only", ETH_RSS_L3_DST_ONLY },
 	{ "l4-src-only", ETH_RSS_L4_SRC_ONLY },
 	{ "l4-dst-only", ETH_RSS_L4_DST_ONLY },
+	{ "esp", ETH_RSS_ESP },
+	{ "ah", ETH_RSS_AH },
 	{ NULL, 0 },
 };
 
Signature · 1 line
2.7.4
Acked-by on v3 2/3
#22 lore raw

Re: [dpdk-dev] [PATCH v3 2/3] app/testpmd: handle RSS offload types ESP and AH

Quoted 51 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Bernard Iremonger
Sent: Tuesday, March 31, 2020 4:57 PM
To: [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Bernard Iremonger <[email protected]>
Subject: [dpdk-dev] [PATCH v3 2/3] app/testpmd: handle RSS offload types ESP and AH

parse RSS offload types ESP and AH
add printf for rss_hf

---
 app/test-pmd/cmdline.c | 4 +++-
 app/test-pmd/config.c  | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c +3 -1
index a037a55..997f063 100644
@@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
 				i, -diag, strerror(-diag));
 		}
 	}
-	if (all_updated && !use_default)
+	if (all_updated && !use_default) {
 		rss_hf = rss_conf.rss_hf;
+		printf("rss_hf %#"PRIx64"\n", rss_hf);
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port =
app/test-pmd/config.c +2 -1
index 8cf84cc..f7d6dd9 100644
@@ -106,6 +106,8 @@ const struct rss_type_info rss_type_table[] = {
 	{ "l3-dst-only", ETH_RSS_L3_DST_ONLY },
 	{ "l4-src-only", ETH_RSS_L4_SRC_ONLY },
 	{ "l4-dst-only", ETH_RSS_L4_DST_ONLY },
+	{ "esp", ETH_RSS_ESP },
+	{ "ah", ETH_RSS_AH },
 	{ NULL, 0 },
 };
 
--
Quoted 1 line

2.7.4

Thanks,
Ori

#23 lore raw

PATCH v3 3/3 net/i40e: add ESP patterns

In reply to Bernard Iremonger

add ESP patterns to i40e_flow_parse_rss_pattern(). update i40e PMD user guide with download link for esp-ah.pkg file.

---
 doc/guides/nics/i40e.rst     | 3 ++-
 drivers/net/i40e/i40e_flow.c | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
doc/guides/nics/i40e.rst +2 -1
index 92590da..556835e 100644
@@ -508,7 +508,8 @@ https://downloadcenter.intel.com/download/27587.
 PPPoE package is released, and it can be downloaded from
 https://downloadcenter.intel.com/download/28040.
 
-ESP-AH package is not released yet.
+ESP-AH package is released, and it can be downloaded from
+https://downloadcenter.intel.com/download/29446.
 
 Load a profile which supports GTP and store backup profile:
 
drivers/net/i40e/i40e_flow.c +4 -0
index d67cd64..baacc9d 100644
@@ -4456,11 +4456,15 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev,
 		{ pattern_fdir_ipv4_tcp, ETH_RSS_NONFRAG_IPV4_TCP },
 		{ pattern_fdir_ipv4_udp, ETH_RSS_NONFRAG_IPV4_UDP },
 		{ pattern_fdir_ipv4_sctp, ETH_RSS_NONFRAG_IPV4_SCTP },
+		{ pattern_fdir_ipv4_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv4_udp_esp, ETH_RSS_ESP },
 		{ pattern_fdir_ipv6,
 			ETH_RSS_FRAG_IPV6 | ETH_RSS_NONFRAG_IPV6_OTHER },
 		{ pattern_fdir_ipv6_tcp, ETH_RSS_NONFRAG_IPV6_TCP },
 		{ pattern_fdir_ipv6_udp, ETH_RSS_NONFRAG_IPV6_UDP },
 		{ pattern_fdir_ipv6_sctp, ETH_RSS_NONFRAG_IPV6_SCTP },
+		{ pattern_fdir_ipv6_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv6_udp_esp, ETH_RSS_ESP },
 	};
 
 	p_info->types = I40E_RSS_TYPE_INVALID;
Signature · 1 line
2.7.4
#24 lore raw

PATCH v2 1/3 librte_ethdev: add RSS offload types for ESP and AH

In reply to Bernard Iremonger

add ETH_RSS_ESP and ETH_RSS_AH macros

---
 lib/librte_ethdev/rte_ethdev.h | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_ethdev/rte_ethdev.h +2 -0
index d1a593a..113e953 100644
@@ -511,6 +511,8 @@ struct rte_eth_rss_conf {
 #define ETH_RSS_GENEVE             (1ULL << 20)
 #define ETH_RSS_NVGRE              (1ULL << 21)
 #define ETH_RSS_GTPU               (1ULL << 23)
+#define ETH_RSS_AH                 (1ULL << 24)
+#define ETH_RSS_ESP                (1ULL << 25)
 
 /*
  * We use the following macros to combine with above ETH_RSS_* for
Signature · 1 line
2.7.4
#25 lore raw

PATCH v2 2/3 app/testpmd: handle RSS offload types ESP and AH

In reply to Bernard Iremonger

parse RSS offload types ESP and AH
add printf for rss_hf

---
 app/test-pmd/cmdline.c | 4 +++-
 app/test-pmd/config.c  | 6 ++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c +3 -1
index a037a55..997f063 100644
@@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
 				i, -diag, strerror(-diag));
 		}
 	}
-	if (all_updated && !use_default)
+	if (all_updated && !use_default) {
 		rss_hf = rss_conf.rss_hf;
+		printf("rss_hf %#"PRIx64"\n", rss_hf);
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port =
app/test-pmd/config.c +6 -0
index 8cf84cc..df52df9 100644
@@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] = {
 	{ "l3-dst-only", ETH_RSS_L3_DST_ONLY },
 	{ "l4-src-only", ETH_RSS_L4_SRC_ONLY },
 	{ "l4-dst-only", ETH_RSS_L4_DST_ONLY },
+	{ "ipv4-esp", ETH_RSS_ESP },
+	{ "ipv6-esp", ETH_RSS_ESP },
+	{ "ipv4-udp-esp", ETH_RSS_ESP },
+	{ "ipv6-udp-esp", ETH_RSS_ESP },
+	{ "ipv4-ah", ETH_RSS_AH },
+	{ "ipv6-ah", ETH_RSS_AH },
 	{ NULL, 0 },
 };
 
Signature · 1 line
2.7.4
#26 lore raw

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH

Hi Bernard,

Quoted 40 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Bernard Iremonger
Sent: Wednesday, March 25, 2020 5:56 PM
To: [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Bernard Iremonger <[email protected]>
Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH

parse RSS offload types ESP and AH
add printf for rss_hf

---
 app/test-pmd/cmdline.c | 4 +++-
 app/test-pmd/config.c  | 6 ++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c +3 -1
index a037a55..997f063 100644
@@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
 				i, -diag, strerror(-diag));
 		}
 	}
-	if (all_updated && !use_default)
+	if (all_updated && !use_default) {
 		rss_hf = rss_conf.rss_hf;
+		printf("rss_hf %#"PRIx64"\n", rss_hf);
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port =
app/test-pmd/config.c +0 -0
index 8cf84cc..df52df9 100644

app/test-pmd/config.c const struct rss_type_info rss_type_table[] = { · line 114

Quoted 9 lines
app/test-pmd/config.c +6 -0
@@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] = {
 	{ "l3-dst-only", ETH_RSS_L3_DST_ONLY },
 	{ "l4-src-only", ETH_RSS_L4_SRC_ONLY },
 	{ "l4-dst-only", ETH_RSS_L4_DST_ONLY },
+	{ "ipv4-esp", ETH_RSS_ESP },
+	{ "ipv6-esp", ETH_RSS_ESP },
+	{ "ipv4-udp-esp", ETH_RSS_ESP },
+	{ "ipv6-udp-esp", ETH_RSS_ESP },
+	{ "ipv4-ah", ETH_RSS_AH },
+	{ "ipv6-ah", ETH_RSS_AH },

Why do you have all those variations since they don't have any affect.
I think it should be just like your first patch, only esp and ah.
For example the udp should look like this:
flow create 0 ingress pattern eth / end actions rss queues 0 1 end types udp esp end / end

Best,
Ori

Quoted 5 lines
app/test-pmd/config.c +0 -1
 	{ NULL, 0 },
 };
 
--

2.7.4

#27 lore raw

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH

Hi Ori,

Quoted 68 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, March 31, 2020 10:58 AM
To: Iremonger, Bernard <[email protected]>; [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; Doherty, Declan <[email protected]>
Cc: Ananyev, Konstantin <[email protected]>
Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH

Hi Bernard,

Quoted 40 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Bernard Iremonger
Sent: Wednesday, March 25, 2020 5:56 PM
To: [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Bernard Iremonger <[email protected]>
Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH

parse RSS offload types ESP and AH
add printf for rss_hf

---
 app/test-pmd/cmdline.c | 4 +++-
 app/test-pmd/config.c  | 6 ++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c index renamed from app/test-pmd/cmdline.c +0 -0

a037a55..997f063 100644

app/test-pmd/cmdline.c +3 -1
@@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
 				i, -diag, strerror(-diag));
 		}
 	}
-	if (all_updated && !use_default)
+	if (all_updated && !use_default) {
 		rss_hf = rss_conf.rss_hf;
+		printf("rss_hf %#"PRIx64"\n", rss_hf);
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port = diff --git

a/app/test-pmd/config.c b/app/test-pmd/config.c index 8cf84cc..df52df9 100644

app/test-pmd/config.c const struct rss_type_info rss_type_table[] = { · line 114

Quoted 9 lines
app/test-pmd/config.c +6 -0
@@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] = {
 	{ "l3-dst-only", ETH_RSS_L3_DST_ONLY },
 	{ "l4-src-only", ETH_RSS_L4_SRC_ONLY },
 	{ "l4-dst-only", ETH_RSS_L4_DST_ONLY },
+	{ "ipv4-esp", ETH_RSS_ESP },
+	{ "ipv6-esp", ETH_RSS_ESP },
+	{ "ipv4-udp-esp", ETH_RSS_ESP },
+	{ "ipv6-udp-esp", ETH_RSS_ESP },
+	{ "ipv4-ah", ETH_RSS_AH },
+	{ "ipv6-ah", ETH_RSS_AH },

Why do you have all those variations since they don't have any affect. I think it should be just like your first patch, only esp and ah. For example the udp should look like this:
flow create 0 ingress pattern eth / end actions rss queues 0 1 end types udp esp end / end

Quoted 3 lines

Best,
Ori

I thought that it might be clearer to map the patterns to the flow. I will change to esp and ah in v3 patch.

Regards,

Bernard.

<snip>

#28 lore raw

PATCH v2 3/3 net/i40e: add ESP patterns

In reply to Bernard Iremonger

add ESP patterns to i40e_flow_parse_rss_pattern(). update i40e PMD user guide with download link for esp-ah.pkg file.

---
 doc/guides/nics/i40e.rst     | 3 ++-
 drivers/net/i40e/i40e_flow.c | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
doc/guides/nics/i40e.rst +2 -1
index 03b117a..65e4634 100644
@@ -508,7 +508,8 @@ https://downloadcenter.intel.com/download/27587.
 PPPoE package is released, and it can be downloaded from
 https://downloadcenter.intel.com/download/28040.
 
-ESP-AH package is not released yet.
+ESP-AH package is released, and it can be downloaded from
+https://downloadcenter.intel.com/download/29446.
 
 Load a profile which supports GTP and store backup profile:
 
drivers/net/i40e/i40e_flow.c +4 -0
index 4774fde..85f3704 100644
@@ -4456,11 +4456,15 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev,
 		{ pattern_fdir_ipv4_tcp, ETH_RSS_NONFRAG_IPV4_TCP },
 		{ pattern_fdir_ipv4_udp, ETH_RSS_NONFRAG_IPV4_UDP },
 		{ pattern_fdir_ipv4_sctp, ETH_RSS_NONFRAG_IPV4_SCTP },
+		{ pattern_fdir_ipv4_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv4_udp_esp, ETH_RSS_ESP },
 		{ pattern_fdir_ipv6,
 			ETH_RSS_FRAG_IPV6 | ETH_RSS_NONFRAG_IPV6_OTHER },
 		{ pattern_fdir_ipv6_tcp, ETH_RSS_NONFRAG_IPV6_TCP },
 		{ pattern_fdir_ipv6_udp, ETH_RSS_NONFRAG_IPV6_UDP },
 		{ pattern_fdir_ipv6_sctp, ETH_RSS_NONFRAG_IPV6_SCTP },
+		{ pattern_fdir_ipv6_esp, ETH_RSS_ESP },
+		{ pattern_fdir_ipv6_udp_esp, ETH_RSS_ESP },
 	};
 
 	p_info->types = I40E_RSS_TYPE_INVALID;
Signature · 1 line
2.7.4