remoteproc: Add character device interface
PATCH v2 1/2 remoteproc: Add character device interface
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
--- drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+) create mode 100644 drivers/remoteproc/remoteproc_cdev.c
drivers/remoteproc/Kconfig +9 -0
@@ -14,6 +14,15 @@ config REMOTEPROC if REMOTEPROC +config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. + config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on ARCH_MXC
drivers/remoteproc/Makefile +1 -0
@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.o remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.o
drivers/remoteproc/remoteproc_cdev.c new file +100 -0
100 lines not on this page · raw message
drivers/remoteproc/remoteproc_internal.h +22 -0
@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,int rproc_init_sysfs (void );void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void rproc_free_vring (struct rproc_vring *rvring);int rproc_alloc_vring (struct rproc_vdev *rvdev,int i);
@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct rproc_mem_entry *rproc_find_carveout_by_name (struct rproc *rproc,const char *name, ...); +static inline int rproc_fw_sanity_check (struct rproc *rproc,const struct firmware *fw) {
include/linux/remoteproc.h +2 -0
@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h>
@@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/**
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v2 2/2 remoteproc: core: Register the character device interface
Add the character device during rproc_add. This would create a character device node at /dev/remoteproc<index>. Userspace applications can interact with the remote processor using this interface.
--- drivers/remoteproc/remoteproc_core.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/remoteproc/remoteproc_core.c +10 -0
@@ -1916,6 +1916,13 @@ int rproc_add(struct rproc *rproc)/* create debugfs entries */ rproc_create_debug_dir (rproc); +/* add char device for this remoteproc */ + ret =rproc_char_device_add (rproc); +if (ret) { +dev_err (dev,"Failed to add char dev for %s\n" , rproc->name); +return ret; + } +/* if rproc is marked always-on, request it to boot */ if (rproc->auto_boot) { ret =rproc_trigger_auto_boot (rproc);
@@ -2137,6 +2144,7 @@ int rproc_del(struct rproc *rproc)mutex_unlock (&rproc->lock);rproc_delete_debug_dir (rproc); +rproc_char_device_remove (rproc);/* the rproc is downref'ed as soon as it's removed from the klist */ mutex_lock (&rproc_list_mutex);
@@ -2220,6 +2228,7 @@ static int __init remoteproc_init(void) {rproc_init_sysfs ();rproc_init_debugfs (); +rproc_init_cdev ();return 0 ; }
@@ -2231,6 +2240,7 @@ static void __exit remoteproc_exit(void)rproc_exit_debugfs ();rproc_exit_sysfs (); +rproc_exit_cdev (); }module_exit (remoteproc_exit);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v2 2/2] remoteproc: core: Register the character device interface
Quoted 7 lines · Rishabh Bhatnagar
Add the character device during
rproc_add. This would create a character device node at /dev/remoteproc<index>. Userspace applications can interact with the remote processor using this interface.Signed-off-by Rishabh Bhatnagar <[email protected]>---
Regards,
Bjorn
Quoted 48 lines
drivers/remoteproc/remoteproc_core.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/remoteproc/remoteproc_core.c +10
-0@@ -1916,6 +1916,13 @@ int rproc_add(struct rproc *rproc)/* create debugfs entries */ rproc_create_debug_dir (rproc); +/* add char device for this remoteproc */ + ret =rproc_char_device_add (rproc); +if (ret) { +dev_err (dev,"Failed to add char dev for %s\n" , rproc->name); +return ret; + } +/* if rproc is marked always-on, request it to boot */ if (rproc->auto_boot) { ret =rproc_trigger_auto_boot (rproc);@@ -2137,6 +2144,7 @@ int rproc_del(struct rproc *rproc)mutex_unlock (&rproc->lock);rproc_delete_debug_dir (rproc); +rproc_char_device_remove (rproc);/* the rproc is downref'ed as soon as it's removed from the klist */ mutex_lock (&rproc_list_mutex);@@ -2220,6 +2228,7 @@ static int __init remoteproc_init(void) {rproc_init_sysfs ();rproc_init_debugfs (); +rproc_init_cdev ();return 0 ; }@@ -2231,6 +2240,7 @@ static void __exit remoteproc_exit(void)rproc_exit_debugfs ();rproc_exit_sysfs (); +rproc_exit_cdev (); }module_exit (remoteproc_exit);Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Hi Rishabh,
Quoted 4 lines · ----- On 1 Apr, 2020, at 02:03, Rishabh Bhatnagar [email protected] wrote:
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application
Typo: usersapce -> userspace.
Quoted 7 lines
crashes after booting the remote processor does not get any indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application.
Should probably use userspace for coherency.
Quoted 21 lines
A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Signed-off-by Rishabh Bhatnagar <[email protected]>---
drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+)create mode 100644
drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +0
-0@@ -14,6 +14,15 @@ config REMOTEPROCif REMOTEPROC
drivers/remoteproc/Kconfig config REMOTEPROC · line 20
Quoted 4 lines
drivers/remoteproc/Kconfig +4
-0+config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc
Not sure about the capital Remoteproc 'R' here, but maybe others can comment.
Quoted 58 lines
drivers/remoteproc/Kconfig +5
-0+ framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. +config
IMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
depends onARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.oremoteproc-y += remoteproc_sysfs.o
remoteproc-y += remoteproc_virtio.o
remoteproc-y += remoteproc_elf_loader.o
+obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o
obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o
obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o
obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +31
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc) +return -EINVAL ; + +if (rproc->state ==RPROC_RUNNING ) +return -EBUSY ; +
drivers/remoteproc/remoteproc_cdev.c line 41
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+return rproc_boot (rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc || rproc->state !=RPROC_RUNNING )
rproc state != RUNNING can probably happen if the remoteproc crashed I think. However, you'll return EINVAL, though I'm not sure about what the user could do in such cases, maybe returning another more meaningful value could be useful.
Quoted 98 lines
drivers/remoteproc/remoteproc_cdev.c new file +59
-0+return -EINVAL ; + +rproc_shutdown (rproc); + +return 0 ; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ +int ret, minor; +dev_t cdevt; + + minor =ida_simple_get (&cdev_minor_ida,0 ,NUM_RPROC_DEVICES , +GFP_KERNEL ); +if (minor <0 ) { +dev_err (&rproc->dev,"%s: No more minor numbers left! rc:%d\n" , + __func__, minor); +return -ENODEV ; + } + +cdev_init (&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner =THIS_MODULE ; + + cdevt =MKDEV (MAJOR (rproc_cdev), minor); + ret =cdev_add (&rproc->char_dev, cdevt,1 ); +if (ret <0 ) +ida_simple_remove (&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; +return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ +__unregister_chrdev (MAJOR (rproc->dev.devt),MINOR (rproc->dev.devt),1 , +"rproc" ); +ida_simple_remove (&cdev_minor_ida,MINOR (rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ +int ret; + + ret =alloc_chrdev_region (&rproc_cdev,0 ,NUM_RPROC_DEVICES ,"rproc" ); +if (ret <0 ) { +pr_err ("Failed to alloc rproc_cdev region, err %d\n" , ret); +return ; + } +} + +void __exit rproc_exit_cdev(void) +{ +__unregister_chrdev (MAJOR (rproc_cdev),0 ,NUM_RPROC_DEVICES ,"rproc" ); +}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name,struct rproc *rproc, int rproc_init_sysfs(void);void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void rproc_free_vring (struct rproc_vring *rvring);int rproc_alloc_vring (struct rproc_vdev *rvdev,int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct
rproc_mem_entry*rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...);
Quoted 1 line
+
Useless newline ?
Quoted 26 lines
static inline
intrproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw){include/linux/remoteproc.h +2
-1@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h> @@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/** -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 76 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Signed-off-by Rishabh Bhatnagar <[email protected]>--- drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+) create mode 100644 drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +9
-0@@ -14,6 +14,15 @@ config REMOTEPROC if REMOTEPROC +config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. + config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on ARCH_MXCdrivers/remoteproc/Makefile +1
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.o remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +14
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h"
drivers/remoteproc/remoteproc_cdev.c line 24
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+ +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev);
I would prefer this to be a on a single line
struct rproc *rproc = container_of(..);
drivers/remoteproc/remoteproc_cdev.c line 26
Quoted 2 lines
drivers/remoteproc/remoteproc_cdev.c new file +2
-0+ +if (!rproc)
I don't think this is possible.
drivers/remoteproc/remoteproc_cdev.c line 31
Quoted 5 lines
drivers/remoteproc/remoteproc_cdev.c new file +5
-0+return -EINVAL ; + +if (rproc->state ==RPROC_RUNNING ) +return -EBUSY ; +
This is racy, it's possible that state wasn't RUNNING, but at the time we're entering rproc_boot() it is - or as Clement correctly points out, the core might be in CRASHED state.
drivers/remoteproc/remoteproc_cdev.c line 32
Quoted 1 line
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+return rproc_boot (rproc);
Feels like we would want a variant of rproc_boot() that doesn't do refcounting... Maybe a rproc_boot_exclusive() that takes the mutex and then fails if the core is refcounted already?
drivers/remoteproc/remoteproc_cdev.c line 42
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc || rproc->state !=RPROC_RUNNING ) +return -EINVAL ;
rproc can't be NULL here and the core might be in CRASHED state here, in which case we still want to abort that and shut down the core...
Note that in the event of calling close() the return value is discarded on the way to userspace and in the event that the process is killed we still expect the remoteproc to be shut down (if the refcount hit 0).
Quoted 7 lines
drivers/remoteproc/remoteproc_cdev.c new file +7
-0+ +rproc_shutdown (rproc); + +return 0 ; +} + +static const struct file_operations rproc_fops = {
drivers/remoteproc/remoteproc_cdev.c line 59
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+ .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ +int ret, minor; +dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0, NUM_RPROC_DEVICES,
Can't you use rproc->index as minor?
Quoted 13 lines
drivers/remoteproc/remoteproc_cdev.c new file +13
-0+ GFP_KERNEL); +if (minor <0 ) { +dev_err (&rproc->dev,"%s: No more minor numbers left! rc:%d\n" , + __func__, minor); +return -ENODEV ; + } + +cdev_init (&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner =THIS_MODULE ; + + cdevt =MKDEV (MAJOR (rproc_cdev), minor); + ret =cdev_add (&rproc->char_dev, cdevt,1 ); +if (ret <0 )
drivers/remoteproc/remoteproc_cdev.c line 82
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+ida_simple_remove (&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; +return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ +__unregister_chrdev (MAJOR (rproc->dev.devt),MINOR (rproc->dev.devt),1 , +"rproc" );
Shouldn't this be cdev_del()?
drivers/remoteproc/remoteproc_cdev.c line 93
Quoted 11 lines
drivers/remoteproc/remoteproc_cdev.c new file +11
-0+ida_simple_remove (&cdev_minor_ida,MINOR (rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ +int ret; + + ret =alloc_chrdev_region (&rproc_cdev,0 ,NUM_RPROC_DEVICES ,"rproc" ); +if (ret <0 ) { +pr_err ("Failed to alloc rproc_cdev region, err %d\n" , ret); +return ;
Drop this return, and hence the {}
drivers/remoteproc/remoteproc_cdev.c line 99
Quoted 6 lines
drivers/remoteproc/remoteproc_cdev.c new file +6
-0+ } +} + +void __exit rproc_exit_cdev(void) +{ +__unregister_chrdev (MAJOR (rproc_cdev),0 ,NUM_RPROC_DEVICES ,"rproc" );
unregister_chrdev_region();
Quoted 64 lines
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+}drivers/remoteproc/remoteproc_internal.h +22
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,int rproc_init_sysfs (void );void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void rproc_free_vring (struct rproc_vring *rvring);int rproc_alloc_vring (struct rproc_vdev *rvdev,int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct rproc_mem_entry *rproc_find_carveout_by_name (struct rproc *rproc,const char *name, ...); +static inline int rproc_fw_sanity_check (struct rproc *rproc,const struct firmware *fw) {include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h> @@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/** Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 98 lines · Bjorn Andersson
Quoted 77 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Signed-off-by Rishabh Bhatnagar <[email protected]>--- drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+) create mode 100644 drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +9
-0@@ -14,6 +14,15 @@ config REMOTEPROC if REMOTEPROC +config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. + config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on ARCH_MXCdrivers/remoteproc/Makefile +1
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.o remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +14
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" drivers/remoteproc/remoteproc_cdev.c line 24
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+ +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev);I would prefer this to be a on a single line
struct rproc *rproc = container_of(..);drivers/remoteproc/remoteproc_cdev.c line 26
Quoted 2 lines
drivers/remoteproc/remoteproc_cdev.c new file +2
-0+ +if (!rproc)I don't think this is possible.
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c line 31
Quoted 5 lines
drivers/remoteproc/remoteproc_cdev.c new file +5
-0+return -EINVAL ; + +if (rproc->state ==RPROC_RUNNING ) +return -EBUSY ; +This is racy, it's possible that state wasn't RUNNING, but at the time we're entering
rproc_boot()it is - or as Clement correctly points out, the core might be in CRASHED state.
I can check for OFFLINE state and only then call rproc_boot.
But we would need to check inside rproc_boot if the state was OFFLINE as well. Same issue we might need to fix for sysfs interface?
Quoted 62 lines
drivers/remoteproc/remoteproc_cdev.c line 32
Quoted 1 line
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+return rproc_boot (rproc);Feels like we would want a variant of
rproc_boot()that doesn't do refcounting... Maybe arproc_boot_exclusive()that takes the mutex and then fails if the core is refcounted already?drivers/remoteproc/remoteproc_cdev.c line 42
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc || rproc->state !=RPROC_RUNNING ) +return -EINVAL ;rproc can't be NULL here and the core might be in CRASHED state here, in which case we still want to abort that and shut down the core...
Note that in the event of calling
close()the return value is discarded on the way to userspace and in the event that the process is killed we still expect the remoteproc to be shut down (if the refcount hit 0).Quoted 7 lines
drivers/remoteproc/remoteproc_cdev.c new file +7
-0+ +rproc_shutdown (rproc); + +return 0 ; +} + +static const struct file_operations rproc_fops = {drivers/remoteproc/remoteproc_cdev.c line 59
Quoted 10 lines
drivers/remoteproc/remoteproc_cdev.c new file +10
-0+ .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ +int ret, minor; +dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0, NUM_RPROC_DEVICES,Can't you use
rproc->indexas minor?Quoted 18 lines
drivers/remoteproc/remoteproc_cdev.c new file +18
-0+ GFP_KERNEL); +if (minor <0 ) { +dev_err (&rproc->dev,"%s: No more minor numbers left! rc:%d\n" , + __func__, minor); +return -ENODEV ; + } + +cdev_init (&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner =THIS_MODULE ; + + cdevt =MKDEV (MAJOR (rproc_cdev), minor); + ret =cdev_add (&rproc->char_dev, cdevt,1 ); +if (ret <0 ) +ida_simple_remove (&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; +return ret; +}
Quoted 8 lines
drivers/remoteproc/remoteproc_cdev.c line 82
Quoted 6 lines
drivers/remoteproc/remoteproc_cdev.c new file +4
-0+ +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt), MINOR(rproc->dev.devt),1,
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+ "rproc");Shouldn't this be
cdev_del()?
_unregist_chrdev should delete the cdev internally.
Quoted 16 lines
drivers/remoteproc/remoteproc_cdev.c line 93
Quoted 13 lines
drivers/remoteproc/remoteproc_cdev.c new file +8
-0+ida_simple_remove (&cdev_minor_ida,MINOR (rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ +int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES,"rproc");
drivers/remoteproc/remoteproc_cdev.c new file +3
-0+if (ret <0 ) { +pr_err ("Failed to alloc rproc_cdev region, err %d\n" , ret); +return ;Drop this return, and hence the {}
Quoted 10 lines
Quoted 7 lines
drivers/remoteproc/remoteproc_cdev.c new file +6
-0+ } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES,"rproc");
unregister_chrdev_region();
we might want to delete character devices as well, which is done by __unregister_chrdev
Quoted 68 lines
Quoted 68 lines
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+}drivers/remoteproc/remoteproc_internal.h +22
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc, int rproc_init_sysfs(void);void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void rproc_free_vring (struct rproc_vring *rvring);int rproc_alloc_vring (struct rproc_vdev *rvdev,int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc, struct rproc_mem_entry * rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...); + static inlineint rproc_fw_sanity_check(struct rproc *rproc, const struct firmware
*fw)
{include/linux/remoteproc.h +2
-1@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h> @@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/** -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using the sysfs interface?
I just want to be sure that there is no alternative to this, because having two ways for application to shutdown the firmware seems to me confusing...
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?
Thanks,
Arnaud
Quoted 210 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>--- drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+) create mode 100644 drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +9
-0@@ -14,6 +14,15 @@ config REMOTEPROC if REMOTEPROC +config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. + config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on ARCH_MXCdrivers/remoteproc/Makefile +1
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.o remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +100
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc) +return -EINVAL ; + +if (rproc->state ==RPROC_RUNNING ) +return -EBUSY ; + +return rproc_boot (rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc || rproc->state !=RPROC_RUNNING ) +return -EINVAL ; + +rproc_shutdown (rproc); + +return 0 ; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ +int ret, minor; +dev_t cdevt; + + minor =ida_simple_get (&cdev_minor_ida,0 ,NUM_RPROC_DEVICES , +GFP_KERNEL ); +if (minor <0 ) { +dev_err (&rproc->dev,"%s: No more minor numbers left! rc:%d\n" , + __func__, minor); +return -ENODEV ; + } + +cdev_init (&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner =THIS_MODULE ; + + cdevt =MKDEV (MAJOR (rproc_cdev), minor); + ret =cdev_add (&rproc->char_dev, cdevt,1 ); +if (ret <0 ) +ida_simple_remove (&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; +return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ +__unregister_chrdev (MAJOR (rproc->dev.devt),MINOR (rproc->dev.devt),1 , +"rproc" ); +ida_simple_remove (&cdev_minor_ida,MINOR (rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ +int ret; + + ret =alloc_chrdev_region (&rproc_cdev,0 ,NUM_RPROC_DEVICES ,"rproc" ); +if (ret <0 ) { +pr_err ("Failed to alloc rproc_cdev region, err %d\n" , ret); +return ; + } +} + +void __exit rproc_exit_cdev(void) +{ +__unregister_chrdev (MAJOR (rproc_cdev),0 ,NUM_RPROC_DEVICES ,"rproc" ); +}drivers/remoteproc/remoteproc_internal.h +22
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,int rproc_init_sysfs (void );void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void rproc_free_vring (struct rproc_vring *rvring);int rproc_alloc_vring (struct rproc_vdev *rvdev,int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct rproc_mem_entry *rproc_find_carveout_by_name (struct rproc *rproc,const char *name, ...); +static inline int rproc_fw_sanity_check (struct rproc *rproc,const struct firmware *fw) {include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h> @@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/**
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.
Quoted 3 lines
I just want to be sure that there is no alternative to this, because having two ways
for application to shutdown the firmware seems to me confusing...
Does making this interface optional/configurable helps?
Quoted 4 lines
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?
Auto recovery works perfectly for us. Although there is a mechanism in place using QMI(Qualcomm MSM interface) that can notify clients about remote processor crash.
Quoted 221 lines
Thanks,
ArnaudQuoted 218 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>--- drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+) create mode 100644 drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +9
-0@@ -14,6 +14,15 @@ config REMOTEPROC if REMOTEPROC +config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. + config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on ARCH_MXCdrivers/remoteproc/Makefile +1
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.o remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +81
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc) +return -EINVAL ; + +if (rproc->state ==RPROC_RUNNING ) +return -EBUSY ; + +return rproc_boot (rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc || rproc->state !=RPROC_RUNNING ) +return -EINVAL ; + +rproc_shutdown (rproc); + +return 0 ; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ +int ret, minor; +dev_t cdevt; + + minor =ida_simple_get (&cdev_minor_ida,0 ,NUM_RPROC_DEVICES , +GFP_KERNEL ); +if (minor <0 ) { +dev_err (&rproc->dev,"%s: No more minor numbers left! rc:%d\n" , + __func__, minor); +return -ENODEV ; + } + +cdev_init (&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner =THIS_MODULE ; + + cdevt =MKDEV (MAJOR (rproc_cdev), minor); + ret =cdev_add (&rproc->char_dev, cdevt,1 ); +if (ret <0 ) +ida_simple_remove (&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; +return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt), MINOR(rproc->dev.devt),1,
drivers/remoteproc/remoteproc_cdev.c new file +9
-0+ "rproc"); +ida_simple_remove (&cdev_minor_ida,MINOR (rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ +int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES,"rproc");
drivers/remoteproc/remoteproc_cdev.c new file +9
-0+if (ret <0 ) { +pr_err ("Failed to alloc rproc_cdev region, err %d\n" , ret); +return ; + } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES,"rproc");
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+}drivers/remoteproc/remoteproc_internal.h +22
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc, int rproc_init_sysfs(void);void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void rproc_free_vring (struct rproc_vring *rvring);int rproc_alloc_vring (struct rproc_vdev *rvdev,int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc, struct rproc_mem_entry * rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...); + static inlineint rproc_fw_sanity_check(struct rproc *rproc, const struct firmware
*fw)
{include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h> @@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/**
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?
Quoted 5 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.
Your description makes me feel like this patch is only a workaround of something that should be fixed in the userland, even if i understand that hanging is one of the most critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor ( e.g. rpmsg service applications) how to stop and restart everything. Using the char device would probaly resolve only a part of the issue...
I'm not aware about your environment and i'm not a userland expert. But what i still not understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).
#start the remote firmware
cp $1 /lib/firmware/
echo $1> /sys/class/remoteproc/remoteproc0/firmware echo start >/sys/class/remoteproc/remoteproc0/state #your binary
cat /dev/kmsg
# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/state
Anyway, it's just my feeling, let other people give their feedback.
Quoted 11 lines
Quoted 3 lines
I just want to be sure that there is no alternative to this, because having two ways
for application to shutdown the firmware seems to me confusing...Does making this interface optional/configurable helps?
Quoted 4 lines
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?Auto recovery works perfectly for us. Although there is a mechanism in place using QMI(Qualcomm MSM interface) that can notify clients about remote processor crash.
Thanks for the information.
Regards
Arnaud
Quoted 213 lines
Quoted 213 lines
Thanks,
ArnaudQuoted 210 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>---
drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++drivers/remoteproc/remoteproc_internal.h| 22 +++++++ include/linux/remoteproc.h | 2 +5 files changed, 134 insertions(+)create mode 100644
drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +0
-0@@ -14,6 +14,15 @@ config REMOTEPROCif REMOTEPROC
drivers/remoteproc/Kconfig +9
-0+config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. +config
IMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
depends onARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.oremoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.o
drivers/remoteproc/remoteproc_cdev.c new file +100
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc) + return -EINVAL; + + if (rproc->state == RPROC_RUNNING) + return -EBUSY; + + return rproc_boot(rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc || rproc->state != RPROC_RUNNING) + return -EINVAL; + + rproc_shutdown(rproc); + + return 0; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ + int ret, minor; + dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0, NUM_RPROC_DEVICES, + GFP_KERNEL); + if (minor < 0) { + dev_err(&rproc->dev, "%s: No more minor numbers left! rc:%d\n", + __func__, minor); + return -ENODEV; + } + + cdev_init(&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner = THIS_MODULE; + + cdevt = MKDEV(MAJOR(rproc_cdev), minor); + ret = cdev_add(&rproc->char_dev, cdevt, 1); + if (ret < 0) + ida_simple_remove(&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; + return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt), MINOR(rproc->dev.devt), 1, + "rproc"); + ida_simple_remove(&cdev_minor_ida, MINOR(rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ + int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES, "rproc"); + if (ret < 0) { + pr_err("Failed to alloc rproc_cdev region, err %d\n", ret); + return; + } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES, "rproc"); +}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc, int rproc_init_sysfs(void); void rproc_exit_sysfs(void); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ + return 0; +} +static inline void rproc_char_device_remove(struct rproc *rproc) +{ +} +#endif + void rproc_free_vring(struct rproc_vring *rvring); int rproc_alloc_vring(struct rproc_vdev *rvdev, int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct
rproc_mem_entry*
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...);+
static inline
intrproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw){include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@ #include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h>@@ -514,6 +515,7 @@ struct rproc { bool auto_boot; struct list_head dump_segments; int nb_vdev; + struct cdev char_dev; }; /**
Hi Arnaud,
Quoted 52 lines · ----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen [email protected] wrote:
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 6 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the
votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something that
should be fixed in the userland, even if i understand that hanging is one of the most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the char
device would probaly resolve only a part of the issue...
Quoted 5 lines
I'm not aware about your environment and i'm not a userland expert. But what i still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).
This is not entirely true, if the parent process is killed with a SIGKILL, then the process will not be able to handle anything and the remoteproc will still be running.
What I understood from Rishabh patch is a way to allow a single process handling the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).
Quoted 10 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/state
This is not really "production proof" and what happens if the application is responsible of setting the firmware which might be jitted ?
And if the script receives the SIGKILL, then we are back to the same problem.
I really think, this is a step forward an easier and reliable use of the remoteproc on userland to guarantee a coherent rproc state even if host application crashes.
Regards,
Clément
Quoted 235 lines
Anyway, it's just my feeling, let other people give their feedback.
Quoted 11 lines
Quoted 3 lines
I just want to be sure that there is no alternative to this, because having two ways
for application to shutdown the firmware seems to me confusing...Does making this interface optional/configurable helps?
Quoted 4 lines
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?Auto recovery works perfectly for us. Although there is a mechanism in place using QMI(Qualcomm MSM interface) that can notify clients about remote processor crash.
Thanks for the information.
Regards
ArnaudQuoted 216 lines
Quoted 216 lines
Thanks,
ArnaudQuoted 213 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>---
drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++drivers/remoteproc/remoteproc_internal.h| 22 +++++++ include/linux/remoteproc.h | 2 +5 files changed, 134 insertions(+)create mode 100644
drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +0
-0@@ -14,6 +14,15 @@ config REMOTEPROCif REMOTEPROC
drivers/remoteproc/Kconfig +9
-0+config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. +config
IMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
depends onARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.oremoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.o
drivers/remoteproc/remoteproc_cdev.c new file +100
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc) + return -EINVAL; + + if (rproc->state == RPROC_RUNNING) + return -EBUSY; + + return rproc_boot(rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc || rproc->state != RPROC_RUNNING) + return -EINVAL; + + rproc_shutdown(rproc); + + return 0; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ + int ret, minor; + dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0, NUM_RPROC_DEVICES, + GFP_KERNEL); + if (minor < 0) { + dev_err(&rproc->dev, "%s: No more minor numbers left! rc:%d\n", + __func__, minor); + return -ENODEV; + } + + cdev_init(&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner = THIS_MODULE; + + cdevt = MKDEV(MAJOR(rproc_cdev), minor); + ret = cdev_add(&rproc->char_dev, cdevt, 1); + if (ret < 0) + ida_simple_remove(&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; + return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt), MINOR(rproc->dev.devt), 1, + "rproc"); + ida_simple_remove(&cdev_minor_ida, MINOR(rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ + int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES, "rproc"); + if (ret < 0) { + pr_err("Failed to alloc rproc_cdev region, err %d\n", ret); + return; + } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES, "rproc"); +}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name,struct rproc *rproc, int rproc_init_sysfs(void); void rproc_exit_sysfs(void); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ + return 0; +} +static inline void rproc_char_device_remove(struct rproc *rproc) +{ +} +#endif + void rproc_free_vring(struct rproc_vring *rvring); int rproc_alloc_vring(struct rproc_vdev *rvdev, int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct
rproc_mem_entry*
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...);+
static inline
intrproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw){include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@ #include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h>@@ -514,6 +515,7 @@ struct rproc { bool auto_boot; struct list_head dump_segments; int nb_vdev; + struct cdev char_dev; }; /**
Hi Clément,
Quoted 81 lines · Clément Leger
Hi Arnaud,
Quoted 52 lines · ----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen [email protected] wrote:
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 6 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the
votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something that
should be fixed in the userland, even if i understand that hanging is one of the most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the char
device would probaly resolve only a part of the issue...Quoted 5 lines
I'm not aware about your environment and i'm not a userland expert. But what i still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).This is not entirely true, if the parent process is killed with a SIGKILL, then the process will not be able to handle anything and the remoteproc will still be running.
What I understood from Rishabh patch is a way to allow a single process handling the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).
Quoted 10 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/state
Quoted 3 lines
This is not really "production proof" and what happens if the application is responsible of setting the firmware which might be jitted ?
And if the script receives the SIGKILL, then we are back to the same problem.
Yes this is just a basic example, not an implementation which would depend on the environment. i'm just trying here to put forward a multi-process solution...and that I'm not an userland expert :).
Quoted 4 lines
I really think, this is a step forward an easier and reliable use of the remoteproc on userland to guarantee a coherent rproc state even if host application crashes.
I can see 3 ways of handling an application crash:
- just shutdown the firmware
=> can be done through char device
- stop some other related processes and/or generate a remote proc crash dump for debug => /sysfs and/or debugfs
- do nothing as you want a silence application reboot and re-attach to the running firmware => use sysfs
I'm challenging the solution because splitting the API seems to me not a good solution. Now i wonder how it works for the other applications that are relying on some other kernel frameworks...
Perhaps the answer is that these frameworks don't use sysfs but char device. That would means that the sysfs solution is not the more adapted solution and perhaps we should migrate to a char device.
But in this case, i think that it should implement the whole API and be exclusive with the syfs legacy API (so no sysfs or sysfs in read-only).
Regards,
Arnaud
Quoted 240 lines
Regards,
Clément
Quoted 235 lines
Anyway, it's just my feeling, let other people give their feedback.
Quoted 11 lines
Quoted 3 lines
I just want to be sure that there is no alternative to this, because having two ways
for application to shutdown the firmware seems to me confusing...Does making this interface optional/configurable helps?
Quoted 4 lines
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?Auto recovery works perfectly for us. Although there is a mechanism in place using QMI(Qualcomm MSM interface) that can notify clients about remote processor crash.
Thanks for the information.
Regards
ArnaudQuoted 216 lines
Quoted 216 lines
Thanks,
ArnaudQuoted 213 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>---
drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++drivers/remoteproc/remoteproc_internal.h| 22 +++++++ include/linux/remoteproc.h | 2 +5 files changed, 134 insertions(+)create mode 100644
drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +0
-0@@ -14,6 +14,15 @@ config REMOTEPROCif REMOTEPROC
drivers/remoteproc/Kconfig +9
-0+config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. +config
IMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
depends onARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.oremoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.o
drivers/remoteproc/remoteproc_cdev.c new file +100
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc) + return -EINVAL; + + if (rproc->state == RPROC_RUNNING) + return -EBUSY; + + return rproc_boot(rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc || rproc->state != RPROC_RUNNING) + return -EINVAL; + + rproc_shutdown(rproc); + + return 0; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ + int ret, minor; + dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0, NUM_RPROC_DEVICES, + GFP_KERNEL); + if (minor < 0) { + dev_err(&rproc->dev, "%s: No more minor numbers left! rc:%d\n", + __func__, minor); + return -ENODEV; + } + + cdev_init(&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner = THIS_MODULE; + + cdevt = MKDEV(MAJOR(rproc_cdev), minor); + ret = cdev_add(&rproc->char_dev, cdevt, 1); + if (ret < 0) + ida_simple_remove(&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; + return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt), MINOR(rproc->dev.devt), 1, + "rproc"); + ida_simple_remove(&cdev_minor_ida, MINOR(rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ + int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES, "rproc"); + if (ret < 0) { + pr_err("Failed to alloc rproc_cdev region, err %d\n", ret); + return; + } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES, "rproc"); +}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name,struct rproc *rproc, int rproc_init_sysfs(void); void rproc_exit_sysfs(void); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ + return 0; +} +static inline void rproc_char_device_remove(struct rproc *rproc) +{ +} +#endif + void rproc_free_vring(struct rproc_vring *rvring); int rproc_alloc_vring(struct rproc_vdev *rvdev, int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct
rproc_mem_entry*
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...);+
static inline
intrproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw){include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@ #include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h>@@ -514,6 +515,7 @@ struct rproc { bool auto_boot; struct list_head dump_segments; int nb_vdev; + struct cdev char_dev; }; /**
Hi Arnaud,
Quoted 108 lines · ----- On 6 Apr, 2020, at 16:17, Arnaud Pouliquen [email protected] wrote:
Hi Clément,
Quoted 81 lines · Clément Leger
Hi Arnaud,
Quoted 52 lines · ----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen [email protected] wrote:
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 6 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the
votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something that
should be fixed in the userland, even if i understand that hanging is one of the most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the char
device would probaly resolve only a part of the issue...Quoted 5 lines
I'm not aware about your environment and i'm not a userland expert. But what i still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).This is not entirely true, if the parent process is killed with a SIGKILL, then the process will not be able to handle anything and the remoteproc will still be running.
What I understood from Rishabh patch is a way to allow a single process handling the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).
Quoted 10 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/stateQuoted 3 lines
This is not really "production proof" and what happens if the application is responsible of setting the firmware which might be jitted ?
And if the script receives the SIGKILL, then we are back to the same problem.Yes this is just a basic example, not an implementation which would depend on the
environment. i'm just trying here to put forward a multi-process solution...and that I'm not an userland expert :).Quoted 5 lines
I really think, this is a step forward an easier and reliable use of the remoteproc
on userland to guarantee a coherent rproc state even if host application crashes.I can see 3 ways of handling an application crash:
- just shutdown the firmware
=> can be done through char device
- stop some other related processes and/or generate a remote proc crash dump for debug
=> /sysfs and/or debugfs
- do nothing as you want a silence application reboot and re-attach to the running firmware
=> use sysfs
Quoted 2 lines
I'm challenging the solution because splitting the API seems to me not a good solution.
Completely ok with that, we have to fully understand the targeted usecase to avoid implemented a flawed interface.
Quoted 3 lines
Now i wonder how it works for the other applications that are relying on some other
kernel frameworks...
For some other device, there is a chardev. The watchdog for intance uses a /dev/watchdog. Regarding the gpio, it seems they are also using a chardev and the sysfs interface is deprecated.
Quoted 6 lines
Perhaps the answer is that these frameworks don't use sysfs but char device. That would means that the sysfs solution is not the more adapted solution and perhaps we should migrate to a char device.
But in this case, i think that it should implement the whole API and be exclusive with
the syfs legacy API (so no sysfs or sysfs in read-only).
I agree with that, if another interface must be defined, then it should implement everything that is supported right now with the sysfs.
Regards,
Clément
Quoted 244 lines
Regards,
ArnaudQuoted 240 lines
Regards,
Clément
Quoted 235 lines
Anyway, it's just my feeling, let other people give their feedback.
Quoted 11 lines
Quoted 3 lines
I just want to be sure that there is no alternative to this, because having two ways
for application to shutdown the firmware seems to me confusing...Does making this interface optional/configurable helps?
Quoted 4 lines
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?Auto recovery works perfectly for us. Although there is a mechanism in place using QMI(Qualcomm MSM interface) that can notify clients about remote processor crash.
Thanks for the information.
Regards
ArnaudQuoted 216 lines
Quoted 216 lines
Thanks,
ArnaudQuoted 213 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>---
drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++drivers/remoteproc/remoteproc_internal.h| 22 +++++++ include/linux/remoteproc.h | 2 +5 files changed, 134 insertions(+)create mode 100644
drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +0
-0@@ -14,6 +14,15 @@ config REMOTEPROCif REMOTEPROC
drivers/remoteproc/Kconfig +9
-0+config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. +config
IMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
depends onARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.oremoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.o
drivers/remoteproc/remoteproc_cdev.c new file +100
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc) + return -EINVAL; + + if (rproc->state == RPROC_RUNNING) + return -EBUSY; + + return rproc_boot(rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc || rproc->state != RPROC_RUNNING) + return -EINVAL; + + rproc_shutdown(rproc); + + return 0; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ + int ret, minor; + dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0, NUM_RPROC_DEVICES, + GFP_KERNEL); + if (minor < 0) { + dev_err(&rproc->dev, "%s: No more minor numbers left! rc:%d\n", + __func__, minor); + return -ENODEV; + } + + cdev_init(&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner = THIS_MODULE; + + cdevt = MKDEV(MAJOR(rproc_cdev), minor); + ret = cdev_add(&rproc->char_dev, cdevt, 1); + if (ret < 0) + ida_simple_remove(&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; + return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt), MINOR(rproc->dev.devt), 1, + "rproc"); + ida_simple_remove(&cdev_minor_ida, MINOR(rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ + int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES, "rproc"); + if (ret < 0) { + pr_err("Failed to alloc rproc_cdev region, err %d\n", ret); + return; + } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES, "rproc"); +}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name,struct rproc *rproc, int rproc_init_sysfs(void); void rproc_exit_sysfs(void); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ + return 0; +} +static inline void rproc_char_device_remove(struct rproc *rproc) +{ +} +#endif + void rproc_free_vring(struct rproc_vring *rvring); int rproc_alloc_vring(struct rproc_vdev *rvdev, int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct
rproc_mem_entry*
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...);+
static inline
intrproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw){include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@ #include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h>@@ -514,6 +515,7 @@ struct rproc { bool auto_boot; struct list_head dump_segments; int nb_vdev; + struct cdev char_dev; }; /**
Quoted 103 lines · Clément Leger
Hi Arnaud,
----- On 6 Apr, 2020, at 16:17, Arnaud Pouliquen
Quoted 98 lines · [email protected] wrote:
Hi Clément,
Quoted 82 lines · Clément Leger
Hi Arnaud,
----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen
Quoted 52 lines · [email protected] wrote:
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 6 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the
votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something that
should be fixed in the userland, even if i understand that hanging is one of the most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the char
device would probaly resolve only a part of the issue...Quoted 5 lines
I'm not aware about your environment and i'm not a userland expert. But what i still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).This is not entirely true, if the parent process is killed with a SIGKILL, then the process will not be able to handle anything and the remoteproc will still be running.
What I understood from Rishabh patch is a way to allow a single process handling the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).
Quoted 10 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/stateQuoted 3 lines
This is not really "production proof" and what happens if the application is responsible of setting the firmware which might be jitted ?
And if the script receives the SIGKILL, then we are back to the same problem.Yes this is just a basic example, not an implementation which would depend on the
environment. i'm just trying here to put forward a multi-process solution...and that I'm not an userland expert :).Quoted 5 lines
I really think, this is a step forward an easier and reliable use of the remoteproc
on userland to guarantee a coherent rproc state even if host application crashes.
Yes what we want is simple mechanism where a single userspace process can boot/ shutdown the remote processor in all scenarios. Adding more processes to monitor the already existing process might have 2 issues. One is there might be a delay between the application crash and process monitor getting to know about it and taking action. This might prove to be fatal in our case. Second, possibly the monitor can hang or get killed and is not deterministic.
Quoted 34 lines
Quoted 13 lines
I can see 3 ways of handling an application crash:
- just shutdown the firmware
=> can be done through char device
- stop some other related processes and/or generate a remote proc crash dump for
debug
=> /sysfs and/or debugfs
- do nothing as you want a silence application reboot and re-attach to the
running firmware
=> use sysfsQuoted 2 lines
I'm challenging the solution because splitting the API seems to me not a good solution.
Completely ok with that, we have to fully understand the targeted usecase to avoid implemented a flawed interface.
Quoted 3 lines
Now i wonder how it works for the other applications that are relying on some other
kernel frameworks...For some other device, there is a chardev. The watchdog for intance uses a
/dev/watchdog. Regarding the gpio, it seems they are also using a chardev and the sysfs interface is deprecated.Quoted 6 lines
Perhaps the answer is that these frameworks don't use sysfs but char device. That would means that the sysfs solution is not the more adapted solution and perhaps we should migrate to a char device.
But in this case, i think that it should implement the whole API and be exclusive with
the syfs legacy API (so no sysfs or sysfs in read-only).
Quoted 3 lines
I agree with that, if another interface must be defined, then it should implement everything that is supported right now with the sysfs.
The other fields that sysfs exposes right now are firmware_name, name(rproc name), state. The targeted usecase was that these are configuration parameters specific to the remoteproc and should stay in the sysfs interface. Whereas char device should provide direct access to remoteproc device.
It would make sense to use this interface in conjunction with sysfs interface, where you use /dev/remoteproc0 to boot/shutdown the remote processor sysfs entries to fine tune the parameters.
Adding ioctls to implement all sysfs functionality seems like overkill to me. Let me know what you guys think.
Quoted 264 lines
Clément
Quoted 261 lines
Regards,
ArnaudQuoted 257 lines
Regards,
Clément
Quoted 252 lines
Anyway, it's just my feeling, let other people give their feedback.
Quoted 11 lines
Quoted 3 lines
I just want to be sure that there is no alternative to this, because having two ways
for application to shutdown the firmware seems to me confusing...Does making this interface optional/configurable helps?
Quoted 4 lines
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?Auto recovery works perfectly for us. Although there is a mechanism in place using QMI(Qualcomm MSM interface) that can notify clients about remote processor crash.
Thanks for the information.
Regards
ArnaudQuoted 233 lines
Quoted 233 lines
Thanks,
ArnaudQuoted 230 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>---
drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100
+++++++++++++++++++++++++++++++
drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 +5 files changed, 134 insertions(+)create mode 100644
drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +0
-0@@ -14,6 +14,15 @@ config REMOTEPROCif REMOTEPROC
+config
REMOTEPROC_CDEV
+ bool "Remoteproc character device interface"
+ help
+ Say y here to have a character device interface for Remoteproc
+ framework. Userspace can boot/shutdown remote processors through
+ this interface.
+
+ It's safe to say N if you don't want to use this interface.
+
configIMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
depends onARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y +=remoteproc_debugfs.o
remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +5
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ */drivers/remoteproc/remoteproc_cdev.c new file +14
-0+ +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open(struct inode *inode, struct file*file)
drivers/remoteproc/remoteproc_cdev.c new file +15
-0+{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc) + return -EINVAL; + + if (rproc->state == RPROC_RUNNING) + return -EBUSY; + + return rproc_boot(rproc); +} + +static int rproc_cdev_release(struct inode *inode, struct file*file)
drivers/remoteproc/remoteproc_cdev.c new file +24
-0+{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc || rproc->state != RPROC_RUNNING) + return -EINVAL; + + rproc_shutdown(rproc); + + return 0; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ + int ret, minor; + dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0,
NUM_RPROC_DEVICES,
+GFP_KERNEL);
+ if (minor < 0) {
+ dev_err(&rproc->dev, "%s: No more minor numbers left! rc:%d\n",
+__func__, minor);
+ return-ENODEV;
+ }drivers/remoteproc/remoteproc_cdev.c new file +16
-0+ + cdev_init(&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner = THIS_MODULE; + + cdevt = MKDEV(MAJOR(rproc_cdev), minor); + ret = cdev_add(&rproc->char_dev, cdevt, 1); + if (ret < 0) + ida_simple_remove(&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; + return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt),
MINOR(rproc->dev.devt), 1,
+ "rproc");
+ida_simple_remove(&cdev_minor_ida, MINOR(rproc->dev.devt));drivers/remoteproc/remoteproc_cdev.c new file +7
-0+} + +void __init rproc_init_cdev (void ) +{ + int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES,"rproc");
+ if (ret < 0) {
+pr_err("Failed to alloc rproc_cdev region, err %d\n", ret);
+ return;
+ }drivers/remoteproc/remoteproc_cdev.c new file +5
-0+} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES,"rproc");
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(constchar *name, struct rproc *rproc, int rproc_init_sysfs(void); void rproc_exit_sysfs(void); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ + return 0; +} +static inline void rproc_char_device_remove(struct rproc *rproc) +{ +} +#endif +void
rproc_free_vring(struct rproc_vring *rvring); intrproc_alloc_vring(struct rproc_vdev *rvdev, int i);drivers/remoteproc/remoteproc_internal.h +0
-0@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct
rproc_mem_entry*
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...);+
static inline
intrproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw){include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@ #include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h>@@ -514,6 +515,7 @@ struct rproc { bool auto_boot; struct list_head dump_segments; int nb_vdev; + struct cdev char_dev; }; /**
Quoted 143 lines · On 4/8/20 8:34 PM, [email protected] wrote:
Quoted 101 lines · Clément Leger
Hi Arnaud,
Quoted 97 lines · ----- On 6 Apr, 2020, at 16:17, Arnaud Pouliquen [email protected] wrote:
Hi Clément,
Quoted 81 lines · Clément Leger
Hi Arnaud,
Quoted 52 lines · ----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen [email protected] wrote:
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 6 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the
votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something that
should be fixed in the userland, even if i understand that hanging is one of the most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the char
device would probaly resolve only a part of the issue...Quoted 5 lines
I'm not aware about your environment and i'm not a userland expert. But what i still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).This is not entirely true, if the parent process is killed with a SIGKILL, then the process will not be able to handle anything and the remoteproc will still be running.
What I understood from Rishabh patch is a way to allow a single process handling the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).
Quoted 10 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/stateQuoted 3 lines
This is not really "production proof" and what happens if the application is responsible of setting the firmware which might be jitted ?
And if the script receives the SIGKILL, then we are back to the same problem.Yes this is just a basic example, not an implementation which would depend on the
environment. i'm just trying here to put forward a multi-process solution...and that I'm not an userland expert :).Quoted 5 lines
I really think, this is a step forward an easier and reliable use of the remoteproc
on userland to guarantee a coherent rproc state even if host application crashes.Yes what we want is simple mechanism where a single userspace process can boot/ shutdown the remote processor in all scenarios. Adding more processes to monitor the already existing process might have 2 issues. One is there might be a delay between the application crash and process monitor getting to know about it and taking action. This might prove to be fatal in our case. Second, possibly the monitor can hang or get killed and is not deterministic.
Quoted 32 lines
Quoted 11 lines
I can see 3 ways of handling an application crash:
- just shutdown the firmware
=> can be done through char device
- stop some other related processes and/or generate a remote proc crash dump for debug
=> /sysfs and/or debugfs
- do nothing as you want a silence application reboot and re-attach to the running firmware
=> use sysfsQuoted 2 lines
I'm challenging the solution because splitting the API seems to me not a good solution.
Completely ok with that, we have to fully understand the targeted usecase to avoid implemented a flawed interface.
Quoted 3 lines
Now i wonder how it works for the other applications that are relying on some other
kernel frameworks...For some other device, there is a chardev. The watchdog for intance uses a
/dev/watchdog. Regarding the gpio, it seems they are also using a chardev and the sysfs interface is deprecated.Quoted 6 lines
Perhaps the answer is that these frameworks don't use sysfs but char device. That would means that the sysfs solution is not the more adapted solution and perhaps we should migrate to a char device.
But in this case, i think that it should implement the whole API and be exclusive with
the syfs legacy API (so no sysfs or sysfs in read-only).Quoted 3 lines
I agree with that, if another interface must be defined, then it should implement everything that is supported right now with the sysfs.
Quoted 9 lines
The other fields that sysfs exposes right now are
firmware_name, name(rproc name), state. The targeted usecase was that these are configuration parameters specific to the remoteproc and should stay in the sysfs interface. Whereas char device should provide direct access to remoteproc device.
It would make sense to use this interface in conjunction with sysfs interface, where you use/dev/remoteproc0to boot/shutdown the remote processor sysfs entries to fine tune the parameters.
Adding ioctls to implement all sysfs functionality seems like overkill to me. Let me know what you guys think.
In my opinion if we open the possibility of accessing to remoteproc through a char device, we should move torwards a solution that would replace the sysfs. In this case sysfs fields could be read-only, and the char devices would have to support the different shutdown modes. This means that the auto shutdown should be configurable (IOCTL?).
But I assume that the minimum could be to only disable write access on the "state" field and handle the "auto shutdown" as an option of the char device.
Anyway it only my opinion, let Bjorn an Mathieu comment and decide :)
Regards,
Arnaud
Quoted 247 lines
Quoted 247 lines
Clément
Quoted 244 lines
Regards,
ArnaudQuoted 240 lines
Regards,
Clément
Quoted 235 lines
Anyway, it's just my feeling, let other people give their feedback.
Quoted 11 lines
Quoted 3 lines
I just want to be sure that there is no alternative to this, because having two ways
for application to shutdown the firmware seems to me confusing...Does making this interface optional/configurable helps?
Quoted 4 lines
What about the opposite service, mean inform the application that the remote processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?Auto recovery works perfectly for us. Although there is a mechanism in place using QMI(Qualcomm MSM interface) that can notify clients about remote processor crash.
Thanks for the information.
Regards
ArnaudQuoted 216 lines
Quoted 216 lines
Thanks,
ArnaudQuoted 213 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>---
drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++drivers/remoteproc/remoteproc_internal.h| 22 +++++++ include/linux/remoteproc.h | 2 +5 files changed, 134 insertions(+)create mode 100644
drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +0
-0@@ -14,6 +14,15 @@ config REMOTEPROCif REMOTEPROC
drivers/remoteproc/Kconfig +9
-0+config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. +config
IMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
depends onARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.oremoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.o
drivers/remoteproc/remoteproc_cdev.c new file +100
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc) + return -EINVAL; + + if (rproc->state == RPROC_RUNNING) + return -EBUSY; + + return rproc_boot(rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ + struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + + if (!rproc || rproc->state != RPROC_RUNNING) + return -EINVAL; + + rproc_shutdown(rproc); + + return 0; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ + int ret, minor; + dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0, NUM_RPROC_DEVICES, + GFP_KERNEL); + if (minor < 0) { + dev_err(&rproc->dev, "%s: No more minor numbers left! rc:%d\n", + __func__, minor); + return -ENODEV; + } + + cdev_init(&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner = THIS_MODULE; + + cdevt = MKDEV(MAJOR(rproc_cdev), minor); + ret = cdev_add(&rproc->char_dev, cdevt, 1); + if (ret < 0) + ida_simple_remove(&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; + return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt), MINOR(rproc->dev.devt), 1, + "rproc"); + ida_simple_remove(&cdev_minor_ida, MINOR(rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ + int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES, "rproc"); + if (ret < 0) { + pr_err("Failed to alloc rproc_cdev region, err %d\n", ret); + return; + } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES, "rproc"); +}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name,struct rproc *rproc, int rproc_init_sysfs(void); void rproc_exit_sysfs(void); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ + return 0; +} +static inline void rproc_char_device_remove(struct rproc *rproc) +{ +} +#endif + void rproc_free_vring(struct rproc_vring *rvring); int rproc_alloc_vring(struct rproc_vdev *rvdev, int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct
rproc_mem_entry*
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...);+
static inline
intrproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw){include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@ #include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h>@@ -514,6 +515,7 @@ struct rproc { bool auto_boot; struct list_head dump_segments; int nb_vdev; + struct cdev char_dev; }; /**
Quoted 163 lines · Arnaud POULIQUEN
Quoted 143 lines · On 4/8/20 8:34 PM, [email protected] wrote:
Quoted 101 lines · Clément Leger
Hi Arnaud,
Quoted 97 lines · ----- On 6 Apr, 2020, at 16:17, Arnaud Pouliquen [email protected] wrote:
Hi Clément,
Quoted 81 lines · Clément Leger
Hi Arnaud,
Quoted 52 lines · ----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen [email protected] wrote:
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 6 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the
votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something that
should be fixed in the userland, even if i understand that hanging is one of the most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the char
device would probaly resolve only a part of the issue...Quoted 5 lines
I'm not aware about your environment and i'm not a userland expert. But what i still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).This is not entirely true, if the parent process is killed with a SIGKILL, then the process will not be able to handle anything and the remoteproc will still be running.
What I understood from Rishabh patch is a way to allow a single process handling the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).
Quoted 10 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/stateQuoted 3 lines
This is not really "production proof" and what happens if the application is responsible of setting the firmware which might be jitted ?
And if the script receives the SIGKILL, then we are back to the same problem.Yes this is just a basic example, not an implementation which would depend on the
environment. i'm just trying here to put forward a multi-process solution...and that I'm not an userland expert :).Quoted 5 lines
I really think, this is a step forward an easier and reliable use of the remoteproc
on userland to guarantee a coherent rproc state even if host application crashes.Yes what we want is simple mechanism where a single userspace process can boot/ shutdown the remote processor in all scenarios. Adding more processes to monitor the already existing process might have 2 issues. One is there might be a delay between the application crash and process monitor getting to know about it and taking action. This might prove to be fatal in our case. Second, possibly the monitor can hang or get killed and is not deterministic.
Quoted 32 lines
Quoted 11 lines
I can see 3 ways of handling an application crash:
- just shutdown the firmware
=> can be done through char device
- stop some other related processes and/or generate a remote proc crash dump for debug
=> /sysfs and/or debugfs
- do nothing as you want a silence application reboot and re-attach to the running firmware
=> use sysfsQuoted 2 lines
I'm challenging the solution because splitting the API seems to me not a good solution.
Completely ok with that, we have to fully understand the targeted usecase to avoid implemented a flawed interface.
Quoted 3 lines
Now i wonder how it works for the other applications that are relying on some other
kernel frameworks...For some other device, there is a chardev. The watchdog for intance uses a
/dev/watchdog. Regarding the gpio, it seems they are also using a chardev and the sysfs interface is deprecated.Quoted 6 lines
Perhaps the answer is that these frameworks don't use sysfs but char device. That would means that the sysfs solution is not the more adapted solution and perhaps we should migrate to a char device.
But in this case, i think that it should implement the whole API and be exclusive with
the syfs legacy API (so no sysfs or sysfs in read-only).Quoted 3 lines
I agree with that, if another interface must be defined, then it should implement everything that is supported right now with the sysfs.
Quoted 9 lines
The other fields that sysfs exposes right now are
firmware_name, name(rproc name), state. The targeted usecase was that these are configuration parameters specific to the remoteproc and should stay in the sysfs interface. Whereas char device should provide direct access to remoteproc device.
It would make sense to use this interface in conjunction with sysfs interface, where you use/dev/remoteproc0to boot/shutdown the remote processor sysfs entries to fine tune the parameters.
Adding ioctls to implement all sysfs functionality seems like overkill to me. Let me know what you guys think.In my opinion if we open the possibility of accessing to remoteproc through a char device, we should move torwards a solution that would replace the sysfs. In this case sysfs fields could be read-only, and the char devices would have to support the different shutdown modes. This means that the auto shutdown should be configurable (IOCTL?).
But I assume that the minimum could be to only disable write access on the "state" field and handle the "auto shutdown" as an option of the char device.
Quoted 2 lines
Anyway it only my opinion, let Bjorn an Mathieu comment and decide :)
I have two concerns with migrating things to a character device:
1) Operating an ioctl based interface requires specialized tooling. E.g. today whatever your installation is you can change firmware name and start a core with the user space tools you have. Further more allowing you to change firmware name before powering on the core would imply that both of these would have to be ioctls (we can't just boot the core on open) - so we would end up duplicating all parts of the sysfs interface in ioctls.
2) Reducing the functionality of the sysfs interface would break compatibility with existing user space, which is verboten. So we would at best duplicate the existing features.
That said, per the same argument I don't really like duplicating the state controls in a character device (i.e. Rishabh's patch), but this really does provide something that we can't do with the current interface.
Regards,
Bjorn
Quoted 178 lines · Bjorn Andersson
Quoted 163 lines · Arnaud POULIQUEN
Quoted 143 lines · On 4/8/20 8:34 PM, [email protected] wrote:
Quoted 101 lines · Clément Leger
Hi Arnaud,
Quoted 97 lines · ----- On 6 Apr, 2020, at 16:17, Arnaud Pouliquen [email protected] wrote:
Hi Clément,
Quoted 81 lines · Clément Leger
Hi Arnaud,
Quoted 52 lines · ----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen [email protected] wrote:
Quoted 33 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 17 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Quoted 7 lines
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Yes correct, while we wait for the application to restart we might observe a fatal crash.
Quoted 6 lines
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 6 lines
What happens in the case where the process monitor itself crashes? This is actually the approach we follow in our downstream code. We have a central entity in userspace that controls bootup/shutdown of some remote processors based on the
votes from userspace clients. We have observed cases where this entity itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something that
should be fixed in the userland, even if i understand that hanging is one of the most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the char
device would probaly resolve only a part of the issue...Quoted 5 lines
I'm not aware about your environment and i'm not a userland expert. But what i still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application ("cat" in my case).This is not entirely true, if the parent process is killed with a SIGKILL, then the process will not be able to handle anything and the remoteproc will still be running.
What I understood from Rishabh patch is a way to allow a single process handling the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).
Quoted 10 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/stateQuoted 3 lines
This is not really "production proof" and what happens if the application is responsible of setting the firmware which might be jitted ?
And if the script receives the SIGKILL, then we are back to the same problem.Yes this is just a basic example, not an implementation which would depend on the
environment. i'm just trying here to put forward a multi-process solution...and that I'm not an userland expert :).Quoted 5 lines
I really think, this is a step forward an easier and reliable use of the remoteproc
on userland to guarantee a coherent rproc state even if host application crashes.Yes what we want is simple mechanism where a single userspace process can boot/ shutdown the remote processor in all scenarios. Adding more processes to monitor the already existing process might have 2 issues. One is there might be a delay between the application crash and process monitor getting to know about it and taking action. This might prove to be fatal in our case. Second, possibly the monitor can hang or get killed and is not deterministic.
Quoted 32 lines
Quoted 11 lines
I can see 3 ways of handling an application crash:
- just shutdown the firmware
=> can be done through char device
- stop some other related processes and/or generate a remote proc crash dump for debug
=> /sysfs and/or debugfs
- do nothing as you want a silence application reboot and re-attach to the running firmware
=> use sysfsQuoted 2 lines
I'm challenging the solution because splitting the API seems to me not a good solution.
Completely ok with that, we have to fully understand the targeted usecase to avoid implemented a flawed interface.
Quoted 3 lines
Now i wonder how it works for the other applications that are relying on some other
kernel frameworks...For some other device, there is a chardev. The watchdog for intance uses a
/dev/watchdog. Regarding the gpio, it seems they are also using a chardev and the sysfs interface is deprecated.Quoted 6 lines
Perhaps the answer is that these frameworks don't use sysfs but char device. That would means that the sysfs solution is not the more adapted solution and perhaps we should migrate to a char device.
But in this case, i think that it should implement the whole API and be exclusive with
the syfs legacy API (so no sysfs or sysfs in read-only).Quoted 3 lines
I agree with that, if another interface must be defined, then it should implement everything that is supported right now with the sysfs.
Quoted 9 lines
The other fields that sysfs exposes right now are
firmware_name, name(rproc name), state. The targeted usecase was that these are configuration parameters specific to the remoteproc and should stay in the sysfs interface. Whereas char device should provide direct access to remoteproc device.
It would make sense to use this interface in conjunction with sysfs interface, where you use/dev/remoteproc0to boot/shutdown the remote processor sysfs entries to fine tune the parameters.
Adding ioctls to implement all sysfs functionality seems like overkill to me. Let me know what you guys think.In my opinion if we open the possibility of accessing to remoteproc through a char device, we should move torwards a solution that would replace the sysfs. In this case sysfs fields could be read-only, and the char devices would have to support the different shutdown modes. This means that the auto shutdown should be configurable (IOCTL?).
But I assume that the minimum could be to only disable write access on the "state" field and handle the "auto shutdown" as an option of the char device.Quoted 2 lines
Anyway it only my opinion, let Bjorn an Mathieu comment and decide :)
I have two concerns with migrating things to a character device:
1) Operating an ioctl based interface requires specialized tooling. E.g. today whatever your installation is you can change firmware name and start a core with the user space tools you have. Further more allowing you to change firmware name before powering on the core would imply that both of these would have to be ioctls (we can't just boot the core on open) - so we would end up duplicating all parts of the sysfs interface in ioctls.
Quoted 3 lines
2) Reducing the functionality of the sysfs interface would break compatibility with existing user space, which is verboten. So we would at best duplicate the existing features.
Agree with your concerns.
But could we consider that an application using this char dev, is no more compatible with existing interface?
And it would make sense that it requests exclusivity on
the remote firmware lice cycle. In this case the sysfs state should be read only to protect from an unexpected shutdown.
Quoted 6 lines
That said, per the same argument I don't really like duplicating the state controls in a character device (i.e. Rishabh's patch), but this really does provide something that we can't do with the current interface.
Yes, that why it could be nice to make it scalable to integrate future extension that can not be implemented using sysfs.
One of my main concern is that forcing the boot on open and shutdown on close limits the usage of this device for some other future purposes. Coming back in the future to a generic solution will be not possible as case of impact on the open close behaviour.
Using ioctls would avoid this limitation...
Ioctl could be used to enable the boot/shutdown on open/close
Then this char device could be also used to generate an event for application on crash.
In this case the char device could be used only for the event, and sysfs state would be used to manage the remoteproc firmware. So sysfs state should be in read write access...
Concerning the firmware name, today sysfs interface imposes only one firmware what's happen if more that one firmware loading is requested (for instance a core firmware with of some processing or rpc modules...).
In this case the sysfs firmware field could not be used.
These examples make me think that sysfs could be to manage through remoteproc_cdev instead of directly calling core function. This would help to define dynamic rules for the sysfs access.
To sum up, nothing against opening interface with the char device. I'm just wondering if this device should not be designed to allow some future extensions of the API, and not only for this use case.
Regards
Arnaud
Quoted 4 lines
Regards,
Bjorn
Mathieu Poirier
maintainerQuoted 188 lines · On Wed, 8 Apr 2020 at 12:35, <[email protected]> wrote:
Quoted 130 lines · Clément Leger
Hi Arnaud,
----- On 6 Apr, 2020, at 16:17, Arnaud Pouliquen
Quoted 125 lines · [email protected] wrote:
Hi Clément,
Quoted 103 lines · Clément Leger
Hi Arnaud,
----- On 6 Apr, 2020, at 11:01, Arnaud Pouliquen
Quoted 66 lines · [email protected] wrote:
Quoted 39 lines · On 4/3/20 9:13 PM, [email protected] wrote:
Quoted 22 lines · Arnaud POULIQUEN
Hi
Quoted 6 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any indication about the crash. It might still assume that the
Quoted 8 lines
application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors
therefore shutting down the remoteproc.Sorry I'm late in the discussion, I hope I've gone through the whole
discussion so I don't reopen a closed point...Quoted 6 lines
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to
stop and restart the remote processor...Yes correct, while we wait for the application to restart we might observe a
fatal crash.Quoted 7 lines
Why this use case can not be solved by a process monitor or a service
in userland that detects the application crash and stop the remote firmware using
the sysfs interface?Quoted 10 lines
What happens in the case where the process monitor itself crashes? This is
actually the approach we follow in our downstream code. We have a central entity
in userspace that controls bootup/shutdown of some remote processors based on
the
votes from userspace clients. We have observed cases where this entity
itself crashes and remote processors are left hanging.Your description makes me feel like this patch is only a workaround of something
that
should be fixed in the userland, even if i understand that hanging is one of the
most
critical problem and have to be fixed.
For instance, how to handle several applications that interact with the remote
processor
( e.g. rpmsg service applications) how to stop and restart everything. Using the
char
device would probaly resolve only a part of the issue...Quoted 7 lines
I'm not aware about your environment and i'm not a userland expert. But what i
still not
understand why a parent process can not do the job...
I just test a simple script on my side that treat the kill -9 of an application
("cat" in my case).This is not entirely true, if the parent process is killed with a SIGKILL, then
the process will not be able to handle anything and the remoteproc will still
be running.What I understood from Rishabh patch is a way to allow a single process handling
the rproc state. We have the same kind of need and currently, if the user application crashes, then the rproc is still running (which happens).Quoted 11 lines
#start the remote firmware
cp $1/lib/firmware/
echo $1>/sys/class/remoteproc/remoteproc0/firmwareecho start >/sys/class/remoteproc/remoteproc0/state #your binary
cat/dev/kmsg# stop the remote firmware in case of crash (and potentially some other apps) echo stop >/sys/class/remoteproc/remoteproc0/stateQuoted 5 lines
This is not really "production proof" and what happens if the application is
responsible of setting the firmware which might be jitted ? And if the script receives the SIGKILL, then we are back to the same problem.Yes this is just a basic example, not an implementation which would depend on
the
environment. i'm just trying here to put forward a multi-process solution...and
that I'm not an userland expert :).Quoted 7 lines
I really think, this is a step forward an easier and reliable use of the
remoteproc
on userland to guarantee a coherent rproc state even if host application
crashes.Yes what we want is simple mechanism where a single userspace process can boot/
shutdown the remote processor in all scenarios. Adding more processes to monitor
the already existing process might have 2 issues. One is there might be a delay
between the application crash and process monitor getting to know about it and taking
action. This might prove to be fatal in our case. Second, possibly the monitor can hang
or get killed and is not deterministic.Quoted 42 lines
Quoted 13 lines
I can see 3 ways of handling an application crash:
- just shutdown the firmware
=> can be done through char device
- stop some other related processes and/or generate a remote proc crash dump for
debug
=> /sysfs and/or debugfs
- do nothing as you want a silence application reboot and re-attach to the
running firmware
=> use sysfsQuoted 3 lines
I'm challenging the solution because splitting the API seems to me not a good
solution.Completely ok with that, we have to fully understand the targeted usecase to
avoid implemented a flawed interface.Quoted 4 lines
Now i wonder how it works for the other applications that are relying on some
other
kernel frameworks...For some other device, there is a chardev. The watchdog for intance uses a
/dev/watchdog. Regarding the gpio, it seems they are also using a chardev
and the sysfs interface is deprecated.Quoted 9 lines
Perhaps the answer is that these frameworks don't use sysfs but char device.
That would means that the sysfs solution is not the more adapted solution and
perhaps we should migrate to a char device.
But in this case, i think that it should implement the whole API and be
exclusive with
the syfs legacy API (so no sysfs or sysfs in read-only).Quoted 3 lines
I agree with that, if another interface must be defined, then it should implement everything that is supported right now with the sysfs.
Quoted 14 lines
The other fields that sysfs exposes right now are
firmware_name, name(rproc name),
state. The targeted usecase was that these are configuration parameters specific
to the remoteproc and should stay in the sysfs interface. Whereas char device
should provide direct access to remoteproc device.
It would make sense to use this interface in conjunction with sysfs interface, where you use/dev/remoteproc0to boot/shutdown the remote processor
sysfs entries to fine tune the parameters.
Adding ioctls to implement all sysfs functionality seems like overkill to me. Let
me know what you guys think.
Hi Rishabh,
The sysfs interface is not going away - it is part of the API and that can't be changed anymore. I suggest the new character device interface strictly implement what is currently needed and leave what is not for future implementation.
Quoted 274 lines
Quoted 274 lines
Clément
Quoted 271 lines
Regards,
ArnaudQuoted 267 lines
Regards,
Clément
Quoted 262 lines
Anyway, it's just my feeling, let other people give their feedback.
Quoted 11 lines
Quoted 4 lines
I just want to be sure that there is no alternative to this, because
having two ways
for application to shutdown the firmware seems to me confusing...Does making this interface optional/configurable helps?
Quoted 6 lines
What about the opposite service, mean inform the application that the remote
processor is crashed?
Do you identify such need? or the "auto" crash recovery is sufficient?Quoted 5 lines
Auto recovery works perfectly for us. Although there is a mechanism in
place using QMI(Qualcomm MSM interface) that can notify clients about remote
processor crash.Thanks for the information.
Regards
ArnaudQuoted 238 lines
Quoted 238 lines
Thanks,
ArnaudQuoted 235 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>--- drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+) create mode 100644 drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +4
-0@@ -14,6 +14,15 @@ config REMOTEPROC if REMOTEPROC +config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface forRemoteproc
+ framework. Userspace can boot/shutdown remote processors
throughdrivers/remoteproc/Kconfig +3
-0+ this interface. + + It's safe to say N if you don't want to use thisinterface.
drivers/remoteproc/Kconfig +1
-0+ config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on ARCH_MXCdrivers/remoteproc/Makefile +0
-0@@ -9,6 +9,7 @@ remoteproc-y +=remoteproc_debugfs.o
remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.odrivers/remoteproc/Makefile +1
-0+obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +5
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ */drivers/remoteproc/remoteproc_cdev.c new file +14
-0+ +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open(struct inode *inode, struct file*file)
drivers/remoteproc/remoteproc_cdev.c new file +15
-0+{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc) +return -EINVAL ; + +if (rproc->state ==RPROC_RUNNING ) +return -EBUSY ; + +return rproc_boot (rproc); +} + +static int rproc_cdev_release(struct inode *inode, struct file*file)
drivers/remoteproc/remoteproc_cdev.c new file +24
-0+{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc || rproc->state !=RPROC_RUNNING ) +return -EINVAL ; + +rproc_shutdown (rproc); + +return 0 ; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ +int ret, minor; +dev_t cdevt; + + minor = ida_simple_get(&cdev_minor_ida, 0,
NUM_RPROC_DEVICES,drivers/remoteproc/remoteproc_cdev.c new file +3
-0+ GFP_KERNEL); +if (minor <0 ) { + dev_err(&rproc->dev, "%s: No more minor numbers left!rc:%d\n",
drivers/remoteproc/remoteproc_cdev.c new file +19
-0+ __func__, minor); +return -ENODEV ; + } + +cdev_init (&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner =THIS_MODULE ; + + cdevt =MKDEV (MAJOR (rproc_cdev), minor); + ret =cdev_add (&rproc->char_dev, cdevt,1 ); +if (ret <0 ) +ida_simple_remove (&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; +return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ + __unregister_chrdev(MAJOR(rproc->dev.devt),
MINOR(rproc->dev.devt), 1,drivers/remoteproc/remoteproc_cdev.c new file +9
-0+ "rproc"); +ida_simple_remove (&cdev_minor_ida,MINOR (rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ +int ret; + + ret = alloc_chrdev_region(&rproc_cdev, 0, NUM_RPROC_DEVICES,"rproc");
drivers/remoteproc/remoteproc_cdev.c new file +2
-0+if (ret <0 ) { + pr_err("Failed to alloc rproc_cdev region, err %d\n",ret);
drivers/remoteproc/remoteproc_cdev.c new file +7
-0+return ; + } +} + +void __exit rproc_exit_cdev(void) +{ + __unregister_chrdev(MAJOR(rproc_cdev), 0, NUM_RPROC_DEVICES,"rproc");
drivers/remoteproc/remoteproc_cdev.c new file +1
-0+}drivers/remoteproc/remoteproc_internal.h +21
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(constchar *name, struct rproc *rproc, int rproc_init_sysfs(void);void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void
rproc_free_vring(struct rproc_vring *rvring); intrproc_alloc_vring(struct rproc_vdev *rvdev, int i);drivers/remoteproc/remoteproc_internal.h +1
-0@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc, struct rproc_mem_entry * rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...); +static inline
int rproc_fw_sanity_check(struct rproc *rproc, const struct
firmware *fw)
{include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h> @@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/**
Mathieu Poirier
maintainerQuoted 21 lines · Arnaud POULIQUEN
Hi
Quoted 5 lines · Rishabh Bhatnagar
Add the character device interface for userspace applications. This interface can be used in order to boot up and shutdown remote subsystems. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor does not get any
Quoted 8 lines
indication about the crash. It might still assume that the application is running. For example modem uses remotefs service to fetch data from disk/flash memory. If the remotefs service crashes, modem keeps on requesting data which might lead to a crash. Adding a character device interface makes the remote processor tightly coupled with the user space application. A crash of the application leads to a close on the file descriptors therefore shutting down the remoteproc.
Sorry I'm late in the discussion, I hope I've gone through the whole discussion so I don't reopen a closed point...
Quoted 8 lines
Something here is not crystal clear to me so I'd rather share it...
I suppose that you the automatic restart of the application is not possible to stop and restart the remote processor...
Why this use case can not be solved by a process monitor or a service in userland that detects the application crash and stop the remote firmware using the sysfs interface?
I also looked for a better way to do things... The conclusion I came to is that it may take too long between the application crash and the monitoring service to stop the firmware via sysfs.
Quoted 6 lines
I just want to be sure that there is no alternative to this, because having two ways for application to shutdown the firmware seems to me confusing...
What about the opposite service, mean inform the application that the remote processor is crashed?
Also a valid point - the problem with asynchronous notification schemes is the possibility to get out of sync. I would also like to find a better way...
Quoted 214 lines
Do you identify such need? or the "auto" crash recovery is sufficient?
Thanks,
ArnaudQuoted 210 lines
Signed-off-by Rishabh Bhatnagar <[email protected]>--- drivers/remoteproc/Kconfig | 9 +++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/remoteproc_cdev.c | 100 +++++++++++++++++++++++++++++++ drivers/remoteproc/remoteproc_internal.h | 22 +++++++ include/linux/remoteproc.h | 2 + 5 files changed, 134 insertions(+) create mode 100644 drivers/remoteproc/remoteproc_cdev.cdrivers/remoteproc/Kconfig +9
-0@@ -14,6 +14,15 @@ config REMOTEPROC if REMOTEPROC +config REMOTEPROC_CDEV + bool "Remoteproc character device interface" + help + Say y here to have a character device interface for Remoteproc + framework. Userspace can boot/shutdown remote processors through + this interface. + + It's safe to say N if you don't want to use this interface. + config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on ARCH_MXCdrivers/remoteproc/Makefile +1
-0@@ -9,6 +9,7 @@ remoteproc-y += remoteproc_debugfs.o remoteproc-y += remoteproc_sysfs.o remoteproc-y += remoteproc_virtio.o remoteproc-y += remoteproc_elf_loader.o +obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o obj-$(CONFIG_OMAP_REMOTEPROC) += omap_remoteproc.odrivers/remoteproc/remoteproc_cdev.c new file +100
-0@@ -0,0 +1,100 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Character device interface driver for Remoteproc framework. +* +* Copyright (c) 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/cdev.h> +#include <linux/fs.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/remoteproc.h> + +#include "remoteproc_internal.h" + +#define NUM_RPROC_DEVICES 64 +static dev_t rproc_cdev; +static DEFINE_IDA (cdev_minor_ida); + +static int rproc_cdev_open (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc) +return -EINVAL ; + +if (rproc->state ==RPROC_RUNNING ) +return -EBUSY ; + +return rproc_boot (rproc); +} + +static int rproc_cdev_release (struct inode *inode,struct file *file) +{ +struct rproc *rproc; + + rproc = container_of(inode->i_cdev, struct rproc, char_dev); + +if (!rproc || rproc->state !=RPROC_RUNNING ) +return -EINVAL ; + +rproc_shutdown (rproc); + +return 0 ; +} + +static const struct file_operations rproc_fops = { + .open = rproc_cdev_open, + .release = rproc_cdev_release, +}; + +int rproc_char_device_add (struct rproc *rproc) +{ +int ret, minor; +dev_t cdevt; + + minor =ida_simple_get (&cdev_minor_ida,0 ,NUM_RPROC_DEVICES , +GFP_KERNEL ); +if (minor <0 ) { +dev_err (&rproc->dev,"%s: No more minor numbers left! rc:%d\n" , + __func__, minor); +return -ENODEV ; + } + +cdev_init (&rproc->char_dev, &rproc_fops); + rproc->char_dev.owner =THIS_MODULE ; + + cdevt =MKDEV (MAJOR (rproc_cdev), minor); + ret =cdev_add (&rproc->char_dev, cdevt,1 ); +if (ret <0 ) +ida_simple_remove (&cdev_minor_ida, minor); + + rproc->dev.devt = cdevt; +return ret; +} + +void rproc_char_device_remove (struct rproc *rproc) +{ +__unregister_chrdev (MAJOR (rproc->dev.devt),MINOR (rproc->dev.devt),1 , +"rproc" ); +ida_simple_remove (&cdev_minor_ida,MINOR (rproc->dev.devt)); +} + +void __init rproc_init_cdev (void ) +{ +int ret; + + ret =alloc_chrdev_region (&rproc_cdev,0 ,NUM_RPROC_DEVICES ,"rproc" ); +if (ret <0 ) { +pr_err ("Failed to alloc rproc_cdev region, err %d\n" , ret); +return ; + } +} + +void __exit rproc_exit_cdev(void) +{ +__unregister_chrdev (MAJOR (rproc_cdev),0 ,NUM_RPROC_DEVICES ,"rproc" ); +}drivers/remoteproc/remoteproc_internal.h +22
-0@@ -47,6 +47,27 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,int rproc_init_sysfs (void );void rproc_exit_sysfs (void ); +#ifdef CONFIG_REMOTEPROC_CDEV +void rproc_init_cdev (void ); +void rproc_exit_cdev (void ); +int rproc_char_device_add (struct rproc *rproc); +void rproc_char_device_remove (struct rproc *rproc); +#else +static inline void rproc_init_cdev (void ) +{ +} +static inline void rproc_exit_cdev (void ) +{ +} +static inline int rproc_char_device_add (struct rproc *rproc) +{ +return 0 ; +} +static inline void rproc_char_device_remove (struct rproc *rproc) +{ +} +#endif +void rproc_free_vring (struct rproc_vring *rvring);int rproc_alloc_vring (struct rproc_vdev *rvdev,int i);@@ -63,6 +84,7 @@ struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc,struct rproc_mem_entry *rproc_find_carveout_by_name (struct rproc *rproc,const char *name, ...); +static inline int rproc_fw_sanity_check (struct rproc *rproc,const struct firmware *fw) {include/linux/remoteproc.h +2
-0@@ -37,6 +37,7 @@#include <linux/types.h> #include <linux/mutex.h> +#include <linux/cdev.h> #include <linux/virtio.h> #include <linux/completion.h> #include <linux/idr.h> @@ -514,6 +515,7 @@ struct rproc {bool auto_boot;struct list_head dump_segments;int nb_vdev; +struct cdev char_dev; };/**