Staging: rtl8192e: remove set but not used variable 'tmpRegC'
PATCH 1/1 Staging: rtl8192e: remove set but not used variable 'tmpRegC'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c: In function rtl92e_start_adapter:drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:693:15: warning: variable ‘tmpRegC’ set but not used [-Wunused-but-set-variable]
commit 94a799425eee ("rtl8192e: Split into two directories") involved this, remove it.
--- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +3 -3
@@ -690,7 +690,7 @@ bool rtl92e_start_adapter(struct net_device *dev)u8 tmpvalue;u8 ICVersion, SwitchingRegulatorOutput;bool bfirmwareok = true; -u32 tmpRegA, tmpRegC, TempCCk; +u32 tmpRegA, TempCCk;int i =0 ;u32 retry_times =0 ;
@@ -889,8 +889,8 @@ bool rtl92e_start_adapter(struct net_device *dev)if (priv->IC_Cut >= IC_VersionCut_D) { tmpRegA =rtl92e_get_bb_reg (dev, rOFDM0_XATxIQImbalance, bMaskDWord); - tmpRegC =rtl92e_get_bb_reg (dev, rOFDM0_XCTxIQImbalance, - bMaskDWord); +rtl92e_get_bb_reg (dev, rOFDM0_XCTxIQImbalance, + bMaskDWord);for (i =0 ; i < TxBBGainTableLength; i++) {if (tmpRegA == dm_tx_bb_gain[i]) { priv->rfa_txpowertrackingindex = (u8 )i;
Signature · 1 line
1.8.3.1
Greg KH
maintainerQuoted 28 lines · Wang Hai
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c: In functionrtl92e_start_adapter:drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:693:15: warning: variable ‘tmpRegC’ set but not used [-Wunused-but-set-variable]commit
94a799425eee("rtl8192e: Split into two directories") involved this, remove it.Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>--- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1
-1@@ -690,7 +690,7 @@ bool rtl92e_start_adapter(struct net_device *dev)u8 tmpvalue;u8 ICVersion, SwitchingRegulatorOutput;bool bfirmwareok = true; -u32 tmpRegA, tmpRegC, TempCCk; +u32 tmpRegA, TempCCk;int i =0 ;u32 retry_times =0 ;
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c bool rtl92e_start_adapter(struct net_device *dev) · line 893
Quoted 7 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +2
-2@@ -889,8 +889,8 @@ bool rtl92e_start_adapter(struct net_device *dev)if (priv->IC_Cut >= IC_VersionCut_D) { tmpRegA =rtl92e_get_bb_reg (dev, rOFDM0_XATxIQImbalance, bMaskDWord); - tmpRegC =rtl92e_get_bb_reg (dev, rOFDM0_XCTxIQImbalance, - bMaskDWord); +rtl92e_get_bb_reg (dev, rOFDM0_XCTxIQImbalance, + bMaskDWord);
That is odd, are you sure you aren't supposed to do something with that value you read?
thanks,
greg k-h
Quoted 28 lines · Wang Hai
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c: In functionrtl92e_start_adapter:drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:693:15: warning: variable ‘tmpRegC’ set but not used [-Wunused-but-set-variable]commit
94a799425eee("rtl8192e: Split into two directories") involved this, remove it.Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>--- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1
-1@@ -690,7 +690,7 @@ bool rtl92e_start_adapter(struct net_device *dev)u8 tmpvalue;u8 ICVersion, SwitchingRegulatorOutput;bool bfirmwareok = true; -u32 tmpRegA, tmpRegC, TempCCk; +u32 tmpRegA, TempCCk;int i =0 ;u32 retry_times =0 ;
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c bool rtl92e_start_adapter(struct net_device *dev) · line 893
Quoted 7 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +2
-2@@ -889,8 +889,8 @@ bool rtl92e_start_adapter(struct net_device *dev)if (priv->IC_Cut >= IC_VersionCut_D) { tmpRegA =rtl92e_get_bb_reg (dev, rOFDM0_XATxIQImbalance, bMaskDWord); - tmpRegC =rtl92e_get_bb_reg (dev, rOFDM0_XCTxIQImbalance, - bMaskDWord); +rtl92e_get_bb_reg (dev, rOFDM0_XCTxIQImbalance, + bMaskDWord);
Delete the call as well.
regards,
dan carpenter