Build failed in Jenkins: v4l-utils #43
See <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes>
Changes:
[hverkuil-cisco] keytable: add new generated keymaps
[hverkuil-cisco] msg2ctl.pl: add newline after log_msg
[hverkuil-cisco] cec-follower: drop the hardcoded UI commands list
[hverkuil-cisco] cec-ctl/cec-log: use new CEC_OP_UI_CMD defines
------------------------------------------
[...truncated 1.10 MB...]
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:800:16: error: ‘arg_u8’ was not declared in this scope
#define arg_on arg_u8
^~~~~~
./cec-log.h:2584:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~
./cec-log.h:800:16: note: suggested alternative: ‘arg_on’
#define arg_on arg_u8
^~~~~~
./cec-log.h:2584:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2584:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_on, "on", on);
^~~~~~~
./cec-log.h:2584:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_on, "on", on);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:800:16: error: ‘arg_u8’ was not declared in this scope
#define arg_on arg_u8
^~~~~~
./cec-log.h:2594:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~
./cec-log.h:800:16: note: suggested alternative: ‘arg_on’
#define arg_on arg_u8
^~~~~~
./cec-log.h:2594:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2594:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_on, "on", on);
^~~~~~~
./cec-log.h:2594:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_on, "on", on);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:818:21: error: ‘arg_u8’ was not declared in this scope
#define arg_minutes arg_u8
^~~~~~
./cec-log.h:2603:12: note: in expansion of macro ‘arg_minutes’
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~~~~~
./cec-log.h:818:21: note: suggested alternative: ‘arg_on’
#define arg_minutes arg_u8
^~~~~~
./cec-log.h:2603:12: note: in expansion of macro ‘arg_minutes’
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2603:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~
./cec-log.h:2603:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:811:18: error: ‘arg_string’ was not declared in this scope
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2611:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~
./cec-log.h:811:18: note: suggested alternative: ‘arg_time’
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2611:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2611:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_time, "time", time);
^~~~~~~
./cec-log.h:2611:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_time, "time", time);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:811:18: error: ‘arg_string’ was not declared in this scope
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2619:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~
./cec-log.h:811:18: note: suggested alternative: ‘arg_time’
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2619:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2619:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_time, "time", time);
^~~~~~~
./cec-log.h:2619:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_time, "time", time);
^~~~~~~
log_msg
./cec-log.h:2630:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_input_src, "htng-input-src", htng_input_src); ^~~~~~~
./cec-log.h:2630:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_input_src, "htng-input-src", htng_input_src); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:579:19: error: ‘arg_u16’ was not declared in this scope
#define arg_major arg_u16
^~~~~~~
./cec-log.h:2632:12: note: in expansion of macro ‘arg_major’
log_arg(&arg_major, "major", major);
^~~~~~~~~
./cec-log.h:579:19: note: suggested alternative: ‘arg_osd’
#define arg_major arg_u16
^~~~~~~
./cec-log.h:2632:12: note: in expansion of macro ‘arg_major’
log_arg(&arg_major, "major", major);
^~~~~~~~~
./cec-log.h:801:17: error: ‘arg_u8’ was not declared in this scope
#define arg_vol arg_u8
^~~~~~
./cec-log.h:2642:12: note: in expansion of macro ‘arg_vol’
log_arg(&arg_vol, "vol", vol);
^~~~~~~
./cec-log.h:801:17: note: suggested alternative: ‘arg_on’
#define arg_vol arg_u8
^~~~~~
./cec-log.h:2642:12: note: in expansion of macro ‘arg_vol’
log_arg(&arg_vol, "vol", vol);
^~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2642:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_vol, "vol", vol);
^~~~~~~
./cec-log.h:2642:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_vol, "vol", vol);
^~~~~~~
log_msg
./cec-log.h:2662:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
./cec-log.h:2662:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:831:18: error: ‘arg_u16’ was not declared in this scope
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2665:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~
./cec-log.h:831:18: note: suggested alternative: ‘arg_osd’
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2665:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2679:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
./cec-log.h:2679:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:792:18: error: ‘arg_u16’ was not declared in this scope
#define arg_chan arg_u16
^~~~~~~
./cec-log.h:2681:12: note: in expansion of macro ‘arg_chan’
log_arg(&arg_chan, "chan", chan);
^~~~~~~~
./cec-log.h:792:18: note: suggested alternative: ‘arg_osd’
#define arg_chan arg_u16
^~~~~~~
./cec-log.h:2681:12: note: in expansion of macro ‘arg_chan’
log_arg(&arg_chan, "chan", chan);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2702:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_ext_chan_type, "htng-ext-chan-type", htng_ext_chan_type); ^~~~~~~
./cec-log.h:2702:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_ext_chan_type, "htng-ext-chan-type", htng_ext_chan_type); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:831:18: error: ‘arg_u16’ was not declared in this scope
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2705:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~
./cec-log.h:831:18: note: suggested alternative: ‘arg_osd’
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2705:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2719:3: error: ‘log_htng_unknown_msg’ was not declared in this scope
log_htng_unknown_msg(msg);
^~~~~~~~~~~~~~~~~~~~
./cec-log.h:2719:3: note: suggested alternative: ‘log_htng_msg’
log_htng_unknown_msg(msg);
^~~~~~~~~~~~~~~~~~~~
log_htng_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h: At global scope:
./cec-log.h:861:29: warning: ‘messages’ defined but not used [-Wunused-variable]
static const struct message messages[] = {
^~~~~~~~make[3]: *** [Makefile:607: cec_follower-cec-follower.o] Error 1
make[3]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/utils/cec-follower'> make[2]: *** [Makefile:481: all-recursive] Error 1
make[2]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/utils'> make[1]: *** [Makefile:590: all-recursive] Error 1
make[1]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/'>
make: *** [Makefile:517: all] Error 2
Build step 'Execute shell' marked build as failure
Hi Mauro,
Quoted 11 lines · Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes>
Changes:
[hverkuil-cisco] keytable: add new generated keymaps
[hverkuil-cisco] msg2ctl.pl: add newline after
log_msg[hverkuil-cisco] cec-follower: drop the hardcoded UI commands list
[hverkuil-cisco] cec-ctl/cec-log: use new
CEC_OP_UI_CMDdefines
You need to remove utils/cec-follower/cec-log.h.
This file was generated but the generated file is now called cec-log-gen.h. A new cec-log.h was also added to utils/common as a companion to cec-log.cpp.
Unfortunately, the old cec-log.h clashes with the new cec-log.h. And since the old cec-log.h was generated and so is not part of the git repo it is not removed as part of a 'git pull'.
Anyway, just remove utils/cec-follower/cec-log.h and it compiles again.
Regards,
Hans
Quoted 254 lines
------------------------------------------
[...truncated 1.10 MB...]
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:800:16: error: ‘arg_u8’ was not declared in this scope#define arg_on arg_u8 ^~~~~~ ./cec-log.h:2584:12: note: in expansion of macro ‘arg_on’ log_arg(&arg_on, "on", on); ^~~~~~ ./cec-log.h:800:16: note: suggested alternative: ‘arg_on’ #define arg_on arg_u8 ^~~~~~ ./cec-log.h:2584:12: note: in expansion of macro ‘arg_on’ log_arg(&arg_on, "on", on); ^~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2584:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_on, "on", on); ^~~~~~~ ./cec-log.h:2584:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_on, "on", on); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:800:16: error: ‘arg_u8’ was not declared in this scope #define arg_on arg_u8 ^~~~~~ ./cec-log.h:2594:12: note: in expansion of macro ‘arg_on’ log_arg(&arg_on, "on", on); ^~~~~~ ./cec-log.h:800:16: note: suggested alternative: ‘arg_on’ #define arg_on arg_u8 ^~~~~~ ./cec-log.h:2594:12: note: in expansion of macro ‘arg_on’ log_arg(&arg_on, "on", on); ^~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2594:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_on, "on", on); ^~~~~~~ ./cec-log.h:2594:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_on, "on", on); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:818:21: error: ‘arg_u8’ was not declared in this scope #define arg_minutes arg_u8 ^~~~~~ ./cec-log.h:2603:12: note: in expansion of macro ‘arg_minutes’ log_arg(&arg_minutes, "minutes", minutes); ^~~~~~~~~~~ ./cec-log.h:818:21: note: suggested alternative: ‘arg_on’ #define arg_minutes arg_u8 ^~~~~~ ./cec-log.h:2603:12: note: in expansion of macro ‘arg_minutes’ log_arg(&arg_minutes, "minutes", minutes); ^~~~~~~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2603:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_minutes, "minutes", minutes); ^~~~~~~ ./cec-log.h:2603:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_minutes, "minutes", minutes); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:811:18: error: ‘arg_string’ was not declared in this scope #define arg_time arg_string ^~~~~~~~~~ ./cec-log.h:2611:12: note: in expansion of macro ‘arg_time’ log_arg(&arg_time, "time", time); ^~~~~~~~ ./cec-log.h:811:18: note: suggested alternative: ‘arg_time’ #define arg_time arg_string ^~~~~~~~~~ ./cec-log.h:2611:12: note: in expansion of macro ‘arg_time’ log_arg(&arg_time, "time", time); ^~~~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2611:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_time, "time", time); ^~~~~~~ ./cec-log.h:2611:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_time, "time", time); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:811:18: error: ‘arg_string’ was not declared in this scope #define arg_time arg_string ^~~~~~~~~~ ./cec-log.h:2619:12: note: in expansion of macro ‘arg_time’ log_arg(&arg_time, "time", time); ^~~~~~~~ ./cec-log.h:811:18: note: suggested alternative: ‘arg_time’ #define arg_time arg_string ^~~~~~~~~~ ./cec-log.h:2619:12: note: in expansion of macro ‘arg_time’ log_arg(&arg_time, "time", time); ^~~~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2619:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_time, "time", time); ^~~~~~~ ./cec-log.h:2619:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_time, "time", time); ^~~~~~~ log_msg ./cec-log.h:2630:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_htng_input_src, "htng-input-src", htng_input_src); ^~~~~~~ ./cec-log.h:2630:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_htng_input_src, "htng-input-src", htng_input_src); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:579:19: error: ‘arg_u16’ was not declared in this scope #define arg_major arg_u16 ^~~~~~~ ./cec-log.h:2632:12: note: in expansion of macro ‘arg_major’ log_arg(&arg_major, "major", major); ^~~~~~~~~ ./cec-log.h:579:19: note: suggested alternative: ‘arg_osd’ #define arg_major arg_u16 ^~~~~~~ ./cec-log.h:2632:12: note: in expansion of macro ‘arg_major’ log_arg(&arg_major, "major", major); ^~~~~~~~~ ./cec-log.h:801:17: error: ‘arg_u8’ was not declared in this scope #define arg_vol arg_u8 ^~~~~~ ./cec-log.h:2642:12: note: in expansion of macro ‘arg_vol’ log_arg(&arg_vol, "vol", vol); ^~~~~~~ ./cec-log.h:801:17: note: suggested alternative: ‘arg_on’ #define arg_vol arg_u8 ^~~~~~ ./cec-log.h:2642:12: note: in expansion of macro ‘arg_vol’ log_arg(&arg_vol, "vol", vol); ^~~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2642:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_vol, "vol", vol); ^~~~~~~ ./cec-log.h:2642:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_vol, "vol", vol); ^~~~~~~ log_msg ./cec-log.h:2662:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~ ./cec-log.h:2662:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:831:18: error: ‘arg_u16’ was not declared in this scope #define arg_freq arg_u16 ^~~~~~~ ./cec-log.h:2665:12: note: in expansion of macro ‘arg_freq’ log_arg(&arg_freq, "freq", freq); ^~~~~~~~ ./cec-log.h:831:18: note: suggested alternative: ‘arg_osd’ #define arg_freq arg_u16 ^~~~~~~ ./cec-log.h:2665:12: note: in expansion of macro ‘arg_freq’ log_arg(&arg_freq, "freq", freq); ^~~~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2679:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~ ./cec-log.h:2679:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:792:18: error: ‘arg_u16’ was not declared in this scope #define arg_chan arg_u16 ^~~~~~~ ./cec-log.h:2681:12: note: in expansion of macro ‘arg_chan’ log_arg(&arg_chan, "chan", chan); ^~~~~~~~ ./cec-log.h:792:18: note: suggested alternative: ‘arg_osd’ #define arg_chan arg_u16 ^~~~~~~ ./cec-log.h:2681:12: note: in expansion of macro ‘arg_chan’ log_arg(&arg_chan, "chan", chan); ^~~~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2702:3: error: ‘log_arg’ was not declared in this scope log_arg(&arg_htng_ext_chan_type, "htng-ext-chan-type", htng_ext_chan_type); ^~~~~~~ ./cec-log.h:2702:3: note: suggested alternative: ‘log_msg’ log_arg(&arg_htng_ext_chan_type, "htng-ext-chan-type", htng_ext_chan_type); ^~~~~~~ log_msg In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:831:18: error: ‘arg_u16’ was not declared in this scope #define arg_freq arg_u16 ^~~~~~~ ./cec-log.h:2705:12: note: in expansion of macro ‘arg_freq’ log_arg(&arg_freq, "freq", freq); ^~~~~~~~ ./cec-log.h:831:18: note: suggested alternative: ‘arg_osd’ #define arg_freq arg_u16 ^~~~~~~ ./cec-log.h:2705:12: note: in expansion of macro ‘arg_freq’ log_arg(&arg_freq, "freq", freq); ^~~~~~~~ In file included from cec-follower.h:25, from cec-follower.cpp:21: ./cec-log.h:2719:3: error: ‘log_htng_unknown_msg’ was not declared in this scope log_htng_unknown_msg(msg); ^~~~~~~~~~~~~~~~~~~~ ./cec-log.h:2719:3: note: suggested alternative: ‘log_htng_msg’ log_htng_unknown_msg(msg); ^~~~~~~~~~~~~~~~~~~~ log_htng_msgIn file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h: At global scope:
./cec-log.h:861:29: warning: ‘messages’ defined but not used [-Wunused-variable]static const struct message messages[] = { ^~~~~~~~make[3]: *** [Makefile:607: cec_follower-cec-follower.o] Error 1
make[3]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/utils/cec-follower'> make[2]: *** [Makefile:481: all-recursive] Error 1
make[2]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/utils'> make[1]: *** [Makefile:590: all-recursive] Error 1
make[1]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/'>
make: *** [Makefile:517: all] Error 2
Build step 'Execute shell' marked build as failure
Mauro Carvalho Chehab
maintainerEm Wed, 2 Oct 2019 10:25:02 +0200
Hans Verkuil <[email protected]> escreveu:
Quoted 17 lines
Hi Mauro,
Quoted 11 lines · Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes>
Changes:
[hverkuil-cisco] keytable: add new generated keymaps
[hverkuil-cisco] msg2ctl.pl: add newline after
log_msg[hverkuil-cisco] cec-follower: drop the hardcoded UI commands list
[hverkuil-cisco] cec-ctl/cec-log: use new
CEC_OP_UI_CMDdefinesYou need to remove
utils/cec-follower/cec-log.h.
Quoted 8 lines
This file was generated but the generated file is now called
cec-log-gen.h. A newcec-log.hwas also added to utils/common as a companion to cec-log.cpp.Unfortunately, the old
cec-log.hclashes with the newcec-log.h. And since the oldcec-log.hwas generated and so is not part of the git repo it is not removed as part of a 'git pull'.Anyway, just remove
utils/cec-follower/cec-log.hand it compiles again.
I manually removed the file at the builder and at the slave machines and asked for a new build. The build now succeeded.
That's said, we should really avoid disruptive changes like that, fixing the building system for it to do the right thing, as users of the v4l-utils will also face the same issue if they update their git trees.
At any time, a clean git update with something similar to:
git remote update
git fetch origin
git reset --hard origin/master
./bootstrap.sh
./configure
make
should work.
Regards,
Mauro
Quoted 45 lines · Mauro Carvalho Chehab
Em Wed, 2 Oct 2019 10:25:02 +0200
Hans Verkuil <[email protected]> escreveu:Quoted 17 lines
Hi Mauro,
Quoted 11 lines · Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes>
Changes:
[hverkuil-cisco] keytable: add new generated keymaps
[hverkuil-cisco] msg2ctl.pl: add newline after
log_msg[hverkuil-cisco] cec-follower: drop the hardcoded UI commands list
[hverkuil-cisco] cec-ctl/cec-log: use new
CEC_OP_UI_CMDdefinesYou need to remove
utils/cec-follower/cec-log.h.Quoted 8 lines
This file was generated but the generated file is now called
cec-log-gen.h. A newcec-log.hwas also added to utils/common as a companion to cec-log.cpp.Unfortunately, the old
cec-log.hclashes with the newcec-log.h. And since the oldcec-log.hwas generated and so is not part of the git repo it is not removed as part of a 'git pull'.Anyway, just remove
utils/cec-follower/cec-log.hand it compiles again.I manually removed the file at the builder and at the slave machines and asked for a new build. The build now succeeded.
That's said, we should really avoid disruptive changes like that, fixing the building system for it to do the right thing, as users of the v4l-utils will also face the same issue if they update their git trees.
At any time, a clean git update with something similar to:
git remote update
git fetch origin
git reset --hard origin/master
./bootstrap.sh
./configure
make
Quoted 5 lines
should work.
Regards,
Mauro
Yes, I discovered it too late. That said, I'm not sure what to do about it since the old generated file is not under the control of git.
A 'make distclean' before the 'git fetch' would remove it, but after the update it is just an orphaned file.
I've actually added a 'make distclean' in my daily build scripts.
Regards,
Hans
Mauro Carvalho Chehab
maintainerEm Wed, 2 Oct 2019 11:49:20 +0200
Hans Verkuil <[email protected]> escreveu:
Quoted 52 lines · Mauro Carvalho Chehab
Quoted 45 lines
Em Wed, 2 Oct 2019 10:25:02 +0200
Hans Verkuil <[email protected]> escreveu:Quoted 17 lines
Hi Mauro,
Quoted 11 lines · Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes>
Changes:
[hverkuil-cisco] keytable: add new generated keymaps
[hverkuil-cisco] msg2ctl.pl: add newline after
log_msg[hverkuil-cisco] cec-follower: drop the hardcoded UI commands list
[hverkuil-cisco] cec-ctl/cec-log: use new
CEC_OP_UI_CMDdefinesYou need to remove
utils/cec-follower/cec-log.h.Quoted 8 lines
This file was generated but the generated file is now called
cec-log-gen.h. A newcec-log.hwas also added to utils/common as a companion to cec-log.cpp.Unfortunately, the old
cec-log.hclashes with the newcec-log.h. And since the oldcec-log.hwas generated and so is not part of the git repo it is not removed as part of a 'git pull'.Anyway, just remove
utils/cec-follower/cec-log.hand it compiles again.I manually removed the file at the builder and at the slave machines and asked for a new build. The build now succeeded.
That's said, we should really avoid disruptive changes like that, fixing the building system for it to do the right thing, as users of the v4l-utils will also face the same issue if they update their git trees.
At any time, a clean git update with something similar to:
git remote update
git fetch origin
git reset --hard origin/master
./bootstrap.sh
./configure
makeQuoted 5 lines
should work.
Regards,
Mauro
Quoted 7 lines
Yes, I discovered it too late. That said, I'm not sure what to do about it since the old generated file is not under the control of git.
A 'make distclean' before the 'git fetch' would remove it, but after the update it is just an orphaned file.
I've actually added a 'make distclean' in my daily build scripts.
That's a very bad idea. The builds should check and pinpoint to regressions at the building system too.
If I understand the problem, you're saying that now cec-log.h depends on the generated cec-log-gen.h, right?
If so, this could be easily fixable by adding an explicit dependency rule to the Makefile.am, like:
cec-log.h: cec-log-gen.h
Thanks,
Mauro
Quoted 66 lines · Mauro Carvalho Chehab
Em Wed, 2 Oct 2019 11:49:20 +0200
Hans Verkuil <[email protected]> escreveu:Quoted 52 lines · Mauro Carvalho Chehab
Quoted 45 lines
Em Wed, 2 Oct 2019 10:25:02 +0200
Hans Verkuil <[email protected]> escreveu:Quoted 17 lines
Hi Mauro,
Quoted 11 lines · Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes>
Changes:
[hverkuil-cisco] keytable: add new generated keymaps
[hverkuil-cisco] msg2ctl.pl: add newline after
log_msg[hverkuil-cisco] cec-follower: drop the hardcoded UI commands list
[hverkuil-cisco] cec-ctl/cec-log: use new
CEC_OP_UI_CMDdefinesYou need to remove
utils/cec-follower/cec-log.h.Quoted 8 lines
This file was generated but the generated file is now called
cec-log-gen.h. A newcec-log.hwas also added to utils/common as a companion to cec-log.cpp.Unfortunately, the old
cec-log.hclashes with the newcec-log.h. And since the oldcec-log.hwas generated and so is not part of the git repo it is not removed as part of a 'git pull'.Anyway, just remove
utils/cec-follower/cec-log.hand it compiles again.I manually removed the file at the builder and at the slave machines and asked for a new build. The build now succeeded.
That's said, we should really avoid disruptive changes like that, fixing the building system for it to do the right thing, as users of the v4l-utils will also face the same issue if they update their git trees.
At any time, a clean git update with something similar to:
git remote update
git fetch origin
git reset --hard origin/master
./bootstrap.sh
./configure
makeQuoted 5 lines
should work.
Regards,
MauroQuoted 7 lines
Yes, I discovered it too late. That said, I'm not sure what to do about it since the old generated file is not under the control of git.
A 'make distclean' before the 'git fetch' would remove it, but after the update it is just an orphaned file.
I've actually added a 'make distclean' in my daily build scripts.
That's a very bad idea. The builds should check and pinpoint to regressions at the building system too.
Quoted 7 lines
If I understand the problem, you're saying that now
cec-log.hdepends on the generatedcec-log-gen.h, right?If so, this could be easily fixable by adding an explicit dependency rule to the Makefile.am, like:
cec-log.h:cec-log-gen.h
No, cec-log.h has nothing to do with cec-log-gen.h.
utils/cec-follower/cec-log.h was a generated file, and badly named.
So this was renamed to cec-log-gen.h.
In addition, a new header utils/common/cec-log.h was added containing prototypes for utils/common/cec-log.cpp.
So after a git pull you end up with two cec-log.h headers:
utils/common/cec-log.h and the orphaned utils/cec-follower/cec-log.h.
Unfortunately, the orphaned cec-log.h is included instead of the one in utils/common.
I'm looking at reorganizing the way this works so perhaps this issue will go away soon.
Regards,
Hans
Build failed in Jenkins: v4l-utils #44
In reply to Jenkins Builder RobotSee <https://builder.linuxtv.org/job/v4l-utils/44/display/redirect?page=changes>
Changes:
[hverkuil-cisco] cec utils: support CEC_ADAP_G_CONNECTOR_INFO
------------------------------------------
[...truncated 1.09 MB...]
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:800:16: error: ‘arg_u8’ was not declared in this scope
#define arg_on arg_u8
^~~~~~
./cec-log.h:2584:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~
./cec-log.h:800:16: note: suggested alternative: ‘arg_on’
#define arg_on arg_u8
^~~~~~
./cec-log.h:2584:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2584:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_on, "on", on);
^~~~~~~
./cec-log.h:2584:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_on, "on", on);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:800:16: error: ‘arg_u8’ was not declared in this scope
#define arg_on arg_u8
^~~~~~
./cec-log.h:2594:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~
./cec-log.h:800:16: note: suggested alternative: ‘arg_on’
#define arg_on arg_u8
^~~~~~
./cec-log.h:2594:12: note: in expansion of macro ‘arg_on’
log_arg(&arg_on, "on", on);
^~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2594:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_on, "on", on);
^~~~~~~
./cec-log.h:2594:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_on, "on", on);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:818:21: error: ‘arg_u8’ was not declared in this scope
#define arg_minutes arg_u8
^~~~~~
./cec-log.h:2603:12: note: in expansion of macro ‘arg_minutes’
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~~~~~
./cec-log.h:818:21: note: suggested alternative: ‘arg_on’
#define arg_minutes arg_u8
^~~~~~
./cec-log.h:2603:12: note: in expansion of macro ‘arg_minutes’
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2603:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~
./cec-log.h:2603:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_minutes, "minutes", minutes);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:811:18: error: ‘arg_string’ was not declared in this scope
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2611:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~
./cec-log.h:811:18: note: suggested alternative: ‘arg_time’
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2611:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2611:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_time, "time", time);
^~~~~~~
./cec-log.h:2611:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_time, "time", time);
^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:811:18: error: ‘arg_string’ was not declared in this scope
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2619:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~
./cec-log.h:811:18: note: suggested alternative: ‘arg_time’
#define arg_time arg_string
^~~~~~~~~~
./cec-log.h:2619:12: note: in expansion of macro ‘arg_time’
log_arg(&arg_time, "time", time);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2619:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_time, "time", time);
^~~~~~~
./cec-log.h:2619:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_time, "time", time);
^~~~~~~
log_msg
./cec-log.h:2630:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_input_src, "htng-input-src", htng_input_src); ^~~~~~~
./cec-log.h:2630:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_input_src, "htng-input-src", htng_input_src); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:579:19: error: ‘arg_u16’ was not declared in this scope
#define arg_major arg_u16
^~~~~~~
./cec-log.h:2632:12: note: in expansion of macro ‘arg_major’
log_arg(&arg_major, "major", major);
^~~~~~~~~
./cec-log.h:579:19: note: suggested alternative: ‘arg_osd’
#define arg_major arg_u16
^~~~~~~
./cec-log.h:2632:12: note: in expansion of macro ‘arg_major’
log_arg(&arg_major, "major", major);
^~~~~~~~~
./cec-log.h:801:17: error: ‘arg_u8’ was not declared in this scope
#define arg_vol arg_u8
^~~~~~
./cec-log.h:2642:12: note: in expansion of macro ‘arg_vol’
log_arg(&arg_vol, "vol", vol);
^~~~~~~
./cec-log.h:801:17: note: suggested alternative: ‘arg_on’
#define arg_vol arg_u8
^~~~~~
./cec-log.h:2642:12: note: in expansion of macro ‘arg_vol’
log_arg(&arg_vol, "vol", vol);
^~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2642:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_vol, "vol", vol);
^~~~~~~
./cec-log.h:2642:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_vol, "vol", vol);
^~~~~~~
log_msg
./cec-log.h:2662:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
./cec-log.h:2662:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:831:18: error: ‘arg_u16’ was not declared in this scope
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2665:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~
./cec-log.h:831:18: note: suggested alternative: ‘arg_osd’
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2665:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2679:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
./cec-log.h:2679:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_chan_type, "htng-chan-type", htng_chan_type); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:792:18: error: ‘arg_u16’ was not declared in this scope
#define arg_chan arg_u16
^~~~~~~
./cec-log.h:2681:12: note: in expansion of macro ‘arg_chan’
log_arg(&arg_chan, "chan", chan);
^~~~~~~~
./cec-log.h:792:18: note: suggested alternative: ‘arg_osd’
#define arg_chan arg_u16
^~~~~~~
./cec-log.h:2681:12: note: in expansion of macro ‘arg_chan’
log_arg(&arg_chan, "chan", chan);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2702:3: error: ‘log_arg’ was not declared in this scope
log_arg(&arg_htng_ext_chan_type, "htng-ext-chan-type", htng_ext_chan_type); ^~~~~~~
./cec-log.h:2702:3: note: suggested alternative: ‘log_msg’
log_arg(&arg_htng_ext_chan_type, "htng-ext-chan-type", htng_ext_chan_type); ^~~~~~~
log_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:831:18: error: ‘arg_u16’ was not declared in this scope
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2705:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~
./cec-log.h:831:18: note: suggested alternative: ‘arg_osd’
#define arg_freq arg_u16
^~~~~~~
./cec-log.h:2705:12: note: in expansion of macro ‘arg_freq’
log_arg(&arg_freq, "freq", freq);
^~~~~~~~In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h:2719:3: error: ‘log_htng_unknown_msg’ was not declared in this scope
log_htng_unknown_msg(msg);
^~~~~~~~~~~~~~~~~~~~
./cec-log.h:2719:3: note: suggested alternative: ‘log_htng_msg’
log_htng_unknown_msg(msg);
^~~~~~~~~~~~~~~~~~~~
log_htng_msg
In file included from cec-follower.h:25,
from cec-follower.cpp:21:
./cec-log.h: At global scope:
./cec-log.h:861:29: warning: ‘messages’ defined but not used [-Wunused-variable]
static const struct message messages[] = {
^~~~~~~~make[3]: *** [Makefile:607: cec_follower-cec-follower.o] Error 1
make[3]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/utils/cec-follower'> make[2]: *** [Makefile:481: all-recursive] Error 1
make[2]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/utils'> make[1]: *** [Makefile:590: all-recursive] Error 1
make[1]: Leaving directory '<https://builder.linuxtv.org/job/v4l-utils/ws/'>
make: *** [Makefile:517: all] Error 2
Build step 'Execute shell' marked build as failure
Jenkins build is back to normal : v4l-utils #45