f2fs: Fix the accounting of dcc->undiscard_blks
PATCH 1/1 f2fs: Fix the accounting of dcc->undiscard_blks
When a discard_cmd needs to be split due to dpolicy->max_requests, then for the remaining length it will be either merged into another cmd or a new discard_cmd will be created. In this case, there is double accounting of dcc->undiscard_blks for the remaining len, due to which it shows incorrect value in stats.
Signed-off-by Sahitya Tummala <[email protected]>
--- fs/f2fs/segment.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/f2fs/segment.c +3 -1
@@ -1214,8 +1214,10 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi, len = total_len; } -if (!err && len) +if (!err && len) { + dcc->undiscard_blks -= len;__update_discard_tree_range (sbi, bdev, lstart, start, len); + }return err; }
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 7 lines · Sahitya Tummala
When a
discard_cmdneeds to be split due todpolicy->max_requests, then for the remaining length it will be either merged into another cmd or a newdiscard_cmdwill be created. In this case, there is double accounting ofdcc->undiscard_blksfor the remaining len, due to which it shows incorrect value in stats.Signed-off-by Sahitya Tummala <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,