patch "Revert "serial: uartps: Fix uartps_major handling"" added to tty-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
Revert "serial: uartps: Fix uartps_major handling"
to my tty git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
in the tty-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 2e01911b7cf7aa07a304a809eca1b11a4bd35859 Mon Sep 17 00:00:00 2001
From: Michal Simek <[email protected]>
Date: Fri, 3 Apr 2020 11:24:30 +0200
Subject: Revert "serial: uartps: Fix uartps_major handling"
This reverts commit 5e9bd2d70ae7c00a95a22994abf1eef728649e64.
As Johan says, this driver needs a lot more work and these changes are only going in the wrong direction:
https://lkml.kernel.org/r/20190523091839.GC568@localhost
--- drivers/tty/serial/xilinx_uartps.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/tty/serial/xilinx_uartps.c +1 -7
@@ -1564,6 +1564,7 @@ static int cdns_uart_probe(struct platform_device *pdev) goto err_out_id; } + uartps_major = cdns_uart_uart_driver->tty_driver->major; cdns_uart_data->cdns_uart_driver = cdns_uart_uart_driver;/*
@@ -1694,7 +1695,6 @@ static int cdns_uart_probe(struct platform_device *pdev) console_port =NULL ;#endif - uartps_major = cdns_uart_uart_driver->tty_driver->major; cdns_uart_data->cts_override =of_property_read_bool (pdev->dev.of_node,"cts-override" );return 0 ;
@@ -1756,12 +1756,6 @@ static int cdns_uart_remove(struct platform_device *pdev) console_port =NULL ;#endif -/* If this is last instance major number should be initialized */ -mutex_lock (&bitmap_lock); -if (bitmap_empty (bitmap,MAX_UART_INSTANCES )) - uartps_major =0 ; -mutex_unlock (&bitmap_lock); -uart_unregister_driver (cdns_uart_data->cdns_uart_driver);return rc; }
Signature · 1 line
2.26.1