patch "Revert "serial: uartps: Do not allow use aliases >=" added to tty-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
Revert "serial: uartps: Do not allow use aliases >=
to my tty git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
in the tty-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 91c9dfa25c7f95b543c280e0edf1fd8de6e90985 Mon Sep 17 00:00:00 2001
From: Michal Simek <[email protected]>
Date: Fri, 3 Apr 2020 11:24:33 +0200
Subject: Revert "serial: uartps: Do not allow use aliases >=
MAX_UART_INSTANCES"
This reverts commit 2088cfd882d0403609bdf426e9b24372fe1b8337.
As Johan says, this driver needs a lot more work and these changes are only going in the wrong direction:
https://lkml.kernel.org/r/20190523091839.GC568@localhost
--- drivers/tty/serial/xilinx_uartps.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/tty/serial/xilinx_uartps.c +2 -4
@@ -1712,8 +1712,7 @@ static int cdns_uart_probe(struct platform_device *pdev)uart_unregister_driver (cdns_uart_data->cdns_uart_driver); err_out_id:mutex_lock (&bitmap_lock); -if (cdns_uart_data->id <MAX_UART_INSTANCES ) -clear_bit (cdns_uart_data->id, bitmap); +clear_bit (cdns_uart_data->id, bitmap);mutex_unlock (&bitmap_lock);return rc; }
@@ -1738,8 +1737,7 @@ static int cdns_uart_remove(struct platform_device *pdev) rc =uart_remove_one_port (cdns_uart_data->cdns_uart_driver, port); port->mapbase =0 ;mutex_lock (&bitmap_lock); -if (cdns_uart_data->id <MAX_UART_INSTANCES ) -clear_bit (cdns_uart_data->id, bitmap); +clear_bit (cdns_uart_data->id, bitmap);mutex_unlock (&bitmap_lock);clk_disable_unprepare (cdns_uart_data->uartclk);clk_disable_unprepare (cdns_uart_data->pclk);
Signature · 1 line
2.26.1