net: bcmgenet: correct per TX/RX ring statistics
Subsystems (3)
Doug Berger
maintainerPATCH 1/1 net: bcmgenet: correct per TX/RX ring statistics
The change to track net_device_stats per ring to better support SMP missed updating the rx_dropped member.
The ndo_get_stats method is also needed to combine the results for ethtool statistics (-S) before filling in the ethtool structure.
--- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/broadcom/genet/bcmgenet.c +3 -0
@@ -934,6 +934,8 @@ static void bcmgenet_get_ethtool_stats(struct net_device *dev,if (netif_running (dev))bcmgenet_update_mib_counters (priv); + dev->netdev_ops->ndo_get_stats (dev); +for (i =0 ; i <BCMGENET_STATS_LEN ; i++) {const struct bcmgenet_stats *s;char *p;
@@ -3156,6 +3158,7 @@ static struct net_device_stats *bcmgenet_get_stats(struct net_device *dev) dev->stats.rx_packets = rx_packets; dev->stats.rx_errors = rx_errors; dev->stats.rx_missed_errors = rx_errors; + dev->stats.rx_dropped = rx_dropped;return &dev->stats; }
Signature · 1 line
2.7.4
Quoted 8 lines · Doug Berger
The change to track
net_device_statsper ring to better support SMP missed updating therx_droppedmember.The
ndo_get_statsmethod is also needed to combine the results for ethtool statistics (-S) before filling in the ethtool structure.Fixes 37a30b435b92 ("net: bcmgenet: Track per TX/RX rings statistics")Signed-off-by Doug Berger <[email protected]>
Thanks for catching that!
Signature · 1 line
Florian
David Miller
maintainerFrom: Doug Berger <[email protected]>
Date: Thu, 23 Apr 2020 15:44:17 -0700
Quoted 8 lines
The change to track
net_device_statsper ring to better support SMP missed updating therx_droppedmember.The
ndo_get_statsmethod is also needed to combine the results for ethtool statistics (-S) before filling in the ethtool structure.Fixes 37a30b435b92 ("net: bcmgenet: Track per TX/RX rings statistics")Signed-off-by Doug Berger <[email protected]>
Applied and queued up for -stable, thanks.