drm: report dp downstream port type as a subconnector property
Subsystems (7)
PATCH 1/5 drm: report dp downstream port type as a subconnector property
From: Oleg Vasilev <[email protected]>
Currently, downstream port type is only reported in debugfs. This information should be considered important since it reflects the actual physical connector type. Some userspace (e.g. window compositors) may want to show this info to a user.
The 'subconnector' property is already utilized for DVI-I and TV-out for reporting connector subtype.
The initial motivation for this feature came from i2c test [1]. It is supposed to be skipped on VGA connectors, but it cannot detect VGA over DP and fails instead.
v2:
- Ville: utilized drm_dp_is_branch()
- Ville: implement DP 1.0 downstream type info
- Replaced create_dp_properties with add_dp_subconnector_property
- Added dp_set_subconnector_property helper
v4:
- Ville: add DP1.0 best assumption about subconnector
- Ville: assume DVI is DVI-D
- Ville: reuse Writeback enum value for Virtual subconnector
- Renamed #defines: HDMI -> HDMIA, DP -> DisplayPort
v5: rebase
v6:
- Jani Nikula: renamed a function name
- Jani Nikula: addressed the issues with documentation
[1]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
--- drivers/gpu/drm/drm_connector.c | 49 ++++++++++++++++++++++++++-- drivers/gpu/drm/drm_dp_helper.c | 71 +++++++++++++++++++++++++++++++++++++++++ include/drm/drm_connector.h | 3 ++ include/drm/drm_dp_helper.h | 8 +++++ include/drm/drm_mode_config.h | 6 ++++ include/uapi/drm/drm_mode.h | 21 +++++++----- 6 files changed, 148 insertions(+), 10 deletions(-)
drivers/gpu/drm/drm_connector.c +47 -2
@@ -844,7 +844,7 @@ static const struct drm_prop_enum_list drm_dvi_i_select_enum_list[] = { DRM_ENUM_NAME_FN(drm_get_dvi_i_select_name, drm_dvi_i_select_enum_list)static const struct drm_prop_enum_list drm_dvi_i_subconnector_enum_list[] = { - { DRM_MODE_SUBCONNECTOR_Unknown,"Unknown" },/* DVI-I and TV-out */ + { DRM_MODE_SUBCONNECTOR_Unknown,"Unknown" },/* DVI-I, TV-out and DP */ {DRM_MODE_SUBCONNECTOR_DVID ,"DVI-D" },/* DVI-I */ {DRM_MODE_SUBCONNECTOR_DVIA ,"DVI-A" },/* DVI-I */ };
@@ -861,7 +861,7 @@ static const struct drm_prop_enum_list drm_tv_select_enum_list[] = { DRM_ENUM_NAME_FN(drm_get_tv_select_name, drm_tv_select_enum_list)static const struct drm_prop_enum_list drm_tv_subconnector_enum_list[] = { - { DRM_MODE_SUBCONNECTOR_Unknown,"Unknown" },/* DVI-I and TV-out */ + { DRM_MODE_SUBCONNECTOR_Unknown,"Unknown" },/* DVI-I, TV-out and DP */ { DRM_MODE_SUBCONNECTOR_Composite,"Composite" },/* TV-out */ {DRM_MODE_SUBCONNECTOR_SVIDEO ,"SVIDEO" },/* TV-out */ { DRM_MODE_SUBCONNECTOR_Component,"Component" },/* TV-out */
@@ -870,6 +870,19 @@ static const struct drm_prop_enum_list drm_tv_subconnector_enum_list[] = {DRM_ENUM_NAME_FN (drm_get_tv_subconnector_name, drm_tv_subconnector_enum_list) +static const struct drm_prop_enum_list drm_dp_subconnector_enum_list[] = { + { DRM_MODE_SUBCONNECTOR_Unknown,"Unknown" },/* DVI-I, TV-out and DP */ + {DRM_MODE_SUBCONNECTOR_VGA ,"VGA" },/* DP */ + {DRM_MODE_SUBCONNECTOR_DVID ,"DVI-D" },/* DP */ + {DRM_MODE_SUBCONNECTOR_HDMIA ,"HDMI" },/* DP */ + { DRM_MODE_SUBCONNECTOR_DisplayPort,"DP" },/* DP */ + { DRM_MODE_SUBCONNECTOR_Wireless,"Wireless" },/* DP */ + { DRM_MODE_SUBCONNECTOR_Native,"Native" },/* DP */ +}; + +DRM_ENUM_NAME_FN (drm_get_dp_subconnector_name, + drm_dp_subconnector_enum_list) +static const struct drm_prop_enum_list hdmi_colorspaces[] = {/* For Default case, driver will set the colorspace */ {DRM_MODE_COLORIMETRY_DEFAULT ,"Default" },
@@ -1186,6 +1199,14 @@ static const struct drm_prop_enum_list dp_colorspaces[] = {* can also expose this property to external outputs, in which case they * must support "None", which should be the default (since external screens * have a built-in scaler). +* +* subconnector: +* This property is used by DVI-I, TVout and DisplayPort to indicate different +* connector subtypes. Enum values more or less match with those from main +* connector types. +* For DVI-I and TVout there is also a matching property "select subconnector" +* allowing to switch between signal types. +* DP subconnector corresponds to a downstream port. */ int drm_connector_create_standard_properties (struct drm_device *dev)
@@ -1275,6 +1296,30 @@ int drm_mode_create_dvi_i_properties(struct drm_device *dev)EXPORT_SYMBOL (drm_mode_create_dvi_i_properties);/** +* drm_connector_attach_dp_subconnector_property - create subconnector property for DP +* @connector: drm_connector to attach property +* +* Called by a driver when DP connector is created. +*/ +void drm_connector_attach_dp_subconnector_property (struct drm_connector *connector) +{ +struct drm_mode_config *mode_config = &connector->dev->mode_config; + +if (!mode_config->dp_subconnector_property) + mode_config->dp_subconnector_property = +drm_property_create_enum (connector->dev, +DRM_MODE_PROP_IMMUTABLE , +"subconnector" , + drm_dp_subconnector_enum_list, +ARRAY_SIZE (drm_dp_subconnector_enum_list)); + +drm_object_attach_property (&connector->base, + mode_config->dp_subconnector_property, + DRM_MODE_SUBCONNECTOR_Unknown); +} +EXPORT_SYMBOL (drm_connector_attach_dp_subconnector_property); + +/** * DOC: HDMI connector properties * * content type (HDMI specific):
drivers/gpu/drm/drm_dp_helper.c +71 -0
77 lines not on this page · raw message
include/drm/drm_connector.h +3 -0
@@ -1556,10 +1556,13 @@ const char *drm_get_dvi_i_subconnector_name(int val);const char *drm_get_dvi_i_select_name (int val);const char *drm_get_tv_subconnector_name (int val);const char *drm_get_tv_select_name (int val); +const char *drm_get_dp_subconnector_name (int val);const char *drm_get_content_protection_name (int val);const char *drm_get_hdcp_content_type_name (int val);int drm_mode_create_dvi_i_properties (struct drm_device *dev); +void drm_connector_attach_dp_subconnector_property (struct drm_connector *connector); +int drm_mode_create_tv_margin_properties (struct drm_device *dev); int drm_mode_create_tv_properties(struct drm_device *dev, unsigned int num_modes,
include/drm/drm_dp_helper.h +8 -0
@@ -26,6 +26,7 @@#include <linux/delay.h> #include <linux/i2c.h> #include <linux/types.h> +#include <drm/drm_connector.h> /* * Unless otherwise noted, all values are from the DP 1.1a spec. Note that
@@ -1608,6 +1609,13 @@ int drm_dp_downstream_max_bpc(const u8 dpcd[DP_RECEIVER_CAP_SIZE],int drm_dp_downstream_id (struct drm_dp_aux *aux,char id[6 ]);void drm_dp_downstream_debug (struct seq_file *m,const u8 dpcd[DP_RECEIVER_CAP_SIZE ],const u8 port_cap[4 ],struct drm_dp_aux *aux); +enum drm_mode_subconnector +drm_dp_subconnector_type (const u8 dpcd[DP_RECEIVER_CAP_SIZE ], +const u8 port_cap[4 ]); +void drm_dp_set_subconnector_property (struct drm_connector *connector, +enum drm_connector_status status, +const u8 *dpcd, +const u8 port_cap[4 ]);void drm_dp_remote_aux_init (struct drm_dp_aux *aux);void drm_dp_aux_init (struct drm_dp_aux *aux);
include/drm/drm_mode_config.h +6 -0
@@ -681,6 +681,12 @@ struct drm_mode_config {struct drm_property *dvi_i_select_subconnector_property;/** +* @dp_subconnector_property: Optional DP property to differentiate +* between different DP downstream port types. +*/ +struct drm_property *dp_subconnector_property; + +/** * @tv_subconnector_property: Optional TV property to differentiate * between different TV connector types. */
include/uapi/drm/drm_mode.h +13 -8
@@ -332,14 +332,19 @@ struct drm_mode_get_encoder {/* This is for connectors with multiple signal types. */ /* Try to match DRM_MODE_CONNECTOR_X as closely as possible. */ enum drm_mode_subconnector { - DRM_MODE_SUBCONNECTOR_Automatic =0 , - DRM_MODE_SUBCONNECTOR_Unknown =0 , -DRM_MODE_SUBCONNECTOR_DVID =3 , -DRM_MODE_SUBCONNECTOR_DVIA =4 , - DRM_MODE_SUBCONNECTOR_Composite =5 , -DRM_MODE_SUBCONNECTOR_SVIDEO =6 , - DRM_MODE_SUBCONNECTOR_Component =8 , -DRM_MODE_SUBCONNECTOR_SCART =9 , + DRM_MODE_SUBCONNECTOR_Automatic =0 ,/* DVI-I, TV */ + DRM_MODE_SUBCONNECTOR_Unknown =0 ,/* DVI-I, TV, DP */ +DRM_MODE_SUBCONNECTOR_VGA =1 ,/* DP */ +DRM_MODE_SUBCONNECTOR_DVID =3 ,/* DVI-I DP */ +DRM_MODE_SUBCONNECTOR_DVIA =4 ,/* DVI-I */ + DRM_MODE_SUBCONNECTOR_Composite =5 ,/* TV */ +DRM_MODE_SUBCONNECTOR_SVIDEO =6 ,/* TV */ + DRM_MODE_SUBCONNECTOR_Component =8 ,/* TV */ +DRM_MODE_SUBCONNECTOR_SCART =9 ,/* TV */ + DRM_MODE_SUBCONNECTOR_DisplayPort =10 ,/* DP */ +DRM_MODE_SUBCONNECTOR_HDMIA =11 ,/* DP */ + DRM_MODE_SUBCONNECTOR_Native =15 ,/* DP */ + DRM_MODE_SUBCONNECTOR_Wireless =18 ,/* DP */ };#define DRM_MODE_CONNECTOR_Unknown 0
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/5 drm/i915: utilize subconnector property for DP
From: Oleg Vasilev <[email protected]>
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself.
v2: updates to match previous commit changes
v3: rebase
v4: renamed a function call
--- drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/display/intel_dp.c +8 -0
@@ -6448,6 +6448,11 @@ intel_dp_detect(struct drm_connector *connector,*/ intel_display_power_flush_work (dev_priv); +if (!intel_dp_is_edp (intel_dp)) +drm_dp_set_subconnector_property (connector, + status, + intel_dp->dpcd, + intel_dp->downstream_ports);return status; }
@@ -7542,6 +7547,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connectstruct drm_i915_private *dev_priv =to_i915 (connector->dev);enum port port =dp_to_dig_port (intel_dp)->base.port; +if (!intel_dp_is_edp (intel_dp)) +drm_connector_attach_dp_subconnector_property (connector); +if (!IS_G4X (dev_priv) && port !=PORT_A )intel_attach_force_audio_property (connector);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/5 drm/nouveau: utilize subconnector property for DP
In reply to Jeevan BFrom: Oleg Vasilev <[email protected]>
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself.
v2: rebase
--- drivers/gpu/drm/nouveau/nouveau_connector.c | 13 +++++++++++++ drivers/gpu/drm/nouveau/nouveau_dp.c | 9 +++++++++ drivers/gpu/drm/nouveau/nouveau_encoder.h | 1 + 3 files changed, 23 insertions(+)
drivers/gpu/drm/nouveau/nouveau_connector.c +13 -0
@@ -648,6 +648,17 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)pm_runtime_mark_last_busy (dev->dev);pm_runtime_put_autosuspend (dev->dev); +if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort || + connector->connector_type == DRM_MODE_CONNECTOR_eDP) { +enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown; + +if (conn_status == connector_status_connected && nv_encoder) + subconnector = nv_encoder->dp.subconnector; +drm_object_property_set_value (&connector->base, + connector->dev->mode_config.dp_subconnector_property, + subconnector); + } +return conn_status; }
@@ -1373,6 +1384,8 @@ nouveau_connector_create(struct drm_device *dev,kfree (nv_connector);return ERR_PTR (ret); } + +drm_mode_add_dp_subconnector_property (connector); funcs = &nouveau_connector_funcs;break ;default :
drivers/gpu/drm/nouveau/nouveau_dp.c +9 -0
@@ -62,6 +62,7 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)struct nouveau_drm *drm =nouveau_drm (dev);struct nvkm_i2c_aux *aux;u8 dpcd[8 ]; +u8 port_cap[DP_MAX_DOWNSTREAM_PORTS ] = {};int ret; aux = nv_encoder->aux;
@@ -72,6 +73,14 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)if (ret)return ret; +if (dpcd[DP_DPCD_REV ] >0x10 ) { + ret =nvkm_rdaux (aux,DP_DOWNSTREAM_PORT_0 , + port_cap,DP_MAX_DOWNSTREAM_PORTS ); +if (ret) +memset (port_cap,0 ,DP_MAX_DOWNSTREAM_PORTS ); + } + nv_encoder->dp.subconnector =drm_dp_subconnector_type (dpcd, port_cap); + nv_encoder->dp.link_bw =27000 * dpcd[1 ]; nv_encoder->dp.link_nr = dpcd[2 ] &DP_MAX_LANE_COUNT_MASK ;
drivers/gpu/drm/nouveau/nouveau_encoder.h +1 -0
@@ -63,6 +63,7 @@ struct nouveau_encoder {struct nv50_mstm *mstm;int link_nr;int link_bw; +enum drm_mode_subconnector subconnector; } dp; };
Signature · 1 line
2.7.4
PATCH v3 1/1 drm/nouveau: utilize subconnector property for DP
From: Oleg Vasilev <[email protected]>
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself.
v2: rebase
v3: renamed a function call
--- drivers/gpu/drm/nouveau/nouveau_connector.c | 13 +++++++++++++ drivers/gpu/drm/nouveau/nouveau_dp.c | 9 +++++++++ drivers/gpu/drm/nouveau/nouveau_encoder.h | 1 + 3 files changed, 23 insertions(+)
drivers/gpu/drm/nouveau/nouveau_connector.c +13 -0
@@ -654,6 +654,17 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)pm_runtime_mark_last_busy (dev->dev);pm_runtime_put_autosuspend (dev->dev); +if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort || + connector->connector_type == DRM_MODE_CONNECTOR_eDP) { +enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown; + +if (conn_status == connector_status_connected && nv_encoder) + subconnector = nv_encoder->dp.subconnector; +drm_object_property_set_value (&connector->base, + connector->dev->mode_config.dp_subconnector_property, + subconnector); + } +return conn_status; }
@@ -1390,6 +1401,8 @@ nouveau_connector_create(struct drm_device *dev,kfree (nv_connector);return ERR_PTR (ret); } + +drm_connector_attach_dp_subconnector_property (connector); funcs = &nouveau_connector_funcs;break ;default :
drivers/gpu/drm/nouveau/nouveau_dp.c +9 -0
@@ -62,6 +62,7 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)struct nouveau_drm *drm =nouveau_drm (dev);struct nvkm_i2c_aux *aux;u8 dpcd[8 ]; +u8 port_cap[DP_MAX_DOWNSTREAM_PORTS ] = {};int ret; aux = nv_encoder->aux;
@@ -72,6 +73,14 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)if (ret)return ret; +if (dpcd[DP_DPCD_REV ] >0x10 ) { + ret =nvkm_rdaux (aux,DP_DOWNSTREAM_PORT_0 , + port_cap,DP_MAX_DOWNSTREAM_PORTS ); +if (ret) +memset (port_cap,0 ,DP_MAX_DOWNSTREAM_PORTS ); + } + nv_encoder->dp.subconnector =drm_dp_subconnector_type (dpcd, port_cap); + nv_encoder->dp.link_bw =27000 * dpcd[1 ]; nv_encoder->dp.link_nr = dpcd[2 ] &DP_MAX_LANE_COUNT_MASK ;
drivers/gpu/drm/nouveau/nouveau_encoder.h +1 -0
@@ -64,6 +64,7 @@ struct nouveau_encoder {struct nv50_mstm *mstm;int link_nr;int link_bw; +enum drm_mode_subconnector subconnector; } dp; };
Signature · 1 line
2.7.4
RE: [v3] drm/nouveau: utilize subconnector property for DP
Hi Ben Skeggs,
Gentle Reminder, Can you please take a look at the patch and provide your ack.
Thanks
Jeevan B
Quoted 116 lines
-----Original Message-----
From: B, Jeevan <[email protected]>
Sent: Sunday, August 16, 2020 12:22 PM
To: [email protected]; [email protected]; dri- [email protected]
Cc: [email protected]; [email protected]; maarten.lankhorst-VuQAYsv1563Yd54FQh9/[email protected]; Nikula, Jani <[email protected]>; Shankar, Uma <[email protected]>; Oleg Vasilev <[email protected]>; B, Jeevan <[email protected]>
Subject: [v3] drm/nouveau: utilize subconnector property for DPFrom: Oleg Vasilev <[email protected]>
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself.
v2: rebase
v3: renamed a function call
Cc Ben Skeggs <[email protected]>Signed-off-by Jeevan B <[email protected]>Signed-off-by Oleg Vasilev <[email protected]>---
drivers/gpu/drm/nouveau/nouveau_connector.c | 13 +++++++++++++ drivers/gpu/drm/nouveau/nouveau_dp.c | 9 +++++++++ drivers/gpu/drm/nouveau/nouveau_encoder.h | 1 + 3 files changed, 23 insertions(+)drivers/gpu/drm/nouveau/nouveau_connector.c +1
-0@@ -654,6 +654,17 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)pm_runtime_mark_last_busy (dev->dev);pm_runtime_put_autosuspend (dev->dev); + if (connector->connector_type ==
DRM_MODE_CONNECTOR_DisplayPort||drivers/gpu/drm/nouveau/nouveau_connector.c +5
-0+ connector->connector_type == DRM_MODE_CONNECTOR_eDP) { +enum drm_mode_subconnector subconnector = +DRM_MODE_SUBCONNECTOR_Unknown; + + if (conn_status == connector_status_connected &&
nv_encoder)drivers/gpu/drm/nouveau/nouveau_connector.c +3
-0+ subconnector = nv_encoder->dp.subconnector; + drm_object_property_set_value(&connector->base, + connector->dev-Quoted 1 line
mode_config.dp_subconnector_property,
drivers/gpu/drm/nouveau/nouveau_connector.c +3
-0+ subconnector); + } +return conn_status; }drivers/gpu/drm/nouveau/nouveau_connector.c +2
-0@@ -1390,6 +1401,8 @@ nouveau_connector_create(struct drm_device *dev,kfree (nv_connector);return ERR_PTR (ret); } + +drm_connector_attach_dp_subconnector_property (connector); funcs = &nouveau_connector_funcs;break ;default:
drivers/gpu/drm/nouveau/nouveau_dp.c +1
-0@@ -62,6 +62,7 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)struct nouveau_drm *drm =nouveau_drm (dev);struct nvkm_i2c_aux *aux;u8 dpcd[8 ]; +u8 port_cap[DP_MAX_DOWNSTREAM_PORTS ] = {};int ret;aux = nv_encoder->aux;drivers/gpu/drm/nouveau/nouveau_dp.c +9
-0@@ -72,6 +73,14 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)if (ret)return ret; +if (dpcd[DP_DPCD_REV ] >0x10 ) { + ret =nvkm_rdaux (aux,DP_DOWNSTREAM_PORT_0 , + port_cap,DP_MAX_DOWNSTREAM_PORTS ); +if (ret) +memset (port_cap,0 ,DP_MAX_DOWNSTREAM_PORTS ); + } + nv_encoder->dp.subconnector =drm_dp_subconnector_type (dpcd, +port_cap); +nv_encoder->dp.link_bw = 27000 * dpcd[1]; nv_encoder->dp.link_nr = dpcd[2] & DP_MAX_LANE_COUNT_MASK;drivers/gpu/drm/nouveau/nouveau_encoder.h +1
-1@@ -64,6 +64,7 @@ struct nouveau_encoder {struct nv50_mstm *mstm;int link_nr;int link_bw; +enum drm_mode_subconnector subconnector; } dp; }; --2.7.4
PATCH 4/5 drm/amdgpu: utilize subconnector property for DP through atombios
In reply to Jeevan BFrom: Oleg Vasilev <[email protected]>
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself.
v2: rebase
v3: renamed a function call
--- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 10 ++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 + drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 18 +++++++++++++++++- 3 files changed, 28 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c +10 -0
@@ -26,6 +26,7 @@#include <drm/drm_edid.h> #include <drm/drm_fb_helper.h> +#include <drm/drm_dp_helper.h> #include <drm/drm_probe_helper.h> #include <drm/amdgpu_drm.h> #include "amdgpu.h"
@@ -1405,6 +1406,10 @@ amdgpu_connector_dp_detect(struct drm_connector *connector, bool force)pm_runtime_put_autosuspend (connector->dev->dev); } +drm_dp_set_subconnector_property (&amdgpu_connector->base, + ret, + amdgpu_dig_connector->dpcd, + amdgpu_dig_connector->downstream_ports);return ret; }
@@ -1951,6 +1956,11 @@ amdgpu_connector_add(struct amdgpu_device *adev,if (has_aux)amdgpu_atombios_dp_aux_init (amdgpu_connector); +if (connector_type == DRM_MODE_CONNECTOR_DisplayPort || + connector_type == DRM_MODE_CONNECTOR_eDP) { +drm_connector_attach_dp_subconnector_property (&amdgpu_connector->base); + } +return ; failed:
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h +1 -0
@@ -469,6 +469,7 @@ struct amdgpu_encoder {struct amdgpu_connector_atom_dig {/* displayport */ u8 dpcd[DP_RECEIVER_CAP_SIZE ]; +u8 downstream_ports[DP_MAX_DOWNSTREAM_PORTS ];u8 dp_sink_type;int dp_clock;int dp_lane_count;
drivers/gpu/drm/amd/amdgpu/atombios_dp.c +17 -1
@@ -328,6 +328,22 @@ static void amdgpu_atombios_dp_probe_oui(struct amdgpu_connector *amdgpu_connect buf[0], buf[1], buf[2]); } +static void amdgpu_atombios_dp_ds_ports (struct amdgpu_connector *amdgpu_connector) +{ +struct amdgpu_connector_atom_dig *dig_connector = amdgpu_connector->con_priv; +int ret; + +if (dig_connector->dpcd[DP_DPCD_REV ] >0x10 ) { + ret =drm_dp_dpcd_read (&amdgpu_connector->ddc_bus->aux, +DP_DOWNSTREAM_PORT_0 , + dig_connector->downstream_ports, +DP_MAX_DOWNSTREAM_PORTS ); +if (ret) +memset (dig_connector->downstream_ports,0 , +DP_MAX_DOWNSTREAM_PORTS ); + } +} +int amdgpu_atombios_dp_get_dpcd (struct amdgpu_connector *amdgpu_connector) {struct amdgpu_connector_atom_dig *dig_connector = amdgpu_connector->con_priv;
@@ -343,7 +359,7 @@ int amdgpu_atombios_dp_get_dpcd(struct amdgpu_connector *amdgpu_connector) dig_connector->dpcd);amdgpu_atombios_dp_probe_oui (amdgpu_connector); - +amdgpu_atombios_dp_ds_ports (amdgpu_connector);return 0 ; }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 5/5 drm/amdgpu: utilize subconnector property for DP through DisplayManager
In reply to Jeevan BFrom: Oleg Vasilev <[email protected]>
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself. Display Core already has the subconnector information, we only need to expose it through DRM property.
v2:rebase
v3: renamed a function call
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 41 +++++++++++++++++++++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 ++ 2 files changed, 43 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +40 -1
@@ -121,6 +121,42 @@ MODULE_FIRMWARE(FIRMWARE_NAVI12_DMCU);static int amdgpu_dm_init (struct amdgpu_device *adev);static void amdgpu_dm_fini (struct amdgpu_device *adev); +static enum drm_mode_subconnector get_subconnector_type (struct dc_link *link) +{ +switch (link->dpcd_caps.dongle_type) { +case DISPLAY_DONGLE_NONE : +return DRM_MODE_SUBCONNECTOR_Native; +case DISPLAY_DONGLE_DP_VGA_CONVERTER : +return DRM_MODE_SUBCONNECTOR_VGA ; +case DISPLAY_DONGLE_DP_DVI_CONVERTER : +case DISPLAY_DONGLE_DP_DVI_DONGLE : +return DRM_MODE_SUBCONNECTOR_DVID ; +case DISPLAY_DONGLE_DP_HDMI_CONVERTER : +case DISPLAY_DONGLE_DP_HDMI_DONGLE : +return DRM_MODE_SUBCONNECTOR_HDMIA ; +case DISPLAY_DONGLE_DP_HDMI_MISMATCHED_DONGLE : +default : +return DRM_MODE_SUBCONNECTOR_Unknown; + } +} + +static void update_subconnector_property (struct amdgpu_dm_connector *aconnector) +{ +struct dc_link *link = aconnector->dc_link; +struct drm_connector *connector = &aconnector->base; +enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown; + +if (connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort) +return ; + +if (aconnector->dc_sink) + subconnector =get_subconnector_type (link); + +drm_object_property_set_value (&connector->base, + connector->dev->mode_config.dp_subconnector_property, + subconnector); +} +/* * initializes drm_device display related structures, based on the information * provided by DAL. The drm strcutures are: drm_crtc, drm_connector,
@@ -1917,7 +1953,6 @@ void amdgpu_dm_update_connector_after_detect(if (aconnector->mst_mgr.mst_state == true)return ; - sink = aconnector->dc_link->local_sink;if (sink)dc_sink_retain (sink);
@@ -2038,6 +2073,8 @@ void amdgpu_dm_update_connector_after_detect(mutex_unlock (&dev->mode_config.mutex); +update_subconnector_property (aconnector); +if (sink)dc_sink_release (sink); }
@@ -4521,6 +4558,8 @@ amdgpu_dm_connector_detect(struct drm_connector *connector, bool force)else connected = (aconnector->base.force ==DRM_FORCE_ON ); +update_subconnector_property (aconnector); +return (connected ? connector_status_connected : connector_status_disconnected); }
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +3 -0
@@ -26,6 +26,7 @@#include <linux/version.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_dp_mst_helper.h> +#include <drm/drm_dp_helper.h> #include "dm_services.h" #include "amdgpu.h" #include "amdgpu_dm.h"
@@ -472,6 +473,8 @@ void amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm,16 ,4 , aconnector->connector_id); + +drm_connector_attach_dp_subconnector_property (&aconnector->base); }int dm_mst_get_pbn_divider (struct dc_link *link)
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm: report dp downstream port type as a subconnector property
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property
URL : https://patchwork.freedesktop.org/series/76430/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3b34502050b6 drm: report dp downstream port type as a subconnector property
-:57: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#57: FILE: drivers/gpu/drm/drm_connector.c:847:
+ { DRM_MODE_SUBCONNECTOR_Unknown, "Unknown" }, /* DVI-I, TV-out and DP */-:79: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_DisplayPort> #79: FILE: drivers/gpu/drm/drm_connector.c:878:
+ { DRM_MODE_SUBCONNECTOR_DisplayPort, "DP" }, /* DP */
-:80: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Wireless> #80: FILE: drivers/gpu/drm/drm_connector.c:879:
+ { DRM_MODE_SUBCONNECTOR_Wireless, "Wireless" }, /* DP */
-:81: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Native> #81: FILE: drivers/gpu/drm/drm_connector.c:880:
+ { DRM_MODE_SUBCONNECTOR_Native, "Native" }, /* DP */
-:122: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #122: FILE: drivers/gpu/drm/drm_connector.c:1311:
+ drm_property_create_enum(connector->dev,
+ DRM_MODE_PROP_IMMUTABLE,
-:153: WARNING:LINE_SPACING: Missing a blank line after declarations #153: FILE: drivers/gpu/drm/drm_dp_helper.c:606:
+ int type;
+ if (!drm_dp_is_branch(dpcd))
-:210: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #210: FILE: drivers/gpu/drm/drm_dp_helper.c:663:
+ drm_object_property_set_value(&connector->base,
+ connector->dev->mode_config.dp_subconnector_property,
-:295: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Automatic> #295: FILE: include/uapi/drm/drm_mode.h:335:
+ DRM_MODE_SUBCONNECTOR_Automatic = 0, /* DVI-I, TV */
-:300: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Composite> #300: FILE: include/uapi/drm/drm_mode.h:340:
+ DRM_MODE_SUBCONNECTOR_Composite = 5, /* TV */
-:302: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Component> #302: FILE: include/uapi/drm/drm_mode.h:342:
+ DRM_MODE_SUBCONNECTOR_Component = 8, /* TV */
total: 0 errors, 1 warnings, 9 checks, 228 lines checked 5540c9591905 drm/i915: utilize subconnector property for DP 0bac12dd1549 drm/nouveau: utilize subconnector property for DP -:27: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown> #27: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:653:
+ enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown;
-:32: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #32: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:658:
+ drm_object_property_set_value(&connector->base,
+ connector->dev->mode_config.dp_subconnector_property,
total: 0 errors, 0 warnings, 2 checks, 53 lines checkede4922d3602ac drm/amdgpu: utilize subconnector property for DP through atombios df174f027acd drm/amdgpu: utilize subconnector property for DP through DisplayManager -:40: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Native> #40: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:128:
+ return DRM_MODE_SUBCONNECTOR_Native;
-:51: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown> #51: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:139:
+ return DRM_MODE_SUBCONNECTOR_Unknown;
-:68: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #68: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:156:
+ drm_object_property_set_value(&connector->base,
+ connector->dev->mode_config.dp_subconnector_property,
total: 0 errors, 0 warnings, 3 checks, 80 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm: report dp downstream port type as a subconnector property
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property
URL : https://patchwork.freedesktop.org/series/76430/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm: report dp downstream port type as a subconnector property Okay!
Commit: drm/i915: utilize subconnector property for DP Okay!
Commit: drm/nouveau: utilize subconnector property for DP Okay!
Commit: drm/amdgpu: utilize subconnector property for DP through atombios Okay!
Commit: drm/amdgpu: utilize subconnector property for DP through DisplayManager -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1154:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1154:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1154:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1154:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1154:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1154:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1159:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1159:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1159:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1161:36: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1228:25: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1228:25: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1228:25: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1234:37: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1260:41: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1262:39: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1266:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1267:17: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2511:24: warning: symbol 'dm_atomic_get_new_state' was not declared. Should it be static? -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2529:24: warning: symbol 'dm_atomic_get_old_state' was not declared. Should it be static? -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5311:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static? -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:750:6: warning: symbol 'amdgpu_dm_audio_eld_notify' was not declared. Should it be static? -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:805:25: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:809:23: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:810:23: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:813:30: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:816:28: warning: cast to restricted __le32 -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8647:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static? -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8651:50: warning: missing braces around initializer +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1190:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1190:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1190:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1190:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1190:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1190:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1195:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1195:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1195:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1197:36: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1264:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1264:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1264:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1270:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1296:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1298:39: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1302:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1303:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2548:24: warning: symbol 'dm_atomic_get_new_state' was not declared. Should it be static? +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2566:24: warning: symbol 'dm_atomic_get_old_state' was not declared. Should it be static? +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5350:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static? +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:786:6: warning: symbol 'amdgpu_dm_audio_eld_notify' was not declared. Should it be static? +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:841:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:845:23: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:846:23: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:849:30: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:852:28: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8686:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static? +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8690:50: warning: missing braces around initializer
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm: report dp downstream port type as a subconnector property
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property
URL : https://patchwork.freedesktop.org/series/76430/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8358 -> Patchwork_17452
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/index.html
Known issues
------------
Here are the changes found in Patchwork_17452 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_pm_rpm@basic-rte:
- fi-hsw-4770: [SKIP][1] ([fdo#109271]) -> [PASS][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/fi-hsw-4770/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/fi-hsw-4770/igt@[email protected]
* igt@i915_selftest@live@uncore:
- fi-bwr-2160: [INCOMPLETE][3] ([i915#489]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/fi-bwr-2160/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/fi-bwr-2160/igt@i915_selftest@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489
Participating hosts (50 -> 43)
------------------------------
Missing (7): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8358 -> Patchwork_17452
CI-20190529: 20190529
CI_DRM_8358: 03d069b768bdd8a6382b296152a676422a4859a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5609: c100fe19f7b144538549415e8503093053883ec6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17452: df174f027acd0927ca25a5e4f1ec6b68312ed184 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
df174f027acd drm/amdgpu: utilize subconnector property for DP through DisplayManager e4922d3602ac drm/amdgpu: utilize subconnector property for DP through atombios 0bac12dd1549 drm/nouveau: utilize subconnector property for DP 5540c9591905 drm/i915: utilize subconnector property for DP 3b34502050b6 drm: report dp downstream port type as a subconnector property
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm: report dp downstream port type as a subconnector property
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property
URL : https://patchwork.freedesktop.org/series/76430/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8358_full -> Patchwork_17452_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17452_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@kms_flip@2x-dpms-vs-vblank-race-interruptible@bc-hdmi-a1-hdmi-a2}:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-glk9/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-glk8/igt@kms_flip@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17452_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-kbl4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-kbl1/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109349])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-iclb2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-iclb7/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#53])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-skl8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-skl1/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109441]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#31])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-apl3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-apl6/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-apl4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-apl4/igt@[email protected]
#### Possible fixes ####
* {igt@gem_exec_parallel@contexts@bcs0}:
- shard-iclb: [INCOMPLETE][15] -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-iclb7/igt@gem_exec_parallel@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-iclb6/igt@gem_exec_parallel@[email protected]
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [INCOMPLETE][17] ([i915#61]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-hsw2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-hsw7/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][19] ([i915#454]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-iclb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-iclb7/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][21] ([i915#180]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-apl3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-apl2/igt@[email protected]
* igt@kms_cursor_legacy@pipe-c-torture-bo:
- shard-kbl: [DMESG-WARN][23] ([i915#128]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-kbl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-kbl2/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-glk: [FAIL][25] ([i915#52] / [i915#54]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-glk5/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-glk2/igt@[email protected]
* {igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2}:
- shard-glk: [FAIL][27] ([i915#34]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-glk5/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-glk7/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2}:
- shard-glk: [FAIL][29] ([i915#79]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-glk4/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-glk9/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-suspend@b-vga1}:
- shard-snb: [INCOMPLETE][31] ([i915#82]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-snb1/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-snb2/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][33] ([i915#1188]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-skl10/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-skl8/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [INCOMPLETE][35] ([i915#648] / [i915#69]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-skl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-skl9/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][37] ([fdo#109441]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* {igt@perf@blocking-parameterized}:
- shard-iclb: [FAIL][39] ([i915#1542]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-iclb5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: [FAIL][41] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][42] ([fdo#108145] / [i915#265])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8358/shard-apl3/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/shard-apl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8358 -> Patchwork_17452
CI-20190529: 20190529
CI_DRM_8358: 03d069b768bdd8a6382b296152a676422a4859a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5609: c100fe19f7b144538549415e8503093053883ec6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17452: df174f027acd0927ca25a5e4f1ec6b68312ed184 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17452/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm: report dp downstream port type as a subconnector property (rev2)
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property (rev2)
URL : https://patchwork.freedesktop.org/series/76430/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip f749c969fd6c drm/nouveau: utilize subconnector property for DP -:29: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown> #29: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:659: + enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown;
-:34: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #34: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:664:
+ drm_object_property_set_value(&connector->base,
+ connector->dev->mode_config.dp_subconnector_property,
total: 0 errors, 0 warnings, 2 checks, 53 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm: report dp downstream port type as a subconnector property (rev2)
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property (rev2)
URL : https://patchwork.freedesktop.org/series/76430/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8925 -> Patchwork_18406
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18406 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18406, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18406:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_parallel@engines@contexts:
- fi-skl-6700k2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-skl-6700k2/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/fi-skl-6700k2/igt@gem_exec_parallel@[email protected]
Known issues
------------
Here are the changes found in Patchwork_18406 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-bsw-kefka/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/fi-bsw-kefka/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][5] ([i915#2276]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-icl-y/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/fi-icl-y/igt@i915_selftest@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-icl-u2/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/fi-icl-u2/igt@kms_flip@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][9] ([i915#62] / [i915#95]) -> [DMESG-FAIL][10] ([i915#62])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/fi-kbl-x1275/igt@[email protected]
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (37 -> 34)
------------------------------
Missing (3): fi-byt-clapper fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* Linux: CI_DRM_8925 -> Patchwork_18406
CI-20190529: 20190529
CI_DRM_8925: b0f0c5e0b08e7d93135a27141919e765db3aaeef @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5771: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18406: f749c969fd6cf5185ed26fff95c8a6ab9f59a422 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f749c969fd6c drm/nouveau: utilize subconnector property for DP
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18406/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx