coccinelle: api: remove kobj_to_dev.cocci script
PATCH 1/1 coccinelle: api: remove kobj_to_dev.cocci script
Using kobj_to_dev() instead of container_of() is not universally accepted among maintainers as an improvement. The warning leads to repeated patch submissions that won't be accepted. Remove the script.
--- scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------ 1 file changed, 45 deletions(-) delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
scripts/coccinelle/api/kobj_to_dev.cocci deleted +0 -45
@@ -1,45 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-only -/// -/// Use kobj_to_dev() instead of container_of() -/// -// Confidence: High -// Copyright: (C) 2020 Denis Efremov ISPRAS -// Options: --no-includes --include-headers -// -// Keywords: kobj_to_dev, container_of -// - -virtual context -virtual report -virtual org -virtual patch - - -@r depends on !patch@ -expression ptr; -symbol kobj; -position p; -@@ - -* container_of(ptr, struct device, kobj)@p - - -@depends on patch@ -expression ptr; -@@ - -- container_of(ptr, struct device, kobj) -+ kobj_to_dev(ptr) - - -@script:python depends on report@ -p << r.p; -@@ - -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") - -@script:python depends on org@ -p << r.p; -@@ - -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
Signature · 1 line
2.25.4
Quoted 9 lines · Keith Busch
Using
kobj_to_dev()instead ofcontainer_of()is not universally accepted among maintainers as an improvement. The warning leads to repeated patch submissions that won't be accepted. Remove the script.Cc Christoph Hellwig <[email protected]>Cc Jens Axboe <[email protected]>Cc Denis Efremov <[email protected]>Cc Julia Lawall <[email protected]>Signed-off-by Keith Busch <[email protected]>
Quoted 57 lines
--- scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------ 1 file changed, 45 deletions(-) delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocciscripts/coccinelle/api/kobj_to_dev.cocci deleted +0
-45@@ -1,45 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-only -/// -/// Use kobj_to_dev() instead of container_of() -/// -// Confidence: High -// Copyright: (C) 2020 Denis Efremov ISPRAS -// Options: --no-includes --include-headers -// -// Keywords: kobj_to_dev, container_of -// - -virtual context -virtual report -virtual org -virtual patch - - -@r depends on !patch@ -expression ptr; -symbol kobj; -position p; -@@ - -* container_of(ptr, struct device, kobj)@p - - -@depends on patch@ -expression ptr; -@@ - -- container_of(ptr, struct device, kobj) -+ kobj_to_dev(ptr) - - -@script:python depends on report@ -p << r.p; -@@ - -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") - -@script:python depends on org@ -p << r.p; -@@ - -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
Quoted 7 lines · Denis Efremov
Quoted 4 lines · Keith Busch
Using
kobj_to_dev()instead ofcontainer_of()is not universally accepted among maintainers as an improvement. The warning leads to repeated patch submissions that won't be accepted. Remove the script.
Quoted 7 lines
Quoted 5 lines
Cc Christoph Hellwig <[email protected]>Cc Jens Axboe <[email protected]>Cc Denis Efremov <[email protected]>Cc Julia Lawall <[email protected]>Signed-off-by Keith Busch <[email protected]>Acked-by Denis Efremov <[email protected]>
Applied.
Quoted 59 lines
Quoted 58 lines
--- scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------ 1 file changed, 45 deletions(-) delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocciscripts/coccinelle/api/kobj_to_dev.cocci deleted +0
-45@@ -1,45 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-only -/// -/// Use kobj_to_dev() instead of container_of() -/// -// Confidence: High -// Copyright: (C) 2020 Denis Efremov ISPRAS -// Options: --no-includes --include-headers -// -// Keywords: kobj_to_dev, container_of -// - -virtual context -virtual report -virtual org -virtual patch - - -@r depends on !patch@ -expression ptr; -symbol kobj; -position p; -@@ - -* container_of(ptr, struct device, kobj)@p - - -@depends on patch@ -expression ptr; -@@ - -- container_of(ptr, struct device, kobj) -+ kobj_to_dev(ptr) - - -@script:python depends on report@ -p << r.p; -@@ - -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") - -@script:python depends on org@ -p << r.p; -@@ - -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
Quoted 3 lines · Keith Busch
Using
kobj_to_dev()instead ofcontainer_of()is not universally accepted among maintainers as an improvement. The warning leads to repeated patch submissions that won't be accepted. Remove the script.
Signature · 1 line
Jens Axboe