scripts: headers_install: Exit with error on config leak
PATCH 1/1 scripts: headers_install: Exit with error on config leak
Misuse of CONFIG_* in UAPI headers should result in an error as it exposes configuration of different targets to userspace.
--- scripts/headers_install.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/headers_install.sh +2 -1
@@ -109,7 +109,8 @@ do done if [ "$warn" = 1 ]; then - echo "warning: $INFILE: leak $c to user-space" >&2 + echo "error: $INFILE: leak $c to user-space" >&2 + exit 1 fi done
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 14 lines · Siddharth Gupta
Misuse of CONFIG_* in UAPI headers should result in an error as it exposes configuration of different targets to userspace.
Signed-off-by Siddharth Gupta <[email protected]>--- scripts/headers_install.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)scripts/headers_install.sh +0
-0
scripts/headers_install.sh do · line 115
Quoted 8 lines
scripts/headers_install.sh +2
-1@@ -109,7 +109,8 @@ do done if [ "$warn" = 1 ]; then - echo "warning: $INFILE: leak $c to user-space" >&2 + echo "error: $INFILE: leak $c to user-space" >&2 + exit 1 fi done
If you want to change this,
please update the comment at line 67.
Also, rename the variable $warn to
something else, $error or $leak_error, etc. ?
Signature · 2 lines
Best Regards Masahiro Yamada
Sure I will make the recommended changes and send a v2 of the patch.
Thanks,
Siddharth
Quoted 31 lines · Masahiro Yamada
Quoted 13 lines · Siddharth Gupta
Misuse of CONFIG_* in UAPI headers should result in an error as it exposes configuration of different targets to userspace.
Signed-off-by Siddharth Gupta <[email protected]>--- scripts/headers_install.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)scripts/headers_install.sh +0
-0scripts/headers_install.sh do · line 115
Quoted 8 lines
scripts/headers_install.sh +2
-1@@ -109,7 +109,8 @@ do done if [ "$warn" = 1 ]; then - echo "warning: $INFILE: leak $c to user-space" >&2 + echo "error: $INFILE: leak $c to user-space" >&2 + exit 1 fi doneIf you want to change this,
please update the comment at line 67.Also, rename the variable $warn to
something else, $error or $leak_error, etc. ?