sh: Drop CONFIG_MTD_M25P80 in sh7757lcr_defconfig
PATCH 1/1 sh: Drop CONFIG_MTD_M25P80 in sh7757lcr_defconfig
From: Bin Meng <[email protected]>
Drop CONFIG_MTD_M25P80 that was removed in
commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c")
---
arch/sh/configs/sh7757lcr_defconfig | 1 - 1 file changed, 1 deletion(-)
arch/sh/configs/sh7757lcr_defconfig +0 -1
@@ -36,7 +36,6 @@ CONFIG_IPV6=y # CONFIG_FW_LOADER is not set CONFIG_MTD=y CONFIG_MTD_BLOCK=y -CONFIG_MTD_M25P80=y CONFIG_BLK_DEV_RAM=y CONFIG_SCSI=y CONFIG_BLK_DEV_SD=y
Signature · 1 line
2.7.4
Hi Bin,
Quoted 6 lines · Bin Meng
From: Bin Meng <[email protected]>
Drop
CONFIG_MTD_M25P80that was removed in
commitb35b9a10362d("mtd: spi-nor: Move m25p80 code inspi-nor.c")Signed-off-by Bin Meng <[email protected]>
Thanks for your patch!
Blindly removing config options from defconfig files that haven't received much love for a while is IMHO not such a good idea, as it makes it harder to see what the affected platform needs, or needed.
arch/sh/configs/sh7757lcr_defconfig CONFIG_IPV6=y · line 41
Quoted 10 lines
arch/sh/configs/sh7757lcr_defconfig +0
-1@@ -36,7 +36,6 @@ CONFIG_IPV6=y # CONFIG_FW_LOADER is not set CONFIG_MTD=y CONFIG_MTD_BLOCK=y -CONFIG_MTD_M25P80=y CONFIG_BLK_DEV_RAM=y CONFIG_SCSI=y CONFIG_BLK_DEV_SD=y
MTD_SPI_NOR became a dependency for MTD_M25P80 since commit 03e296f613affcc2671c1e86d8c25ecad867204e ("mtd: m25p80: use the SPI nor framework") and commit e43b20619bdb6c851dd7b49cbd15e52875a785d4 ("mtd:
spi-nor: shorten Kconfig naming"). Hence CONFIG_MTD_SPI_NOR=y should be added to avoid breaking the platform's SPI FLASH support.
Just removing CONFIG_MTD_M25P80=y from the defconfig makes this less visible for someone who wants to build a kernel for this platform using "make sh7757lcr_defconfig": it can no longer be seen that CONFIG_MTD_M25P80=y won't be present in the resulting .config file.
I think the platform would be better served with a proper refresh of the defconfig file.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert,
Quoted 34 lines · Geert Uytterhoeven
Hi Bin,
Quoted 6 lines · Bin Meng
From: Bin Meng <[email protected]>
Drop
CONFIG_MTD_M25P80that was removed in
commitb35b9a10362d("mtd: spi-nor: Move m25p80 code inspi-nor.c")Signed-off-by Bin Meng <[email protected]>Thanks for your patch!
Blindly removing config options from defconfig files that haven't received much love for a while is IMHO not such a good idea, as it makes it harder to see what the affected platform needs, or needed.
arch/sh/configs/sh7757lcr_defconfig CONFIG_IPV6=y · line 41
Quoted 10 lines
arch/sh/configs/sh7757lcr_defconfig +0
-1@@ -36,7 +36,6 @@ CONFIG_IPV6=y # CONFIG_FW_LOADER is not set CONFIG_MTD=y CONFIG_MTD_BLOCK=y -CONFIG_MTD_M25P80=y CONFIG_BLK_DEV_RAM=y CONFIG_SCSI=y CONFIG_BLK_DEV_SD=y
MTD_SPI_NORbecame a dependency forMTD_M25P80since commit03e296f613affcc2671c1e86d8c25ecad867204e("mtd: m25p80: use the SPI nor framework") and commite43b20619bdb6c851dd7b49cbd15e52875a785d4("mtd:
spi-nor: shortenKconfignaming"). HenceCONFIG_MTD_SPI_NOR=yshould be added to avoid breaking the platform's SPI FLASH support.
Quoted 5 lines
Just removing
CONFIG_MTD_M25P80=yfrom the defconfig makes this less visible for someone who wants to build a kernel for this platform using "makesh7757lcr_defconfig": it can no longer be seen thatCONFIG_MTD_M25P80=ywon't be present in the resulting .config file.
Thank you for the review! Sorry I missed that.
Quoted 2 lines
I think the platform would be better served with a proper refresh of the defconfig file.
I am not sure if doing a defconfig refresh should be a separate patch. I felt mixing the refresh with the real changes makes the code review a little bit hard. I just sent v2 without the refresh. Please let me know if it is okay.
Regards,
Bin
Hi Bin,
Quoted 38 lines · Bin Meng
Quoted 31 lines · Geert Uytterhoeven
Quoted 6 lines · Bin Meng
From: Bin Meng <[email protected]>
Drop
CONFIG_MTD_M25P80that was removed in
commitb35b9a10362d("mtd: spi-nor: Move m25p80 code inspi-nor.c")Signed-off-by Bin Meng <[email protected]>Thanks for your patch!
Blindly removing config options from defconfig files that haven't received much love for a while is IMHO not such a good idea, as it makes it harder to see what the affected platform needs, or needed.
arch/sh/configs/sh7757lcr_defconfig CONFIG_IPV6=y · line 41
Quoted 10 lines
arch/sh/configs/sh7757lcr_defconfig +0
-1@@ -36,7 +36,6 @@ CONFIG_IPV6=y # CONFIG_FW_LOADER is not set CONFIG_MTD=y CONFIG_MTD_BLOCK=y -CONFIG_MTD_M25P80=y CONFIG_BLK_DEV_RAM=y CONFIG_SCSI=y CONFIG_BLK_DEV_SD=y
MTD_SPI_NORbecame a dependency forMTD_M25P80since commit03e296f613affcc2671c1e86d8c25ecad867204e("mtd: m25p80: use the SPI nor framework") and commite43b20619bdb6c851dd7b49cbd15e52875a785d4("mtd:
spi-nor: shortenKconfignaming"). HenceCONFIG_MTD_SPI_NOR=yshould be added to avoid breaking the platform's SPI FLASH support.Quoted 5 lines
Just removing
CONFIG_MTD_M25P80=yfrom the defconfig makes this less visible for someone who wants to build a kernel for this platform using "makesh7757lcr_defconfig": it can no longer be seen thatCONFIG_MTD_M25P80=ywon't be present in the resulting .config file.
Quoted 6 lines
Thank you for the review! Sorry I missed that.
Quoted 2 lines
I think the platform would be better served with a proper refresh of the defconfig file.
I am not sure if doing a defconfig refresh should be a separate patch.
OK.
Quoted 3 lines
I felt mixing the refresh with the real changes makes the code review a little bit hard. I just sent v2 without the refresh. Please let me know if it is okay.
Thank you, that's fine. It turns out sh7757lcr_defconfig has less bitrotted than I had feared.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds