MIPS: perf: Remove unnecessary "fallthrough" pseudo keywords
Subsystems (2)
PATCH v2 1/1 MIPS: perf: Remove unnecessary "fallthrough" pseudo keywords
The last branch of switch-case doesn't need a "fallthrough" pseudo keyword, and it will cause errors when building a kernel with -Werror:
arch/mips/kernel/perf_event_mipsxx.c: In function 'reset_counters':
include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
200 | # define fallthrough __attribute__((__fallthrough__))
| ^~~~~~~~~~~~~Quoted 1 line
Quoted 1 line
arch/mips/kernel/perf_event_mipsxx.c:932:3: note: in expansion of macro 'fallthrough'
932 | fallthrough;
| ^~~~~~~~~~~
arch/mips/kernel/perf_event_mipsxx.c: In function 'loongson3_reset_counters':
include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
200 | # define fallthrough __attribute__((__fallthrough__))
| ^~~~~~~~~~~~~
arch/mips/kernel/perf_event_mipsxx.c:903:3: note: in expansion of macro 'fallthrough'
903 | fallthrough;
| ^~~~~~~~~~~cc1: all warnings being treated as errors
Fix it by removing unnecessary "fallthrough" pseudo keywords.
--- arch/mips/kernel/perf_event_mipsxx.c | 2 -- 1 file changed, 2 deletions(-)
arch/mips/kernel/perf_event_mipsxx.c +2 -2
@@ -900,7 +900,7 @@ static void loongson3_reset_counters(void *arg) mipspmu.write_counter (0 ,0 );mipsxx_pmu_write_control (0 ,575 <<5 ); mipspmu.write_counter (0 ,0 ); - fallthrough; +break ; } }
@@ -929,7 +928,7 @@ static void reset_counters(void *arg)case 1 :mipsxx_pmu_write_control (0 ,0 ); mipspmu.write_counter (0 ,0 ); - fallthrough; +break ; } }
Signature · 1 line
2.7.0
Quoted 19 lines · Huacai Chen
The last branch of switch-case doesn't need a "fallthrough" pseudo keyword, and it will cause errors when building a kernel with -Werror:
arch/mips/kernel/perf_event_mipsxx.c: In function 'reset_counters':
include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]200 | # define fallthrough __attribute__((__fallthrough__)) | ^~~~~~~~~~~~~Quoted 1 line
Quoted 1 line
arch/mips/kernel/perf_event_mipsxx.c:932:3: note: in expansion of macro 'fallthrough'932 | fallthrough; | ^~~~~~~~~~~ arch/mips/kernel/perf_event_mipsxx.c: In function 'loongson3_reset_counters': include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror] 200 | # define fallthrough __attribute__((__fallthrough__)) | ^~~~~~~~~~~~~ arch/mips/kernel/perf_event_mipsxx.c:903:3: note: in expansion of macro 'fallthrough' 903 | fallthrough; | ^~~~~~~~~~~cc1: all warnings being treated as errors
Quoted 8 lines
Fix it by removing unnecessary "fallthrough" pseudo keywords.
Fixes e9dfbaaeef1c9fe ("MIPS: perf: Add hardware perf events support for new Loongson-3")Reported-by kbuild test robot <[email protected]>Signed-off-by Huacai Chen <[email protected]>--- arch/mips/kernel/perf_event_mipsxx.c | 2 -- 1 file changed, 2 deletions(-)
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]