ARM: dts: stm32: enable stmpe811 on stm32429-disco board
Subsystems (2)
PATCH 3/4 ARM: dts: stm32: enable stmpe811 on stm32429-disco board
[PATCH 3/4] ARM: dts: stm32: enable stmpe811 on stm32429-disco board
remove id, blocks, irq-trigger from the stmpe mfd dts node.
PATCH 3/4 ARM: dts: stm32: enable stmpe811 on stm32429-disco board
From: dillon min <[email protected]>
Enable the stmpe811 touch screen on stm32429-disco board.
--- arch/arm/boot/dts/stm32f429-disco.dts | 47 +++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
arch/arm/boot/dts/stm32f429-disco.dts +47 -0
@@ -49,6 +49,8 @@ #include "stm32f429.dtsi" #include "stm32f429-pinctrl.dtsi" #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/gpio/gpio.h> / { model = "STMicroelectronics STM32F429i-DISCO board";
@@ -127,3 +129,48 @@ pinctrl-names = "default"; status = "okay"; }; + +&i2c3 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c3_pins>; + clock-frequency = <100000>; + status = "okay"; + + stmpe811@41 { + compatible = "st,stmpe811"; + reg = <0x41>; + interrupts = <15 IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&gpioa>; + /* 3.25 MHz ADC clock speed */ + st,adc-freq = <1>; + /* 12-bit ADC */ + st,mod-12b = <1>; + /* internal ADC reference */ + st,ref-sel = <0>; + /* ADC converstion time: 80 clocks */ + st,sample-time = <4>; + + stmpe_touchscreen { + compatible = "st,stmpe-ts"; + /* 8 sample average control */ + st,ave-ctrl = <3>; + /* 7 length fractional part in z */ + st,fraction-z = <7>; + /* + * 50 mA typical 80 mA max touchscreen drivers + * current limit value + */ + st,i-drive = <1>; + /* 1 ms panel driver settling time */ + st,settling = <3>; + /* 5 ms touch detect interrupt delay */ + st,touch-det-delay = <5>; + }; + + stmpe_adc { + compatible = "st,stmpe-adc"; + /* forbid to use ADC channels 3-0 (touch) */ + st,norequest-mask = <0x0F>; + }; + }; +};
Signature · 1 line
2.7.4
Hi Dillon
Quoted 6 lines · On 5/7/20 11:16 AM, [email protected] wrote:
From: dillon min <[email protected]>
Enable the stmpe811 touch screen on stm32429-disco board.
Signed-off-by dillon min <[email protected]>---
You have to add version to your patches. When you send updates of your patches, it is better to resend the whole series by adding [PATCH v2] ... instead of [PATCH] (you can do it easily using git format-patch and subject-prefix). Then in your cover letter you have to explain changes between 2 series versions.
So please resend the whole series by adding V2 prefix, update cover-letter explaining changes, and add a title to your cover-letter please.
regards
alex
Quoted 56 lines
arch/arm/boot/dts/stm32f429-disco.dts | 47 +++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)arch/arm/boot/dts/stm32f429-disco.dts +37
-0@@ -49,6 +49,8 @@ #include "stm32f429.dtsi" #include "stm32f429-pinctrl.dtsi" #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/gpio/gpio.h> / { model = "STMicroelectronics STM32F429i-DISCO board";@@ -127,3 +129,48 @@ pinctrl-names = "default"; status = "okay"; }; + +&i2c3 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c3_pins>; + clock-frequency = <100000>; + status = "okay"; + + stmpe811@41 { + compatible = "st,stmpe811"; + reg = <0x41>; + interrupts = <15 IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&gpioa>; + /* 3.25 MHz ADC clock speed */ + st,adc-freq = <1>; + /* 12-bit ADC */ + st,mod-12b = <1>; + /* internal ADC reference */ + st,ref-sel = <0>; + /* ADC converstion time: 80 clocks */ + st,sample-time = <4>; + + stmpe_touchscreen { + compatible = "st,stmpe-ts"; + /* 8 sample average control */ + st,ave-ctrl = <3>; + /* 7 length fractional part in z */ + st,fraction-z = <7>; + /* + * 50 mA typical 80 mA max touchscreen drivers + * current limit value + */ + st,i-drive = <1>; + /* 1 ms panel driver settling time */ + st,settling = <3>; + /* 5 ms touch detect interrupt delay */
arch/arm/boot/dts/stm32f429-disco.dts line 176
Quoted 10 lines
arch/arm/boot/dts/stm32f429-disco.dts +10
-0+ st,touch-det-delay = <5>; + }; + + stmpe_adc { + compatible = "st,stmpe-adc"; + /* forbid to use ADC channels 3-0 (touch) */ + st,norequest-mask = <0x0F>; + }; + }; +};
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi dillon
If you change something in your patchset please make sure to add version to patch (e.g. [PATCH v2 3/4] ARM: dt....) and also mention in commit message below Signed-off-by what you changed.
Also make sure to set your
email client to text mode also for replies, that makes life easier for everyone.
Refer to these instructions:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Best Regards,
Philippe
Quoted 3 lines · On Thu, 2020-05-07 at 17:16 +0800, [email protected] wrote:
[PATCH 3/4] ARM: dts: stm32: enable stmpe811 on stm32429-disco board
remove id, blocks, irq-trigger from the stmpe mfd dts node.