mm: memblock: fix minor typo and unclear comment
PATCH 1/1 mm: memblock: fix minor typo and unclear comment
From: chenqiwu <[email protected]>
Fix a minor typo "usabe->usable" for the current discription of member variable "memory" in struct memblock.
BTW, I think it's unclear the member variable "base" in struct memblock_type is currently described as the physical address of memory region, change it to base address of the region is clearer since the variable is decorated as phys_addr_t.
--- include/linux/memblock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/memblock.h +2 -2
@@ -41,7 +41,7 @@ enum memblock_flags {/** * struct memblock_region - represents a memory region -* @base: physical address of the region +* @base: base address of the region * @size: size of the region * @flags: memory region attributes * @nid: NUMA node id
@@ -75,7 +75,7 @@ struct memblock_type {* struct memblock - memblock allocator metadata * @bottom_up: is bottom up direction? * @current_limit: physical address of the current allocation limit -* @memory: usabe memory regions +* @memory: usable memory regions * @reserved: reserved memory regions * @physmem: all physical memory */
Signature · 1 line
1.9.1
Quoted 11 lines · On Thu, May 07, 2020 at 06:22:32PM +0800, [email protected] wrote:
From: chenqiwu <[email protected]>
Fix a minor typo "
usabe->usable" for the current discription of member variable "memory" in struct memblock.BTW, I think it's unclear the member variable "base" in struct
memblock_typeis currently described as the physical address of memory region, change it to base address of the region is clearer since the variable is decorated asphys_addr_t.Signed-off-by chenqiwu <[email protected]>
Quoted 29 lines
--- include/linux/memblock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)include/linux/memblock.h +2
-2@@ -41,7 +41,7 @@ enum memblock_flags {/** * struct memblock_region - represents a memory region -* @base: physical address of the region +* @base: base address of the region * @size: size of the region * @flags: memory region attributes * @nid: NUMA node id @@ -75,7 +75,7 @@ struct memblock_type {* struct memblock - memblock allocator metadata * @bottom_up: is bottom up direction? * @current_limit: physical address of the current allocation limit -* @memory: usabe memory regions +* @memory: usable memory regions * @reserved: reserved memory regions * @physmem: all physical memory */ Signature · 1 line
1.9.1
Signature · 2 lines
Sincerely yours, Mike.