Skip to contentSkip to conversation

ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue

PATCH Applied Hanjun Guo 3 participants 3 messages May 8, 2020 – May 11, 2020

Subsystems (2)
lore
Share & tools
lore

Hanjun Guo

author maintainer
#0 lore raw

PATCH v2 1/1 ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue

As we already applied a workaround for the off-by-1 issue, it's good to add extra message "applying workaround" to make people less uneasy to see FW_BUG message in the boot log.

---

v2:
- Print the extra message only for rid_in == map->input_base;
- Still based on top of for-next/acpi branch of ARM64 repo

 drivers/acpi/arm64/iort.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/acpi/arm64/iort.c +2 -0
index b011d25..6e445bc 100644
@@ -332,6 +332,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
 		       map, rid_in);
 		if (rid_in != map->input_base)
 			return -ENXIO;
+
+		pr_err(FW_BUG "applying workaround.\n");
 	}
 
 	*rid_out = map->output_base + (rid_in - map->input_base);
Signature · 1 line
1.7.12.4
Acked-by on v2 1/1
#1 lore raw
Quoted 29 lines · Hanjun Guo

As we already applied a workaround for the off-by-1 issue, it's good to add extra message "applying workaround" to make people less uneasy to see FW_BUG message in the boot log.

---

v2:
- Print the extra message only for rid_in == map->input_base;
- Still based on top of for-next/acpi branch of ARM64 repo

 drivers/acpi/arm64/iort.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/acpi/arm64/iort.c +2 -1
index b011d25..6e445bc 100644
@@ -332,6 +332,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
                       map, rid_in);
                if (rid_in != map->input_base)
                        return -ENXIO;
+
+               pr_err(FW_BUG "applying workaround.\n");
        }
 
        *rid_out = map->output_base + (rid_in - map->input_base);
--
Quoted 2 lines

1.7.12.4

maintainer Applied
#2 lore raw
In reply to Hanjun Guo
Quoted 3 lines · Hanjun Guo

As we already applied a workaround for the off-by-1 issue, it's good to add extra message "applying workaround" to make people less uneasy to see FW_BUG message in the boot log.

Applied to arm64 (for-next/acpi), thanks!

[1/1] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue

      https://git.kernel.org/arm64/c/44cdc7b16e0a

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev