staging: vt6656: vt6655: cleaning Makefile
v2 cover staging: vt6656: vt6655: cleaning Makefile
This patchset will remove unused definitions of C Macros, reorder variable definition and increase indentation to match visual block.
---
v2: spliting original patch to 2 separate patches
Matej Dujava (2):
staging: vt6656: vt6655: clean Makefiles
staging: vt6655: vt6656: change order of makefile variable definitions
drivers/staging/vt6655/Makefile | 27 ++++++++++++--------------- drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6656/Makefile | 7 ++----- 3 files changed, 14 insertions(+), 21 deletions(-)
--
2.26.2
PATCH v2 1/2 staging: vt6656: vt6655: clean Makefiles
This patch is removing CFLAGS that are defining flags that are not used.
--- drivers/staging/vt6655/Makefile | 3 --- drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6656/Makefile | 3 --- 3 files changed, 7 deletions(-)
drivers/staging/vt6655/Makefile +0 -3
@@ -1,7 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -# TODO: all of these should be removed -ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__ -ccflags-y += -DHOSTAP vt6655_stage-y += device_main.o \ card.o \
drivers/staging/vt6655/device_main.c +0 -1
@@ -32,7 +32,6 @@* * Revision History: */ -#undef __NO_VERSION__#include <linux/file.h> #include "device.h"
drivers/staging/vt6656/Makefile +0 -3
@@ -1,7 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -# TODO: all of these should be removed -ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__ -ccflags-y += -DHOSTAP vt6656_stage-y += main_usb.o \ card.o \
Signature · 1 line
2.26.2
Greg Kroah-Hartman
maintainerRe: [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles
Quoted 6 lines · Matej Dujava
This patch is removing CFLAGS that are defining flags that are not used.
Signed-off-by Matej Dujava <[email protected]>--- drivers/staging/vt6655/Makefile | 3 --- drivers/staging/vt6655/device_main.c | 1 -
This file is not a Makefile :(
Please properly describe patches.
Also state below the --- line what changed from the first version, otherwise I have no idea.
Please fix up and send a v3 series.
thanks,
greg k-h
PATCH v2 2/2 staging: vt6655: vt6656: change order of makefile variable definitions
In reply to Matej DujavaThis patch will add indentation to multiline variable and put obj-$(CONFIG_X) at the begining of the file.
--- drivers/staging/vt6655/Makefile | 24 ++++++++++++------------ drivers/staging/vt6656/Makefile | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-)
drivers/staging/vt6655/Makefile +12 -12
@@ -1,15 +1,15 @@ # SPDX-License-Identifier: GPL-2.0 -vt6655_stage-y += device_main.o \ - card.o \ - channel.o \ - mac.o \ - baseband.o \ - rxtx.o \ - dpc.o \ - power.o \ - srom.o \ - key.o \ - rf.o - obj-$(CONFIG_VT6655) += vt6655_stage.o + +vt6655_stage-y += device_main.o \ + card.o \ + channel.o \ + mac.o \ + baseband.o \ + rxtx.o \ + dpc.o \ + power.o \ + srom.o \ + key.o \ + rf.o
drivers/staging/vt6656/Makefile +2 -2
@@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_VT6656) += vt6656_stage.o + vt6656_stage-y += main_usb.o \ card.o \ mac.o \
@@ -11,5 +13,3 @@ vt6656_stage-y += main_usb.o \ rf.o \ usbpipe.o \ channel.o - -obj-$(CONFIG_VT6656) += vt6656_stage.o
Signature · 1 line
2.26.2
Greg Kroah-Hartman
maintainerRe: [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
Quoted 2 lines · Matej Dujava
This patch will add indentation to multiline variable and put obj-$(CONFIG_X) at the begining of the file.
Why change the order? What does that fix? Why do this? You say what you do here, but not why. And without that, I can't see the reason to accept this patch :(
thanks,
greg k-h